June 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Fixed SerializationException typo
by Code Review 27 Jun '17

27 Jun '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core: Fixed SerializationException typo ...................................................................... core: Fixed SerializationException typo Change-Id: Ia0a8d59b54c21a06d90719f0593d8a6e75525cfc Signed-off-by: Petr Kotas <pkotas(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/Deserializer.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/SerializationException.java D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/SerializationExeption.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/Serializer.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectDeserializer.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializer.java 6 files changed, 31 insertions(+), 33 deletions(-) Approvals: Jenkins CI: Passed CI tests Petr Kotas: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/78161 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0a8d59b54c21a06d90719f0593d8a6e75525cfc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Petr Kotas <pkotas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Petr Kotas <pkotas(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fixing FenceAgent toString
by Code Review 27 Jun '17

27 Jun '17

>From Eli Mesika <emesika(a)redhat.com>: Eli Mesika has submitted this change and it was merged. Change subject: core: fixing FenceAgent toString ...................................................................... core: fixing FenceAgent toString core: fixing FenceAgent toString to display options correctly The protocol between engine and VDSM requires that the separator between fence agent options will be a NEWLINE. However we are implementing the toString method that is using the logger to write log messages, we should replace the NEWLINE with COMMA. Change-Id: Ic117ee404fb909515d5a3d18c6e2c1ba8fa1a9b0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1457814 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/pm/FenceAgent.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified Ravi Nori: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/78621 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic117ee404fb909515d5a3d18c6e2c1ba8fa1a9b0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix potential OvfParserTest NPE
by Code Review 27 Jun '17

27 Jun '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix potential OvfParserTest NPE ...................................................................... core: Fix potential OvfParserTest NPE OvfParser#utcDateStringToLocalDate may potentially return null (even though this is not possible in this test due to the hard-coded argument that's passed to it), causing static analysis tools such as Coverity or even IntelliJ IDEA to issue a warning on this test. This patch flips the test around and constructs a new Date object from the expected timestamp instead of extracting the timestamp from the parsed Date object. This change not only silences the aforementioned static analysis tools, but also makes the test a tad more resilient - if utcDateStringToLocalDate would ever be broken in the future in a way where it returns null for this argument the test would now fail cleanly instead of erroring out with a NullPointerException. This patch addresses Coverity CID 1376661. Change-Id: If23a59cd5f85085bd6c965ab653238c351e9d8a1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ovf/OvfParserTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/78687 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If23a59cd5f85085bd6c965ab653238c351e9d8a1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Fix issue with bookmarks
by Code Review 26 Jun '17

26 Jun '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Fix issue with bookmarks ...................................................................... webadmin: Fix issue with bookmarks - Fixed problem where we were setting a Singleton list as the selectedItems, which cannot be cleared. Change-Id: I738fd7a79f188cef1681e4e60741b4acca55b656 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/bookmarks/BookmarkListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/overlay/BookmarkView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/BookmarkModelProvider.java 3 files changed, 4 insertions(+), 11 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/78664 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I738fd7a79f188cef1681e4e60741b4acca55b656 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Correct spelling in ballooning message
by Code Review 26 Jun '17

26 Jun '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Correct spelling in ballooning message ...................................................................... webadmin: Correct spelling in ballooning message Change-Id: Iabf384eb26c3c93b5f9109cd57afeb59be7d1c8d Signed-off-by: Phillip Bailey <phbailey(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Phillip Bailey: Verified -- To view, visit https://gerrit.ovirt.org/78662 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iabf384eb26c3c93b5f9109cd57afeb59be7d1c8d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: spec: add m2crypto dependency
by Code Review 26 Jun '17

26 Jun '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: add m2crypto dependency ...................................................................... packaging: spec: add m2crypto dependency m2crypto is required by src/ovirt_hosted_engine_setup/pkissh.py It was removed by commit a2f09c62612ee407b1c0fce1323561cb9c992340 because it was marked as host dependency only and delegated to vdsm dependency tree. m2crypto is required by hosted-engine code so readding it. Change-Id: I0256391c29f44538e50b0dad0682c24646e401e3 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-hosted-engine-setup.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78653 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0256391c29f44538e50b0dad0682c24646e401e3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[master]: el7: update qemu-kvm-ev gpg key url
by Code Review 26 Jun '17

26 Jun '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: el7: update qemu-kvm-ev gpg key url ...................................................................... el7: update qemu-kvm-ev gpg key url Change-Id: Ic1d3a320e9b329763185750bf86784da0b9d1059 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1464527 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-el7-x86_64-deps.repo.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78648 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1d3a320e9b329763185750bf86784da0b9d1059 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com> Gerrit-Reviewer: Nelly Credi <ncredi(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: StorageModel diamond operator usage
by Code Review 26 Jun '17

26 Jun '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: StorageModel diamond operator usage ...................................................................... webadmin: StorageModel diamond operator usage Change-Id: I5ff7ab34d9c5c87ab29cdec07d2eff2b4f598790 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java 1 file changed, 12 insertions(+), 12 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/78636 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ff7ab34d9c5c87ab29cdec07d2eff2b4f598790 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: StorageModel type inference
by Code Review 26 Jun '17

26 Jun '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: StorageModel type inference ...................................................................... webadmin: StorageModel type inference Change-Id: I00fd19f016170ba6ce2aa02d77ee68553d230b58 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/78635 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00fd19f016170ba6ce2aa02d77ee68553d230b58 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: StorageModel#getStorageModels() iteration
by Code Review 26 Jun '17

26 Jun '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: StorageModel#getStorageModels() iteration ...................................................................... webadmin: StorageModel#getStorageModels() iteration Use the more exact IStorageModel type instead of a general purpose Object when iterating getStorageModels(). Change-Id: I0935c3c6975b96163df66ea4e755427c226bc29d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/78640 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0935c3c6975b96163df66ea4e755427c226bc29d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: StorageModel Collections#singletonList usages
by Code Review 26 Jun '17

26 Jun '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: StorageModel Collections#singletonList usages ...................................................................... webadmin: StorageModel Collections#singletonList usages Use the more efficient and more intuitive Collections#singletonList instead of the awkward Arrays#asList with a single argument. Change-Id: Ia90c027c69cfda7fe836ece925a6d5b43d0922d3 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/78637 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia90c027c69cfda7fe836ece925a6d5b43d0922d3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: StorageModel streams
by Code Review 26 Jun '17

26 Jun '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: StorageModel streams ...................................................................... webadmin: StorageModel streams Change-Id: I42547fbae9880d70c2a78d4a1b7f8eae430a82c7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java 1 file changed, 22 insertions(+), 44 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/78641 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42547fbae9880d70c2a78d4a1b7f8eae430a82c7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: StorageModel method references
by Code Review 26 Jun '17

26 Jun '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: StorageModel method references ...................................................................... webadmin: StorageModel method references Change-Id: I51bcf7931a94c4a0ad66d8a7024ec55a977c2294 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/78639 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51bcf7931a94c4a0ad66d8a7024ec55a977c2294 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: StorageModel redundant static qualification
by Code Review 26 Jun '17

26 Jun '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: StorageModel redundant static qualification ...................................................................... webadmin: StorageModel redundant static qualification Change-Id: I8feaf125026501e1af4849fa497e66031bfceb8a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/78638 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8feaf125026501e1af4849fa497e66031bfceb8a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Fix typo in EventType
by Code Review 26 Jun '17

26 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: engine: Fix typo in EventType ...................................................................... engine: Fix typo in EventType Change-Id: I6285bbb29430d60836acf273590c2ac33b18fb25 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/eventqueue/EventType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxy.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/78223 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6285bbb29430d60836acf273590c2ac33b18fb25 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[refs/meta/config]: gerrit: Refine watched files
by Code Review 26 Jun '17

26 Jun '17

>From Shlomo Ben David <sbendavi(a)redhat.com>: Shlomo Ben David has submitted this change and it was merged. Change subject: gerrit: Refine watched files ...................................................................... gerrit: Refine watched files The 'utils' and 'host' are too generic patterns and should be refined. Change-Id: I29f9b7ee8a82342da1013d964d58727e4d034b66 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M reviewers.config 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Shlomo Ben David: Looks good to me, approved; Passed CI tests Roy Golan: Looks good to me, but someone else must approve Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/78339 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I29f9b7ee8a82342da1013d964d58727e4d034b66 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: refs/meta/config Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shlomi Ben-David Gerrit-Reviewer: Shlomi Ben-David <shlomi.ben.david(a)gmail.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.1]: build: post ovirt-hosted-engine-setup-2.1.3.2
by Code Review 26 Jun '17

26 Jun '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: build: post ovirt-hosted-engine-setup-2.1.3.2 ...................................................................... build: post ovirt-hosted-engine-setup-2.1.3.2 Change-Id: I9deddc1d3aa74aa1875681d37f4f7cf653307c4a Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/build-artifacts.sh M configure.ac M ovirt-hosted-engine-setup.spec.in 3 files changed, 11 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78643 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9deddc1d3aa74aa1875681d37f4f7cf653307c4a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.1]: build: ovirt-hosted-engine-setup-2.1.3.2
by Code Review 26 Jun '17

26 Jun '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-setup-2.1.3.2 ...................................................................... build: ovirt-hosted-engine-setup-2.1.3.2 Change-Id: Ic327f928dcd4ca596d624960b437a477ab0ff49a Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/build-artifacts.sh M configure.ac M ovirt-hosted-engine-setup.spec.in 3 files changed, 7 insertions(+), 7 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78642 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic327f928dcd4ca596d624960b437a477ab0ff49a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in jenkins[master]: publisher: restore publishing vdsm ppc64le 4.1 builds
by Code Review 26 Jun '17

26 Jun '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: publisher: restore publishing vdsm ppc64le 4.1 builds ...................................................................... publisher: restore publishing vdsm ppc64le 4.1 builds We don't have issues with multi arch anymore, Need to verify it works with OST 4.1 suite before merging. Change-Id: I4417f8c9f4e941e6a75053bcc0d5685eafbf980d Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/ovirt/publish-rpms-nightly-4.1.yaml 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me Eyal Edri: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78596 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4417f8c9f4e941e6a75053bcc0d5685eafbf980d Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in jenkins[master]: Force mock to use 'chroot' in mock_runner.sh
by Code Review 26 Jun '17

26 Jun '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: Force mock to use 'chroot' in mock_runner.sh ...................................................................... Force mock to use 'chroot' in mock_runner.sh The 'mock' default behaviour was changed in FC26 to use 'systemd-nspawn' instead of 'chroot'. This breaks various assumptions make in 'mock_runner.sh'. This patch makes 'mock_runner.sh' force 'mock' to use 'chroot'. Change-Id: Ie5d27e7ec17cade6484a83dbfe75565bf1948746 Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1478 Signed-off-by: Barak Korren <bkorren(a)redhat.com> --- M mock_configs/mock_runner.sh 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me, approved; Ready for merge Barak Korren: Verified; Ready for review Daniel Belenky: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78606 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5d27e7ec17cade6484a83dbfe75565bf1948746 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.1]: upgrade: fix appliance version check
by Code Review 26 Jun '17

26 Jun '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: upgrade: fix appliance version check ...................................................................... upgrade: fix appliance version check Fix appliance version check in the eventuality that appliance version contain more than two values separated by a '.'. Change-Id: Iee926cb6784cfc04ef41d945457972fdc98f1bef Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1464866 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/gr-he-upgradeappliance/engine/misc.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78571 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee926cb6784cfc04ef41d945457972fdc98f1bef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.1 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Allow to migrate a paused VM with Post-copy policy
by Code Review 26 Jun '17

26 Jun '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: Allow to migrate a paused VM with Post-copy policy ...................................................................... core: Allow to migrate a paused VM with Post-copy policy Libvirt does not allow to migrate a VM in Paused state with post-copy migration. If migration policy of a cluster contains a "postcopy" action, every attempt to migrate a paused VM fails because libvirt returns an error, not allowing migration to start. On the other side, the current Post-copy migration policy uses post-copy only as last resort, when a regular migration stalls. It is unlikely that migration will be stalling when migrating a paused VM, so it is safe to use a Post-copy policy with it. Libvirt bug have been open for this issue: https://bugzilla.redhat.com/show_bug.cgi?id=1464792 This patch introduces a workaround: MigrateVmCommand will filter a "postcopy" action out of the effective migration policy, if the VM is in Paused state. This helps to avoid libvirt error and allows to migrate such a VM in a cluster with Post-copy migration policy. Change-Id: I5fcaf057f3d3443d5d0dd30e542a8e159acc5bd4 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java 1 file changed, 23 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/78308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5fcaf057f3d3443d5d0dd30e542a8e159acc5bd4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: aaa: Rename error to error_description and error_code to error
by Code Review 26 Jun '17

26 Jun '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: aaa: Rename error to error_description and error_code to error ...................................................................... aaa: Rename error to error_description and error_code to error Rename error to error_description and error_code to error for both OAuth and OpenId code in SSO. Change Welcome servlet code to reflect the changes. Change-Id: I2437e07fb8dc1c2897002b5887c1c2d1f7ee4561 Bug-Url: https://bugzilla.redhat.com/1416491 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OpenIdUserInfoServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoConstants.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/LoginServlet.java M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/LogoutServlet.java M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/OAuthCallbackServlet.java M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/WelcomeServlet.java M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/WelcomeUtils.java M backend/manager/modules/welcome/src/main/webapp/WEB-INF/ovirt-engine.jsp 9 files changed, 42 insertions(+), 34 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78256 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2437e07fb8dc1c2897002b5887c1c2d1f7ee4561 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: aaa: Add OpenId support
by Code Review 26 Jun '17

26 Jun '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: aaa: Add OpenId support ...................................................................... aaa: Add OpenId support Add support for openid discovery, jwks endpoint, userinfo servlet and support for prompt and display request parameters. Change-Id: I1bf7c53e2ee8b0b42dfaaf50594811f74a20ae53 Bug-Url: https://bugzilla.redhat.com/1416491 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/InteractiveNextAuthServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthAuthorizeServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthTokenServlet.java A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OpenIdAuthorizeServlet.java A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OpenIdConfigurationServlet.java A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OpenIdJwksServlet.java A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OpenIdUserInfoServlet.java A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OpenIdUtils.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoConstants.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoSession.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/web.xml 12 files changed, 558 insertions(+), 97 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76053 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1bf7c53e2ee8b0b42dfaaf50594811f74a20ae53 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: aaa: Add OpenId Token end point
by Code Review 26 Jun '17

26 Jun '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: aaa: Add OpenId Token end point ...................................................................... aaa: Add OpenId Token end point Add OpenId Connect token endpoint and remove OpenId connect logic from OAuth token endpoint. The OAuth auth code can be used only once to get the token. A second attempt should throw an error. Change-Id: Ic00c6567308108d2eaa3743f7c890be01e26faa0 Bug-Url: https://bugzilla.redhat.com/1416491 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthAuthorizeServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthTokenServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OpenIdAuthorizeServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OpenIdConfigurationServlet.java A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OpenIdTokenServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OpenIdUserInfoServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoConstants.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoContext.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoSession.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/web.xml 11 files changed, 320 insertions(+), 112 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78257 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic00c6567308108d2eaa3743f7c890be01e26faa0 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: StorageIsoListModel - use ArrayList#sort
by Code Review 25 Jun '17

25 Jun '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: StorageIsoListModel - use ArrayList#sort ...................................................................... webadmin: StorageIsoListModel - use ArrayList#sort Use the better performing ArrayList#sort instead of the general purpose Collections#sort when sorting the list of RepoImages. Change-Id: Ic926f8036ebb4602eb769417b4ab4e496012dcd4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/78611 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic926f8036ebb4602eb769417b4ab4e496012dcd4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: StorageIsoListModel type inference
by Code Review 25 Jun '17

25 Jun '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: StorageIsoListModel type inference ...................................................................... webadmin: StorageIsoListModel type inference Change-Id: Ic49cc03dc49c13e271f92c2a7a5a11720934139f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/78610 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic49cc03dc49c13e271f92c2a7a5a11720934139f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: StorageIsoListModel#getSelectedItems casts
by Code Review 25 Jun '17

25 Jun '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: StorageIsoListModel#getSelectedItems casts ...................................................................... webadmin: StorageIsoListModel#getSelectedItems casts Remove redundant casts of getSelectedItems to ArrayLists which are not needed for the class' functionality and do nothing but confuse the reader. Change-Id: Id24e6752dbcb20af76050f2935023a5aa0197f4e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java 1 file changed, 4 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/78612 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id24e6752dbcb20af76050f2935023a5aa0197f4e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: make each disk appear on its own separate line
by Code Review 25 Jun '17

25 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: make each disk appear on its own separate line ...................................................................... webadmin: make each disk appear on its own separate line Currently when multiple disks are selected to be moved, the disks allocation dialog makes some of the disk's fields appear in the previous row instead. Fixed by wrapping each disk with a bootstrap row. Before screenshot: http://i.imgur.com/ucne2s4.png After screenshot: http://i.imgur.com/q9ZIWKD.png Change-Id: I86981b1538f08e728842dcc974ebfb45bd2aea83 Bug-Url: https://bugzilla.redhat.com/1436766 Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationItemView.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationView.ui.xml 2 files changed, 44 insertions(+), 26 deletions(-) Approvals: Benny Zlotnik: Verified Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77750 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86981b1538f08e728842dcc974ebfb45bd2aea83 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: inventory: Add validation for inactive storage domains
by Code Review 25 Jun '17

25 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: Add validation for inactive storage domains ...................................................................... inventory: Add validation for inactive storage domains Change-Id: Ic123c502d650d9bd3e0d4e82afcb3d06c7e90ac5 --- M src/inventory_report/Makefile.am M src/inventory_report/produceReport/pre-upgrade-checks M src/inventory_report/produceReport/produceReport.sh A src/inventory_report/produceReport/sqls/storage_domains_query_get_failing_domains.sql 4 files changed, 17 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/78595 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic123c502d650d9bd3e0d4e82afcb3d06c7e90ac5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: Add validation for inactive storage domains
by Code Review 25 Jun '17

25 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: Add validation for inactive storage domains ...................................................................... inventory: Add validation for inactive storage domains Change-Id: Ic123c502d650d9bd3e0d4e82afcb3d06c7e90ac5 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/Makefile.am M src/inventory_report/produceReport/pre-upgrade-checks M src/inventory_report/produceReport/produceReport.sh A src/inventory_report/produceReport/sqls/storage_domains_query_get_failing_domains.sql 4 files changed, 17 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78572 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic123c502d650d9bd3e0d4e82afcb3d06c7e90ac5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: reduce code duplication in ovf readers
by Code Review 24 Jun '17

24 Jun '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core: reduce code duplication in ovf readers ...................................................................... core: reduce code duplication in ovf readers Introduce a method for reading a property from the OVF and invoking a given consumer that typically updates the entity accordingly. Change-Id: I3b7b61fbed16f863e46d2e1994aebdfb9474004b Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java 3 files changed, 232 insertions(+), 446 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/78395 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b7b61fbed16f863e46d2e1994aebdfb9474004b Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix a typo
by Code Review 24 Jun '17

24 Jun '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core: fix a typo ...................................................................... core: fix a typo utcDateStringToLocaDate -> utcDateStringToLocalDate Change-Id: I73145b948f6df2652ec285a2fcbfa790edcd8c0d Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfParser.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ovf/OvfParserTest.java 5 files changed, 10 insertions(+), 10 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/78511 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73145b948f6df2652ec285a2fcbfa790edcd8c0d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>

1 0

Change in ovirt-engine[master]: aaa: Running the command logon on the VM via the REST failed
by Code Review 23 Jun '17

23 Jun '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: aaa: Running the command logon on the VM via the REST failed ...................................................................... aaa: Running the command logon on the VM via the REST failed Passwords should be encrypted using engine pki certificate and not using client cetificate. Restapi does not send client id so using engine pki cert SSO can still save encrypted password in SsoSession. The saved password is used to execute VmLogon command. Change-Id: I049acc6ab02e173ae52aa12133c0a13eb1ec223b Bug-Url: https://bugzilla.redhat.com/1463634 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/context/SsoContextListener.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoContext.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoLocalConfig.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java 4 files changed, 36 insertions(+), 17 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78533 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I049acc6ab02e173ae52aa12133c0a13eb1ec223b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: inventory: Add table component in cluster without DC
by Code Review 23 Jun '17

23 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: Add table component in cluster without DC ...................................................................... inventory: Add table component in cluster without DC Change-Id: I4e8826e8a4155f233f2335cf14afa3943ddf53ca Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/pre-upgrade-checks 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/78573 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e8826e8a4155f233f2335cf14afa3943ddf53ca Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: upgrade: fix appliance version check
by Code Review 23 Jun '17

23 Jun '17

>From Simone Tiraboschi <stirabos(a)redhat.com>: Simone Tiraboschi has submitted this change and it was merged. Change subject: upgrade: fix appliance version check ...................................................................... upgrade: fix appliance version check Fix appliance version check in the eventuality that appliance version contain more than two values separated by a '.'. Change-Id: Iee926cb6784cfc04ef41d945457972fdc98f1bef Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1464461 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/gr-he-upgradeappliance/engine/misc.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, but someone else must approve Simone Tiraboschi: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78570 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee926cb6784cfc04ef41d945457972fdc98f1bef Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-4.1]: node: EFI support only on x86_64
by Code Review 23 Jun '17

23 Jun '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: node: EFI support only on x86_64 ...................................................................... node: EFI support only on x86_64 ppc64le packages for EFI support are not available. Moving to arch specific section. Change-Id: I08362355c6ebb71d5e6c61bfb7b3085517a42820 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry-picked from 67870d2651b573df969721b9575e5d3037e30a8b) --- M ovirt-release41.spec.in 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Ryan Barry: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/78567 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08362355c6ebb71d5e6c61bfb7b3085517a42820 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.1]: packaging: spec: arch specific dep dmidecode
by Code Review 23 Jun '17

23 Jun '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: arch specific dep dmidecode ...................................................................... packaging: spec: arch specific dep dmidecode dmidecode is not available outside ix86/x86_64. Change-Id: Iec12b60fbdc80e000ca51c7a192ccbd065c61c26 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit 0b8048d2b7ac00aa441283ddbe339dd578f1acc6) --- M ovirt-hosted-engine-setup.spec.in 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78568 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec12b60fbdc80e000ca51c7a192ccbd065c61c26 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-log-collector[master]: CollectorBase: fix list index out of range
by Code Review 22 Jun '17

22 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: CollectorBase: fix list index out of range ...................................................................... CollectorBase: fix list index out of range Re-ordered tests on an list avoiding an index out of range exception if the sosreport filename is not in the output of sosreport call. The IndexError was used to detect an error in sosreport call instead of properly handling a parsing error. Added exception handling for this cases and made it a critical error since this means the underlying sosreport is having troubles. Change-Id: I40235242bf4eabd4b1cd9599eb45cb124e182df3 Bug-Url: https://bugzilla.redhat.com/1460734 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 18 insertions(+), 12 deletions(-) Approvals: Douglas Schilling Landgraf: Looks good to me, approved Sandro Bonazzola: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78534 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40235242bf4eabd4b1cd9599eb45cb124e182df3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[master]: ovirt-release-master: add m2crypto back on node
by Code Review 22 Jun '17

22 Jun '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-release-master: add m2crypto back on node ...................................................................... ovirt-release-master: add m2crypto back on node Hack for avoiding add host failures due to missing m2crypto on node. VDSM removed m2crypto as dependency in https://gerrit.ovirt.org/#/c/76027/ but it's still needed by ovirt-host-deploy runtime for certificates nrollment. Change requested here: https://bugzilla.redhat.com/1464199 Change-Id: I11a7db45d9beea773cf31187046aa67d9ecb5fbf Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-release-master.spec.in 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Looks good to me, but someone else must approve Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78539 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11a7db45d9beea773cf31187046aa67d9ecb5fbf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Dafna Ron <dron(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: DC QoS exception
by Code Review 22 Jun '17

22 Jun '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. Change subject: webadmin: DC QoS exception ...................................................................... webadmin: DC QoS exception - Fixed exception due to QoS models having multi selection enabled by default and that requires a data display to be associated with the selection model which wasn't the case. - Added the ability to have multiple active detail models for cases where we have multiple details models showing on a single page. This allows for proper refreshes of the views. - Cleaned up some commented code that wasn't being used. Change-Id: Ic61934da65459180cc4f3fec0688a8d04a95af19 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/DetailModelProvider.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/DetailTabModelProvider.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/SearchableDetailModelProvider.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/SearchableDetailTabModelProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ListWithDetailsModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkQoSModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/DataCenterQosListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/EditCpuQosModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/EditHostNetworkQosModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/EditStorageQosModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/NewCpuQosModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/NewHostNetworkQosModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/NewStorageQosModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/QosModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/UserPortalDetailModelProvider.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/UserPortalSearchableDetailModelProvider.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/RegisterTemplateInfoPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/RegisterVmInfoPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportTemplatePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmFromExportDomainPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/ImportVmFromExternalProviderPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/HostNetworkQosListModelTable.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterQosView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/VmNetworkQosListModelTable.java 26 files changed, 116 insertions(+), 42 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/78255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic61934da65459180cc4f3fec0688a8d04a95af19 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Skip content type checks when removing snapshot memory...
by Code Review 22 Jun '17

22 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Skip content type checks when removing snapshot memory volume ...................................................................... core: Skip content type checks when removing snapshot memory volume Commit 2087f033 introduced a protection on deletion of memory images, however, since snapshot removal is removing those disks through RemoveDiskCommand the operation will be blocked upon snapshot with memory removal which should succeed. This patch adds the option to suppress content type checks upon disk removal and use it when removing a snapshot with memory Bug-Url: https://bugzilla.redhat.com/1464100 Change-Id: I82278e9f302225b2f7146b7c81344294d8ed41ca Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMemoryVolumesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/RemoveDiskCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveDiskParameters.java 4 files changed, 14 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/78521 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82278e9f302225b2f7146b7c81344294d8ed41ca Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webamdin: Standardize AbstractVmPopupWidget#DataCenterWithCl...
by Code Review 22 Jun '17

22 Jun '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webamdin: Standardize AbstractVmPopupWidget#DataCenterWithClusterComparator ...................................................................... webamdin: Standardize AbstractVmPopupWidget#DataCenterWithClusterComparator DataCenterWithClusterComparator is a boilerplate implementation for sorting DataCenterWithCluster objects by the DC name and then by the cluster name. This patch standardizes the implementation by removing the boilerplate code and replacing it with a chained Comparator.comapring(...).thenComapring call. The original code seems to have several slight bugs which do not seem to be the intended behavior based on the class' comment ("Comparator that sorts on data center name first, and then cluster name. Ignoring case."), and may lead to inconsistent sorting: - Two objects with a null DC name will be considered equivalent, regardless of the cluster name. This seems inconsistent with the behavior of sorting two objects with the same DC name by the cluster name. - Moreover, for two objects have a non-null DC name, if they have equal (*case sensitive*) DC names, they are sorted by the cluster name, but if the DC names are not equal, they are sorted by it in a *case insensitive* order. The revised code takes a cleaner, more obvious approach: - Sort by the DC names, in a case insensitive order, with the nulls last. - Break ties by sorting by cluster names, in a case insensitive order, again with nulls last. Change-Id: I6e5a06a8af094b3693228c29ed87182b4ae3183a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java 1 file changed, 5 insertions(+), 28 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/78525 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e5a06a8af094b3693228c29ed87182b4ae3183a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: AbstractVmPopupWidget type inference
by Code Review 22 Jun '17

22 Jun '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: AbstractVmPopupWidget type inference ...................................................................... webadmin: AbstractVmPopupWidget type inference Change-Id: Iec87e12aad361ef99efd905bdf3189f52c8c5b74 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/78523 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec87e12aad361ef99efd905bdf3189f52c8c5b74 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: AbstractVmPopupWidget diamond operator
by Code Review 22 Jun '17

22 Jun '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: AbstractVmPopupWidget diamond operator ...................................................................... webadmin: AbstractVmPopupWidget diamond operator Use Java 7's diamond operator to make the code cleaner and easier to read. Change-Id: I79812f1fe4197a9e37cec4225a1ec1fbe120bfa2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/78524 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79812f1fe4197a9e37cec4225a1ec1fbe120bfa2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: add element IDs to left navigation
by Code Review 22 Jun '17

22 Jun '17

>From Greg Sheremeta <gshereme(a)redhat.com>: Greg Sheremeta has submitted this change and it was merged. Change subject: engine: add element IDs to left navigation ...................................................................... engine: add element IDs to left navigation Add element IDs to left navigation to ease testing with selenium webdriver. I did not use the element id framework because then every tab would be IDed 'SimpleTab_hyperlink'. Change-Id: I81a0d7981b8ff977ca7cc2c254c8b4cc24cb6ff0 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tab/AbstractHeadlessTabPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tab/AbstractTab.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tab/TabDefinition.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/HeaderPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/HeaderView.java 5 files changed, 40 insertions(+), 14 deletions(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/67284 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81a0d7981b8ff977ca7cc2c254c8b4cc24cb6ff0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: reduce experimental history to 14
by Code Review 22 Jun '17

22 Jun '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: reduce experimental history to 14 ...................................................................... reduce experimental history to 14 matching other projects policy and reducing the space it currently occipies on jenkins master JIRA: https://ovirt-jira.atlassian.net/browse/OVIRT-1464 Change-Id: I8945739a01b987307e9a8aa5ec72d5deacd6b036 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/ovirt/test-experimental-latest-repo.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for review Eyal Edri: Verified; Looks good to me, approved; Ready for merge Barak Korren: Looks good to me Jenkins CI: Passed CI tests Evgheni Dereveanchin: Looks good to me -- To view, visit https://gerrit.ovirt.org/78390 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8945739a01b987307e9a8aa5ec72d5deacd6b036 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in jenkins[master]: Fix branches of metamodel jobs
by Code Review 22 Jun '17

22 Jun '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: Fix branches of metamodel jobs ...................................................................... Fix branches of metamodel jobs Currently the API metamodel jobs with versions 'master' and '1.1' are both triggered when is submitted to the 'master' branch. This patch fixes that, so that the job with version 'master' is triggered only when a change is submitted to the 'master' branch, and the job with version '1.1' is triggered only when a change is submitted to the 'metamodel_1.1' branch. Change-Id: I47004570fa3770c669b8d082c35d72ef70c222b5 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-api-metamodel/ovirt-engine-api-metamodel_checks.yaml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Ready for review Eyal Edri: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78509 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47004570fa3770c669b8d082c35d72ef70c222b5 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in jenkins[master]: OVIRT-1451 - Add a CI mirror for Gluster 3.10
by Code Review 22 Jun '17

22 Jun '17

>From Evgheni Dereveanchin <ederevea(a)redhat.com>: Evgheni Dereveanchin has submitted this change and it was merged. Change subject: OVIRT-1451 - Add a CI mirror for Gluster 3.10 ...................................................................... OVIRT-1451 - Add a CI mirror for Gluster 3.10 This patch adds glusterfs-3.10-el7 to our CI mirrors. Change-Id: I88715ac7380ad0a24f8a011107330fc990a9c5f0 Jira-ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1451 Signed-off-by: Evgheni Dereveanchin <ederevea(a)redhat.com> --- M data/mirrors-reposync.conf M jobs/confs/projects/system/sync_mirrors.yaml 2 files changed, 8 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for review Barak Korren: Looks good to me Eyal Edri: Looks good to me Jenkins CI: Passed CI tests Evgheni Dereveanchin: Verified; Looks good to me, approved; Ready for merge -- To view, visit https://gerrit.ovirt.org/78343 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88715ac7380ad0a24f8a011107330fc990a9c5f0 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: packaging: license: add NOTICE file
by Code Review 22 Jun '17

22 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: packaging: license: add NOTICE file ...................................................................... packaging: license: add NOTICE file Most Apache License 2.0 projects don't have a NOTICE file, but ASF proejects always do. So whenever you are using code from an ASF project you have to make sure you copy over that project's NOTICE file. In ovirt-engine, it looks like the files in utils/src/main/java/org/ovirt/engine/core/utils/ssl were taken from the old Apache HttpClient project. The NOTICE file for one revision of this project is here: https://svn.apache.org/repos/asf/httpcomponents/oac.hc3x/trunk/NOTICE.txt Another use of ASF code I found was: frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/StringUtils.java which seems to be taken from an old version of Apache Commons Lang, which had a NOTICE file approximately like this one: https://git-wip-us.apache.org/repos/asf?p=commons-lang.git;a=blob;f=NOTICE.… Adding the NOTICE to the project. Change-Id: I640c5d46cb3d78cf9f95c789e3956633ac8c5741 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit 1044a0e7a2baafaccdf804e1d75b8b8a5d8acd3b) --- A NOTICE 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78494 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I640c5d46cb3d78cf9f95c789e3956633ac8c5741 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0