June 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.1]: packaging: licenses: fix webadmin licenses
by Code Review 22 Jun '17

22 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: packaging: licenses: fix webadmin licenses ...................................................................... packaging: licenses: fix webadmin licenses frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/java/util/UUID.java: * Copyright 2003-2007 Sun Microsystems, Inc. All Rights Reserved. frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/java/util/StringTokenizer.java: * Copyright 1994-2004 Sun Microsystems, Inc. All Rights Reserved. LICENSE: 2. Grant of Copyright License. Subject to the terms and conditions of LICENSE: Copyright [yyyy] [name of copyright owner] These two must have been taken from OpenJDK. They are covered by GPLv2 plus the Classpath Exception. Change-Id: I6f424e2ca585e1c5b8f382e88240f8b4c16f544b Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/java/util/LICENSE M ovirt-engine.spec.in 2 files changed, 350 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78492 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f424e2ca585e1c5b8f382e88240f8b4c16f544b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: packaging: licenses: fix checkstyle
by Code Review 22 Jun '17

22 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: packaging: licenses: fix checkstyle ...................................................................... packaging: licenses: fix checkstyle build-tools-root/ovirt-checkstyle-extension/src/main/java/org/ovirt/checkstyle/checks/DiamondOperatorCheck.java:// Copyright (C) 2001-2011 Oliver Burn Copyright (C) 2015 Allon Mureinik (adoption to oVirt) This is covered by LGPLv2.1+. Change-Id: Ie9ef5b8d3c7ed40956b34675272dab25ea28aa45 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A build-tools-root/ovirt-checkstyle-extension/src/main/java/org/ovirt/checkstyle/checks/lgpl-2.1.txt 1 file changed, 502 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78493 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9ef5b8d3c7ed40956b34675272dab25ea28aa45 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: packaging: licenses: fix backend licensing
by Code Review 22 Jun '17

22 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: packaging: licenses: fix backend licensing ...................................................................... packaging: licenses: fix backend licensing backend/manager/modules/services/src/main/webapp/spicehtml5-main.jsp: Copyright (C) 2012 by Jeremy P. White <jwhite(a)codeweavers.com> backend/manager/modules/services/src/main/webapp/novnc-main.jsp: Copyright (C) 2011 Joel Martin These two are covered by LGPLv3, as indicated in their license notices. We need to comply with the license by including a copy of both LGPLv3 (https://www.gnu.org/licenses/lgpl-3.0.txt) and GPLv3 (https://www.gnu.org/licenses/gpl-3.0.txt) Change-Id: I07deb61296afd80a523c79efb0572e01984eefc4 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A backend/manager/modules/services/src/main/webapp/gpl-3.0.txt A backend/manager/modules/services/src/main/webapp/lgpl-3.0.txt M ovirt-engine.spec.in 3 files changed, 842 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78495 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07deb61296afd80a523c79efb0572e01984eefc4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-release[ovirt-4.1]: build: ovirt-release41-4.1.3_rc3
by Code Review 22 Jun '17

22 Jun '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-release41-4.1.3_rc3 ...................................................................... build: ovirt-release41-4.1.3_rc3 Change-Id: Id2f7dcfb46a44a9c4ca1e99771cd4cf6be0ccf41 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-release41.spec.in 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78496 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2f7dcfb46a44a9c4ca1e99771cd4cf6be0ccf41 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: licenses: fix backend licensing
by Code Review 22 Jun '17

22 Jun '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: licenses: fix backend licensing ...................................................................... packaging: licenses: fix backend licensing backend/manager/modules/services/src/main/webapp/spicehtml5-main.jsp: Copyright (C) 2012 by Jeremy P. White <jwhite(a)codeweavers.com> backend/manager/modules/services/src/main/webapp/novnc-main.jsp: Copyright (C) 2011 Joel Martin These two are covered by LGPLv3, as indicated in their license notices. We need to comply with the license by including a copy of both LGPLv3 (https://www.gnu.org/licenses/lgpl-3.0.txt) and GPLv3 (https://www.gnu.org/licenses/gpl-3.0.txt) Change-Id: I07deb61296afd80a523c79efb0572e01984eefc4 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A backend/manager/modules/services/src/main/webapp/gpl-3.0.txt A backend/manager/modules/services/src/main/webapp/lgpl-3.0.txt M ovirt-engine.spec.in 3 files changed, 842 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78368 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07deb61296afd80a523c79efb0572e01984eefc4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.1]: build: ovirt-live 4.1.3 rc3
by Code Review 22 Jun '17

22 Jun '17

>From Lev Veyde <lveyde(a)redhat.com>: Lev Veyde has submitted this change and it was merged. Change subject: build: ovirt-live 4.1.3 rc3 ...................................................................... build: ovirt-live 4.1.3 rc3 Change-Id: Ib923a4ff9c2586e4eb16a164ffcdf68483102ba6 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M centos-7/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Lev Veyde: Verified; Looks good to me, approved; Passed CI tests Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib923a4ff9c2586e4eb16a164ffcdf68483102ba6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.1 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: license: add NOTICE file
by Code Review 22 Jun '17

22 Jun '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: license: add NOTICE file ...................................................................... packaging: license: add NOTICE file Most Apache License 2.0 projects don't have a NOTICE file, but ASF proejects always do. So whenever you are using code from an ASF project you have to make sure you copy over that project's NOTICE file. In ovirt-engine, it looks like the files in utils/src/main/java/org/ovirt/engine/core/utils/ssl were taken from the old Apache HttpClient project. The NOTICE file for one revision of this project is here: https://svn.apache.org/repos/asf/httpcomponents/oac.hc3x/trunk/NOTICE.txt Another use of ASF code I found was: frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/StringUtils.java which seems to be taken from an old version of Apache Commons Lang, which had a NOTICE file approximately like this one: https://git-wip-us.apache.org/repos/asf?p=commons-lang.git;a=blob;f=NOTICE.… Adding the NOTICE to the project. Change-Id: I640c5d46cb3d78cf9f95c789e3956633ac8c5741 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A NOTICE 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I640c5d46cb3d78cf9f95c789e3956633ac8c5741 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: licenses: fix checkstyle
by Code Review 22 Jun '17

22 Jun '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: licenses: fix checkstyle ...................................................................... packaging: licenses: fix checkstyle build-tools-root/ovirt-checkstyle-extension/src/main/java/org/ovirt/checkstyle/checks/DiamondOperatorCheck.java:// Copyright (C) 2001-2011 Oliver Burn Copyright (C) 2015 Allon Mureinik (adoption to oVirt) This is covered by LGPLv2.1+. Change-Id: Ie9ef5b8d3c7ed40956b34675272dab25ea28aa45 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A build-tools-root/ovirt-checkstyle-extension/src/main/java/org/ovirt/checkstyle/checks/lgpl-2.1.txt 1 file changed, 502 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/78369 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9ef5b8d3c7ed40956b34675272dab25ea28aa45 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: licenses: fix webadmin licenses
by Code Review 22 Jun '17

22 Jun '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: licenses: fix webadmin licenses ...................................................................... packaging: licenses: fix webadmin licenses frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/java/util/UUID.java: * Copyright 2003-2007 Sun Microsystems, Inc. All Rights Reserved. frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/java/util/StringTokenizer.java: * Copyright 1994-2004 Sun Microsystems, Inc. All Rights Reserved. LICENSE: 2. Grant of Copyright License. Subject to the terms and conditions of LICENSE: Copyright [yyyy] [name of copyright owner] These two must have been taken from OpenJDK. They are covered by GPLv2 plus the Classpath Exception. Change-Id: I6f424e2ca585e1c5b8f382e88240f8b4c16f544b Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/java/util/LICENSE M ovirt-engine.spec.in 2 files changed, 350 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/78373 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f424e2ca585e1c5b8f382e88240f8b4c16f544b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: Add check for compensation tasks
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: Add check for compensation tasks ...................................................................... inventory: Add check for compensation tasks We already check for async tasks running, commands running and now new check is for compensation tasks. Change-Id: I41417963e994a8d569c004b8b86dc15925415b2c Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/Makefile.am M src/inventory_report/produceReport/pre-upgrade-checks M src/inventory_report/produceReport/produceReport.sh A src/inventory_report/produceReport/sqls/business_entity_snapshot_query_running_compensation_tasks.sql 4 files changed, 38 insertions(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78487 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41417963e994a8d569c004b8b86dc15925415b2c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: report encrypted fence agent passwords
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: report encrypted fence agent passwords ...................................................................... report encrypted fence agent passwords This patch adds to report the fence agent passwords. The idea behind is have such information available in case the hypervisors need to reinstall, example: from EL6 to EL7 platform. Change-Id: Iabd075488148a20c48637b10dc6a437b7310f1e4 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/Makefile.am M src/inventory_report/produceReport/produceReport.sh A src/inventory_report/produceReport/sqls/agent_passwords.sql A src/inventory_report/produceReport/sqls/cleanup_procedures_for_reporting_agent_passwords_as_csv.sql A src/inventory_report/produceReport/sqls/prepare_procedures_for_reporting_agent_passwords_as_csv.sql 5 files changed, 113 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78486 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iabd075488148a20c48637b10dc6a437b7310f1e4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: specify it's async tasks in Engine
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: specify it's async tasks in Engine ...................................................................... inventory: specify it's async tasks in Engine Change-Id: I4745d509770698ff5b1efc27fa5ac3b3fa79f508 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/pre-upgrade-checks 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78485 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4745d509770698ff5b1efc27fa5ac3b3fa79f508 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: Check for running commands
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: Check for running commands ...................................................................... inventory: Check for running commands Before upgrade engine let's check if there are commands still running. Change-Id: I38456cde17d5606d5ea55ccf0859600424f09f76 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/Makefile.am M src/inventory_report/produceReport/pre-upgrade-checks M src/inventory_report/produceReport/produceReport.sh A src/inventory_report/produceReport/sqls/command_entities_query_get_running_commands.sql 4 files changed, 44 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78484 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38456cde17d5606d5ea55ccf0859600424f09f76 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: Add validation for async tasks running in engine.
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: Add validation for async tasks running in engine. ...................................................................... inventory: Add validation for async tasks running in engine. Change-Id: Id7bd301c4abcb9233d5dfcfa87f436a4907a3b56 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/Makefile.am M src/inventory_report/produceReport/pre-upgrade-checks M src/inventory_report/produceReport/produceReport.sh A src/inventory_report/produceReport/sqls/async_tasks_query_running_tasks.sql 4 files changed, 41 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78483 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7bd301c4abcb9233d5dfcfa87f436a4907a3b56 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: make cluster_query_check_datacenter.sql compat with db 4.x
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: make cluster_query_check_datacenter.sql compat with db 4.x ...................................................................... make cluster_query_check_datacenter.sql compat with db 4.x Previously, the query only works with vds_groups table. Change-Id: I48fd281871da4ea13a43461833acd6d0b603eb28 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/sqls/cluster_query_check_datacenter.sql 1 file changed, 32 insertions(+), 6 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78482 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48fd281871da4ea13a43461833acd6d0b603eb28 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: fix missing table of contents.
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: fix missing table of contents. ...................................................................... fix missing table of contents. Change-Id: I1e44d8e2eff779cafbc5baf625e2c949c05580be Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M src/inventory_report/produceReport/produceReport.sh 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78481 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e44d8e2eff779cafbc5baf625e2c949c05580be Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: produceReport: only show versions in libvirt and vdsm fields
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: produceReport: only show versions in libvirt and vdsm fields ...................................................................... produceReport: only show versions in libvirt and vdsm fields Each component of the hosts table should only show the version. Change-Id: I0a0fd76ca4c2b547c8bd39cf4ed60dd711fef12e Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/produceReport.sh 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78480 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a0fd76ca4c2b547c8bd39cf4ed60dd711fef12e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: suggest engine-upgrade-check in engine details
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: suggest engine-upgrade-check in engine details ...................................................................... inventory: suggest engine-upgrade-check in engine details In the Engine details, let's suggest to users to run engine-upgrade-check before any upgrade in engine. Change-Id: I85c91d948933f44810ba435edd22625465b4454a Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/produceReport.sh 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78479 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85c91d948933f44810ba435edd22625465b4454a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: replace important icon with warning one.
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: replace important icon with warning one. ...................................................................... replace important icon with warning one. both produced exclamation symbol, one in triangle (this one stays), and other without any graphical support at all(this one was replaced). This created uncertainty where they differ (except for the triangle part), and exclamation without trinagle was much narrower then other symbol, which disrupted alignment. Change-Id: I6fdcb5225bc25d36307e007c0c4e057b618a8c28 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M src/inventory_report/produceReport/pre-upgrade-checks M src/inventory_report/produceReport/produceReport.sh 2 files changed, 3 insertions(+), 4 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78478 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fdcb5225bc25d36307e007c0c4e057b618a8c28 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: check for vms with VirtIO serial console in <= 3.5
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: check for vms with VirtIO serial console in <= 3.5 ...................................................................... inventory: check for vms with VirtIO serial console in <= 3.5 VMs with VirtIO serial console enabled in cluster levels 3.5 and below cannot be later live migrated to 3.6 hosts (on RHEL7). Change-Id: I50e493c7b2d849dc8a1588629f21bedf4bf832d7 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/Makefile.am M src/inventory_report/produceReport/pre-upgrade-checks M src/inventory_report/produceReport/produceReport.sh A src/inventory_report/produceReport/sqls/vms_with_cluster_lower_3_6_with_virtio_serial_console.sql 4 files changed, 71 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78477 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50e493c7b2d849dc8a1588629f21bedf4bf832d7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: Use IN instead of in for SQL cmds
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: Use IN instead of in for SQL cmds ...................................................................... inventory: Use IN instead of in for SQL cmds Change-Id: I08563cc0a882156ce2f9f1b54beaa44c0937c0f1 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/sqls/table_check_if_vds_groups_and_cluster_coexist.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/78476 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08563cc0a882156ce2f9f1b54beaa44c0937c0f1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: Add external link to CheckMixedRhelVersions option
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: Add external link to CheckMixedRhelVersions option ...................................................................... inventory: Add external link to CheckMixedRhelVersions option Change-Id: Ie493ba666d278300082f543952fa8365c540ad33 --- M src/inventory_report/produceReport/pre-upgrade-checks 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78475 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie493ba666d278300082f543952fa8365c540ad33 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: Check for Linux VMs with incorrect timezone
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: Check for Linux VMs with incorrect timezone ...................................................................... inventory: Check for Linux VMs with incorrect timezone Display a message if any Linux VM contain incorrect timezone. Change-Id: I0ae2d61f37636a17984c8a6d4c99e37c6787eeae Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/Makefile.am M src/inventory_report/produceReport/pre-upgrade-checks M src/inventory_report/produceReport/produceReport.sh A src/inventory_report/produceReport/sqls/vms_query_linux_and_others_vms_with_incorrect_timezone.sql 4 files changed, 182 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78474 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ae2d61f37636a17984c8a6d4c99e37c6787eeae Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: Check for Windows VMs with incorrect timezone
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: Check for Windows VMs with incorrect timezone ...................................................................... inventory: Check for Windows VMs with incorrect timezone Display a message if any Windows VM contain incorrect timezone. Change-Id: I5b4bdcb549fa29df8188a3a90d3d71ebfc0537d3 --- M src/inventory_report/Makefile.am M src/inventory_report/produceReport/pre-upgrade-checks M src/inventory_report/produceReport/produceReport.sh A src/inventory_report/produceReport/sqls/vms_query_windows_vms_with_incorrect_timezone.sql 4 files changed, 175 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78473 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b4bdcb549fa29df8188a3a90d3d71ebfc0537d3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: do not mix graphic admonition with awesomeicons + macros.
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: do not mix graphic admonition with awesomeicons + macros. ...................................................................... do not mix graphic admonition with awesomeicons + macros. Change-Id: I16be5d7cead45c44855828ee4ea9aef3d036221f Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M src/inventory_report/produceReport/pre-upgrade-checks M src/inventory_report/produceReport/produceReport.sh 2 files changed, 21 insertions(+), 18 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78472 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16be5d7cead45c44855828ee4ea9aef3d036221f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: Use warning/ok icons for pretty name validation
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: Use warning/ok icons for pretty name validation ...................................................................... inventory: Use warning/ok icons for pretty name validation Change-Id: I2de507362b128455cb97632572fd81181bb2198f Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/pre-upgrade-checks 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78471 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2de507362b128455cb97632572fd81181bb2198f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: Use better naming for hosts columns
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: Use better naming for hosts columns ...................................................................... inventory: Use better naming for hosts columns Cut 'versions' and use the right name for the packages. Change-Id: Ic532c66b0b424a2218820414d34ecfced483e5ec Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/produceReport.sh 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78470 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic532c66b0b424a2218820414d34ecfced483e5ec Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: split SQL to show DC and bash
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: split SQL to show DC and bash ...................................................................... inventory: split SQL to show DC and bash Others components can re-use all SQLs from the sqls dir. Change-Id: I3863f8d9b1b30d3ee7e895c3b3b33d8d6db1c0a4 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/Makefile.am M src/inventory_report/produceReport/produceReport.sh A src/inventory_report/produceReport/sqls/datacenter_show_all.sql 3 files changed, 7 insertions(+), 4 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78469 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3863f8d9b1b30d3ee7e895c3b3b33d8d6db1c0a4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: replace surname to last name
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: replace surname to last name ...................................................................... inventory: replace surname to last name Use Last Name instead of Surname. Use First Name as first field showing. Change-Id: Ib1583bfa8ace2e185a2f7863f4343dd1ad98025b Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/produceReport.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78468 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1583bfa8ace2e185a2f7863f4343dd1ad98025b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: pre-upgrade: add validation for host pretty name
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: pre-upgrade: add validation for host pretty name ...................................................................... pre-upgrade: add validation for host pretty name Reports empty pretty name values for hosts in order to warn about those hosts that may not display the correct Host type after upgrade. Change-Id: I60203503ec4025e5c56459cefe02e2061e7ca3cb Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1445297 Signed-off-by: emesika <emesika(a)redhat.com> Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/Makefile.am M src/inventory_report/produceReport/pre-upgrade-checks M src/inventory_report/produceReport/produceReport.sh A src/inventory_report/produceReport/sqls/hosts_query_check_pretty_name.sql 4 files changed, 60 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60203503ec4025e5c56459cefe02e2061e7ca3cb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: Add pkgs versions from sosreport (Engine)
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: Add pkgs versions from sosreport (Engine) ...................................................................... inventory: Add pkgs versions from sosreport (Engine) Show pkgs versions from engine. Change-Id: If8ac8602bb4bfcd7f124591e7a32ca385d30a868 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/pre-upgrade-checks M src/inventory_report/produceReport/produceReport.sh 2 files changed, 9 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78466 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8ac8602bb4bfcd7f124591e7a32ca385d30a868 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: pre-upgrade text
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: pre-upgrade text ...................................................................... inventory: pre-upgrade text Drop trailing colon to conform with the rest of the inventory script headres. Change-Id: I31933c5fbd264c948c167fb4da058543ed04acb8 Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> --- M src/inventory_report/produceReport/produceReport.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78465 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31933c5fbd264c948c167fb4da058543ed04acb8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: pre-upgrade-checks: Use Caps for Tables
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: pre-upgrade-checks: Use Caps for Tables ...................................................................... pre-upgrade-checks: Use Caps for Tables Change-Id: I16a568717e261f67ed413cdc5b7dfb60e6746019 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/pre-upgrade-checks 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78464 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16a568717e261f67ed413cdc5b7dfb60e6746019 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: Use sort unique to display past engines
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: Use sort unique to display past engines ...................................................................... inventory: Use sort unique to display past engines Change-Id: Iaa1d7d1a2bf7ccad6117cce594cb32ed6c16ecad Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/produceReport.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78463 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa1d7d1a2bf7ccad6117cce594cb32ed6c16ecad Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: only shows upgraded engines field if necessary
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: only shows upgraded engines field if necessary ...................................................................... inventory: only shows upgraded engines field if necessary Previously, we always showed the field 'Probable past the engine versions even when no upgrades happened from 3.y or show duplicate data. This patch will make sure we display this field only when needed and with no duplicate data. Change-Id: I1e82fdc1d00c6f11e3814dd5fb8d655f60d2c0f5 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/produceReport.sh 1 file changed, 15 insertions(+), 11 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78462 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e82fdc1d00c6f11e3814dd5fb8d655f60d2c0f5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory script: warn about vds_groups and cluster tables c...
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory script: warn about vds_groups and cluster tables coexist ...................................................................... inventory script: warn about vds_groups and cluster tables coexist vds_groups table has been renamed to cluster, shouldn't coexist Change-Id: Ibb72982c604c429cf6994e2a1859035d0c3b1aac Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/Makefile.am M src/inventory_report/produceReport/pre-upgrade-checks M src/inventory_report/produceReport/produceReport.sh A src/inventory_report/produceReport/sqls/table_check_if_vds_groups_and_cluster_coexist.sql 4 files changed, 19 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78460 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb72982c604c429cf6994e2a1859035d0c3b1aac Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: remove unneeded double quotes from msg
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: remove unneeded double quotes from msg ...................................................................... inventory: remove unneeded double quotes from msg Change-Id: I34db0360bb66f4c8f07d2564e5fae52b7171a76e Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/importDumpIntoNewDb.sh 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78461 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34db0360bb66f4c8f07d2564e5fae52b7171a76e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: pre-upgrade-checks: new line for hosts message
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: pre-upgrade-checks: new line for hosts message ...................................................................... pre-upgrade-checks: new line for hosts message Change-Id: I897d3c0c0c73e14357679b1084ce03daf64a73b2 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/pre-upgrade-checks 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78459 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I897d3c0c0c73e14357679b1084ce03daf64a73b2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: pre-upgrade-checks: improving text to users
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: pre-upgrade-checks: improving text to users ...................................................................... pre-upgrade-checks: improving text to users Change-Id: I0cf1e81210d36e5bc12025bb0002feefd5f3d87b Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/pre-upgrade-checks 1 file changed, 10 insertions(+), 10 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78458 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0cf1e81210d36e5bc12025bb0002feefd5f3d87b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: engine_versions_through_all_upgrades: improve regex
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: engine_versions_through_all_upgrades: improve regex ...................................................................... engine_versions_through_all_upgrades: improve regex Previously, the versions were displayed incorrectly, like 03.06 instead of 3.6. This patch improve regex to display correctly the field. Change-Id: I68ef6c065d06d7e118a6ef9bf7ed79ecac662bcd Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/sqls/engine_versions_through_all_upgrades.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78457 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68ef6c065d06d7e118a6ef9bf7ed79ecac662bcd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: produceReport: Improve table headers
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: produceReport: Improve table headers ...................................................................... produceReport: Improve table headers Let's improve the user experience and accurate the names of fields. Change-Id: I97a80b080a6567fdece227929bc1dca5e6b6abf5 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/produceReport.sh M src/inventory_report/produceReport/sqls/networks_table_not_using_network_attachments.sql M src/inventory_report/produceReport/sqls/networks_table_using_network_attachments.sql 3 files changed, 17 insertions(+), 17 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78456 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97a80b080a6567fdece227929bc1dca5e6b6abf5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: Use font-awesome icons
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: Use font-awesome icons ...................................................................... inventory: Use font-awesome icons Instead of mix 'passed' string and icons, let's use icons as well for the validated checks. Change-Id: I51cd890ff243070dee9de24da4946759ffd731b4 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/pre-upgrade-checks M src/inventory_report/produceReport/produceReport.sh 2 files changed, 7 insertions(+), 12 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78455 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51cd890ff243070dee9de24da4946759ffd731b4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: produceReport: improve footnote msg
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: produceReport: improve footnote msg ...................................................................... produceReport: improve footnote msg Few improvements to the footnote message Change-Id: I9998c3c5749f1761024f9d3a70fe1a43fd4bb83f Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/produceReport.sh 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78454 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9998c3c5749f1761024f9d3a70fe1a43fd4bb83f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: pre-upgrade-checks: Improve message about vms in cluster <= 3.5
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: pre-upgrade-checks: Improve message about vms in cluster <= 3.5 ...................................................................... pre-upgrade-checks: Improve message about vms in cluster <= 3.5 Change-Id: I241566d0be32236cc64a49d7c3208124e207b81d Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/pre-upgrade-checks 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78453 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I241566d0be32236cc64a49d7c3208124e207b81d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: produceReport: Rename DWH to Data Warehouse
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: produceReport: Rename DWH to Data Warehouse ...................................................................... produceReport: Rename DWH to Data Warehouse Change-Id: I4cbf4c36aa0892d84f75b2dcc8ade2ecc3a4f692 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/produceReport.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78452 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4cbf4c36aa0892d84f75b2dcc8ade2ecc3a4f692 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: unpackAndPrepareDump: fix typo postgress
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: unpackAndPrepareDump: fix typo postgress ...................................................................... unpackAndPrepareDump: fix typo postgress Change-Id: I462faa761d8a1e3d632c79968d518a0f2c8b3675 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/unpackAndPrepareDump.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I462faa761d8a1e3d632c79968d518a0f2c8b3675 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: config: update ENGINE_DEFAULTS
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: config: update ENGINE_DEFAULTS ...................................................................... config: update ENGINE_DEFAULTS Configuration file has been moved to: /usr/share/ovirt-engine/services/ovirt-engine/ovirt-engine.conf Change-Id: I118bc011df91513c764b3ae8f90949ed26db7a92 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1023455 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/config.py.in.in 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78450 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I118bc011df91513c764b3ae8f90949ed26db7a92 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: make sure CheckMixedRhelVersions are set true
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: make sure CheckMixedRhelVersions are set true ...................................................................... inventory: make sure CheckMixedRhelVersions are set true Advise users to disable the upgrade mode after all hosts upgraded to EL7 and before upgrading the manager. Change-Id: I85b733facb6d58db1b4d2bfd51b87ba5c3e86882 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/Makefile.am M src/inventory_report/produceReport/pre-upgrade-checks M src/inventory_report/produceReport/produceReport.sh A src/inventory_report/produceReport/sqls/vdc_options_query_checkmixedrhelversion.sql 4 files changed, 25 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78449 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85b733facb6d58db1b4d2bfd51b87ba5c3e86882 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: removing extra spaces, adding AS to have uniform syntax
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: removing extra spaces, adding AS to have uniform syntax ...................................................................... removing extra spaces, adding AS to have uniform syntax Change-Id: I961f2958bfc69aa5a3b3605070e5aa9e89809b57 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M src/inventory_report/produceReport/produceReport.sh 1 file changed, 8 insertions(+), 8 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78448 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I961f2958bfc69aa5a3b3605070e5aa9e89809b57 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: produceReport: Add db size to inventory script
by Code Review 21 Jun '17

21 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: produceReport: Add db size to inventory script ...................................................................... produceReport: Add db size to inventory script During the report, let's show the db size. Change-Id: I34e15c04a1ea4f74fcd75393e9b66674bdd74ca0 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/Makefile.am M src/inventory_report/produceReport/produceReport.sh A src/inventory_report/produceReport/sqls/database_size.sql 3 files changed, 9 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78447 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34e15c04a1ea4f74fcd75393e9b66674bdd74ca0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0