June 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: backend: fix log with empty removed luns list
by Code Review 11 Jun '17

11 Jun '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: backend: fix log with empty removed luns list ...................................................................... backend: fix log with empty removed luns list When SyncLunsInfoForBlockStorageDomain removes old luns from the db, it logs "Removed LUNs, IDs '<luns_list>'". When there are no luns to remove, the following useless log was still printed: "Removed LUNs, IDs ''". This patch fixes this bug so no log will be printed if there are no luns to remove. Change-Id: I072af233a3201980f69e73806fb068e6f1c39c1d Bug-Url: https://bugzilla.redhat.com/1460512 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommandTest.java 2 files changed, 25 insertions(+), 10 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/78064 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I072af233a3201980f69e73806fb068e6f1c39c1d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Correct getting ConnectAllHostsToLunResult
by Code Review 11 Jun '17

11 Jun '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: Correct getting ConnectAllHostsToLunResult ...................................................................... core: Correct getting ConnectAllHostsToLunResult Commit 05ceb0 introduced ConnectAllHostsToLunResult in order to make VdcReturnValueBase final. It, unfortunately, introduced a regression in ExtendSANStorageDomainCommand where ExtendSANStorageDomainCommand's return value was cast to a ConnectAllHostsToLunResult instead of the called ConnectAllHostsToLun result. Change-Id: I4fb74837c063addcd8810d6dfdab07b9a8c29870 Bug-Url: https://bugzilla.redhat.com/1460195 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ExtendSANStorageDomainCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/78052 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4fb74837c063addcd8810d6dfdab07b9a8c29870 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: ListModelObjectCellTable ArrayList ctor
by Code Review 11 Jun '17

11 Jun '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: ListModelObjectCellTable ArrayList ctor ...................................................................... webadmin: ListModelObjectCellTable ArrayList ctor This patch creates an ArrayList from the getSelectedSet() by using the overloaded consturctor instead of looping over getSelectedSet() and calling List#add for each element. At worst, this syntax is just cleaner and easier to understand. At best, it may offer a slightly improved performance, as the ArrayList has prior knowledge of the number of elements being added to it, and can thus avoid resizes. Change-Id: I0ab0b97006e95007e8495a7c017b563bcc148de8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelObjectCellTable.java 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/78051 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ab0b97006e95007e8495a7c017b563bcc148de8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: ListModelObjectCellTable type inference
by Code Review 11 Jun '17

11 Jun '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: ListModelObjectCellTable type inference ...................................................................... webadmin: ListModelObjectCellTable type inference Change-Id: Ibaf764577154f1e55c0929702f3d5b42439d47d2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelObjectCellTable.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/78049 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibaf764577154f1e55c0929702f3d5b42439d47d2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: ListModelObjectCellTable diamond operator
by Code Review 11 Jun '17

11 Jun '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: ListModelObjectCellTable diamond operator ...................................................................... webadmin: ListModelObjectCellTable diamond operator Change-Id: Ibfb3cb30b660ded5538018eb827542c88f9f27ed Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelObjectCellTable.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/78050 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibfb3cb30b660ded5538018eb827542c88f9f27ed Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Add support for bundling builds in changes
by Code Review 11 Jun '17

11 Jun '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. Change subject: Add support for bundling builds in changes ...................................................................... Add support for bundling builds in changes Added objects for tracking information about sets of builds in Jenkins and change object classes which allow embedding such information in change objects. Changed the implementation of GerritMergedChange to store builds. Had to change the internal data representation because objects that are a mix of tuple and 'regular' attributes are not pickled correctly in Python v2.7.13 Also made JenkinsTestedChangeList able to extract relevant information about builds from listed changes. Change-Id: I47fe457a2834ad4a28038a2ac98ba9b8d7ea61dc Signed-off-by: Barak Korren <bkorren(a)redhat.com> Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1077 --- M scripts/change_queue/__init__.py M scripts/change_queue/changes/__init__.py M scripts/jenkins_objects.py M test/test_jenkins_objects.py 4 files changed, 279 insertions(+), 9 deletions(-) Approvals: Barak Korren: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77002 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47fe457a2834ad4a28038a2ac98ba9b8d7ea61dc Gerrit-PatchSet: 10 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in jenkins[master]: Added build tracking to change queue pipelines
by Code Review 11 Jun '17

11 Jun '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. Change subject: Added build tracking to change queue pipelines ...................................................................... Added build tracking to change queue pipelines standard-enqueue jobs now embed information about launched build jobs into queued change objects Tester jobs for oVirt change queues can now track build jobs for tested changes, wait until they are done, and then compose the results into extra_sources files to be used by OST tests Change-Id: I3059c1ece2ed63adfa41a9804a172b5f4293b4fd Signed-off-by: Barak Korren <bkorren(a)redhat.com> Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1077 --- M pipelines/ovirt_change-queue-tester.groovy M pipelines/standard-enqueue.groovy 2 files changed, 143 insertions(+), 14 deletions(-) Approvals: Barak Korren: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77049 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3059c1ece2ed63adfa41a9804a172b5f4293b4fd Gerrit-PatchSet: 10 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in jenkins[master]: Adding production change queue job scaffolding
by Code Review 11 Jun '17

11 Jun '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. Change subject: Adding production change queue job scaffolding ...................................................................... Adding production change queue job scaffolding Adding some of the jobs needed for a full production change queue implementation: - A 'standard-enqueue' job to submit all merged patches with artifacts for testing by the change queue - A change queue jobs for oVirt 'master' and '4.1' - A stub test job for the change queue Also fixed some bugs with change queue code found in the process Signed-off-by: Barak Korren <bkorren(a)redhat.com> Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1077 Change-Id: I690ef51f621e925c092a8c2d96b78e9e2898ac97 --- M jobs/confs/groovy-scripts/pipeline-loader.groovy A jobs/confs/projects/ovirt/change-queues.yaml A jobs/confs/yaml/templates/change-queue.yaml A jobs/confs/yaml/templates/standard-enqueue.yaml M pipelines/change-queue.groovy A pipelines/ovirt_change-queue-tester.groovy A pipelines/standard-enqueue.groovy M scripts/change_queue/__init__.py M scripts/gerrit.py M scripts/jenkins_objects.py 10 files changed, 411 insertions(+), 8 deletions(-) Approvals: Barak Korren: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76456 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I690ef51f621e925c092a8c2d96b78e9e2898ac97 Gerrit-PatchSet: 20 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in jenkins[master]: Improve pipeline-loader checkout_repo function
by Code Review 11 Jun '17

11 Jun '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. Change subject: Improve pipeline-loader checkout_repo function ...................................................................... Improve pipeline-loader checkout_repo function Make the checkout_repo function also create the directory for the checkout and descend into it. That will make it more useful for other pipeline scripts. Change-Id: I57f470fa9aade3a69cd8920e734953f1967d3eb8 Signed-off-by: Barak Korren <bkorren(a)redhat.com> --- M jobs/confs/groovy-scripts/pipeline-loader.groovy 1 file changed, 13 insertions(+), 11 deletions(-) Approvals: Barak Korren: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77253 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57f470fa9aade3a69cd8920e734953f1967d3eb8 Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: backend: new exclusive lock for SyncLunsCommand
by Code Review 11 Jun '17

11 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: backend: new exclusive lock for SyncLunsCommand ...................................................................... backend: new exclusive lock for SyncLunsCommand This patch replaces the group of the exclusive lock that is used in SyncLunsInfoForBlockStorageDomainCommand (hereafter called "SyncLunsCommand") from SYNC_LUNS to STORAGE in order to avoid running it in parallel with ExtendSANStorageDomainCommand and ReduceSANStorageDomainDevicesCommand. To understand why it would corrupt the db, think about the following scenario: 1. There exists a block storage domain, sd1, and it is composed from one lun, lun1. 1. Thread A enters SyncLunsCommand::executeCommand, performs the call to getLunsFromVgInfo() and stores the information about lun1 in lunsFromVgInfo. 2. Thread B starts and completes the execution of ExtendSANStorageDomainCommand, so now sd1 is composed from two luns, lun1 and lun2. 3. Thread A executes the next line and stores the luns of sd1, lun1 and lun2, in lunsFromDb. 4. Thread A continues and at the end removes lun2 from the luns table, since it assumes that it's an unused and irrelevant lun. A similar case would happen with ReduceSANStorageDomainDevicesCommand (the only difference is that we will end up with another lun that should not have remained in the db). Since 13 other commands use a lock with the group STORAGE, and since we should make sure that some important commands won't get stuck when running in parallel with SyncLunsCommand, here's a list of all them: **Irrelevant commands** Following are commands that can't run in parallel with SyncLunsCommand because they will be blocked in the can do action anyway. Remember that executeCommand requires an active block domain. 1. DetachStorageDomainFromPoolCommand - sd should be on maintenance. 2. ForceRemoveStorageDomainCommand - sd cannot be active. 3. RemoveStorageDomainCommand - sd should be detached. 4. ImportHostedEngineStorageDomainCommand - sd still doesn't exist. 5. ActivateStorageDomainCommand - calls to SyncLunsCommand right after freeing the STORAGE lock. 6. AddExistingBlockStorageDomainCommand - sd still doesn't exist. 7. AttachStorageDomainToPoolCommand - sd should be detached. **Commands that we don't want to run in parallel with SyncLunsCommand** 1. ExtendSANStorageDomainCommand 2. ReduceSANStorageDomainDevicesCommand **Other commands that will collide with SyncLunsCommand** Following are commands that will collide with SyncLunsCommand, and thus the first command that will get the lock will succeed to run: 1. DeactivateStorageDomainCommand 2. ProcessOvfUpdateForStorageDomainCommand 3. ScanStorageForUnregisteredDisksCommand 4. UpdateStorageServerConnectionCommand Since SyncLunsCommand is not system initiated but user initiated, IMHO the risk that these commands will clash is presumably low. Change-Id: Ie0d56c593c5847e164f90d885a6711cd77c9c486 Related-To: https://bugzilla.redhat.com/1455548 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/locks/LockingGroup.java 2 files changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/78056 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0d56c593c5847e164f90d885a6711cd77c9c486 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: backend: override applyLockProperties in SyncLUNs
by Code Review 11 Jun '17

11 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: backend: override applyLockProperties in SyncLUNs ...................................................................... backend: override applyLockProperties in SyncLUNs The method applyLockProperties was not overridden by SyncLunsInfoForBlockStorageDomainCommand and thus the exclusive lock with the group SYNC_LUNS on the storage domain's id was never taken before running this command. Since we don't want two SyncLunsInfoForBlockStorageDomain commands to run concurrently for the same block storage domain, this patch overrides this method so that lock will be taken. Change-Id: Ica5aad22abd354c94110ab14d371be6d63ef43b1 Related-To: https://bugzilla.redhat.com/1455548 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommand.java 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/78055 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica5aad22abd354c94110ab14d371be6d63ef43b1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: backend: introduce SyncAttachedDirectLunsCommand
by Code Review 11 Jun '17

11 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: backend: introduce SyncAttachedDirectLunsCommand ...................................................................... backend: introduce SyncAttachedDirectLunsCommand This patch introduces a new command to synchronize direct luns that are attached to VMs in a given data center. It is useful when upgrading a data center or when a direct lun lacks some information because it was created via the REST API without a host. The command gets the data center id and synchronizes all the attached direct luns in it. It can also get one or more attached direct luns ids and synchronize only them. Note that the reason that we can't synchronize a floating direct lun is that it can be done by a host from any of the data centers, and hosts from different data centers might return different information about the lun. When a direct lun is attached to a VM, we pick a random host from the data center that this vm belongs to and use it to synchtonize the lun's information. Change-Id: I62b2d6a19400c180ae5869990df92639bbaa9b3b Related-To:https://bugzilla.redhat.com/1404389 Related-To:https://bugzilla.redhat.com/1455547 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/SyncAttachedDirectLunsCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/SyncAttachedDirectLunsCommandTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SyncAttachedDirectLunsParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskLunMapDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskLunMapDaoImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M packaging/dbscripts/disk_lun_map_sp.sql 13 files changed, 313 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/78059 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62b2d6a19400c180ae5869990df92639bbaa9b3b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: backend: sync all luns when upgrading a data center
by Code Review 11 Jun '17

11 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: backend: sync all luns when upgrading a data center ...................................................................... backend: sync all luns when upgrading a data center Up until now, when upgrading a data center from version <= 4.0 to version >= 4.1, all the storage domains' luns were synchronized in order to update their discard related new data from vdsm. However, direct luns were never synchronized and updated, so their discard related data was not automatically updated. Now, also direct luns that are attached to a VM in the data center are synchronized. Also, since UpdateStoragePoolCommand now uses SyncAllUsedLunsCommand and doesn't call directly to SyncLunsInfoForBlockStorageDomainCommand for all n active block storage domain, synchronizing all their luns should take ~ n times faster than it did before. Change-Id: Id2f191a5f3580d7c73764b9dcd80fe8b4ed43b1e Bug-Url:https://bugzilla.redhat.com/1455547 Bug-Url:https://bugzilla.redhat.com/1455548 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommandTest.java 2 files changed, 14 insertions(+), 106 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/78061 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2f191a5f3580d7c73764b9dcd80fe8b4ed43b1e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: backend: introduce SyncStorageDomainsLunsCommand
by Code Review 11 Jun '17

11 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: backend: introduce SyncStorageDomainsLunsCommand ...................................................................... backend: introduce SyncStorageDomainsLunsCommand This patch introduces a new command to synchronize all active block storage domains in a given data center. Previously, when synchronizing more than one storage domain (when upgrading a data center or when activating a host where the other hosts in the data center are not active), the engine used to call SyncLunsInfoForBlockStorageDomainCommand for each storage domain. The problem was that SyncLunsInfoForBlockStorageDomainCommand used to call GetVgInfoVDSCommand, so for each storage domain we did a full roundtrip to vdsm and back to the engine. With this patch, SyncStorageDomainsLunsCommand calls GetDeviceList only once, and uses that information to update all the domains in the data center. Therefore, when synchronizing n domains, the engine should do it ~ n times faster than it did before. Change-Id: I744ae190397e00856ed67b99046efd1b1bb26054 Related-To:https://bugzilla.redhat.com/1404389 Related-To:https://bugzilla.redhat.com/1455547 Related-To:https://bugzilla.redhat.com/1455548 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AbstractSyncLunsCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/SyncStorageDomainsLunsCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/AbstractSyncLunsCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/SyncStorageDomainsLunsCommandTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SyncLunsParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 6 files changed, 380 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/78058 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I744ae190397e00856ed67b99046efd1b1bb26054 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: backend: introduce SyncAllUsedLunsCommand
by Code Review 11 Jun '17

11 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: backend: introduce SyncAllUsedLunsCommand ...................................................................... backend: introduce SyncAllUsedLunsCommand This patch introduces a new command to synchronize all used luns in a given data center, storage domains' luns and attached direct luns. Change-Id: I601c0efa1f61a6268ffa98a186f7cb1187a2a33b Related-To:https://bugzilla.redhat.com/1455547 Related-To:https://bugzilla.redhat.com/1455548 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/SyncAllUsedLunsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 2 files changed, 42 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/78060 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I601c0efa1f61a6268ffa98a186f7cb1187a2a33b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: backend: feed SyncLunsInfo command with VG info
by Code Review 11 Jun '17

11 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: backend: feed SyncLunsInfo command with VG info ...................................................................... backend: feed SyncLunsInfo command with VG info This patch adds an option to set the list of luns, usually returned by GetVGInfoVDSCommand, in SyncLunsInfoForBlockStorageDomainParameters. When set, the command will not execute the call to GetVGInfoVDSCommand, but use the input from the parameters. Change-Id: I7115d7fc4a90faa61039d541617adba6822db2dd Related-To:https://bugzilla.redhat.com/1455548 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/FCPStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/ISCSIStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommandTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SyncLunsInfoForBlockStorageDomainParameters.java 6 files changed, 55 insertions(+), 15 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/78057 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7115d7fc4a90faa61039d541617adba6822db2dd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Refactor of setting disk attributes.
by Code Review 11 Jun '17

11 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Refactor of setting disk attributes. ...................................................................... core: Refactor of setting disk attributes. Engine updates the new disk image with updated size and actual size attributes based on the downloaded image retrieved from Glance. The engine reads the image using inputstream and therefore makes it hard to maintain for extra fields to update. The proposed patch refactors the update of the disk image fields, to be done inside the parsing method, making diskImage a parameter in the method signature. Change-Id: Iea7f2c6b566d9436d9799c56e86901e956ec49ae Bug-Url: https://bugzilla.redhat.com/1456432 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackImageProviderProxy.java 1 file changed, 20 insertions(+), 16 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/77949 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea7f2c6b566d9436d9799c56e86901e956ec49ae Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Update relative path in test.
by Code Review 11 Jun '17

11 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Update relative path in test. ...................................................................... core: Update relative path in test. Use relative path of bll instead of root backend - when running tests from the IDE the working directory is the root folder although run it from bll with mvn will use working directory of backend/manager/modules/bll, therefore changing the relative path of the XML file in the test to be relative to bll so jenkins tests will pass and for the IDE the working directory should be changed manually in the run configurations to be backend/manager/modules/bll. Change-Id: I54a8b0264e453696d168fc12a9ce6d9e6da5e946 Bug-Url: https://bugzilla.redhat.com/1443641 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/utils/OvfUtilsTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/77888 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54a8b0264e453696d168fc12a9ce6d9e6da5e946 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Filter out unregistered external VMs.
by Code Review 11 Jun '17

11 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Filter out unregistered external VMs. ...................................................................... core: Filter out unregistered external VMs. Once a storage domain is being imported and attached, the engine set a list of unregistered entities the user can register. If one of those entities is external VM the engine should ignore it since it is not a VM which the user should import. Change-Id: I13c4ef4d33929fc6d9fd098f913d67c3688aded0 Bug-Url: https://bugzilla.redhat.com/1443641 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/utils/OvfUtilsTest.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OvfUtils.java 2 files changed, 33 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/77889 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13c4ef4d33929fc6d9fd098f913d67c3688aded0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Use disk id instead of volume id in OvfUtilsTest
by Code Review 11 Jun '17

11 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Use disk id instead of volume id in OvfUtilsTest ...................................................................... core: Use disk id instead of volume id in OvfUtilsTest This fix is related to test of unregistered disks. The engine filters out disks which are attached to VMs to know which are unregistered disks and which are not. Since the filtering is being done with the disk id the test should be changed to use the disk id in the OVF instead of the volume id. Change-Id: Ib5d1f613a6ead694e93f8a29cda53b0f24d6de03 Bug-Url: https://bugzilla.redhat.com/1443641 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/utils/OvfUtilsTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/77887 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5d1f613a6ead694e93f8a29cda53b0f24d6de03 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: frontend: set DAD to false when entity is unavailable
by Code Review 11 Jun '17

11 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: frontend: set DAD to false when entity is unavailable ...................................................................... frontend: set DAD to false when entity is unavailable Patch a2e073845dc5485b36a6bad00c1a8e63c238342b indeed fixed a UI bug as requested, but it also made it impossible to: 1. Navigate to new block storage domain window. 2. Set DAD to true. 3. Navigate to file domain and create one. Since the last time DAD was available it was set to true, and since only the availability of DAD is set to false, the value remains true and the frontend tries to create a file domain with DAD = true ,which is impossible, and the user gets an error message. This patch sets DAD to false whenever it is unavailable. Change-Id: I7dfaa3e5e8ab083d2c0e4f3409e24a1b5111487b Bug-Url: https://bugzilla.redhat.com/1458568 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/78012 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7dfaa3e5e8ab083d2c0e4f3409e24a1b5111487b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: fix missing table of contents.
by Code Review 09 Jun '17

09 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: fix missing table of contents. ...................................................................... fix missing table of contents. Change-Id: I1e44d8e2eff779cafbc5baf625e2c949c05580be Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M src/inventory_report/produceReport/produceReport.sh 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Looks good to me, approved Martin Mucha: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78042 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e44d8e2eff779cafbc5baf625e2c949c05580be Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: jsonrpc: validate the connection with ping command
by Code Review 09 Jun '17

09 Jun '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. Change subject: jsonrpc: validate the connection with ping command ...................................................................... jsonrpc: validate the connection with ping command Use ping command instead of Host.getHardwareInfo to validate the status of the jsonrpc connection. Change-Id: I56a78f55c7dd53e1632a0ce4f51c3f985997e4cc Bug-Url: https://bugzilla.redhat.com/1457471 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/util.py 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56a78f55c7dd53e1632a0ce4f51c3f985997e4cc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.1]: Ignore unrelated responses from server
by Code Review 09 Jun '17

09 Jun '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Ignore unrelated responses from server ...................................................................... Ignore unrelated responses from server When using for example Kerberos authentication the server can return to the client more then one response. The client is interested only in last response which contains the information about the authentication, if it was successfull, so this patch add logic to ignore the headers which don't belong to last response. Change-Id: I3d894361dc15f6c21941db254c567d2d5ab9fb6f Related-to: https://bugzilla.redhat.com/1459254 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit af184796a6c15e7f3b3148c7edf7d053c5fe6142) --- M sdk/ext/ovirtsdk4c/ov_http_client.c 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78032 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d894361dc15f6c21941db254c567d2d5ab9fb6f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Ignore unrelated responses from server
by Code Review 09 Jun '17

09 Jun '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Ignore unrelated responses from server ...................................................................... Ignore unrelated responses from server When using for example Kerberos authentication the server can return to the client more then one response. The client is interested only in last response which contains the information about the authentication, if it was successfull, so this patch add logic to ignore the headers which don't belong to last response. Change-Id: I3d894361dc15f6c21941db254c567d2d5ab9fb6f Related-to: https://bugzilla.redhat.com/1459254 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/ext/ovirtsdk4c/ov_http_client.c 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77945 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d894361dc15f6c21941db254c567d2d5ab9fb6f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: sos: add an option to limit the maximum log size
by Code Review 09 Jun '17

09 Jun '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: sos: add an option to limit the maximum log size ...................................................................... sos: add an option to limit the maximum log size If log-size is specified, limit the maximum size of the logs collected from each host to log-size, and additionally limit the maximum number of days to 1 Change-Id: I0e4921c407bac0fc7abd15c1de188e91ef44f82c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1020790 Signed-off-by: Ryan Barry <rbarry(a)redhat.com> --- M src/__main__.py M src/ovirt-log-collector.8 2 files changed, 35 insertions(+), 7 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77279 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e4921c407bac0fc7abd15c1de188e91ef44f82c Gerrit-PatchSet: 7 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: cleanup unused parameter from RngUtils
by Code Review 09 Jun '17

09 Jun '17

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. Change subject: core: cleanup unused parameter from RngUtils ...................................................................... core: cleanup unused parameter from RngUtils The parameter usage was removed in 3d23f6bdf81c3f8d32ec512141fd058131fa0e6f but since this patch was meant to be backported, it was kept as simple as possible. This patch cleans the unused parameter up. Change-Id: If9c181174b760711a8f67388f93ad52704159fed Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddRngDeviceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateRngDeviceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VirtIoRngValidator.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/RngUtils.java 7 files changed, 8 insertions(+), 11 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77838 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If9c181174b760711a8f67388f93ad52704159fed Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Memory hotunplug button and missing specParams
by Code Review 09 Jun '17

09 Jun '17

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Memory hotunplug button and missing specParams ...................................................................... webadmin: Memory hotunplug button and missing specParams Memory hot unplug button is disabled for devices that misses specParams required to perform hot unplug - 'size' and 'node'. Bug-Url: https://bugzilla.redhat.com/1452631 Change-Id: I7d9fdab555097018bea4197b12eb3e60dfedeef5 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/HotUnplugCell.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties 3 files changed, 15 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76985 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d9fdab555097018bea4197b12eb3e60dfedeef5 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: Provide clearer error when failing to retrieve vm.conf from ...
by Code Review 09 Jun '17

09 Jun '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: Provide clearer error when failing to retrieve vm.conf from storage. ...................................................................... Provide clearer error when failing to retrieve vm.conf from storage. Change-Id: Id7b7d91d30625875856316fb8c4f26cd655ff94f Bug-Url: https://bugzilla.redhat.com/1434209 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> --- M src/bin/hosted-engine.in 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Denis Chaplygin: Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Jenny Tokar: Verified Yanir Quinn: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/77959 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7b7d91d30625875856316fb8c4f26cd655ff94f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Use AuditLogImpl for logging events
by Code Review 09 Jun '17

09 Jun '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: Use AuditLogImpl for logging events ...................................................................... engine: Use AuditLogImpl for logging events Instead of instantiating a command only for the sake of logging, the AuditLogImpl can be used instead for the exact purpose. In addition, the exact code was used for logging both host set memory and host set cpu actions. Code was reused for that purpose. Change-Id: I15fb72bfeb747b71ef5ede0026b26696ee68c025 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java 1 file changed, 14 insertions(+), 26 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77223 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15fb72bfeb747b71ef5ede0026b26696ee68c025 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: produceReport: only show versions in libvirt and vdsm fields
by Code Review 09 Jun '17

09 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: produceReport: only show versions in libvirt and vdsm fields ...................................................................... produceReport: only show versions in libvirt and vdsm fields Each component of the hosts table should only show the version. Change-Id: I0a0fd76ca4c2b547c8bd39cf4ed60dd711fef12e Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/produceReport.sh 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78024 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a0fd76ca4c2b547c8bd39cf4ed60dd711fef12e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Increase memory of running VM by non-dividable value
by Code Review 08 Jun '17

08 Jun '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: Increase memory of running VM by non-dividable value ...................................................................... core: Increase memory of running VM by non-dividable value If memory of VM in state UP was increased by value not dividable by config value HotPlugMemoryBlockSizeMb, then both memory in next run snapshot and DB was update. Now memory is update only in next run snapshot. Change-Id: Id65c4172d58fe57853b81b611cc06eb763a86a4e Bug-Url: https://bugzilla.redhat.com/1459765 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jakub Niedermertl: Verified Arik Hadas: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/78019 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id65c4172d58fe57853b81b611cc06eb763a86a4e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Validation of 'size' specParam in HotUnplugMemoryCommand
by Code Review 08 Jun '17

08 Jun '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: Validation of 'size' specParam in HotUnplugMemoryCommand ...................................................................... core: Validation of 'size' specParam in HotUnplugMemoryCommand Presence of 'size' specParam of hot unplugged memory device is validated. Change-Id: If29e04bc99c3ce4cb3799b1d93b7345f7c2f1e79 Bug-Url: https://bugzilla.redhat.com/1452631 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotUnplugMemoryCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 24 insertions(+), 0 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77022 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If29e04bc99c3ce4cb3799b1d93b7345f7c2f1e79 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Hotunplug button works with String specParams
by Code Review 08 Jun '17

08 Jun '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: webadmin: Hotunplug button works with String specParams ...................................................................... webadmin: Hotunplug button works with String specParams Memory hot unplug button in VM Devices subtab works with string specParams. Change-Id: Ic11f7514a47e79ffecdd0c5cf92867996b65bf32 Bug-Url: https://bugzilla.redhat.com/1452631 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDevicesListModel.java 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic11f7514a47e79ffecdd0c5cf92867996b65bf32 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: remove useless 'roundedElapsedTime'
by Code Review 08 Jun '17

08 Jun '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: remove useless 'roundedElapsedTime' ...................................................................... core: remove useless 'roundedElapsedTime' This field that resided in VmStatistics is always equal to the 'elapsedTime' field, so it is not needed. Change-Id: Ibb575cd96ec91a6154678e2a9cacbf0bcbaf5a46 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterVmView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskVmView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostVmView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/pool/SubTabPoolVmView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/template/SubTabTemplateVmView.java 10 files changed, 6 insertions(+), 47 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/78009 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb575cd96ec91a6154678e2a9cacbf0bcbaf5a46 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: inventory: suggest engine-upgrade-check in engine details
by Code Review 08 Jun '17

08 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: suggest engine-upgrade-check in engine details ...................................................................... inventory: suggest engine-upgrade-check in engine details In the Engine details, let's suggest to users to run engine-upgrade-check before any upgrade in engine. Change-Id: I85c91d948933f44810ba435edd22625465b4454a Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/produceReport.sh 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77966 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85c91d948933f44810ba435edd22625465b4454a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Memory device specParams int -> String
by Code Review 08 Jun '17

08 Jun '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: Memory device specParams int -> String ...................................................................... core: Memory device specParams int -> String Previously memory VM device specParams attribute held properties `node` and `size` as type `int`. However only types String and Map<String, String|Map> in specParams can be serialized to OVF. Such state resulted in empty tags in OVF: <SpecParams> <node></node> <size></size> </SpecParams> and subsequently in these properties missing from `specParams` map. >From this patch on `node` and `size` are stored in specParams of memory devices as Strings. Dealing with devices with integer properties: * engine memory: restart on update * DB: upgrade script * VDSM VM.conf: specParams are converted during device import (VmDevicesMonitoring#buildNewVmDevice) * snapshots: there shouldn't be any ints in snapshots, but rather empty xml tags in ovf files Since vdsm-api.yml defines 'node' and 'size' properties of VmMemoryDevice sturcture as type 'uint', these properties are converted before sending to vdsm (MemoryUtils). Dealing with devices with missing properties: These devices can survive in running VMs on VDSM or in VM snapshots created in engine version 3.6-4.1. VDSM can't currently can't parse missing properties from domain xml. Engine altered to be able to deal with missing properties (VmDeviceCommonUtils#getSizeOfMemoryDeviceMb). Memory devices are imported from snapshots only if snapshot is being previewed with memory (VmDeviceUtils#addImportedOtherDevices). Memory devices of snapshots previewed without memory would be automatically deleted during first VM device monitoring cycle anyway. Memory device is never sent to VDSM in field "custom" as unmanaged devices usually are. Memory device is sent to VDSM only with memory volume. In this case such memory devices would be created in libvirt anyway from snapshot created by libvirt. Sending these devices from engine prevent VDSM to report memory devices as unrecognized ones (VmInfoBuilderImpl#handleMemoryDevice). Bug-Url: https://bugzilla.redhat.com/1452631 Change-Id: If242a7938c7351001a35ad5f32bd62101bf74efc Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotSetAmountOfMemoryCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotUnplugMemoryCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ConvertVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HotUnplugMemoryVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetAmountOfMemoryVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/architecture/MemoryUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderImpl.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoring.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateBrokerVDSCommand.java A packaging/dbscripts/upgrade/04_02_0300_malformed_memory_devices_removed.sql 20 files changed, 146 insertions(+), 32 deletions(-) Approvals: Jakub Niedermertl: Verified Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76640 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If242a7938c7351001a35ad5f32bd62101bf74efc Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: check if ovirt-provider-ovn is installed based on...
by Code Review 08 Jun '17

08 Jun '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: check if ovirt-provider-ovn is installed based on provider id ...................................................................... packaging: check if ovirt-provider-ovn is installed based on provider id ovirt-provider-ovn will only be installed if not previously installed by engine-setup. The provider id saved in the postinstall file will be used to make the check. Note that this patch does not add a check against a provider installation done outside engine-setup. This will be handled separately. Change-Id: Id8077f42a4f409e14e8341d46b93491211b7e329 Signed-off-by: Marcin Mirecki<mmirecki(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/network/ovirtproviderovn.py 2 files changed, 18 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Marcin Mirecki: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/77779 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8077f42a4f409e14e8341d46b93491211b7e329 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: change incorrect ovn provider dependency
by Code Review 08 Jun '17

08 Jun '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: change incorrect ovn provider dependency ...................................................................... packaging: change incorrect ovn provider dependency One of the packages to be installed during ovirt-provider-ovn intallation was incorrect. It must be openvswitch-ovn-central instead of openvswitch-ovn-host Change-Id: Ic5d7b1b9d372b0c7dc7864c479d6c601db6c76f4 Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/network/ovirtproviderovn.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Marcin Mirecki: Verified Dominik Holler: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/77871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5d7b1b9d372b0c7dc7864c479d6c601db6c76f4 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: minor cleanup in lun disks monitoring
by Code Review 08 Jun '17

08 Jun '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: minor cleanup in lun disks monitoring ...................................................................... core: minor cleanup in lun disks monitoring 1. Use Collections.emptyMap instead of instantiating a map every time, even if there are no lun disks connected to the VM. 2. Use early-return to simplify the code. Change-Id: I9f5b3f386df87e03e3edfab5f1287707a0ca7242 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 21 insertions(+), 21 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/78008 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f5b3f386df87e03e3edfab5f1287707a0ca7242 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin, userportal: Improve GWT symbol map handling
by Code Review 08 Jun '17

08 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin,userportal: Improve GWT symbol map handling ...................................................................... webadmin,userportal: Improve GWT symbol map handling Before this patch, GWT .symbolMap files were installed through optional `{webadmin-portal,userportal}-debuginfo` RPM packages, which used the following layout: $PREFIX/share/ovirt-engine/gwt-symbols/webadmin/symbolMaps/ $PREFIX/share/ovirt-engine/gwt-symbols/userportal/symbolMaps/ with above directories containing <gwtPermStrongName>.symbolMap files. This had two main drawbacks: 1, GWT symbol maps were optional (not available right after Engine installation), imposing one extra step when trying to diagnose and fix GWT UI related problems 2, GWT symbol maps are big: 9 locales x 3 user agents = 27 .symbolMap files for each GWT application, for WebAdmin each .symbolMap file is ~37 M (x 27 = ~1 G) After this patch, GWT .symbolMap files are part of the core UI packages, using the following layout: $PREFIX/share/ovirt-engine/gwt-symbols/webadmin/symbolMaps.zip $PREFIX/share/ovirt-engine/gwt-symbols/userportal/symbolMaps.zip This solves both issues listed above. In case of an uncaught UI exception, `OvirtRemoteLoggingService` servlet opens the .zip file (using Java 8 zip FileSystem support) and streams relevant .symbolMap content needed for Java stack trace de-obfuscation. This also means that `{webadmin-portal,userportal}-debuginfo` RPM packages are now unnecessary and are therefore removed. Change-Id: I083a3b8ad5588f56b8569c862240591a44002326 Bug-Url: https://bugzilla.redhat.com/1431545 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M Makefile M backend/manager/modules/restapi/apidoc/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml A frontend/webadmin/modules/frontend-assemblies/pom.xml A frontend/webadmin/modules/frontend-assemblies/src/main/resources/assemblies/gwt-symbols.xml D frontend/webadmin/modules/frontend-symbols/pom.xml D frontend/webadmin/modules/frontend-symbols/resources/userportal/.keep D frontend/webadmin/modules/frontend-symbols/resources/webadmin/.keep M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/OvirtRemoteLoggingService.java M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M ovirt-engine.spec.in M pom.xml 15 files changed, 161 insertions(+), 148 deletions(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/77892 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I083a3b8ad5588f56b8569c862240591a44002326 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-scheduler-proxy[master]: Release 0.1.7
by Code Review 08 Jun '17

08 Jun '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. Change subject: Release 0.1.7 ...................................................................... Release 0.1.7 Change-Id: Ic288044c92db2cf03d9f7a669eea36d0f9e01618 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M VERSION M ovirt-scheduler-proxy.spec.in 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: Martin Sivák: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/77999 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic288044c92db2cf03d9f7a669eea36d0f9e01618 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-scheduler-proxy Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-scheduler-proxy[master]: Override Fedora 24 repositories for CI
by Code Review 08 Jun '17

08 Jun '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. Change subject: Override Fedora 24 repositories for CI ...................................................................... Override Fedora 24 repositories for CI Change-Id: I422a2a30c9a0d79f276630cd013a14b5a3797f2f Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- A automation/build-artifacts.repos.fc24 A automation/check-patch.repos.fc24 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78007 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I422a2a30c9a0d79f276630cd013a14b5a3797f2f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-scheduler-proxy Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: save the ovirt-engine provider id
by Code Review 08 Jun '17

08 Jun '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: save the ovirt-engine provider id ...................................................................... packaging: save the ovirt-engine provider id The id of the installed ovirt-provider-ovn should be saved by engine-setup. We could have multiple providers added to the provider, so we need to know which is the one added by engine-setup in case of future updates. Change-Id: I14a3676b4dc66afe09f0e25e6f8026af60b14c3b Signed-off-by: Marcin Mirecki<mmirecki(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/network/ovirtproviderovn.py 2 files changed, 21 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Marcin Mirecki: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/77778 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14a3676b4dc66afe09f0e25e6f8026af60b14c3b Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: introduce SyncAttachedDirectLunsCommand
by Code Review 08 Jun '17

08 Jun '17

>From Daniel Erez <derez(a)redhat.com>: Daniel Erez has submitted this change and it was merged. Change subject: backend: introduce SyncAttachedDirectLunsCommand ...................................................................... backend: introduce SyncAttachedDirectLunsCommand This patch introduces a new command to synchronize direct luns that are attached to VMs in a given data center. It is useful when upgrading a data center or when a direct lun lacks some information because it was created via the REST API without a host. The command gets the data center id and synchronizes all the attached direct luns in it. It can also get one or more attached direct luns ids and synchronize only them. Note that the reason that we can't synchronize a floating direct lun is that it can be done by a host from any of the data centers, and hosts from different data centers might return different information about the lun. When a direct lun is attached to a VM, we pick a random host from the data center that this vm belongs to and use it to synchtonize the lun's information. Change-Id: I62b2d6a19400c180ae5869990df92639bbaa9b3b Related-To:https://bugzilla.redhat.com/1404389 Related-To:https://bugzilla.redhat.com/1455547 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/SyncAttachedDirectLunsCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/SyncAttachedDirectLunsCommandTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SyncAttachedDirectLunsParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskLunMapDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskLunMapDaoImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDiskDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskLunMapDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskVmElementDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/LunDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M packaging/dbscripts/disk_lun_map_sp.sql 20 files changed, 342 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/77101 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62b2d6a19400c180ae5869990df92639bbaa9b3b Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: introduce SyncAllUsedLunsCommand
by Code Review 08 Jun '17

08 Jun '17

>From Daniel Erez <derez(a)redhat.com>: Daniel Erez has submitted this change and it was merged. Change subject: backend: introduce SyncAllUsedLunsCommand ...................................................................... backend: introduce SyncAllUsedLunsCommand This patch introduces a new command to synchronize all used luns in a given data center, storage domains' luns and attached direct luns. Change-Id: I601c0efa1f61a6268ffa98a186f7cb1187a2a33b Related-To:https://bugzilla.redhat.com/1455547 Related-To:https://bugzilla.redhat.com/1455548 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/SyncAllUsedLunsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 2 files changed, 42 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/77102 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I601c0efa1f61a6268ffa98a186f7cb1187a2a33b Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: sync all luns when upgrading a data center
by Code Review 08 Jun '17

08 Jun '17

>From Daniel Erez <derez(a)redhat.com>: Daniel Erez has submitted this change and it was merged. Change subject: backend: sync all luns when upgrading a data center ...................................................................... backend: sync all luns when upgrading a data center Up until now, when upgrading a data center from version <= 4.0 to version >= 4.1, all the storage domains' luns were synchronized in order to update their discard related new data from vdsm. However, direct luns were never synchronized and updated, so their discard related data was not automatically updated. Now, also direct luns that are attached to a VM in the data center are synchronized. Also, since UpdateStoragePoolCommand now uses SyncAllUsedLunsCommand and doesn't call directly to SyncLunsInfoForBlockStorageDomainCommand for all n active block storage domain, synchronizing all their luns should take ~ n times faster than it did before. Change-Id: Id2f191a5f3580d7c73764b9dcd80fe8b4ed43b1e Bug-Url:https://bugzilla.redhat.com/1455547 Bug-Url:https://bugzilla.redhat.com/1455548 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommandTest.java 2 files changed, 14 insertions(+), 106 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/77103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2f191a5f3580d7c73764b9dcd80fe8b4ed43b1e Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: introduce SyncStorageDomainsLunsCommand
by Code Review 08 Jun '17

08 Jun '17

>From Daniel Erez <derez(a)redhat.com>: Daniel Erez has submitted this change and it was merged. Change subject: backend: introduce SyncStorageDomainsLunsCommand ...................................................................... backend: introduce SyncStorageDomainsLunsCommand This patch introduces a new command to synchronize all active block storage domains in a given data center. Previously, when synchronizing more than one storage domain (when upgrading a data center or when activating a host where the other hosts in the data center are not active), the engine used to call SyncLunsInfoForBlockStorageDomainCommand for each storage domain. The problem was that SyncLunsInfoForBlockStorageDomainCommand used to call GetVgInfoVDSCommand, so for each storage domain we did a full roundtrip to vdsm and back to the engine. With this patch, SyncStorageDomainsLunsCommand calls GetDeviceList only once, and uses that information to update all the domains in the data center. Therefore, when synchronizing n domains, the engine should do it ~ n times faster than it did before. Change-Id: I744ae190397e00856ed67b99046efd1b1bb26054 Related-To:https://bugzilla.redhat.com/1404389 Related-To:https://bugzilla.redhat.com/1455547 Related-To:https://bugzilla.redhat.com/1455548 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AbstractSyncLunsCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/SyncStorageDomainsLunsCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/AbstractSyncLunsCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/SyncStorageDomainsLunsCommandTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SyncLunsParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 6 files changed, 377 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/74381 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I744ae190397e00856ed67b99046efd1b1bb26054 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: use streams in GetDeviceListQuery
by Code Review 08 Jun '17

08 Jun '17

>From Daniel Erez <derez(a)redhat.com>: Daniel Erez has submitted this change and it was merged. Change subject: backend: use streams in GetDeviceListQuery ...................................................................... backend: use streams in GetDeviceListQuery Change-Id: I24ac7b35724649418a21609d210b6535caa1ef32 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/lun/GetDeviceListQuery.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/77099 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24ac7b35724649418a21609d210b6535caa1ef32 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: feed SyncLunsInfo command with VG info
by Code Review 08 Jun '17

08 Jun '17

>From Daniel Erez <derez(a)redhat.com>: Daniel Erez has submitted this change and it was merged. Change subject: backend: feed SyncLunsInfo command with VG info ...................................................................... backend: feed SyncLunsInfo command with VG info This patch adds an option to set the list of luns, usually returned by GetVGInfoVDSCommand, in SyncLunsInfoForBlockStorageDomainParameters. When set, the command will not execute the call to GetVGInfoVDSCommand, but use the input from the parameters. Change-Id: I7115d7fc4a90faa61039d541617adba6822db2dd Related-To:https://bugzilla.redhat.com/1455548 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/FCPStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/ISCSIStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommandTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SyncLunsInfoForBlockStorageDomainParameters.java 6 files changed, 55 insertions(+), 15 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/77100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7115d7fc4a90faa61039d541617adba6822db2dd Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0