Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: Only show hosts health status check if required
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: inventory: Only show hosts health status check if required
......................................................................
inventory: Only show hosts health status check if required
If all hosts are good, no need to show this field in the report
Change-Id: Ie4eb7b7fcc7f1f3f4264329636a8f31bf4d7b57a
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/produceReport.sh
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/78426
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4eb7b7fcc7f1f3f4264329636a8f31bf4d7b57a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-4.1
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: Check if there are clusters without DC
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: inventory: Check if there are clusters without DC
......................................................................
inventory: Check if there are clusters without DC
Pre upgrade validation for clusters
Change-Id: I448273a0f3443dc4b7695eae4d0042a89696becd
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/produceReport.sh
A src/inventory_report/sqls/cluster_query_check_datacenter.sql
2 files changed, 13 insertions(+), 0 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/78425
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I448273a0f3443dc4b7695eae4d0042a89696becd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-4.1
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-log-collector[ovirt-log-collector-4.1]: reporting mac_addresses, initial/upgrade versions, %memory, ...
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: reporting mac_addresses, initial/upgrade versions, %memory, %cpu
......................................................................
reporting mac_addresses, initial/upgrade versions, %memory, %cpu
Change-Id: I68c080f0f03ab8d8cf2cd3bbcd8d302b80f2e1c5
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M src/inventory_report/produceReport.sh
A src/inventory_report/sqls/engine_versions_through_all_upgrades.sql
A src/inventory_report/sqls/networks_table_not_using_network_attachments.sql
A src/inventory_report/sqls/networks_table_using_network_attachments.sql
4 files changed, 106 insertions(+), 83 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/78424
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I68c080f0f03ab8d8cf2cd3bbcd8d302b80f2e1c5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-4.1
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-log-collector[ovirt-log-collector-4.1]: do not require execution from current dir + init variables o...
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: do not require execution from current dir + init variables on 1 place
......................................................................
do not require execution from current dir + init variables on 1 place
• uninitialized variables, inlined function 'initDbVariables'
• script needs not to be executed from current directory, thus 'sqls'
directory needs to be referenced in relations to produceReport script
Change-Id: Ibb424687aee48708203668af9234eafd620d5d05
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M src/inventory_report/produceReport.sh
1 file changed, 11 insertions(+), 16 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/78423
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb424687aee48708203668af9234eafd620d5d05
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-4.1
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory_report: Add documentation about tables values
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: inventory_report: Add documentation about tables values
......................................................................
inventory_report: Add documentation about tables values
Code readability improvement.
Change-Id: Ia35ea91f812e9b9a2a564770c054abef2babc7bc
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/sqls/storage_create_related_lookup_tables.sql
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/78422
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia35ea91f812e9b9a2a564770c054abef2babc7bc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-4.1
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-log-collector[ovirt-log-collector-4.1]: produceReport: use ascii table to display vms/hosts health
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: produceReport: use ascii table to display vms/hosts health
......................................................................
produceReport: use ascii table to display vms/hosts health
- A patch for improving the display layout for vms/hosts
- Add option to only crate adoc table without header
Change-Id: Iadceef2c5246241c44998bf615834130db965a60
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/produceReport.sh
1 file changed, 17 insertions(+), 6 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/78421
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iadceef2c5246241c44998bf615834130db965a60
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-4.1
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: Validate vms: Paused, ImageIllegal or ImageLocked
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: inventory: Validate vms: Paused, ImageIllegal or ImageLocked
......................................................................
inventory: Validate vms: Paused, ImageIllegal or ImageLocked
Add additional validation for vms status.
Change-Id: Ife1a341ea2ab8270527859b96fa3dbb6b7ee00fa
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/produceReport.sh
M src/inventory_report/sqls/cleanup.sql
A src/inventory_report/sqls/vms_create_related_lookup_tables.sql
A src/inventory_report/sqls/vms_query_health.sql
4 files changed, 72 insertions(+), 0 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/78420
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ife1a341ea2ab8270527859b96fa3dbb6b7ee00fa
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-4.1
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory - move storage create tablet to sql file
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: inventory - move storage create tablet to sql file
......................................................................
inventory - move storage create tablet to sql file
Splitting the logic helps the code readability.
Change-Id: I51397016d18293dc37c9161f5f6d67709f9cdc30
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/produceReport.sh
M src/inventory_report/sqls/cleanup.sql
A src/inventory_report/sqls/storage_create_related_lookup_tables.sql
3 files changed, 34 insertions(+), 22 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/78419
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I51397016d18293dc37c9161f5f6d67709f9cdc30
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-4.1
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-log-collector[ovirt-log-collector-4.1]: produceReport.sh: Add validation for third party certificates
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: produceReport.sh: Add validation for third party certificates
......................................................................
produceReport.sh: Add validation for third party certificates
If users set different path for ENGINE_PKI_TRUST_STORE to
load third party certificates, let's identify it.
Change-Id: Ie37650b82aea135d83d0a3b24cba1b9cc5ca6ce9
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/produceReport.sh
1 file changed, 33 insertions(+), 1 deletion(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/78418
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie37650b82aea135d83d0a3b24cba1b9cc5ca6ce9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-4.1
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-log-collector[ovirt-log-collector-4.1]: produceReport: Add pre-upgrade validation
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: produceReport: Add pre-upgrade validation
......................................................................
produceReport: Add pre-upgrade validation
This patch add a new session to report called Pre-upgrade,
which will do SQL commands to validate users database for
upgrade scenario. In this initial commit, we added the skill
to check hosts health. Finally, we also split the sql commands
and bash script for plainness.
Change-Id: I5d59a7e7fc896a4a59e08fee1d637d0289e2d2ce
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/produceReport.sh
A src/inventory_report/sqls/cleanup.sql
A src/inventory_report/sqls/hosts_create_related_lookup_tables.sql
A src/inventory_report/sqls/hosts_query_check_health.sql
4 files changed, 98 insertions(+), 29 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/78417
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d59a7e7fc896a4a59e08fee1d637d0289e2d2ce
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-4.1
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months