June 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: backend: remove unused LockingGroup DOMAIN_EXECUTION
by Code Review 06 Jun '17

06 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: backend: remove unused LockingGroup DOMAIN_EXECUTION ...................................................................... backend: remove unused LockingGroup DOMAIN_EXECUTION Change-Id: Ic8e5e9a256dbd362953826cb0aad7ccc888085a3 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/locks/LockingGroup.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/77492 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8e5e9a256dbd362953826cb0aad7ccc888085a3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1.2.z]: core: Include jcl-over-slf4j into tools modules
by Code Review 06 Jun '17

06 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Include jcl-over-slf4j into tools modules ...................................................................... core: Include jcl-over-slf4j into tools modules Apache commons-logging libraries are reimplemented within WildFly. In older versions the reimplementation has been provided by 'org.slf4j.jcl-over-slf4j' module, but in newer version reimplementation has been changed to 'org.jboss.logmanager.commons.logging'. This works fine if application is executed inside running WildFly, but we are using those libraries also outside running EAP in command line tools. In order to be able to use slf4j as our logging frontend we are using standard slf4j implementation instead of WildFly reimplementation of slf4j for our command line tools. Apache commons-logging is used indirectly through commons-configuration also in command line tool engine-config, so we would need to add 'org.slf4j.jcl-over-slf4j' into our special modules for command line tools to override this reimplementation change. Change-Id: Ia3fce0af7de78f5757a13a18c06dcd885dc7c215 Bug-Url: https://bugzilla.redhat.com/1457900 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/dependencies/tools/pom.xml A backend/manager/dependencies/tools/src/main/modules/org/apache/commons/logging/main/module.xml A backend/manager/dependencies/tools/src/main/modules/org/slf4j/jcl-over-slf4j/main/module.xml M ovirt-engine.spec.in 4 files changed, 50 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Passed CI tests Martin Peřina: Verified Juan Hernandez: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77863 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3fce0af7de78f5757a13a18c06dcd885dc7c215 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1.2.z Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1.2.z]: build: ovirt-engine-4.1.2.3
by Code Review 06 Jun '17

06 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: build: ovirt-engine-4.1.2.3 ...................................................................... build: ovirt-engine-4.1.2.3 Change-Id: Ib8e3e42cb65f8318f03e5a57cbdb56c553f21213 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/dependencies/common/pom.xml M backend/manager/dependencies/pom.xml M backend/manager/dependencies/tools/pom.xml M backend/manager/extensions-tool/pom.xml M backend/manager/logutils/pom.xml M backend/manager/modules/aaa/pom.xml M backend/manager/modules/auth-plugin/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/builtin-extensions/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/enginesso/pom.xml M backend/manager/modules/extensions-manager/pom.xml M backend/manager/modules/logger/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/apidoc/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/uutils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/ovirt-findbugs-filters/pom.xml M build-tools-root/pom.xml M build/validations/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend-symbols/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M mavenmake/pom.xml M pom.xml 57 files changed, 58 insertions(+), 58 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8e3e42cb65f8318f03e5a57cbdb56c553f21213 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1.2.z Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine-sdk[sdk_4.1]: Depend on python PyCurl version 7.43.0-6 on fc25
by Code Review 06 Jun '17

06 Jun '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Depend on python PyCurl version 7.43.0-6 on fc25 ...................................................................... Depend on python PyCurl version 7.43.0-6 on fc25 This patch add a depency on PyCurl package vesion 7.43.0-6 on Fedora 25. It's because of the PyCurl library which caused the Python SDK to not work. More information can be found at rhbz@1456477. Change-Id: Iea574cd206c68b14780ed250cfb653ed6a4dfee3 Bug-Url: https://bugzilla.redhat.com/1456666 Related-to: https://bugzilla.redhat.com/1456477 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M packaging/spec.fc25.in 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77865 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea574cd206c68b14780ed250cfb653ed6a4dfee3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Depend on python PyCurl version 7.43.0-6 on fc25
by Code Review 06 Jun '17

06 Jun '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Depend on python PyCurl version 7.43.0-6 on fc25 ...................................................................... Depend on python PyCurl version 7.43.0-6 on fc25 This patch add a depency on PyCurl package vesion 7.43.0-6 on Fedora 25. It's because of the PyCurl library which caused the Python SDK to not work. More information can be found at rhbz@1456477. Change-Id: Iea574cd206c68b14780ed250cfb653ed6a4dfee3 Bug-Url: https://bugzilla.redhat.com/1456666 Related-to: https://bugzilla.redhat.com/1456477 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M packaging/spec.fc25.in 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77732 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea574cd206c68b14780ed250cfb653ed6a4dfee3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add check for null storage format in storage domain va...
by Code Review 06 Jun '17

06 Jun '17

>From Maor Lipchuk <mlipchuk(a)redhat.com>: Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add check for null storage format in storage domain validator. ...................................................................... core: Add check for null storage format in storage domain validator. Add a null check in case of a REST request for storage format in storage domain validator. Change-Id: I7911876d933a9f523ee5e985980699d64a0cbfbf Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainValidator.java 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/77794 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7911876d933a9f523ee5e985980699d64a0cbfbf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Align pom file for microbenchmarks with other modules
by Code Review 06 Jun '17

06 Jun '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: core: Align pom file for microbenchmarks with other modules ...................................................................... core: Align pom file for microbenchmarks with other modules Removes module version and artifactId from pom file to align with other modules, which inherits version and artifactId from parent. Change-Id: Ib267f6eb1d013a11301882a569d0a667ebeefda4 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/microbenchmarks/pom.xml 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77395 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib267f6eb1d013a11301882a569d0a667ebeefda4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Double SSH timeout for install/upgrade
by Code Review 06 Jun '17

06 Jun '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: core: Double SSH timeout for install/upgrade ...................................................................... core: Double SSH timeout for install/upgrade Installation/Upgrade of the host may take a lot of time without any activity on SSH connection especially on slower hardware. But we don't want to increase SSH timeout globally, because this may in some use cases increase the time to restart non-responsive HA VMs, so we will just double SSH inactivity timeout only for installation/upgrade. Change-Id: I40264df442e3f4c1b9b3b7e5145651764747fd73 Bug-Url: https://bugzilla.redhat.com/1455667 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/OVirtNodeUpgrade.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/EngineSSHDialog.java 3 files changed, 31 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77572 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40264df442e3f4c1b9b3b7e5145651764747fd73 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove Python like syntax
by Code Review 06 Jun '17

06 Jun '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: core: Remove Python like syntax ...................................................................... core: Remove Python like syntax Removes Python like syntax from SSH related classes. Change-Id: I9eed4ff1fc47b677d6d2018399de6c1dc555668b Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/EngineSSHClient.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/EngineSSHDialog.java 2 files changed, 18 insertions(+), 18 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77849 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9eed4ff1fc47b677d6d2018399de6c1dc555668b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Use TimeUnit for time value conversions
by Code Review 06 Jun '17

06 Jun '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: core: Use TimeUnit for time value conversions ...................................................................... core: Use TimeUnit for time value conversions Use TimeUnit methods for time value conversion in SSH related classes. Change-Id: I16793b950037e297064fc622df4f4ac592002ad6 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/EngineSSHClient.java 1 file changed, 3 insertions(+), 8 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16793b950037e297064fc622df4f4ac592002ad6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0