July 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: Revert "restapi: Add Link-Following support"
by Code Review 26 Jul '17

26 Jul '17

>From Ori Liel <oliel(a)redhat.com>: Ori Liel has submitted this change and it was merged. ( https://gerrit.ovirt.org/79822 ) Change subject: Revert "restapi: Add Link-Following support" ...................................................................... Revert "restapi: Add Link-Following support" dependency on ovirt-engine-api-metamodel 1.2.8 causes regressions. This reverts commit d940b9819161b93ddc9d17cbd7422569897dd53d. Change-Id: I7f7b02e0d926f16be6c760c18ed4ca2b480b7c9e Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/ServiceTree.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/ServiceTreeCrawler.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/ServiceTreeNode.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/EntityHelper.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/ReflectionHelper.java D backend/manager/modules/restapi/interface/definition/src/test/java/org/ovirt/engine/api/utils/EntityHelperTest.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotDiskResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/ResourceLocator.java D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/LinkFollower.java D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/LinksTreeNode.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/ParametersHelper.java D backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/utils/LinksTreeNodeTest.java D backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/util/LinkFollowerTest.java M pom.xml 16 files changed, 11 insertions(+), 919 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved; Passed CI tests Martin Peřina: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/79822 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f7b02e0d926f16be6c760c18ed4ca2b480b7c9e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Add upstream-source-collector script to OST
by Code Review 26 Jul '17

26 Jul '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. ( https://gerrit.ovirt.org/79353 ) Change subject: Add upstream-source-collector script to OST ...................................................................... Add upstream-source-collector script to OST OST repos can also have thier upstream repos to 'rebase' code from. In order to support that I'm adding the upstream-source-collector script to all OST jobs Change-Id: I03956fdbb7bfb6eedb7f7eb596507a33b8f48ebf Signed-off-by: Gil Shinar <gshinar(a)redhat.com> --- 0 files changed, 0 insertions(+), 0 deletions(-) Approvals: Eyal Edri: Looks good to me, approved; Ready for merge Barak Korren: Looks good to me Gil Shinar: Verified; Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/79353 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03956fdbb7bfb6eedb7f7eb596507a33b8f48ebf Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in jenkins[master]: Create STD-CI jobs for GitHub staging projects
by Code Review 26 Jul '17

26 Jul '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/79722 ) Change subject: Create STD-CI jobs for GitHub staging projects ...................................................................... Create STD-CI jobs for GitHub staging projects Change-Id: Ifa7bd5700529028e01f8226f13822c13efb77d97 Signed-off-by: Barak Korren <bkorren(a)redhat.com> Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1533 --- A jobs/confs/staging-projects/stage-gh-stdci.yaml 1 file changed, 32 insertions(+), 0 deletions(-) Approvals: Eyal Edri: Looks good to me Barak Korren: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/79722 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa7bd5700529028e01f8226f13822c13efb77d97 Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in jenkins[master]: Create STD-CI jobs for a staging project
by Code Review 26 Jul '17

26 Jul '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/79600 ) Change subject: Create STD-CI jobs for a staging project ...................................................................... Create STD-CI jobs for a staging project Also update the defaults file to make it behave more like the production file Change-Id: Icb500dbc81674cf00b4dcf940354836b8838036b Signed-off-by: Barak Korren <bkorren(a)redhat.com> Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1532 --- M jobs/confs/staging-projects/defaults.yaml A jobs/confs/staging-projects/stage-stdci.yaml A jobs/confs/yaml/scms/stage-stdci.yaml 3 files changed, 34 insertions(+), 15 deletions(-) Approvals: Eyal Edri: Looks good to me Barak Korren: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/79600 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb500dbc81674cf00b4dcf940354836b8838036b Gerrit-PatchSet: 5 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in jenkins[master]: Add gerrit-with-proto macro for non git:// cloning
by Code Review 26 Jul '17

26 Jul '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/79647 ) Change subject: Add gerrit-with-proto macro for non git:// cloning ...................................................................... Add gerrit-with-proto macro for non git:// cloning Our existing 'gerrit' SCM macro only supports cloning with 'git://' so adding a new macro called 'gerrit-with-proto' that supports specifying which protocol to clone with. Change-Id: I16c03f9f3812d6574239c5d31427857c8fc01caf Signed-off-by: Barak Korren <bkorren(a)redhat.com> --- M jobs/confs/yaml/scms/gerrit.yaml 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Barak Korren: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/79647 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16c03f9f3812d6574239c5d31427857c8fc01caf Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in jenkins[master]: Handle branches other then 'master' on GitHub
by Code Review 26 Jul '17

26 Jul '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/79786 ) Change subject: Handle branches other then 'master' on GitHub ...................................................................... Handle branches other then 'master' on GitHub Our GitHub code could only handle the 'master' branch so far. This should fix it. Change-Id: I7975a870218a95dfa63db47fa445f5ff79ee9594 Signed-off-by: Barak Korren <bkorren(a)redhat.com> --- M jobs/confs/yaml/triggers/github.yaml 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Ondra Machacek: Looks good to me Barak Korren: Verified; Looks good to me, approved; Ready for merge Eyal Edri: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/79786 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7975a870218a95dfa63db47fa445f5ff79ee9594 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in jenkins[master]: Remove old deploy-to-experimental jobs
by Code Review 26 Jul '17

26 Jul '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/79326 ) Change subject: Remove old deploy-to-experimental jobs ...................................................................... Remove old deploy-to-experimental jobs These jubs use to be triggered by build-artifacts jobs, and are now no longer triggered by anything so we can safely remove them. Change-Id: I5f39bcd4f095d55a819636d51c6e0b9ecd7abdaa Signed-off-by: Barak Korren <bkorren(a)redhat.com> --- M jobs/confs/projects/ovirt/deploy_to_experimental.yaml 1 file changed, 0 insertions(+), 14 deletions(-) Approvals: Barak Korren: Verified; Looks good to me, approved; Ready for merge Gil Shinar: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/79326 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f39bcd4f095d55a819636d51c6e0b9ecd7abdaa Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Add Link-Following support
by Code Review 26 Jul '17

26 Jul '17

>From Ori Liel <oliel(a)redhat.com>: Ori Liel has submitted this change and it was merged. ( https://gerrit.ovirt.org/76077 ) Change subject: restapi: Add Link-Following support ...................................................................... restapi: Add Link-Following support Add 'link-following' feature. This feature enables API users to request references inside an entity to be fully fetched alonside the entity. For example, to recieve a VM along with its nics: GET .../api/vms?follow=nics Complex usages are possible, with several links/references of an entity followd, and at several levels of depth, e.g: GET .../api/vms?follow=disk_attachments.disk,nics Bug-Url: https//bugzilla.redhat.com/1463633 Change-Id: I68e242b3668612c70abca9e80d0495b87833ae27 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/ServiceTree.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/ServiceTreeCrawler.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/ServiceTreeNode.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/EntityHelper.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/ReflectionHelper.java A backend/manager/modules/restapi/interface/definition/src/test/java/org/ovirt/engine/api/utils/EntityHelperTest.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotDiskResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/ResourceLocator.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/LinkFollower.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/LinksTreeNode.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/ParametersHelper.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/utils/LinksTreeNodeTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/util/LinkFollowerTest.java M pom.xml 16 files changed, 919 insertions(+), 11 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68e242b3668612c70abca9e80d0495b87833ae27 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: VmModelBehaviorBase type inference
by Code Review 25 Jul '17

25 Jul '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/79708 ) Change subject: webadmin: VmModelBehaviorBase type inference ...................................................................... webadmin: VmModelBehaviorBase type inference Change-Id: I28644c7d225ca80adfeb272a3da3581d118128fb Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/79708 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28644c7d225ca80adfeb272a3da3581d118128fb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: resize dashboard on window resize
by Code Review 25 Jul '17

25 Jul '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/79776 ) Change subject: webadmin: resize dashboard on window resize ...................................................................... webadmin: resize dashboard on window resize Previously, the dashboard (and other ui plugins) had their height calculated at iframe load time. However, when a user resized the window, the iframe height was not recalculated, often leading to a duplicate vertical scrollbar (one for the page, one for the iframe.) Fixed by simply calling the frame resize handler on page resize as well. Change-Id: I3af0f64bf4d7013dd3d31f675490368e5bdd7c7c Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/DynamicUrlContentTabView.java 1 file changed, 6 insertions(+), 8 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/79776 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3af0f64bf4d7013dd3d31f675490368e5bdd7c7c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0