Change in ovirt-engine[master]: core: Set memory disks description to include VM and snapsho...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80977 )
Change subject: core: Set memory disks description to include VM and snapshot info
......................................................................
core: Set memory disks description to include VM and snapshot info
Change-Id: I6abbdf34ed21c5adec8f3260ac19239865fcc372
Bug-Url: https://bugzilla.redhat.com/1483500
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/LiveSnapshotMemoryImageBuilder.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryUtils.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommand.java
A packaging/dbscripts/upgrade/04_02_0530_update_memory_disks_description.sql
5 files changed, 33 insertions(+), 20 deletions(-)
Approvals:
Tal Nisan: Verified; Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/80977
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6abbdf34ed21c5adec8f3260ac19239865fcc372
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Eyal Shenitzky <eshenitz(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shani Leviim <sleviim(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months
Change in ovirt-engine-sdk-ruby[sdk_4.1]: Remove RPM build dependencies not needed
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged. ( https://gerrit.ovirt.org/81032 )
Change subject: Remove RPM build dependencies not needed
......................................................................
Remove RPM build dependencies not needed
This patch removes some build dependencies that aren't used during the
RPM build process.
Change-Id: Ida85427b7286ad8f0aeee6a7690845e4ce3340c9
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit b9d456a1ba493dae68a310eb855a4f332eaa2e21)
---
M packaging/spec.el7.in
M packaging/spec.fc23.in
M packaging/spec.fc24.in
M packaging/spec.fc25.in
4 files changed, 0 insertions(+), 13 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/81032
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ida85427b7286ad8f0aeee6a7690845e4ce3340c9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months
Change in ovirt-engine-sdk-ruby[master]: Remove RPM build dependencies not needed
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged. ( https://gerrit.ovirt.org/81030 )
Change subject: Remove RPM build dependencies not needed
......................................................................
Remove RPM build dependencies not needed
This patch removes some build dependencies that aren't used during the
RPM build process.
Change-Id: Ida85427b7286ad8f0aeee6a7690845e4ce3340c9
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M packaging/spec.el7.in
M packaging/spec.fc24.in
M packaging/spec.fc25.in
3 files changed, 0 insertions(+), 12 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/81030
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ida85427b7286ad8f0aeee6a7690845e4ce3340c9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months
Change in ovirt-log-collector[master]: inventory: check if postgres data exist in the sos
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/81026 )
Change subject: inventory: check if postgres data exist in the sos
......................................................................
inventory: check if postgres data exist in the sos
In case the sosreport doesn't contain the postgres data,
exit and provide a message to users.
Change-Id: Ia01aa082a8dbb777b872b992fc050ab7ac7ebf1d
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/unpackAndPrepareDump.sh
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/81026
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia01aa082a8dbb777b872b992fc050ab7ac7ebf1d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months
Change in ovirt-release[master]: spec: remove experimental repo
by Code Review
>From Lev Veyde <lveyde(a)redhat.com>:
Lev Veyde has submitted this change and it was merged. ( https://gerrit.ovirt.org/81020 )
Change subject: spec: remove experimental repo
......................................................................
spec: remove experimental repo
Experimental repo is now deprecated, thus we're removing it.
Change-Id: Ib2b3316aec886460225f3e4268186357383486cb
Signed-off-by: Lev Veyde <lveyde(a)redhat.com>
---
M Makefile.am
M configure.ac
D ovirt-experimental.repo.in
M ovirt-release-master.spec.in
4 files changed, 0 insertions(+), 63 deletions(-)
Approvals:
Lev Veyde: Verified; Looks good to me, approved; Passed CI tests
Sandro Bonazzola: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/81020
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2b3316aec886460225f3e4268186357383486cb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months
Change in ovirt-release[ovirt-4.1]: spec: remove experimental repo
by Code Review
>From Lev Veyde <lveyde(a)redhat.com>:
Lev Veyde has submitted this change and it was merged. ( https://gerrit.ovirt.org/81019 )
Change subject: spec: remove experimental repo
......................................................................
spec: remove experimental repo
Experimental repo is now deprecated, thus we're removing it.
Change-Id: Ic921cc3bd98e7508b74108d342a4bc8bd943b798
Signed-off-by: Lev Veyde <lveyde(a)redhat.com>
---
M Makefile.am
M configure.ac
D ovirt-experimental.repo.in
M ovirt-release41.spec.in
4 files changed, 0 insertions(+), 59 deletions(-)
Approvals:
Lev Veyde: Verified; Looks good to me, approved
Sandro Bonazzola: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/81019
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic921cc3bd98e7508b74108d342a4bc8bd943b798
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-release
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months
Change in ovirt-engine[master]: core: enable port mirroring with engine xml
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/80865 )
Change subject: core: enable port mirroring with engine xml
......................................................................
core: enable port mirroring with engine xml
Add the information about port mirroring to the metadata section.
It will look inside the metadata section as follow:
<ovirt-vm:vm>
<device mac_address="00:1a:4a:16:01:00">
<portMirroring>
<network>network1</network>
<network>network2</network>
</portMirroring>
</device>
</ovirt-vm:vm>
Change-Id: I1e40d9a23b739147043ebe7332d4afed1cc7a315
Bug-Url: https://bugzilla.redhat.com/1481217
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java
1 file changed, 26 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/80865
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1e40d9a23b739147043ebe7332d4afed1cc7a315
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months
Change in ovirt-engine[master]: core: add run-and-pause to the metadata
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/80970 )
Change subject: core: add run-and-pause to the metadata
......................................................................
core: add run-and-pause to the metadata
This part signals VDSM to ask libvirt to pause the VM right
after it starts.
Change-Id: I6f5d5dca18f0bf9dda1b1e8e93363b5385cb0397
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, but someone else must approve
Arik Hadas: Verified; Looks good to me, approved
Michal Skrivanek: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/80970
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6f5d5dca18f0bf9dda1b1e8e93363b5385cb0397
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months
Change in ovirt-engine[master]: core: minor cleanup in engine xml builder
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/80899 )
Change subject: core: minor cleanup in engine xml builder
......................................................................
core: minor cleanup in engine xml builder
- Remove unused hostId field
- More concise code for iterating over map's items
- more concise code for memoization supplier definition
Change-Id: I1e215b5e398d6b70e077ca052f622a4315262fca
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java
1 file changed, 6 insertions(+), 11 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/80899
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1e215b5e398d6b70e077ca052f622a4315262fca
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months
Change in ovirt-engine[master]: core: write cpu-shares in engine xml
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/80971 )
Change subject: core: write cpu-shares in engine xml
......................................................................
core: write cpu-shares in engine xml
We ignore 'niceness' for now and simply write the 'shares'
setting if it is set with a valid value.
Change-Id: I41623b3ecd3b1e45ab926fabdb5e1650a00bc0fb
Bug-Url: https://bugzilla.redhat.com/1484023
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java
1 file changed, 11 insertions(+), 11 deletions(-)
Approvals:
Martin Sivák: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/80971
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I41623b3ecd3b1e45ab926fabdb5e1650a00bc0fb
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months