Change in ovirt-engine[master]: webadmin: Improve multi-dialog-per-model infra
by Code Review
>From Vojtech Szocs <vszocs(a)redhat.com>:
Vojtech Szocs has submitted this change and it was merged. ( https://gerrit.ovirt.org/67532 )
Change subject: webadmin: Improve multi-dialog-per-model infra
......................................................................
webadmin: Improve multi-dialog-per-model infra
1. This infra is now Model-centric, allowing each and every
Model to specify custom properties that behave just like
the standard `Window` and `ConfirmWindow` properties.
For example:
@Override
public Map<String, Model> getWindowProperties() {
Map<String, Model> map = super.getWindowProperties();
map.put(PROP_CUSTOM_WINDOW, getCustomWindow());
return map;
}
@Override
public void setWindowProperty(String propName, Model value) {
if (PROP_CUSTOM_WINDOW.equals(propName)) {
setCustomWindow(value);
} else {
super.setWindowProperty(propName, value);
}
}
tells UI infra to treat `PROP_CUSTOM_WINDOW` as another
(additional) Window-like property for the given model.
Note that you still need to map your custom property to
corresponding GWTP popup via ModelBoundPopupResolver API.
2. As a result, removed duplicate code in popup resolver
impl's (which was not aware of multi-dialog-per-model
concept in the first place, anyway) as well as removing
duplicate overrides in VM & Template GIN Modules.
Change-Id: Iba0a72bc7e8e9f980017d24bc92e1b4a7dd5b3c5
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/ModelBoundPopupHandler.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/ModelBoundPopupResolver.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/TabModelProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/IModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/VmBaseListModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/TemplateModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VirtualMachineModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/GuidePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/QuotaPopupView.java
11 files changed, 174 insertions(+), 214 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Greg Sheremeta: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/67532
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iba0a72bc7e8e9f980017d24bc92e1b4a7dd5b3c5
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-log-collector[master]: inventory: Check for images with illegal or locked status
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/80535 )
Change subject: inventory: Check for images with illegal or locked status
......................................................................
inventory: Check for images with illegal or locked status
Virtual Machine might contain images with illegal status, lets
detect it before the upgrade. Thanks to Gordon Watson for the
suggestion and initial SQL.
Change-Id: I24c33d1146611ecd76b8b030b8bea8a334a4827f
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/Makefile.am
M src/inventory_report/produceReport/pre-upgrade-checks
M src/inventory_report/produceReport/produceReport.sh
A src/inventory_report/produceReport/sqls/images_query_invalid_status.sql
4 files changed, 27 insertions(+), 0 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
Martin Mucha: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/80535
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I24c33d1146611ecd76b8b030b8bea8a334a4827f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-release[master]: el7: add opstool7-common repository
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/80538 )
Change subject: el7: add opstool7-common repository
......................................................................
el7: add opstool7-common repository
Some of the packages previously in fluentd-012 repo
have been moved to common repository being shared
with sensu or collectd.
Added the new common repository.
Change-Id: I598eaac309673a03ac68132d16341b676a5afb1c
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ovirt-el7-ppc64le-deps.repo.in
M ovirt-el7-x86_64-deps.repo.in
2 files changed, 13 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/80538
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I598eaac309673a03ac68132d16341b676a5afb1c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Dafna Ron <dron(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dusan Fodor <dfodor(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br>
Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-hosted-engine-ha[master]: automation: add glusterfs 3.10 repository
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/80537 )
Change subject: automation: add glusterfs 3.10 repository
......................................................................
automation: add glusterfs 3.10 repository
Resolves:
Error: Package: vdsm-4.20.2-47.gitef4630a.el7.centos.x86_64 (ovirt-master-snapshot)
Requires: glusterfs-fuse >= 3.10
Available: glusterfs-fuse-3.7.9-12.el7.centos.x86_64 (centos-base-el7)
Change-Id: I59931ab40f5db07ca1b0ff7d9a8d76d73a133e6d
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M automation/build-artifacts.repos.el7
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/80537
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I59931ab40f5db07ca1b0ff7d9a8d76d73a133e6d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Dafna Ron <dron(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[master]: core: Move <cputune> element to correct place.
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/80526 )
Change subject: core: Move <cputune> element to correct place.
......................................................................
core: Move <cputune> element to correct place.
The <cputune> element in the libvirt XML
generated by the engine was in a wrong place
(as part of <cpu> element) and libvirt ignored it.
Now it is moved one level up.
Change-Id: I3b06341b713ede3619f3087b8bcc6d991a68bff1
Bug-Url: https://bugzilla.redhat.com/1479794
Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java
1 file changed, 17 insertions(+), 14 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Andrej Krejcir: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/80526
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b06341b713ede3619f3087b8bcc6d991a68bff1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[master]: frontend: Remove non-Javadoc comments
by Code Review
>From Greg Sheremeta <gshereme(a)redhat.com>:
Greg Sheremeta has submitted this change and it was merged. ( https://gerrit.ovirt.org/79656 )
Change subject: frontend: Remove non-Javadoc comments
......................................................................
frontend: Remove non-Javadoc comments
Proper Javadoc comments start with /** prefix.
Any comments not using above prefix are simply ignored
when generating Javadoc for the given program element,
e.g. method. Those are typically placeholders like
/* (non-Javadoc)
* @see stuff
*/
generated by Java IDEs. Those placeholders add no real
value to the Javadoc and the @see tag often gets out
of sync due to e.g. code refactoring or redesign.
To add custom Javadoc on top of one that's inherited
from the parent program element, use {@inheritDoc}.
Change-Id: I73d418f659d42b02f871b5d0e87c7982c6706312
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/TabModelProvider.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/BaseCommandTarget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostErrataPresenter.java
4 files changed, 5 insertions(+), 31 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, approved
Vojtech Szocs: Verified
--
To view, visit https://gerrit.ovirt.org/79656
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I73d418f659d42b02f871b5d0e87c7982c6706312
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[master]: webadmin: avoid NPE on String.join
by Code Review
>From Daniel Erez <derez(a)redhat.com>:
Daniel Erez has submitted this change and it was merged. ( https://gerrit.ovirt.org/80438 )
Change subject: webadmin: avoid NPE on String.join
......................................................................
webadmin: avoid NPE on String.join
StringUtils.join was replaced by String.join on
commit 88138bf0839d5b8d322cc1dfb1a706825ffeef06.
Consequently, disk selection on Disks tab is causing
an NPE on DiskGeneralModel -> updateProperties.
Change-Id: I61b4f882cd9c34abda0422e7825a5aa1fdc86917
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/StringHelper.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskGeneralModel.java
2 files changed, 12 insertions(+), 2 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Daniel Erez: Verified
Jenkins CI: Passed CI tests
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/80438
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I61b4f882cd9c34abda0422e7825a5aa1fdc86917
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[master]: webadmin: add VAR__ACTION__TRANSFER to AppErrors
by Code Review
>From Daniel Erez <derez(a)redhat.com>:
Daniel Erez has submitted this change and it was merged. ( https://gerrit.ovirt.org/80510 )
Change subject: webadmin: add VAR__ACTION__TRANSFER to AppErrors
......................................................................
webadmin: add VAR__ACTION__TRANSFER to AppErrors
Added VAR__ACTION__TRANSFER to AppErrors.java
for UI support.
Change-Id: I494c93f318c36c7e6d2011acc595c14eb346450a
Bug-Url: https://bugzilla.redhat.com/1477922
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/80510
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I494c93f318c36c7e6d2011acc595c14eb346450a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[master]: webadmin: Re-design of HOST interfaces
by Code Review
>From Alexander Wels <awels(a)redhat.com>:
Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/78388 )
Change subject: webadmin: Re-design of HOST interfaces
......................................................................
webadmin: Re-design of HOST interfaces
- Redesigns host network interfaces sub tab to
match VM network interface sub tab.
- Cleaned up a bunch of files no longer needed.
- Added essential information to list view without having to
click to open it.
- Updated VM interfaces to match host interfaces.
- Changes PatternflyListViewItem to be a composite with ui
binder.
- Fix issue with break bond context menu not showing.
Change-Id: I925aa80897636748034f1b1cd7bcfbd56a279fb3
Bug-Url: https://bugzilla.redhat.com/1462629
Bug-Url: https://bugzilla.redhat.com/1464722
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/css/PatternflyConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractSubTabPresenter.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/ExpandAllButtonPresenterWidget.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/ExpandAllButtonView.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/ExpandAllButtonView.ui.xml
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/HasExpandAll.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/listgroup/ExpandableListViewItem.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/listgroup/PatternflyListView.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/listgroup/PatternflyListViewItem.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/listgroup/PatternflyListViewItem.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/ActionTable.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/header/IconTypeHeader.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/AbstractModelBoundTableWidget.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/network/BondedNetworkIcon.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/network/NetworkIcon.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/IconStatusPanel.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmInterfaceListGroupItem.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListViewItem.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceLineModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostVLan.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationMessages.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractMainTabWithDetailsPresenter.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostInterfacePresenter.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RoleView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/SystemPermissionView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/instancetypes/InstanceTypesView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ClusterPolicyView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostInterfaceView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkHostView.java
D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/BondPanel.java
D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/HostInterfaceForm.java
D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/HostInterfaceHorizontalPanel.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/HostNetworkInterfaceBondedListViewItem.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/HostNetworkInterfaceListViewItem.java
D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfaceLabel.java
D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfacePanel.java
D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/StatisticsPanel.java
D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/VLanPanel.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages.properties
M packaging/branding/ovirt.brand/common.css
M packaging/branding/ovirt.brand/ovirt.css
50 files changed, 1,481 insertions(+), 939 deletions(-)
Approvals:
Alexander Wels: Verified; Passed CI tests
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/78388
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I925aa80897636748034f1b1cd7bcfbd56a279fb3
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Ales Musil <amusil(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[master]: webadmin: reduce white space around bread crumbs
by Code Review
>From Alexander Wels <awels(a)redhat.com>:
Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/80489 )
Change subject: webadmin: reduce white space around bread crumbs
......................................................................
webadmin: reduce white space around bread crumbs
- Per UXD team reduced the white space around the bread crumbs a little.
Change-Id: I55f53c45156941faeee093a529e3d6ff2f315b48
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M packaging/branding/ovirt.brand/ovirt.css
1 file changed, 7 insertions(+), 1 deletion(-)
Approvals:
Alexander Wels: Verified
Jenkins CI: Passed CI tests
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/80489
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I55f53c45156941faeee093a529e3d6ff2f315b48
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months