Change in ovirt-engine[master]: webadmin: remove unused resources
by Code Review
>From Greg Sheremeta <gshereme(a)redhat.com>:
Greg Sheremeta has submitted this change and it was merged. ( https://gerrit.ovirt.org/80417 )
Change subject: webadmin: remove unused resources
......................................................................
webadmin: remove unused resources
Remove unused resources. Many of these resources were
obsoleted by the new UI.
Change-Id: If2240fa5c2b322b898809495c1a70895f172df21
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
D frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/CascadeActionPanel.css
D frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/DropdownButtonPanel.css
D frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/RefreshPanel.css
D frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/TabbedSplitLayout.css
D frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/button_up.png
D frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/cascade_button.png
D frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/check_icon.png
D frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/refresh_button.png
D frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/public/images/dropdown_item_bg.png
D frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/public/images/main_tab_left.png
D frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/public/images/main_tab_right.png
D frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/public/images/tab_arrow_selected.png
D frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/public/images/tab_left_selected.png
D frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/public/images/tab_right_selected.png
D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/css/FooterHeaderlessTable.css
D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/css/SystemTree.css
D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/css/TaskTreeHeaderlessTable.css
D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/collapse_splitter.png
D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/expand_splitter.png
D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/icn_group.png
D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/icon_info.png
D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/read_only_tag.gif
D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/public/images/arrow_red.gif
D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/public/images/login/login_page_header_title.png
D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/public/images/rh-masterhead-logo.gif
D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/public/images/search_bar_left.png
D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/public/images/search_bar_left_HasSelectedTags.png
D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/public/images/search_bar_middle.png
D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/public/images/search_bar_right.png
D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/public/images/search_bar_right_HasSelectedTags.png
D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/public/images/tbl_left.gif
D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/public/images/triangle_down_gray.gif
D packaging/branding/ovirt.brand/images/dialog/dialog_header_TL.png
D packaging/branding/ovirt.brand/images/dialog/dialog_header_TR.png
D packaging/branding/ovirt.brand/images/dialog/dialog_header_background_repetitive.png
D packaging/branding/ovirt.brand/images/dialog/panel_edge_B.png
D packaging/branding/ovirt.brand/images/dialog/panel_edge_BL.png
D packaging/branding/ovirt.brand/images/dialog/panel_edge_BR.png
D packaging/branding/ovirt.brand/images/dialog/panel_edge_BR_resize.png
D packaging/branding/ovirt.brand/images/dialog/panel_edge_L.png
D packaging/branding/ovirt.brand/images/dialog/panel_edge_R.png
D packaging/branding/ovirt.brand/images/dialog/panel_edge_T.png
D packaging/branding/ovirt.brand/images/dialog/panel_edge_TL.png
D packaging/branding/ovirt.brand/images/dialog/panel_edge_TR.png
D packaging/branding/ovirt.brand/images/oVirt_About_BG_Overlay.png
D packaging/branding/ovirt.brand/images/oVirt_Banner_image_transparent.png
D packaging/branding/ovirt.brand/images/oVirt_Login_Bottom_Left_Corner.png
D packaging/branding/ovirt.brand/images/oVirt_Login_Top_Right_Corner.png
D packaging/branding/ovirt.brand/images/ovirt_top_logo.png
49 files changed, 0 insertions(+), 369 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/80417
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If2240fa5c2b322b898809495c1a70895f172df21
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[master]: core: Verify that the VM exists when returning callback
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80351 )
Change subject: core: Verify that the VM exists when returning callback
......................................................................
core: Verify that the VM exists when returning callback
It seems that there are use cases where a merge operation fails, leaving
a step in ACTIVE state in the command_entities table. However, at
some point, the VM is deleted. In this case, i.e. as long as the failed
step is ACTIVE, engine restart fails because we will be looking for a VM
that doesn't exist anymore and failing on NPE. In this patch, a
protective check is added in order not to fail on NPE when restarting
the engine and a warning is added to the log asking the user to cleanup
the command_entities table.
Change-Id: Ia49bd24da914f36f09241feae8875055ea1dd27a
Bug-Url: https://bugzilla.redhat.com/1477042
Signed-off-by: Ala Hino <ahino(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommand.java
1 file changed, 8 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Ala Hino: Verified
--
To view, visit https://gerrit.ovirt.org/80351
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia49bd24da914f36f09241feae8875055ea1dd27a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[master]: core: Add VM search by has_illegal_images
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80114 )
Change subject: core: Add VM search by has_illegal_images
......................................................................
core: Add VM search by has_illegal_images
Add the ability to search VMs by the has_illegal_images property.
Change-Id: Ic8b5cc960dfd03b06e944693a0d4b2dc3886ef85
Bug-Url: https://bugzilla.redhat.com/1372163
Signed-off-by: Ala Hino <ahino(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, but someone else must approve
Allon Mureinik: Looks good to me, approved
Ala Hino: Verified
--
To view, visit https://gerrit.ovirt.org/80114
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic8b5cc960dfd03b06e944693a0d4b2dc3886ef85
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[master]: core: Display an alert if the VM has illegal images
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80113 )
Change subject: core: Display an alert if the VM has illegal images
......................................................................
core: Display an alert if the VM has illegal images
Display an alert next to the VM if the VM has illegal images. A VM may
have illegal images if, for example, there was a failure during merge.
It is important to display an alert because an illegal image may
indicate that the volume on the storage is illegal, because if the
VM is stopped, the user will not be able to start it again before fixing
the illegal volume.
Change-Id: I46bdceea155774bbb7641dd767c3caf4f53b8102
Bug-Url: https://bugzilla.redhat.com/1372163
Signed-off-by: Ala Hino <ahino(a)redhat.com>
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDaoImpl.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VmStatusColumn.java
M packaging/dbscripts/create_views.sql
6 files changed, 34 insertions(+), 3 deletions(-)
Approvals:
Eli Mesika: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Ala Hino: Verified
Arik Hadas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/80113
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I46bdceea155774bbb7641dd767c3caf4f53b8102
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[master]: webadmin: fix NPE in UI occurred while importing a template
by Code Review
>From Tomas Jelinek <tjelinek(a)redhat.com>:
Tomas Jelinek has submitted this change and it was merged. ( https://gerrit.ovirt.org/80395 )
Change subject: webadmin: fix NPE in UI occurred while importing a template
......................................................................
webadmin: fix NPE in UI occurred while importing a template
When importing a Template from the Export Domain, a NPE occurred
since the General sub tab view was already set to NULL while trying to
approach this object for cleanup.
Change-Id: I5abf761b1a12055043b21a17d6672cbb2f94bbd1
Signed-off-by: Sharon Gratch <sgratch(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmFromExportDomainPopupView.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, approved; Passed CI tests
Sharon Gratch: Verified
--
To view, visit https://gerrit.ovirt.org/80395
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5abf761b1a12055043b21a17d6672cbb2f94bbd1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[master]: core: VmTemplateDaoTest method references
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80307 )
Change subject: core: VmTemplateDaoTest method references
......................................................................
core: VmTemplateDaoTest method references
Clean up the code by using method references instead of anonymous
lambdas.
Change-Id: Ifc959e45ae5e13e3d322436627a48d13604c9863
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmTemplateDaoTest.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/80307
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc959e45ae5e13e3d322436627a48d13604c9863
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[master]: core: Reuse FixturesTool.IMAGE_GROUP_ID in ImageStorageDomai...
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80309 )
Change subject: core: Reuse FixturesTool.IMAGE_GROUP_ID in ImageStorageDomainMapDaoTest
......................................................................
core: Reuse FixturesTool.IMAGE_GROUP_ID in ImageStorageDomainMapDaoTest
Change-Id: I8c9b6c0db7bd064670a682f3328b8840b9dea61a
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ImageStorageDomainMapDaoTest.java
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/80309
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c9b6c0db7bd064670a682f3328b8840b9dea61a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[master]: core: IscsiBondDaoTest to extend BaseGenericDaoTestCase
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80311 )
Change subject: core: IscsiBondDaoTest to extend BaseGenericDaoTestCase
......................................................................
core: IscsiBondDaoTest to extend BaseGenericDaoTestCase
Make IscsiBondDaoTest extend BaseGenericDaoTestCase instead of
reimplementing its logic.
Change-Id: I0c64418e0e60d522fd72b818dffcd2349d658f33
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/IscsiBondDaoTest.java
1 file changed, 35 insertions(+), 52 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/80311
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0c64418e0e60d522fd72b818dffcd2349d658f33
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[master]: core: Remove unused VmStatic[Dao] from VmInitDaoTest
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80308 )
Change subject: core: Remove unused VmStatic[Dao] from VmInitDaoTest
......................................................................
core: Remove unused VmStatic[Dao] from VmInitDaoTest
Removed a useless VmStatic member and the VmStaticDao used to
initialize it, as they are not used at all in the test.
Besides cleaning up the test from redundant members, this patch also
speeds it up by saving a useless DAO call in the test's set up.
Change-Id: I788fc42f1052040be0ede139106277d40b79b6f3
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmInitDaoTest.java
1 file changed, 0 insertions(+), 7 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/80308
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I788fc42f1052040be0ede139106277d40b79b6f3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[master]: core: StorageServerConnectionDaoTest#existingNfsAutoConnection
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80313 )
Change subject: core: StorageServerConnectionDaoTest#existingNfsAutoConnection
......................................................................
core: StorageServerConnectionDaoTest#existingNfsAutoConnection
The only usage for this member is its ID, which can be taken from
FixturesTool anyway.
This patch removes this redundant member, both in order to clean up
the code and to speed up the test by removing a useless DAO call from
the test's setup.
Change-Id: Iaa95d1ec41d9cf55bbbfeb367b6e76a4d5d52dc1
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionDaoTest.java
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/80313
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa95d1ec41d9cf55bbbfeb367b6e76a4d5d52dc1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months