August 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Reuse FixturesTool.STORAGE_DOMAIN_SCALE_SD5 in DAO tests
by Code Review 08 Aug '17

08 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80258 ) Change subject: core: Reuse FixturesTool.STORAGE_DOMAIN_SCALE_SD5 in DAO tests ...................................................................... core: Reuse FixturesTool.STORAGE_DOMAIN_SCALE_SD5 in DAO tests Change-Id: Ibb62d69e95213a1defabfcd86ab864f87a020a95 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AuditLogDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/EntityDaoImplTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ImageStorageDomainMapDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/PermissionDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StoragePoolDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StoragePoolIsoMapDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmTemplateDaoTest.java 9 files changed, 22 insertions(+), 25 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/80258 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb62d69e95213a1defabfcd86ab864f87a020a95 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: StoragePoolDaoTest to extend BaseGenericDaoTestCase
by Code Review 08 Aug '17

08 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80259 ) Change subject: core: StoragePoolDaoTest to extend BaseGenericDaoTestCase ...................................................................... core: StoragePoolDaoTest to extend BaseGenericDaoTestCase Make StoragePoolDaoTest extend BaseGenericDaoTestCase instead of reimplementing its logic. Change-Id: I9f3fb83bb7660d11def5cc9663496ec518c92342 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StoragePoolDaoTest.java 1 file changed, 45 insertions(+), 112 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/80259 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f3fb83bb7660d11def5cc9663496ec518c92342 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Reuse FixturesTool.STORAGE_DOMAIN_SCALE_SD6 in DAO test
by Code Review 08 Aug '17

08 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80260 ) Change subject: core: Reuse FixturesTool.STORAGE_DOMAIN_SCALE_SD6 in DAO test ...................................................................... core: Reuse FixturesTool.STORAGE_DOMAIN_SCALE_SD6 in DAO test Change-Id: If3b272ae34c8b3d23c4bca763036ba68c126e72b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StoragePoolIsoMapDaoTest.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/80260 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3b272ae34c8b3d23c4bca763036ba68c126e72b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove storage pool from StoragePoolIsoMapDaoTest
by Code Review 08 Aug '17

08 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80262 ) Change subject: core: Remove storage pool from StoragePoolIsoMapDaoTest ...................................................................... core: Remove storage pool from StoragePoolIsoMapDaoTest The only aspect of the storage pool used in StoragePoolIsoMapDaoTest is it's ID, which is just given as a constant in FixturesTool. This patch removes the redundant objects from the StoragePoolIsoMapDaoTest to make it clearer and easier to maintain. As a side bonus, it also removes another DAO call, speeding up the test. Change-Id: I6f214062fbd419547eac5a65e2b15b88af4b887c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StoragePoolIsoMapDaoTest.java 1 file changed, 4 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/80262 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f214062fbd419547eac5a65e2b15b88af4b887c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Rename StoragePoolIsoMapDaoTest#storagePoolIsoMapDao
by Code Review 08 Aug '17

08 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80261 ) Change subject: core: Rename StoragePoolIsoMapDaoTest#storagePoolIsoMapDao ...................................................................... core: Rename StoragePoolIsoMapDaoTest#storagePoolIsoMapDao storagePoolIsoMapDa is in fact a StoragePoolDao instance. This patch renames the local variable to represent that. Change-Id: I3ceab23b9057b87901fd162f3d75e5667962562a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StoragePoolIsoMapDaoTest.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/80261 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ceab23b9057b87901fd162f3d75e5667962562a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: StoragePoolIsoMapDaoTest to extend BaseGenericDaoTestCase
by Code Review 08 Aug '17

08 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80263 ) Change subject: core: StoragePoolIsoMapDaoTest to extend BaseGenericDaoTestCase ...................................................................... core: StoragePoolIsoMapDaoTest to extend BaseGenericDaoTestCase Make StoragePoolIsoMapDaoTest extend BaseGenericDaoTestCase instead of reimplementing its logic. Change-Id: I889e32a742b0068e7b7c7930ac455223f422c1ad Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StoragePoolIsoMapDaoTest.java 1 file changed, 28 insertions(+), 51 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/80263 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I889e32a742b0068e7b7c7930ac455223f422c1ad Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: StorageServerConnectionExtensionDaoTest to extend Base...
by Code Review 08 Aug '17

08 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80264 ) Change subject: core: StorageServerConnectionExtensionDaoTest to extend BaseGenericDaoTestCase ...................................................................... core: StorageServerConnectionExtensionDaoTest to extend BaseGenericDaoTestCase Make StorageServerConnectionExtensionDaoTest extend BaseGenericDaoTestCase instead of reimplementing its logic. Change-Id: I6e91f55864005cfed52fefc37c112b8cc2489cbf Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionExtensionDaoTest.java 1 file changed, 33 insertions(+), 58 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/80264 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e91f55864005cfed52fefc37c112b8cc2489cbf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove StorageServerConnection from StorageServerConne...
by Code Review 08 Aug '17

08 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80265 ) Change subject: core: Remove StorageServerConnection from StorageServerConnectionLunMapDaoTest ...................................................................... core: Remove StorageServerConnection from StorageServerConnectionLunMapDaoTest The only part of the StorageServerConnection used in StorageServerConnectionLunMapDaoTest is its ID, which can just be taken from the FixturesTool constant. This patch removes the roundtrip to the database that retrieves the unneeded object in order to clean up the test and make it easier to maintain. As a side bonus, removing this DAO call from the setup also speeds up the test. Change-Id: Ib7a62010021111069604c9b9cf5f01fc2ce891c3 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionLunMapDaoTest.java 1 file changed, 2 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/80265 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7a62010021111069604c9b9cf5f01fc2ce891c3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Reuse FixturesTool.LUN_ID1 in DAO tests
by Code Review 08 Aug '17

08 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80266 ) Change subject: core: Reuse FixturesTool.LUN_ID1 in DAO tests ...................................................................... core: Reuse FixturesTool.LUN_ID1 in DAO tests Change-Id: I6499ac66e19546eea3a2d4f67ed75ad921c7c7d1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskLunMapDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionLunMapDaoTest.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/80266 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6499ac66e19546eea3a2d4f67ed75ad921c7c7d1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Reuse FixturesTool.LUN_ID_FOR_DISK in DAO tests
by Code Review 08 Aug '17

08 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80267 ) Change subject: core: Reuse FixturesTool.LUN_ID_FOR_DISK in DAO tests ...................................................................... core: Reuse FixturesTool.LUN_ID_FOR_DISK in DAO tests Change-Id: I46fde72bfcd354a21fd0d16cb0073014921f4d9f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionLunMapDaoTest.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/80267 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46fde72bfcd354a21fd0d16cb0073014921f4d9f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0