August 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: ButtonCell button to bootstrap
by Code Review 30 Aug '17

30 Aug '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/81235 ) Change subject: webadmin: ButtonCell button to bootstrap ...................................................................... webadmin: ButtonCell button to bootstrap - Update the button style in NullableButtonCell to be bootstrap styles. Change-Id: I4d2c192fa8d47da2058fb6fe2ca6ffa1e2a3ef7a Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/NullableButtonCell.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/81235 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d2c192fa8d47da2058fb6fe2ca6ffa1e2a3ef7a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: fix npe when switching back to user main grid
by Code Review 30 Aug '17

30 Aug '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/81234 ) Change subject: webadmin: fix npe when switching back to user main grid ...................................................................... webadmin: fix npe when switching back to user main grid - Fixed npe due to no data when switching back to the users main grid Change-Id: I4a458fb9aa7995dddce58163eeec8f21d213114c Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractSubTabPresenter.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/81234 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a458fb9aa7995dddce58163eeec8f21d213114c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: DC QoS updates
by Code Review 30 Aug '17

30 Aug '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/81237 ) Change subject: webadmin: DC QoS updates ...................................................................... webadmin: DC QoS updates - Fixed issue where VM network,Host network, and CPU Qos grids where not updating when switching DC. Change-Id: Id6cdb3efd4f81865a1e18d7ac03a2415c1d1c17e Bug-Url: https://bugzilla.redhat.com/1486198 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterQosView.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/81237 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6cdb3efd4f81865a1e18d7ac03a2415c1d1c17e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: display external network
by Code Review 30 Aug '17

30 Aug '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/81236 ) Change subject: webadmin: display external network ...................................................................... webadmin: display external network - Fixed npe causing external networks to not display Change-Id: If6a66f54d8ee1d51a00b2721ec2ce6475682ef71 Bug-Url: https://bugzilla.redhat.com/1483433 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkExternalSubnetView.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/81236 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6a66f54d8ee1d51a00b2721ec2ce6475682ef71 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Expand width of new Affinity Group popup
by Code Review 30 Aug '17

30 Aug '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/81238 ) Change subject: webadmin: Expand width of new Affinity Group popup ...................................................................... webadmin: Expand width of new Affinity Group popup The existing width of the new Affinity Group popup dialog is too narrow to accommodate the width of the ja_JP translation of the "No available VMs" placeholder text. This patch expands the width of the dialog so that it fits properly. Screenshot: http://imgur.com/a/Sk5l6 Change-Id: I5a3d4d45e62e8480fd25ec34a143a92a18006b6a Bug-Url: https://bugzilla.redhat.com/1348467 Signed-off-by: Phillip Bailey <phbailey(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/AffinityGroupPopupView.ui.xml 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Phillip Bailey: Verified -- To view, visit https://gerrit.ovirt.org/81238 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a3d4d45e62e8480fd25ec34a143a92a18006b6a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Fix positioning of virt buttons
by Code Review 30 Aug '17

30 Aug '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/81176 ) Change subject: webadmin: Fix positioning of virt buttons ...................................................................... webadmin: Fix positioning of virt buttons - VM: * RunOnce hid under Run * Poweroff hid under Shutdown * ChangeCD moved to extended area * Migrate moved to main area * Snapshot moved to main area - Cluster: * Remove moved to main area - VM|Disks * Remove moved to main area Change-Id: Iab4f3fc517e96f1f57245b56a7a263d6dc8dcd84 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/VmDiskActionPanelPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/ClusterActionPanelPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/VirtualMachineActionPanelPresenterWidget.java 3 files changed, 37 insertions(+), 36 deletions(-) Approvals: Jakub Niedermertl: Looks good to me, but someone else must approve Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/81176 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab4f3fc517e96f1f57245b56a7a263d6dc8dcd84 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Add check for the previous state of portMirroring ...
by Code Review 30 Aug '17

30 Aug '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/81202 ) Change subject: webadmin: Add check for the previous state of portMirroring and passthrough ...................................................................... webadmin: Add check for the previous state of portMirroring and passthrough Add check that previous state is not overwritten by the new state. Copy the old changeProhibitionReason message in case it is needed. Change-Id: I913be053b86092e99447070858822dae70e88ea7 Signed-off-by: Ales Musil <amusil(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1435094 Bug-Url: https://bugzilla.redhat.com/1486547 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Ales Musil: Verified Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/81202 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I913be053b86092e99447070858822dae70e88ea7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ales Musil <amusil(a)redhat.com> Gerrit-Reviewer: Ales Musil <amusil(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: frontend: BreadCrumbsView: don't encode strings twice.
by Code Review 30 Aug '17

30 Aug '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/81229 ) Change subject: frontend: BreadCrumbsView: don't encode strings twice. ...................................................................... frontend: BreadCrumbsView: don't encode strings twice. setText encodes strings to safe html, while currentName itself is guaranteed to already be encoded. This causes the entry to be encoded twice and not be displayed properly (displaying html entities instead). Directly set the strings via setInnerHTML instead. As currentName is guaranteed to be encoded, it is safe. Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=1483295 Change-Id: I145c2428442c42a5a3e563968c45eb8265852a57 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/OvirtBreadCrumbsView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Leon Goldberg: Verified -- To view, visit https://gerrit.ovirt.org/81229 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I145c2428442c42a5a3e563968c45eb8265852a57 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: broker: Removed support for several simultaneous clients.
by Code Review 30 Aug '17

30 Aug '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. ( https://gerrit.ovirt.org/80647 ) Change subject: broker: Removed support for several simultaneous clients. ...................................................................... broker: Removed support for several simultaneous clients. https://github.com/oVirt/ovirt-site/pull/1157 Change-Id: I8fa7d1612cbb90da615d1da4198fe1c2a43c36dd Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> Signed-off-by: Denis Chaplygin <dchaplyg(a)redhat.com> --- M ovirt_hosted_engine_ha/broker/listener.py M ovirt_hosted_engine_ha/broker/storage_broker.py 2 files changed, 51 insertions(+), 53 deletions(-) Approvals: Denis Chaplygin: Verified Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80647 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8fa7d1612cbb90da615d1da4198fe1c2a43c36dd Gerrit-PatchSet: 9 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: storage: Removed BlockStorageBackend
by Code Review 30 Aug '17

30 Aug '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. ( https://gerrit.ovirt.org/81010 ) Change subject: storage: Removed BlockStorageBackend ...................................................................... storage: Removed BlockStorageBackend BlockStorageBackend was never used and we should switch to the VdsmStorageBacken in future patches. https://github.com/oVirt/ovirt-site/pull/1157 Change-Id: I6f98331984940d6e01c4b64899ec3d2180f1b839 Signed-off-by: Denis Chaplygin <dchaplyg(a)redhat.com> --- M ovirt_hosted_engine_ha/broker/storage_broker.py M ovirt_hosted_engine_ha/lib/storage_backends.py M ovirt_hosted_engine_ha/lib/storage_backends_test.py 3 files changed, 2 insertions(+), 512 deletions(-) Approvals: Denis Chaplygin: Verified Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Andrej Krejcir: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/81010 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f98331984940d6e01c4b64899ec3d2180f1b839 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0