Change in ovirt-engine[ovirt-engine-4.1]: core: AddEmptyStoragePoolCommand: set vdsmName to default ne...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80000 )
Change subject: core: AddEmptyStoragePoolCommand: set vdsmName to default network
......................................................................
core: AddEmptyStoragePoolCommand: set vdsmName to
default network
vdsm_name must not be null; Set vdsmName to the default network created
in addDefaultNetworks.
This patch fixes OST that was broken by
https://gerrit.ovirt.org/#/c/79116/
(cherry-picked from commit c382df3fc03dd2b7bbbf2c9182e30b33f2547c57)
Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=1476823
Change-Id: Ie76729c169915a0fdfc7dc322cbdec099d41c693
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AddEmptyStoragePoolCommand.java
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Dominik Holler: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Leon Goldberg: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/80000
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie76729c169915a0fdfc7dc322cbdec099d41c693
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[ovirt-engine-4.1]: frontned: remove ui network name/vnic profile restrictions
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/79999 )
Change subject: frontned: remove ui network name/vnic profile restrictions
......................................................................
frontned: remove ui network name/vnic profile restrictions
(cherry-picked from commit b63dd92feab73914954c5403fdf2c29ceb815054)
Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=1476823
Change-Id: I86a74f3908cf6e545b8e42d3694f6058c4c5c22b
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VnicProfile.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java
4 files changed, 18 insertions(+), 25 deletions(-)
Approvals:
Dominik Holler: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Leon Goldberg: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79999
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I86a74f3908cf6e545b8e42d3694f6058c4c5c22b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[ovirt-engine-4.1]: backend: remove character restrictions from network names
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/79990 )
Change subject: backend: remove character restrictions from network names
......................................................................
backend: remove character restrictions from network names
Currently, oVirt limits the names of its networks to 15
alphanumeric characters. This limitation dates back to
the ages where all networks were VM network, all were
implemented by a Linux bridge, and the same name was
used to identify the network and the Linux bridge
implementing it on each host.
That has to change. 15 characters are not enough for
humans; spaces, and other special characters are
visually useful, and non-English speaking users
would love to use their native alphabet in network names.
For this reason network names are allowed to consist of 256 Unicode
characters. If a Linux bridge is created, the name is created
from the network name, if it is suitable, or from the network's uuid.
(cherry-picked from commit 0cee2277bbbf176a6ed0f56e40a04ff56b86f1f5)
Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=1476823
Change-Id: Idadf272959ae10afc1de7ed6ce6daed70b78b73d
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/AddNetworkCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/Network.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/HostNetwork.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/bll/network/NetworkVdsmNameMapper.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetCapabilitiesVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostSetupNetworksVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
M packaging/dbscripts/create_views.sql
M packaging/dbscripts/network_sp.sql
A packaging/dbscripts/upgrade/04_01_0840_add_vdsm_name_to_network.sql
16 files changed, 116 insertions(+), 20 deletions(-)
Approvals:
Dominik Holler: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Leon Goldberg: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79990
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idadf272959ae10afc1de7ed6ce6daed70b78b73d
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[master]: engine: Use separate threadpools for each executor service
by Code Review
>From Martin Peřina <mperina(a)redhat.com>:
Martin Peřina has submitted this change and it was merged. ( https://gerrit.ovirt.org/79652 )
Change subject: engine: Use separate threadpools for each executor service
......................................................................
engine: Use separate threadpools for each executor service
Use separate thread pools for each executor service
so threads will be marked with the threadpool name
in the thread dump making it easier to analyze the
thread usage.
Change-Id: I6be96a3c703e3dbcb565929d56f8752dd6f533fa
Bug-Url: https://bugzilla.redhat.com/1416141
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/utils/EngineThreadPools.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/utils/ThreadPools.java
M packaging/services/ovirt-engine/ovirt-engine.conf.in
M packaging/services/ovirt-engine/ovirt-engine.xml.in
4 files changed, 32 insertions(+), 20 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Martin Peřina: Looks good to me, but someone else must approve
Ravi Nori: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79652
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6be96a3c703e3dbcb565929d56f8752dd6f533fa
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[master]: webadmin: remove SPICE HTML5 support
by Code Review
>From Tomas Jelinek <tjelinek(a)redhat.com>:
Tomas Jelinek has submitted this change and it was merged. ( https://gerrit.ovirt.org/79493 )
Change subject: webadmin: remove SPICE HTML5 support
......................................................................
webadmin: remove SPICE HTML5 support
It did not manage to leave the tech preview state for years, now it's time to
remove it.
Change-Id: I8f1799a59945ec236152c71b14db804a8ca22dcd
Bug-Url: https://bugzilla.redhat.com/1443989
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M Makefile
D backend/manager/modules/services/src/main/webapp/spicehtml5-main.jsp
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseUiCommonModule.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ConsolePopupPresenterWidget.java
D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceHtml5Impl.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/UiCommonDefaultTypeResolver.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleOptionsFrontendPersisterImpl.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ConsolePopupView.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ConsolePopupView.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties
D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ISpiceHtml5.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java
M ovirt-engine.spec.in
14 files changed, 19 insertions(+), 526 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
Sandro Bonazzola: Looks good to me, but someone else must approve
Jakub Niedermertl: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Vojtech Szocs: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/79493
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f1799a59945ec236152c71b14db804a8ca22dcd
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months