August 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: fixing NPE in fencing flow
by Code Review 08 Aug '17

08 Aug '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. ( https://gerrit.ovirt.org/80345 ) Change subject: core: fixing NPE in fencing flow ...................................................................... core: fixing NPE in fencing flow This patch fixed an NPE in fencing flow non-responding-treatment. Adding a check for NULL resolved the problem. Change-Id: I70b3e988cdc3392bea05bb58df2f480f73a4112c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1477700 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/VdsNotRespondingTreatmentCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Eli Mesika: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/80345 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70b3e988cdc3392bea05bb58df2f480f73a4112c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Bookmark list
by Code Review 08 Aug '17

08 Aug '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/80359 ) Change subject: webadmin: Bookmark list ...................................................................... webadmin: Bookmark list - Added dropdown containing applicable bookmarks for the entity. - Added tool tips to bookmark buttons. Change-Id: I0be57b43f78cdd777317cc481ed3b007b893895b Bug-Url: https://bugzilla.redhat.com/1478942 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/SearchPanelPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/SearchPanelView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/SearchPanelView.ui.xml M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties 5 files changed, 88 insertions(+), 4 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80359 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0be57b43f78cdd777317cc481ed3b007b893895b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: host popup info icon alignment
by Code Review 08 Aug '17

08 Aug '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/80365 ) Change subject: webadmin: host popup info icon alignment ...................................................................... webadmin: host popup info icon alignment - Make alignment consistent across host popup Change-Id: Id5251d3adf1711ebd804c637dec2024d13b91e0d Bug-Url: https://bugzilla.redhat.com/1434348 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id5251d3adf1711ebd804c637dec2024d13b91e0d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: readonly managed gluster volume checkbox
by Code Review 08 Aug '17

08 Aug '17

>From Sahina Bose <sabose(a)redhat.com>: Sahina Bose has submitted this change and it was merged. ( https://gerrit.ovirt.org/78245 ) Change subject: webadmin: readonly managed gluster volume checkbox ...................................................................... webadmin: readonly managed gluster volume checkbox Set the Managed gluster volume checkbox to be readonly when edit is not allowed Change-Id: Ia6b83af6f45ddc1a976189c46670e637c478f949 iBug-Url: https://bugzilla.redhat.com/1417558 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/GlusterStorageModel.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: godas(a)redhat.com: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Sahina Bose: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/78245 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6b83af6f45ddc1a976189c46670e637c478f949 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Denis Chapligin <akashihi(a)gmail.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-Reviewer: godas(a)redhat.com

1 0

Change in ovirt-release[ovirt-4.1]: build: 4.1.5 rc3
by Code Review 08 Aug '17

08 Aug '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/80381 ) Change subject: build: 4.1.5 rc3 ...................................................................... build: 4.1.5 rc3 Enables centos-opstools repo for ppc64le which is now available. Change-Id: I4a9c4056964ecc41ab6c7b9409f67694f646956b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1364083 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-el7-ppc64le-deps.repo.in M ovirt-release41.spec.in 3 files changed, 7 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80381 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a9c4056964ecc41ab6c7b9409f67694f646956b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-release: test el7 ppc64le on 4.1
by Code Review 08 Aug '17

08 Aug '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/80379 ) Change subject: ovirt-release: test el7 ppc64le on 4.1 ...................................................................... ovirt-release: test el7 ppc64le on 4.1 Change-Id: I23f439a69167f2227a5ecbba15409fec633b1d23 Related-To: https://bugzilla.redhat.com/1364083 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-release/ovirt-release_standard.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Staging Jenkins Server: Passed CI tests Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80379 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I23f439a69167f2227a5ecbba15409fec633b1d23 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Staging Jenkins Server

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: Use default grid item comparator
by Code Review 08 Aug '17

08 Aug '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80127 ) Change subject: webadmin: Use default grid item comparator ...................................................................... webadmin: Use default grid item comparator If a grid has no explicit column sorting applied by the user (which is the initial state of all grids), use a default item comparator with following logic: - first, try to compare by name (lexo-numeric) if the item is assignable to Nameable interface (this covers most, but not all, business entities), or treat it as null - otherwise (for items still considered equal by above rule), try to compare by queryable ID if the item is assignable to Queryable interface (this should cover the rest of entities), or treat it as null - finally, put "null" items at the end (nulls last strategy) Above comparator logic is in-line with the general UI design of having "Name" column with clickable links leading to detail views for each main grid. Above comparator is not applied if a grid has been explicitly sorted by the user (by clicking the given column header). Change-Id: I4711af76410a16354c38c083130be1c2e033306f Bug-Url: https://bugzilla.redhat.com/1445235 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/DataBoundTabModelProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SortedListModel.java 3 files changed, 74 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/80127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4711af76410a16354c38c083130be1c2e033306f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: VnicProfile and Network name
by Code Review 07 Aug '17

07 Aug '17

>From Greg Sheremeta <gshereme(a)redhat.com>: Greg Sheremeta has submitted this change and it was merged. ( https://gerrit.ovirt.org/80074 ) Change subject: webadmin: VnicProfile and Network name ...................................................................... webadmin: VnicProfile and Network name - In the detail view, it was impossible to tell which vnic profile or network you were working with because the name was not unique. Added the remaining fields to the string so you can tell which entity you are working with. Change-Id: I5e1dd82fea64687f19dad15dceb0a12ac37cd32c Signed-off-by: Alexander Wels <awels(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/NetworkBreadCrumbsPresenterWidget.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/VnicProfileBreadCrumbsPresenterWidget.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/NetworkBreadCrumbsView.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/VnicProfileBreadCrumbsView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabNetworkPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabVnicProfilePresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/NetworkSubTabPanelView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/profile/VnicProfileSubTabPanelView.java 9 files changed, 134 insertions(+), 21 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80074 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e1dd82fea64687f19dad15dceb0a12ac37cd32c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Alert/Event clear all not working
by Code Review 07 Aug '17

07 Aug '17

>From Greg Sheremeta <gshereme(a)redhat.com>: Greg Sheremeta has submitted this change and it was merged. ( https://gerrit.ovirt.org/80361 ) Change subject: webadmin: Alert/Event clear all not working ...................................................................... webadmin: Alert/Event clear all not working - Fixed issue where alert/event clear all in the notification drawer was not working. Change-Id: Id057987ad2f7a9f67862a8f4575dd97ee777639a Bug-Url: https://bugzilla.redhat.com/1477986 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/HeaderPresenterWidget.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id057987ad2f7a9f67862a8f4575dd97ee777639a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: vdsbroker: Add Host.getLldp
by Code Review 07 Aug '17

07 Aug '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. ( https://gerrit.ovirt.org/79916 ) Change subject: vdsbroker: Add Host.getLldp ...................................................................... vdsbroker: Add Host.getLldp The VDSM API is going to be extended by the new command Host.getLldp. The vdsbroker is extended to use this new command. Change-Id: I247f15a6c3333876067779bfe1078a594147ac4c Signed-off-by: Dominik Holler <dholler(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/LldpReturn.java 3 files changed, 34 insertions(+), 0 deletions(-) Approvals: Dominik Holler: Verified Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/79916 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I247f15a6c3333876067779bfe1078a594147ac4c Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0