Change in ovirt-log-collector[master]: inventory: split bash and SQL - storage domains
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/80026 )
Change subject: inventory: split bash and SQL - storage domains
......................................................................
inventory: split bash and SQL - storage domains
Change-Id: I352ad8cea86560c4170fe7d2abcf098b709b7da7
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/Makefile.am
M src/inventory_report/produceReport/produceReport.sh
A src/inventory_report/produceReport/sqls/storage_domains_query_data.sql
3 files changed, 25 insertions(+), 20 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
Sandro Bonazzola: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/80026
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I352ad8cea86560c4170fe7d2abcf098b709b7da7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months
Change in ovirt-engine[master]: core: use engine xml according to cluster compatibility version
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/79984 )
Change subject: core: use engine xml according to cluster compatibility version
......................................................................
core: use engine xml according to cluster compatibility version
By not specifying any version when checking the config-value, we
essentially check the 'general' version. That is not what we want
to determine whether or not to use the engine xml by, but to check
if engine xml is enabled for the VM compatibility version instead.
Change-Id: I42c2cb80dcdbe3980d23434edcb91cd5929454b6
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoring.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateBrokerVDSCommand.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoringTest.java
3 files changed, 14 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79984
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I42c2cb80dcdbe3980d23434edcb91cd5929454b6
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months
Change in ovirt-engine[master]: webadmin: Fix missing validation highlight
by Code Review
>From Alexander Wels <awels(a)redhat.com>:
Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/80054 )
Change subject: webadmin: Fix missing validation highlight
......................................................................
webadmin: Fix missing validation highlight
This patch fixes the missing validation highlight on the 'Physical
Memory Guaranteed' field in the 'Resource Allocation' side tab of
the new/edit VM popup dialog.
Change-Id: I5c3b95862c8e541829689e1e3393b9447f1fcbdd
Bug-Url: https://bugzilla.redhat.com/1456778
Signed-off-by: Phillip Bailey <phbailey(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
2 files changed, 14 insertions(+), 4 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Phillip Bailey: Verified
--
To view, visit https://gerrit.ovirt.org/80054
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5c3b95862c8e541829689e1e3393b9447f1fcbdd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months
Change in ovirt-engine[master]: config: Made LibGfApi configurable using engine-config
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79785 )
Change subject: config: Made LibGfApi configurable using engine-config
......................................................................
config: Made LibGfApi configurable using engine-config
Change-Id: Ifda65801d2e7d756109b9f79c6e7c2ecf07cd5db
Bug-Url: https://bugzilla.redhat.com/1022961
Signed-off-by: Denis Chaplygin <dchaplyg(a)redhat.com>
---
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
M packaging/etc/engine-config/engine-config.properties
2 files changed, 4 insertions(+), 0 deletions(-)
Approvals:
Denis Chaplygin: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79785
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifda65801d2e7d756109b9f79c6e7c2ecf07cd5db
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months
Change in ovirt-engine[master]: engine: libgfapi feature and cluster level feature have diff...
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79895 )
Change subject: engine: libgfapi feature and cluster level feature have different names.
......................................................................
engine: libgfapi feature and cluster level feature have different names.
Change-Id: I9e4788b6028622f282a527feff6ab5b15c77e786
Bug-Url: https://bugzilla.redhat.com/1022961
Signed-off-by: Denis Chaplygin <dchaplyg(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtils.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtilsTest.java
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Denis Chaplygin: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Sahina Bose: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/79895
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e4788b6028622f282a527feff6ab5b15c77e786
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months
Change in ovirt-iso-uploader[master]: upload: Added support for glusterfs
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/79930 )
Change subject: upload: Added support for glusterfs
......................................................................
upload: Added support for glusterfs
Newer glusterfs volumes have NFS disabled by default, so i use
native gluster api to upload files directly to the ISO storage domain.
Change-Id: If79d868a372c705160333d386de13fc90a835821
Signed-off-by: Denis Chaplygin <dchaplyg(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1437799
---
M AUTHORS
M ovirt-iso-uploader.spec.in
M src/Makefile.am
M src/__main__.py
A src/glfs_api.py
5 files changed, 127 insertions(+), 0 deletions(-)
Approvals:
Denis Chaplygin: Verified
Sandro Bonazzola: Looks good to me, approved
Niels de Vos: Verified; Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79930
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If79d868a372c705160333d386de13fc90a835821
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-iso-uploader
Gerrit-Branch: master
Gerrit-Owner: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Niels de Vos <ndevos(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months
Change in jenkins[master]: Allow executing mirror_client.py from cli
by Code Review
>From Barak Korren <bkorren(a)redhat.com>:
Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/79874 )
Change subject: Allow executing mirror_client.py from cli
......................................................................
Allow executing mirror_client.py from cli
This patch allows to execute mirror_client.py from cli.
This is done for two major reasons:
1) To allow execution of mirror_client.py from mock_runner.sh for
future features.
2) To allow mirror injection to be run locally by users.
Usage:
./mirror_client.py [MIRRORS FILE URI] [LIST OF YUM CONFS TO MODIFY]
Change-Id: I63e6e7e2dd0531a78954a17e44ca7682c44d288a
---
M scripts/mirror_client.py
1 file changed, 31 insertions(+), 0 deletions(-)
Approvals:
Staging Jenkins Server: Passed CI tests
Barak Korren: Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
Daniel Belenky: Verified; Ready for review
--
To view, visit https://gerrit.ovirt.org/79874
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I63e6e7e2dd0531a78954a17e44ca7682c44d288a
Gerrit-PatchSet: 4
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: Staging Jenkins Server
6 years, 8 months
Change in jenkins[master]: Add support to inject mirrors to .yumrepos files
by Code Review
>From Barak Korren <bkorren(a)redhat.com>:
Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/79875 )
Change subject: Add support to inject mirrors to .yumrepos files
......................................................................
Add support to inject mirrors to .yumrepos files
This patch adds support for specifying .yumrepos
file(s) in a projects automation dir.
mock_runner will find the relevant .yumrepos file
for a given execution script, and will inject CI mirrors
to the matching files.
Jira: https://ovirt-jira.atlassian.net/browse/OVIRT-1556
Change-Id: I95fc24bcadc15d2d7b3e3ed62d78a4d9cc857fa7
---
M mock_configs/mock_runner.sh
1 file changed, 41 insertions(+), 4 deletions(-)
Approvals:
Staging Jenkins Server: Passed CI tests
Barak Korren: Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
Daniel Belenky: Verified; Ready for review
--
To view, visit https://gerrit.ovirt.org/79875
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I95fc24bcadc15d2d7b3e3ed62d78a4d9cc857fa7
Gerrit-PatchSet: 8
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: Staging Jenkins Server
6 years, 8 months
Change in jenkins[master]: Removed unused variable from gen_ci_env_info
by Code Review
>From Barak Korren <bkorren(a)redhat.com>:
Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/79987 )
Change subject: Removed unused variable from gen_ci_env_info
......................................................................
Removed unused variable from gen_ci_env_info
also renamed script_path to path_to_script
to make it clearer.
Change-Id: I43afe2f0e89fac0989065866e67bbd899011d600
---
M mock_configs/mock_runner.sh
1 file changed, 7 insertions(+), 7 deletions(-)
Approvals:
Staging Jenkins Server: Passed CI tests
Barak Korren: Looks good to me, approved; Ready for merge
Daniel Belenky: Verified; Ready for review
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79987
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I43afe2f0e89fac0989065866e67bbd899011d600
Gerrit-PatchSet: 3
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: Staging Jenkins Server
6 years, 8 months
Change in ovirt-engine[master]: image upload: raise upload finished event
by Code Review
>From Daniel Erez <derez(a)redhat.com>:
Daniel Erez has submitted this change and it was merged. ( https://gerrit.ovirt.org/80021 )
Change subject: image upload: raise upload finished event
......................................................................
image upload: raise upload finished event
Raise uploadFinishedEvent only on success or failure phases;
i.e. not on PAUSED_SYSTEM phase, to avoid removing hnadler from
managed list in UploadImageManager.
Change-Id: I5c4ede52bd7997c6bac25ecb495da60453d1a098
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageHandler.java
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/80021
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5c4ede52bd7997c6bac25ecb495da60453d1a098
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months