- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: support sort by client and server side in one table
by piotr.kliczewski＠gmail.com 29 Jun '16

29 Jun '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: support sort by client and server side in one table ...................................................................... webadmin: support sort by client and server side in one table Before when we have table we could sort only server side or client side, depends on flag we set. There could be situations where we need to have support for both. An example is 'Active User Sessions' tab, where we show columns which are in database and also in memory. This patch add support, so we can have some columns sorted server side, and some by client side. Change-Id: Ic4c1dba19cedf015c5cad42a4f6872a79669d944 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1340451 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/ColumnResizeCellTable.java 1 file changed, 20 insertions(+), 11 deletions(-) Approvals: Ondra Machacek: Verified Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59938 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4c1dba19cedf015c5cad42a4f6872a79669d944 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: sessions: make columns sortable
by piotr.kliczewski＠gmail.com 29 Jun '16

29 Jun '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: sessions: make columns sortable ...................................................................... webadmin: sessions: make columns sortable This patch add missing support of those colums to be sortable: * sessionLastActiveColumn * sessionStartColumn * sourceIpColumn * sessionDbIdColumn Change-Id: Idc21a4e774053954d09fd0c604e7630b4b3a87ee Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1340451 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SessionConditionFieldAutoCompleter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabSessionView.java 2 files changed, 28 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59939 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc21a4e774053954d09fd0c604e7630b4b3a87ee Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: aaa: FQDN checking introduced by SSO should be case-insensitive
by mperina＠redhat.com 29 Jun '16

29 Jun '16

Martin Peřina has submitted this change and it was merged. Change subject: aaa: FQDN checking introduced by SSO should be case-insensitive ...................................................................... aaa: FQDN checking introduced by SSO should be case-insensitive The client redirect uri check done by sso needs to be case insensitive. Change-Id: I01b12c1f2671d16bfe0aafd3c11f92e1421ba1bc Bug-Url: https://bugzilla.redhat.com/1351217 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59949 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01b12c1f2671d16bfe0aafd3c11f92e1421ba1bc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in jenkins[master]: remove devel until we figure out how to send to the relevant...
by eedri＠redhat.com 29 Jun '16

29 Jun '16

Eyal Edri has submitted this change and it was merged. Change subject: remove devel until we figure out how to send to the relevant maintainers ...................................................................... remove devel until we figure out how to send to the relevant maintainers Change-Id: Ib75c817735f60edf5b943aa7bbce6fcfaf0232ec Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/ovirt/system-tests.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge -- To view, visit https://gerrit.ovirt.org/59953 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib75c817735f60edf5b943aa7bbce6fcfaf0232ec Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI

1 0

Change in ovirt-engine[master]: jsonrpc: version bump
by mperina＠redhat.com 29 Jun '16

29 Jun '16

Martin Peřina has submitted this change and it was merged. Change subject: jsonrpc: version bump ...................................................................... jsonrpc: version bump Change-Id: I12f0dd2759e046b241ac1790b15fb3384495b3c2 Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Bug-Url: https://bugzilla.redhat.com/1349008 --- M ovirt-engine.spec.in M pom.xml 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Verified Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59887 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12f0dd2759e046b241ac1790b15fb3384495b3c2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in mom[master]: Release mom-0.5.5
by msivak＠redhat.com 29 Jun '16

29 Jun '16

Martin Sivák has submitted this change and it was merged. Change subject: Release mom-0.5.5 ...................................................................... Release mom-0.5.5 Change-Id: Icde802c071931abd6c051b21d8c9dcb3c090bf35 Signed-off-by: Martin Sivak <msivak(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/59947 --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Sivák: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/59947 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icde802c071931abd6c051b21d8c9dcb3c090bf35 Gerrit-PatchSet: 2 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>

1 0

Change in jenkins[master]: reduce abandon to 180 days
by amarchuk＠redhat.com 29 Jun '16

29 Jun '16

Anton Marchukov has submitted this change and it was merged. Change subject: reduce abandon to 180 days ...................................................................... reduce abandon to 180 days Change-Id: I0266dffc6928f20ab1c7592dbf0c1639964e3a56 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/yaml/jobs/system/system_gerrit-alert-old-patches.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Anton Marchukov: Verified; Looks good to me; Passed CI tests; Ready for merge -- To view, visit https://gerrit.ovirt.org/59943 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0266dffc6928f20ab1c7592dbf0c1639964e3a56 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: remove redundant comment
by mlipchuk＠redhat.com 29 Jun '16

29 Jun '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: remove redundant comment ...................................................................... core: remove redundant comment As per mlipchuk's request in [1] was separated to the independent change. [1] https://goo.gl/7ikIGL Change-Id: I9965434868dbc9bd94b981d09ea00698d4ed6f41 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmOperationCommandBase.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/59806 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9965434868dbc9bd94b981d09ea00698d4ed6f41 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: NetworkAttachment should use AnonymousHostNetworkQos
by tnisan＠redhat.com 29 Jun '16

29 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: core: NetworkAttachment should use AnonymousHostNetworkQos ...................................................................... core: NetworkAttachment should use AnonymousHostNetworkQos this patch alters NetworkAttachment not to use HostNetworkQos for overriding HostNetworkQos values. This was former approach and there was problem with bean validation, which failed if name/DC id was not provided in that override. This patch solves ONLY bll layer. Db and rest layer is still the same. ad DB layer: all qos are in QOS table, without referential integrity check, allowing null valued name and storage_pool_id. Although unfortunate design, this does not pose any current problems. ad REST layer: with changes in this patch it will work, however OO design is not OK, as overriding qos values is not the same as HostNetworkQos — user still might pass name or DC id and those values will be silently ignored Change-Id: I8d5fcce039ee5c24ece32cec006a85db79757949 Bug-Url: https://bugzilla.redhat.com/1329224 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/AnonymousHostNetworkQos.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/HostNetworkQos.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkAttachment.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkAttachmentDaoImpl.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkAttachmentMapper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/EffectiveHostNetworkQos.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/BaseNetworkImplementationDetailsUtilsTest.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/EffectiveHostNetworkQosTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/InterfacePropertiesAccessor.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModelParametersHelper.java 13 files changed, 74 insertions(+), 40 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59541 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d5fcce039ee5c24ece32cec006a85db79757949 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Extracted HostNetworkQos properties to separate class
by tnisan＠redhat.com 29 Jun '16

29 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Extracted HostNetworkQos properties to separate class ...................................................................... core: Extracted HostNetworkQos properties to separate class Change-Id: I5ca3a75ba71af7a63a48f33ff016d99ec86becc1 Bug-Url: https://bugzilla.redhat.com/1329224 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/AnonymousHostNetworkQos.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/HostNetworkQos.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/HostNetworkQosProperties.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 4 files changed, 212 insertions(+), 53 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59540 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ca3a75ba71af7a63a48f33ff016d99ec86becc1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0