- Engine-commits - oVirt List Archives

Change in ovirt-release[ovirt-4.0]: node: Hack around myhostname issue
by sbonazzo＠redhat.com 18 May '16

18 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: node: Hack around myhostname issue ...................................................................... node: Hack around myhostname issue Change-Id: Ia94aa2b6d267cd42a7658ab94b0630a3936c8047 Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org> Signed-off-by: Tolik Litovsky <tlitovsk(a)redhat.com> --- M ovirt-release40.spec.in 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Fabian Deutsch: Looks good to me, but someone else must approve Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57631 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia94aa2b6d267cd42a7658ab94b0630a3936c8047 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-4.0]: Add EFI dependencies for NGN
by sbonazzo＠redhat.com 18 May '16

18 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Add EFI dependencies for NGN ...................................................................... Add EFI dependencies for NGN We're pulling these out of the kickstart, to keep all dependencies in the release file.. Change-Id: I929497a33cb7747bd33d934aa1bc9fc4377044df Signed-off-by: Ryan Barry <rbarry(a)redhat.com> Signed-off-by: Tolik Litovsky <tlitovsk(a)redhat.com> --- M ovirt-release40.spec.in 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I929497a33cb7747bd33d934aa1bc9fc4377044df Gerrit-PatchSet: 3 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Change permissionCheckSubject for inherited command.
by mlipchuk＠redhat.com 18 May '16

18 May '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Change permissionCheckSubject for inherited command. ...................................................................... core: Change permissionCheckSubject for inherited command. Based on the commit Ida67a4409509652d5eeb1a953c3537051e4e61bb, StorageDomainCommandBase implements the getPermissionCheckSubjects with a new ArrayList and avoid using Singleton list. Based on that AttachStorageDomainToPoolCommand can avoid using two lists and use only the one which was created at StorageDomainCommandBase. Change-Id: Ia5c9e1b068272d2c876a43437368cccfd8437816 Signed-off-by: Maor Lipchuk <maorlipchuk(a)gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AttachStorageDomainToPoolCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Maor Lipchuk: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5c9e1b068272d2c876a43437368cccfd8437816 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Change singletonList to new Array for StorageCommandBase.
by mlipchuk＠redhat.com 18 May '16

18 May '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Change singletonList to new Array for StorageCommandBase. ...................................................................... core: Change singletonList to new Array for StorageCommandBase. Each command inherited from StorageDomainCommandBase, which does not implement the procedure getPermissionCheckSubjects, will risk an exception of UnsupportedOperationException once a new permission will be added to it. An example of a failure can be found when using enabling quota in a Data Center. Hence, changing permissionCheckSubjects singleton collection to use a new array list instead. Change-Id: Ida67a4409509652d5eeb1a953c3537051e4e61bb Signed-off-by: Maor Lipchuk <maorlipchuk(a)gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Maor Lipchuk: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57584 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida67a4409509652d5eeb1a953c3537051e4e61bb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-3.6]: node: Add mailx requirement
by sbonazzo＠redhat.com 18 May '16

18 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: node: Add mailx requirement ...................................................................... node: Add mailx requirement Adding mailx to be able to read emails from daemon/agents. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1335503 Change-Id: I952d56574af11ea4748c9d4c33c704b095bbd08e Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> Signed-off-by: Tolik Litovsky <tlitovsk(a)redhat.com> --- M ovirt-release36.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57637 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I952d56574af11ea4748c9d4c33c704b095bbd08e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-4.0]: node: Add mailx requirement
by sbonazzo＠redhat.com 18 May '16

18 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: node: Add mailx requirement ...................................................................... node: Add mailx requirement Adding mailx to be able to read emails from daemon/agents. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1335503 Change-Id: I952d56574af11ea4748c9d4c33c704b095bbd08e Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> Signed-off-by: Tolik Litovsky <tlitovsk(a)redhat.com> --- M ovirt-release40.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57624 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I952d56574af11ea4748c9d4c33c704b095bbd08e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Improve addLinks() readability and performance
by oliel＠redhat.com 18 May '16

18 May '16

Ori Liel has submitted this change and it was merged. Change subject: restapi: Improve addLinks() readability and performance ...................................................................... restapi: Improve addLinks() readability and performance This patch makes improvements to the process of adding links to retrieved API entities, making it slightly more readable and more importantly, more efficient. Bug-Url: https://bugzilla.redhat.com/1208221 Change-Id: If75f7bf1107b3198b196d4b3a06153570562ab93 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/LinkHelper.java 2 files changed, 297 insertions(+), 206 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved; Passed CI tests Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57231 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If75f7bf1107b3198b196d4b3a06153570562ab93 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: (SN) Actual IP address should be shown for dhcp bo...
by alkaplan＠redhat.com 18 May '16

18 May '16

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: (SN) Actual IP address should be shown for dhcp boot protocol ...................................................................... webadmin: (SN) Actual IP address should be shown for dhcp boot protocol Change-Id: I26a3b5e76e7405b34d52ca0235425264a2cfed6d Bug-Url: https://bugzilla.redhat.com/1325670 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/InterfacePropertiesAccessor.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NetworkAttachmentModel.java 2 files changed, 61 insertions(+), 1 deletion(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Verified; Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57505 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26a3b5e76e7405b34d52ca0235425264a2cfed6d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: build: post ovirt-hosted-engine-setup-2.0.0_beta1
by stirabos＠redhat.com 18 May '16

18 May '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: build: post ovirt-hosted-engine-setup-2.0.0_beta1 ...................................................................... build: post ovirt-hosted-engine-setup-2.0.0_beta1 Change-Id: I8bdffbb88a99a89b37a0e6bc1fc2da36899a0d86 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/build-artifacts.sh M configure.ac 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified Simone Tiraboschi: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57606 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8bdffbb88a99a89b37a0e6bc1fc2da36899a0d86 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: sort the vms lists in import vms window
by tjelinek＠redhat.com 18 May '16

18 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: sort the vms lists in import vms window ...................................................................... webadmin: sort the vms lists in import vms window Sorting both lists displayed in the "Import Virtual Machine(s)" window (VMs tab->import action). There are 2 lists of VMs in that window: Virtual Machines on Source", "Virtual Machines to Import" and both of them are now displaying the VMs sorted by name (alphabetically, the same as displayed in the Storage tab->VM Import sub tab). Please note that the lists remain sorted after loading the VMs to import and also after moving chosen VMs from list to list using the arrows. Change-Id: I8cb771e129087c77bd2a906a12fe3f9c05f8e0ee Bug-Url: https://bugzilla.redhat.com/1296558 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/SplitTable.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java 2 files changed, 63 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved; Passed CI tests Sharon Gratch: Verified -- To view, visit https://gerrit.ovirt.org/57552 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8cb771e129087c77bd2a906a12fe3f9c05f8e0ee Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0