- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: aaa: run mapUser before authentication in REST
by tnisan＠redhat.com 28 Apr '16

28 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: aaa: run mapUser before authentication in REST ...................................................................... aaa: run mapUser before authentication in REST Change-Id: I877e68b13a21f905eec06e3d4bb7d9fcdfb95739 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1330742 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/BasicAuthenticationFilter.java 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56693 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I877e68b13a21f905eec06e3d4bb7d9fcdfb95739 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine-sdk-ruby[master]: Update to version 4.0.15 of the API model
by juan.hernandez＠redhat.com 28 Apr '16

28 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: Update to version 4.0.15 of the API model ...................................................................... Update to version 4.0.15 of the API model This patch updates the SDK to use the latest released version of the API model. Change-Id: I5284ce7355f23607a48a5e016d5b332fb4109dc2 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/56742 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5284ce7355f23607a48a5e016d5b332fb4109dc2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Use "Action" type
by juan.hernandez＠redhat.com 28 Apr '16

28 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: Use "Action" type ...................................................................... Use "Action" type Currently when the SDK needs to perform an action, like starting a virtual machine, the corresponding service class generates directly the "<action>...</action>" XML text, and it doesn't extract the output parameters of some actions. This patch changes it so that instead of generating directly the XML text it creates an instance of the "Action" struct, populates it, and then generates the XML text using the "ActionWriter" class. In also modifies the SDK so that it takes the returned action and extracts the output parameters. Change-Id: If2e254cf2b89baa91aaa13a058274a0c0c6b02a0 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java M sdk/lib/ovirtsdk4/service.rb M sdk/spec/spec_helper.rb A sdk/spec/storage_domain_service_spec.rb A sdk/spec/vm_service_spec.rb 5 files changed, 121 insertions(+), 47 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56737 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2e254cf2b89baa91aaa13a058274a0c0c6b02a0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Move List and Struct implementation into __init__.py
by juan.hernandez＠redhat.com 28 Apr '16

28 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: Move List and Struct implementation into __init__.py ...................................................................... Move List and Struct implementation into __init__.py This patch is moving list.py and struct.py implentations into __init__.py, because list is python word for list data type, it's safer to not use same name for modules. Change-Id: I3b70906e058f6e49bd9d43322a57d60552b0421f Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/python/ReadersGenerator.java M generator/src/main/java/org/ovirt/sdk/python/TypesGenerator.java M generator/src/main/java/org/ovirt/sdk/python/WritersGenerator.java M sdk/lib/ovirtsdk4/__init__.py D sdk/lib/ovirtsdk4/list.py D sdk/lib/ovirtsdk4/struct.py 6 files changed, 74 insertions(+), 108 deletions(-) Approvals: Ondra Machacek: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b70906e058f6e49bd9d43322a57d60552b0421f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fixed gotcha in jdk8 streams
by tjelinek＠redhat.com 28 Apr '16

28 Apr '16

Tomas Jelinek has submitted this change and it was merged. Change subject: core: fixed gotcha in jdk8 streams ...................................................................... core: fixed gotcha in jdk8 streams code .findFirst().orElse(null) does NOT return first instance in stream or null. It returns first instance, if there's non-null first instance. It returns null if stream is empty. And throws NPE, when there's null valued instance in stream. Javadoc: /** * Returns an {@link Optional} describing the first element of this stream, * or an empty {@code Optional} if the stream is empty. If the stream has * no encounter order, then any element may be returned. * * <p>This is a <a href="package-summary.html#StreamOps">short-circuiting * terminal operation</a>. * * @return an {@code Optional} describing the first element of this stream, * or an empty {@code Optional} if the stream is empty * @throws NullPointerException if the element selected is null */ Change-Id: Ie15941484acb6eb0420bc55d72d5cbd9f3b5b1b2 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkConfigurator.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/NetworkConfiguratorTest.java 2 files changed, 60 insertions(+), 7 deletions(-) Approvals: Martin Mucha: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/56646 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie15941484acb6eb0420bc55d72d5cbd9f3b5b1b2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: storage: correctly evaluate glusterfs SD canonical path
by msivak＠redhat.com 28 Apr '16

28 Apr '16

Martin Sivák has submitted this change and it was merged. Change subject: storage: correctly evaluate glusterfs SD canonical path ...................................................................... storage: correctly evaluate glusterfs SD canonical path In the past we let the user specify a path for file based (NFS or gluster) storage domains which includes a trailing '/'. This caused other issues (double mount point when the engine import it) and so we had a patch to evaluate the canonical path and eventually fix the mount point in the configuration file before trying again to connect it. Due to a bug in the evaluation of the canonical path for gluster volumes, it was looping forever on gluster deployed systems. Improoving the the logging to make it more evident. Change-Id: Ic7a877bb4386214044cf85de18f99b1b443222eb Bug-Url: https://bugzilla.redhat.com/1327516 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt_hosted_engine_ha/env/constants.py.in M ovirt_hosted_engine_ha/env/path.py M ovirt_hosted_engine_ha/lib/storage_server.py 3 files changed, 35 insertions(+), 18 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests Sahina Bose: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/56186 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7a877bb4386214044cf85de18f99b1b443222eb Gerrit-PatchSet: 8 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Make SDK code pep8 compliant
by juan.hernandez＠redhat.com 28 Apr '16

28 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: Make SDK code pep8 compliant ...................................................................... Make SDK code pep8 compliant Change the generator to generate pep8 compliant code. Also change manually writter python library code to be pep8 compliant. Run pep8 checks in package proccess. Change-Id: Iaade9bc51ba941650396d63f417bee22a0ff5af1 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M automation/build-artifacts.packages.el7 M automation/build-artifacts.packages.fc23 M automation/check-patch.packages.el7 M automation/check-patch.packages.fc23 M generator/src/main/java/org/ovirt/sdk/python/ReadersGenerator.java M generator/src/main/java/org/ovirt/sdk/python/ServicesGenerator.java M generator/src/main/java/org/ovirt/sdk/python/TypesGenerator.java M generator/src/main/java/org/ovirt/sdk/python/WritersGenerator.java M sdk/lib/ovirtsdk4/__init__.py M sdk/lib/ovirtsdk4/service.py M sdk/lib/ovirtsdk4/struct.py M sdk/pom.xml 12 files changed, 51 insertions(+), 29 deletions(-) Approvals: Ondra Machacek: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56684 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaade9bc51ba941650396d63f417bee22a0ff5af1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Live Merge: Improve Live Merge Recovery Mechanism
by tnisan＠redhat.com 28 Apr '16

28 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Live Merge: Improve Live Merge Recovery Mechanism ...................................................................... core: Live Merge: Improve Live Merge Recovery Mechanism When sending live merge command, we may fail to get vdsm's response due to network error. In this case, the parent of the volume that should have been deleted (the volume that the data is merged in to) will be marked as ILLEGAL. However, a merge job may have started, and even possibly completed, and we want to allow the user to try live merge again in order to remove the snapshot. When the user tries live merge again, if the volume is already deleted from the chain or if there is a running merge job, vdsm returs 'imageErr' or 'mergeErr', respectively. In this patch, engine catches those errors and continues the merge flow as if it succeeded. If merge succeeded the volume is removed from database. Otherwise, volume stays in ILLEGAL state. Change-Id: Ic54ae8576410afbdd095fdae1fb298f2262218f5 Bug-Url: https://bugzilla.redhat.com/1301083 Bug-Url: https://bugzilla.redhat.com/1304761 Bug-Url: https://bugzilla.redhat.com/1314082 Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeStatusCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 4 files changed, 48 insertions(+), 18 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/56734 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic54ae8576410afbdd095fdae1fb298f2262218f5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-3.6]: node: Enable sshd.service by default
by sbonazzo＠redhat.com 28 Apr '16

28 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: node: Enable sshd.service by default ...................................................................... node: Enable sshd.service by default Previously we enabled sshd.socket by default, this lead to bug https://bugzilla.redhat.com/show_bug.cgi?id=1327332#c5 Now we just enable the sshd.service, which should avoid this bug, and also be aligned with what anaconda does. Change-Id: I88a0703b1a4818c4817637ce1e6021e979602b45 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1323975 Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org> --- M host-node/systemd/system-preset/98-ovirt-host-node.preset 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Fabian Deutsch: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56741 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88a0703b1a4818c4817637ce1e6021e979602b45 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-3.6]: node: Don't touch vdsm
by sbonazzo＠redhat.com 28 Apr '16

28 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: node: Don't touch vdsm ...................................................................... node: Don't touch vdsm vdsm has it's own presets for it's own services, thus we leave it untouched. Change-Id: I582f0333cf115eb67d9e4ed734a0fdbb0683c058 Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org> --- M host-node/systemd/system-preset/98-ovirt-host-node.preset 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Fabian Deutsch: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56740 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I582f0333cf115eb67d9e4ed734a0fdbb0683c058 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0