- Engine-commits - oVirt List Archives

Change in ovirt-release[ovirt-4.0]: automation: aligned with 3.6 branch
by sbonazzo＠redhat.com 14 Apr '16

14 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: automation: aligned with 3.6 branch ...................................................................... automation: aligned with 3.6 branch Change-Id: I5ec85781b1f52e639c415ed11438903eaec33a29 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/check-patch.packages A automation/check-patch.repos M automation/check-patch.sh 3 files changed, 9 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56132 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ec85781b1f52e639c415ed11438903eaec33a29 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: spec: dropped <= 3.5 compatibility
by sbonazzo＠redhat.com 14 Apr '16

14 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: dropped <= 3.5 compatibility ...................................................................... packaging: spec: dropped <= 3.5 compatibility Change-Id: I656e19edd23d8e899b776ac1da65389d45e5984d Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54089 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I656e19edd23d8e899b776ac1da65389d45e5984d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_3.6]: Explicitly specify class to parse
by juan.hernandez＠redhat.com 14 Apr '16

14 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: Explicitly specify class to parse ...................................................................... Explicitly specify class to parse Currently when the SDK needs to parse the XML documents returned by the server it calls the "parseString" method generated by the generateDS.py tool. This method decides what is the type of the object checking the root element name. For example, if the root tag is "vm" it will create an instance of the "VM" class, if the root tag is "cluster" it will create an instance of the "Cluster" class, etc. But in some cases this decision isn't correct, particular if the root tag is "version" then the class can be "Version" or "VersionCaps", as both use the same tag. As a result, parsing the results of "/capabilities/{id}" generate an object of class "Version", when it should generate an object of type "VersionCaps". The consequence of this is that calling "api.capabilities.get(id=...)" will always return the wrong type of object. To fix this issue this patch makes the following changes: 1. Add a template to generate inside the "params.py" file a new "parseClass" method that does almost the same than "parseString", but that receives a parameter that explicitly indcates what should be the type of the created object. 2. Modify the "Proxy" class so that all its methods receive and forward a "cls" parameter containing the type of the object. 3. Modify the template for the capabilities resource so that it explicitly passes the "VersionCaps" type to the "get" method of the "Proxy" class. Change-Id: I4a07fe9baeabb64f3d3b69e0eb77c2e0472b7bfd Bug-Url: https://bugzilla.redhat.com/1326729 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/engine/sdk/generator/python/XsdCodegen.java M generator/src/main/java/org/ovirt/engine/sdk/generator/python/templates/CollectionGetCapabilitiesTemplate A generator/src/main/java/org/ovirt/engine/sdk/generator/python/templates/ParseClassTemplate A generator/src/main/java/org/ovirt/engine/sdk/generator/python/templates/ParseClassTemplate.java M src/ovirtsdk/api.py M src/ovirtsdk/infrastructure/brokers.py M src/ovirtsdk/infrastructure/proxy.py M src/ovirtsdk/xml/params.py 8 files changed, 101 insertions(+), 21 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Fabrice Bacchella: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/56096 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a07fe9baeabb64f3d3b69e0eb77c2e0472b7bfd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Fabrice Bacchella <fabrice.bacchella(a)orange.fr> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[master]: automation: aligned with 3.6 branch
by sbonazzo＠redhat.com 14 Apr '16

14 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: automation: aligned with 3.6 branch ...................................................................... automation: aligned with 3.6 branch Change-Id: I5ec85781b1f52e639c415ed11438903eaec33a29 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/build-artifacts.sh M automation/check-patch.packages A automation/check-patch.repos M automation/check-patch.sh 4 files changed, 13 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56130 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ec85781b1f52e639c415ed11438903eaec33a29 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Create TooltippedIcon
by alkaplan＠redhat.com 14 Apr '16

14 Apr '16

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Create TooltippedIcon ...................................................................... webadmin: Create TooltippedIcon A base class for an icon with a tooltip is created in this patch. The class is created by extracting most of the code from InfoIcon and allowing the icons used to be set. InfoIcon is now a specific case of a TooltippedIcon. Change-Id: I7fd072077ba13a13bf8e4de39d60f1723cb0421c Bug-Url: https://bugzilla.redhat.com/1281666 Signed-off-by: mirecki <mmirecki(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/InfoIcon.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/TooltippedIcon.java 2 files changed, 84 insertions(+), 72 deletions(-) Approvals: Marcin Mirecki: Verified Alona Kaplan: Passed CI tests Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55854 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7fd072077ba13a13bf8e4de39d60f1723cb0421c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Adding read-only check in ExternalNetworkProviderProxy
by alkaplan＠redhat.com 14 Apr '16

14 Apr '16

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Adding read-only check in ExternalNetworkProviderProxy ...................................................................... engine: Adding read-only check in ExternalNetworkProviderProxy Adding a check against the read only attribute. The check is actually doubled, as the check is (should be) made in the appropriate Actions, where a better error message is provided. Change-Id: If46d14c09e1743ae0553d364917c1a4cdae900c4 Signed-off-by: mirecki <mmirecki(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1314375 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/BaseNetworkProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/ExternalNetworkProviderProxy.java 2 files changed, 39 insertions(+), 1 deletion(-) Approvals: Marcin Mirecki: Verified Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55263 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If46d14c09e1743ae0553d364917c1a4cdae900c4 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: packaging: setup: avoid copying answerfile over scp
by sbonazzo＠redhat.com 14 Apr '16

14 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: avoid copying answerfile over scp ...................................................................... packaging: setup: avoid copying answerfile over scp On additional hosts: - Reading first host answerfile from the shared storage Change-Id: I1ddd660d745887814b77ce4db4c1065e5b2128bd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1322729 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt-hosted-engine-setup.spec.in M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/core/remote_answerfile.py M src/plugins/ovirt-hosted-engine-setup/storage/storage.py 4 files changed, 63 insertions(+), 222 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/55503 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ddd660d745887814b77ce4db4c1065e5b2128bd Gerrit-PatchSet: 5 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Don't overwrite local domain's format
by tnisan＠redhat.com 14 Apr '16

14 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Don't overwrite local domain's format ...................................................................... core: Don't overwrite local domain's format ensureStorageFormatInitialized(), called from AddStorageDomainCommand#validate() already takes care of calculating the correct format for the domain. Overwriting in in AddLocalStorageDomainCommand is at best just redundant (for data domains) and at worst just plain wrong (for export and iso domains). Change-Id: Iead537b06ce234f41ccb399d757eff442c5342e4 Bug-Url: https://bugzilla.redhat.com/1323462 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddLocalStorageDomainCommand.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/56088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iead537b06ce234f41ccb399d757eff442c5342e4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Read only feature for adding external networks
by alkaplan＠redhat.com 14 Apr '16

14 Apr '16

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Read only feature for adding external networks ...................................................................... webadmin: Read only feature for adding external networks The list of external providers on the add network dialog should not contain read only providers. Change-Id: I895207228046a1677bf16e9d20c1ec96dfbc0728 Signed-off-by: mirecki <mmirecki(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1314375 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java 1 file changed, 25 insertions(+), 1 deletion(-) Approvals: Marcin Mirecki: Verified Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55106 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I895207228046a1677bf16e9d20c1ec96dfbc0728 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Read only feature for removing external networks
by alkaplan＠redhat.com 14 Apr '16

14 Apr '16

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Read only feature for removing external networks ...................................................................... webadmin: Read only feature for removing external networks The 'remove from external provider' checkbox should not be visible on the network removal dialog when an external network is read only Change-Id: I0de1027d934889bd0c2892050347eee63b724ccd Signed-off-by: mirecki <mmirecki(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1314375 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/RemoveNetworksModel.java 1 file changed, 90 insertions(+), 9 deletions(-) Approvals: Marcin Mirecki: Verified Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0de1027d934889bd0c2892050347eee63b724ccd Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0