- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: v2v: Set disk's boot flag after conversion
by ahadas＠redhat.com 28 Mar '16

28 Mar '16

Arik Hadas has submitted this change and it was merged. Change subject: v2v: Set disk's boot flag after conversion ...................................................................... v2v: Set disk's boot flag after conversion Disk's boot flag is determined in ConvertVmCommand when disk information is already written into DB. Because of that the boot flag needs to be written after that in a separate call. Change-Id: Ic9603163bfd03bfe248ebfdd227e4a9087568706 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1308914 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConvertVmCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDiskDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDiskDaoImpl.java M packaging/dbscripts/base_disks_sp.sql 4 files changed, 39 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55321 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9603163bfd03bfe248ebfdd227e4a9087568706 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Restore V3 "storage_manager" element
by juan.hernandez＠redhat.com 28 Mar '16

28 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Restore V3 "storage_manager" element ...................................................................... restapi: Restore V3 "storage_manager" element The storage "storage_manager" element was replaced by a new "spm" element some time ago, and it was removed from version 4 of the API. But it needs to be preserved in version 3 of the API. This patch adds the required conversions to support it. Change-Id: I424e4f53c3a1c380d9b38b170dabc190ef89d34f Bug-Url: https://bugzilla.redhat.com/1321452 Related-To: https://bugzilla.redhat.com/1136061 Related-To: https://gerrit.ovirt.org/32274 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3HostInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3HostOutAdapter.java 2 files changed, 49 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55328 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I424e4f53c3a1c380d9b38b170dabc190ef89d34f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: schema: Allow to pass scheduling policy name for Up...
by juan.hernandez＠redhat.com 28 Mar '16

28 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: schema: Allow to pass scheduling policy name for Update Cluster ...................................................................... restapi: schema: Allow to pass scheduling policy name for Update Cluster This will enable auto completion for policy name in the SDK as well. Change-Id: I75de8bf1f1917720598b634e4fcbd87f3b4463c3 Bug-Url: https://bugzilla.redhat.com/1315657 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ori Liel: Looks good to me, approved Juan Hernandez: Passed CI tests Roy Golan: Verified -- To view, visit https://gerrit.ovirt.org/54962 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75de8bf1f1917720598b634e4fcbd87f3b4463c3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: Revert "core: prevent a race on add template version"
by ahadas＠redhat.com 28 Mar '16

28 Mar '16

Arik Hadas has submitted this change and it was merged. Change subject: Revert "core: prevent a race on add template version" ...................................................................... Revert "core: prevent a race on add template version" This reverts commit 0c02d2930c1b0064417d1f2b22871a61b86ddc72. Cannot add null value to ConcurrentHashMap. Not sure how it wasn't catched in the verification. Change-Id: Icbb7fd15dcee11d40c26edcbff429914d2dc690f Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/exclude-filters.xml M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java 2 files changed, 0 insertions(+), 11 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/55345 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icbb7fd15dcee11d40c26edcbff429914d2dc690f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove VmTemplateCommand#executeCommand
by ahadas＠redhat.com 28 Mar '16

28 Mar '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Remove VmTemplateCommand#executeCommand ...................................................................... core: Remove VmTemplateCommand#executeCommand Throwing a NotImplementedException isn't a useful behavior - its just a stub implementation intended to mark that whoever extends this class should override this method. A much better way to do this is to declare the class abstract (as it already is), and leave this method unimplemented, so overriding it is checked in compile time. Change-Id: Ia96bf6ddfd5ca194a70f86742be609ec8a400d4e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55297 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia96bf6ddfd5ca194a70f86742be609ec8a400d4e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[master]: plugins: Remove unneeded after=
by didi＠redhat.com 28 Mar '16

28 Mar '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: plugins: Remove unneeded after= ...................................................................... plugins: Remove unneeded after= No need to set after=event2 in event1 if event2 runs at a later stage. Change-Id: Ifb8d0c071f369af8c9597c6666bc1d41eb6da4ab Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt-engine-setup-plugin-live/src/plugins/all-in-one/vdsmi.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55340 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb8d0c071f369af8c9597c6666bc1d41eb6da4ab Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: userportal: Fixed New Template dialog size
by derez＠redhat.com 28 Mar '16

28 Mar '16

Daniel Erez has submitted this change and it was merged. Change subject: userportal: Fixed New Template dialog size ...................................................................... userportal: Fixed New Template dialog size Changed the size of the New Template dialog in the user portal so elements won't slide off it when "Create as a Template Sub Version" widget is open. Change-Id: I366f19dc7bb6efd8a2b4b96f539a80d269de5e1b Bug-Url: https://bugzilla.redhat.com/1190142 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmMakeTemplatePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmMakeTemplatePopupView.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Tomer Saban: Verified -- To view, visit https://gerrit.ovirt.org/54453 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I366f19dc7bb6efd8a2b4b96f539a80d269de5e1b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_3.6]: sdk: Support URL parameters in actions
by juan.hernandez＠redhat.com 28 Mar '16

28 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Support URL parameters in actions ...................................................................... sdk: Support URL parameters in actions Currently the SDK doesn't support the URL parameters that are available in some actions. For example, the action to deactivate a host supports the "async" parameter, but it isn't possible to use in the SDK because the signature of the "deactivate" method doesn't contain it: def deactivate( self, action=params.Action(), correlation_id=None ) It should be like this instead: def deactivate( self, action=params.Action(), correlation_id=None, async=None ) In order to support that this patch modifies the code generator so that these URL parameters are added to the signature, and sent to the server. Change-Id: I7cad178d3b7d809d5bb81efcc128a671e97bdea3 Bug-Url: https://bugzilla.redhat.com/1311495 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/engine/sdk/generator/python/Action.java M generator/src/main/java/org/ovirt/engine/sdk/generator/python/Documentation.java M generator/src/main/java/org/ovirt/engine/sdk/generator/python/templates/ResourceActionTemplate M src/ovirtsdk/infrastructure/brokers.py 4 files changed, 1,252 insertions(+), 775 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53962 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7cad178d3b7d809d5bb81efcc128a671e97bdea3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: text: slightly improve English
by alkaplan＠redhat.com 28 Mar '16

28 Mar '16

Alona Kaplan has submitted this change and it was merged. Change subject: text: slightly improve English ...................................................................... text: slightly improve English Change-Id: Ib3600459e9bee5d5bf36398aa52a2d15a6e0312f Bug-Url: https://bugzilla.redhat.com/1261795 Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55289 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3600459e9bee5d5bf36398aa52a2d15a6e0312f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: core: flush in _earlyDebug
by didi＠redhat.com 28 Mar '16

28 Mar '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: core: flush in _earlyDebug ...................................................................... core: flush in _earlyDebug Change-Id: Ia63f0e58d355afc9b153bc5ef6d9538f00f96617 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M src/otopi/context.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55326 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia63f0e58d355afc9b153bc5ef6d9538f00f96617 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0