- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: build: animal-sniffer in compile time
by amureini＠redhat.com 23 Mar '16

23 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: build: animal-sniffer in compile time ...................................................................... build: animal-sniffer in compile time animal-sniffer is an important check that prevents future breakages in GWT. As it's no longer run in CI, and as it takes a negligible time to run this patch makes sure it will be run as part of the build, and is governed by a property (like, e.g., checkstyle, which is much more expensive) Change-Id: I678cf246a446f2146de93b5f96a35ec0091234fc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/extensions-api-root/pom.xml M backend/manager/modules/searchbackend/pom.xml M build-tools-root/ovirt-findbugs-filters/pom.xml M frontend/webadmin/modules/pom.xml M pom.xml 7 files changed, 44 insertions(+), 98 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests Vojtech Szocs: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/54997 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I678cf246a446f2146de93b5f96a35ec0091234fc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-host-deploy[master]: packaging: updated AUTHORS
by sbonazzo＠redhat.com 23 Mar '16

23 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: updated AUTHORS ...................................................................... packaging: updated AUTHORS Change-Id: Ic76fb07be2dd377c76078e728d949ecf6c95df30 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M AUTHORS 1 file changed, 25 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55149 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic76fb07be2dd377c76078e728d949ecf6c95df30 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-host-deploy[master]: packaging: gettext: use 0.18.2 or latest
by sbonazzo＠redhat.com 23 Mar '16

23 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: gettext: use 0.18.2 or latest ...................................................................... packaging: gettext: use 0.18.2 or latest Use gettext 0.18.2 or newest: gettext 0.19.6 introduces a new macro, allowing to use latest gettext provided it's newer than requires See: https://lists.gnu.org/archive/html/bug-gettext/2015-08/msg00026.html - Solved: autoreconf: running: automake --add-missing --copy --force-missing configure.ac:39: warning: The 'AM_PROG_MKDIR_P' macro is deprecated, and its use is discouraged. configure.ac:39: You should use the Autoconf-provided 'AC_PROG_MKDIR_P' macro instead, configure.ac:39: and use '$(MKDIR_P)' instead of '$(mkdir_p)'in your Makefile.am files. - ignore autogenerated intl directory - Drop requirement on GCC for having gettext support, we're using Python. Change-Id: I32a81cc3e3892aa0e7096d0694ebc2346e465aa4 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M .gitignore M configure.ac M ovirt-host-deploy.spec.in M po/Makevars M po/POTFILES.in 5 files changed, 50 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/55148 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32a81cc3e3892aa0e7096d0694ebc2346e465aa4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: the HA flag was not shown in the edit instance type
by tnisan＠redhat.com 23 Mar '16

23 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: the HA flag was not shown in the edit instance type ...................................................................... webadmin: the HA flag was not shown in the edit instance type It was sent to backend and stored to db, but on edit instance type, it did not show up properly. Change-Id: I2a8c9a4127f5ef108b415d1961ccad55f71fe6a7 Bug-Url: https://bugzilla.redhat.com/1275778 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/ExistingNonClusterModelBehavior.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55116 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a8c9a4127f5ef108b415d1961ccad55f71fe6a7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Supported browser link color
by tnisan＠redhat.com 23 Mar '16

23 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Supported browser link color ...................................................................... webadmin: Supported browser link color - Changed the color of the supported browser link to match other links on welcome page. Change-Id: I912087c24d2057bc62630ba20ec33c014312450f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1314430 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationMessages.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/public/WebAdmin.css 2 files changed, 6 insertions(+), 1 deletion(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Looks good to me, approved Oved Ourfali: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55027 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I912087c24d2057bc62630ba20ec33c014312450f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: Clarify cloud-init generation prompt
by sbonazzo＠redhat.com 23 Mar '16

23 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Clarify cloud-init generation prompt ...................................................................... Clarify cloud-init generation prompt The prompt that asks the user if to generate the cloud-init image or use an already existing one was modified to make it clear that no-cloud is type of cloud-init image. Change-Id: Ie9c609b471b03812dca718ccf61e2288a97d4fbc Signed-off-by: Lev Veyde <lveyde(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1228141 --- M src/plugins/ovirt-hosted-engine-setup/vm/cloud_init.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55144 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9c609b471b03812dca718ccf61e2288a97d4fbc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: Clarify cloud-init generation prompt
by sbonazzo＠redhat.com 23 Mar '16

23 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Clarify cloud-init generation prompt ...................................................................... Clarify cloud-init generation prompt The prompt that asks the user if to generate the cloud-init image or use an already existing one was modified to make it clear that no-cloud is type of cloud-init image. Change-Id: Ie9c609b471b03812dca718ccf61e2288a97d4fbc Signed-off-by: Lev Veyde <lveyde(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1228141 --- M po/pt_BR.po M src/plugins/ovirt-hosted-engine-setup/vm/cloud_init.py 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/55139 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9c609b471b03812dca718ccf61e2288a97d4fbc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: HE: Editing forbidden fields on HE VM should show better error
by tnisan＠redhat.com 23 Mar '16

23 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: HE: Editing forbidden fields on HE VM should show better error ...................................................................... HE: Editing forbidden fields on HE VM should show better error This fixes a small bug that happened during rebase. Change-Id: Ic50531ead764de98f86de30bcc9891b0db1d11ec Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1160094 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Passed CI tests Martin Sivák: Verified Phillip Bailey: Looks good to me, but someone else must approve Roy Golan: Looks good to me, approved Jenny Tokar: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/54809 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic50531ead764de98f86de30bcc9891b0db1d11ec Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: HE: Set default priority and timezone when importing hosted ...
by tnisan＠redhat.com 23 Mar '16

23 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: HE: Set default priority and timezone when importing hosted engine VM ...................................................................... HE: Set default priority and timezone when importing hosted engine VM Also fix the fields to defaults if missing in already imported HE VM. Bug-Url: https://bugzilla.redhat.com/1160094 Change-Id: I40d6396fcc767e041466ace758d2a8fe0631aeef Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HostedEngineImporter.java A packaging/dbscripts/upgrade/03_06_2060_set_timezone_priority_for_he.sql 2 files changed, 14 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Passed CI tests Martin Sivák: Verified Eli Mesika: Looks good to me, but someone else must approve Phillip Bailey: Looks good to me, but someone else must approve Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54810 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40d6396fcc767e041466ace758d2a8fe0631aeef Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: HE: Fix next run need detection bug
by tnisan＠redhat.com 23 Mar '16

23 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: HE: Fix next run need detection bug ...................................................................... HE: Fix next run need detection bug Missing parentheses in the condition caused the logic to be wrong. Since the condition was too complicated I decided to split it in two. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1160094 Change-Id: Ia0144801dbe367191416d9ebc3c30607f0bf6c8f Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Martin Sivák: Verified Phillip Bailey: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/54918 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0144801dbe367191416d9ebc3c30607f0bf6c8f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0