- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Fix format of "Link" header
by juan.hernandez＠redhat.com 10 Mar '16

10 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix format of "Link" header ...................................................................... restapi: Fix format of "Link" header The introduction of version 4 of the API included a regression in this area: the "Link" header that is part of the HEAD request isn't formatted correctly. This patch fixes that issue. Change-Id: I08a5845577a6871d08d700b929ed647c55d9a5bd Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java 1 file changed, 3 insertions(+), 5 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54577 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08a5845577a6871d08d700b929ed647c55d9a5bd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Petr Balogh <pbalogh(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: hypervisors: moving to ovirt-engine sdk version 4
by sbonazzo＠redhat.com 10 Mar '16

10 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: hypervisors: moving to ovirt-engine sdk version 4 ...................................................................... hypervisors: moving to ovirt-engine sdk version 4 ovirt-engine-python-sdk was renamed to python-ovirt-engine-sdk4, and its API changed heavily. Change-Id: I76789f190efc5d0c8eba530131bbd562b192d723 Signed-off-by: Rafael Martins <rmartins(a)redhat.com> --- M configure.ac M ovirt-log-collector.spec.in M src/helper/hypervisors.py 3 files changed, 39 insertions(+), 49 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Rafael Martins: Verified -- To view, visit https://gerrit.ovirt.org/54398 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76789f190efc5d0c8eba530131bbd562b192d723 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: vm/cloud_init: fix English
by sbonazzo＠redhat.com 10 Mar '16

10 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: vm/cloud_init: fix English ...................................................................... vm/cloud_init: fix English Should should appear only once in a sentence (except in this one!) Change-Id: Ifaf42a9fac22b707f05bef845d1342223fb53720 Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> --- M po/pt_BR.po M src/plugins/ovirt-hosted-engine-setup/vm/cloud_init.py 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54377 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifaf42a9fac22b707f05bef845d1342223fb53720 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Network Import dialog open/cancel fails
by tnisan＠redhat.com 10 Mar '16

10 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Network Import dialog open/cancel fails ...................................................................... webadmin: Network Import dialog open/cancel fails The Network Import dialog in the network list fails to close when cancel is pressed. It also opens only once, all further attempts to open it fail. The issue was caused by an incorrect model being injected into the model (the external provider one). The same dialog is also used in external providers network import. There it works fine, as the model is the right one. Change-Id: Id6a687c0c290891b3c5636dc82d598399f3e37df Bug-Url: https://bugzilla.redhat.com/1306585 Signed-off-by: mirecki <mmirecki(a)redhat.com> --- A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/BaseImportNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/DiscoverNetworksModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/provider/ImportNetworksPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ImportNetworksPopupView.java 5 files changed, 378 insertions(+), 365 deletions(-) Approvals: Marcin Mirecki: Verified Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54279 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6a687c0c290891b3c5636dc82d598399f3e37df Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: minidnf: removed useless space strings marked for translation
by didi＠redhat.com 10 Mar '16

10 Mar '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: minidnf: removed useless space strings marked for translation ...................................................................... minidnf: removed useless space strings marked for translation Change-Id: I0a733b1237be0473dfc6d6543cfb232f5275cd2c Signed-off-by: Rafael Martins <rmartins(a)redhat.com> --- M src/otopi/minidnf.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, approved Rafael Martins: Verified -- To view, visit https://gerrit.ovirt.org/54428 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a733b1237be0473dfc6d6543cfb232f5275cd2c Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Add Image Upload progress to disk list
by amureini＠redhat.com 09 Mar '16

09 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Add Image Upload progress to disk list ...................................................................... webadmin: Add Image Upload progress to disk list Display progress of Image Uploads in the disk list. The progress is shown using a subclass of the AbstractPercentColumn, with a text display of the transfer progress or current state (e.g. Paused, Resuming, etc). Change-Id: I9639175d9cc6d2083644f7ffb4bb5c87ebb708bf Related-To: https://bugzilla.redhat.com/1091377 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/DiskUploadImageProgressColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/BaseVmDiskListModelTable.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageDiskView.java 7 files changed, 180 insertions(+), 6 deletions(-) Approvals: Greg Padgett: Verified Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47919 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9639175d9cc6d2083644f7ffb4bb5c87ebb708bf Gerrit-PatchSet: 28 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Image Upload link from Disks tab and Storage > Dis...
by amureini＠redhat.com 09 Mar '16

09 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Image Upload link from Disks tab and Storage > Disks sub-tab ...................................................................... webadmin: Image Upload link from Disks tab and Storage > Disks sub-tab Add new links to control Image Upload to both the Disks tab and the Storage > Disks sub-tab of webadmin. Links are: Upload - start a new upload Pause Upload - pause an ongoing upload (enabled only if in-progress uploads are selectd) Resume Upload - resume a paused upload (enabled only if a paused upload is selected) Cancel Upload - cancel an ongoing upload (enabled only if in-progress uploads are selected The logic for these new operations is contained in UploadImageModel, because some involve checking state specific to image uploads and/or invoke the UploadImageStatus command with specific arguments. Change-Id: Ib4afcf04f100c27925055412112ac12c0a60ed13 Related-To: https://bugzilla.redhat.com/1091377 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/DiskModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/StorageModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageDiskView.java 10 files changed, 478 insertions(+), 0 deletions(-) Approvals: Greg Padgett: Verified Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/50570 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4afcf04f100c27925055412112ac12c0a60ed13 Gerrit-PatchSet: 24 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Image Upload dialog
by amureini＠redhat.com 09 Mar '16

09 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Image Upload dialog ...................................................................... webadmin: Image Upload dialog Webadmin dialog for starting and resuming Image Uploads. Change-Id: I0afd6145712a677e9c9e8d596b52ce0d30f1ccb8 Related-To: https://bugzilla.redhat.com/1091377 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/storage/UploadImagePopupPresenterWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/UploadImagePopupView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/UploadImagePopupView.ui.xml 13 files changed, 1,477 insertions(+), 1 deletion(-) Approvals: Greg Padgett: Verified Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/50569 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0afd6145712a677e9c9e8d596b52ce0d30f1ccb8 Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Introduce ReadOnlyDiskModel for Image Upload
by amureini＠redhat.com 09 Mar '16

09 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Introduce ReadOnlyDiskModel for Image Upload ...................................................................... webadmin: Introduce ReadOnlyDiskModel for Image Upload The dialog for resuming an Image Upload will display the disk properties, for which a model is needed that does not accept modifications but shows the disk's descriptive attributes. Change-Id: I14dcbfb50a6249de6380346469baa055f7130662 Related-To: https://bugzilla.redhat.com/1091377 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ReadOnlyDiskModel.java 4 files changed, 172 insertions(+), 3 deletions(-) Approvals: Greg Padgett: Verified Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/50568 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14dcbfb50a6249de6380346469baa055f7130662 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: frontend: VDSM error strings for Image Upload
by amureini＠redhat.com 09 Mar '16

09 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: frontend: VDSM error strings for Image Upload ...................................................................... frontend: VDSM error strings for Image Upload Change-Id: I0b56fad9f22025a5f99b6a4dac2669377c3ccd9c Related-To: https://bugzilla.redhat.com/1091377 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Greg Padgett: Verified Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/50567 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b56fad9f22025a5f99b6a4dac2669377c3ccd9c Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0