- Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-ruby[master]: Rename "Ovirt::SDK::V4" to "OvirtSDK4"
by juan.hernandez＠redhat.com 02 Mar '16

02 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: Rename "Ovirt::SDK::V4" to "OvirtSDK4" ...................................................................... Rename "Ovirt::SDK::V4" to "OvirtSDK4" This patch changes the namespace of the SDK from "Ovirt::SDK::V4" to "OvirtSDK4", to make it more similar to the other SDKs. Change-Id: Ib186d0cdd6afad5f4c50c9aa889eee89ebb0739c Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/RubyNames.java M packaging/spec.el7.in M packaging/spec.fc23.in M sdk/README.md M sdk/Rakefile M sdk/examples/add_cluster.rb M sdk/examples/add_data_center.rb M sdk/examples/add_host.rb M sdk/examples/add_nfs_data_storage_domain.rb M sdk/examples/add_nfs_iso_storage_domain.rb M sdk/examples/add_vm.rb M sdk/examples/add_vm_disk.rb M sdk/examples/add_vm_nic.rb M sdk/examples/attach_nfs_data_storage_domain.rb M sdk/examples/attach_nfs_iso_storage_domain.rb M sdk/examples/follow_vm_links.rb M sdk/examples/list_vms.rb M sdk/examples/remove_host.rb M sdk/examples/remove_vm.rb M sdk/examples/search_vms.rb M sdk/examples/show_summary.rb M sdk/examples/start_vm.rb M sdk/examples/stop_vm.rb M sdk/examples/update_data_center.rb D sdk/ext/ovirtsdk/ov_module.c R sdk/ext/ovirtsdk4c/extconf.rb R sdk/ext/ovirtsdk4c/ov_error.c R sdk/ext/ovirtsdk4c/ov_error.h C sdk/ext/ovirtsdk4c/ov_module.c R sdk/ext/ovirtsdk4c/ov_module.h R sdk/ext/ovirtsdk4c/ov_xml_constants.c R sdk/ext/ovirtsdk4c/ov_xml_constants.h R sdk/ext/ovirtsdk4c/ov_xml_reader.c R sdk/ext/ovirtsdk4c/ov_xml_reader.h R sdk/ext/ovirtsdk4c/ov_xml_writer.c R sdk/ext/ovirtsdk4c/ov_xml_writer.h R sdk/ext/ovirtsdk4c/ovirtsdk4c.c D sdk/lib/ovirt/sdk/v4/http.rb D sdk/lib/ovirt/sdk/v4/reader.rb D sdk/lib/ovirt/sdk/v4/service.rb D sdk/lib/ovirt/sdk/v4/type.rb D sdk/lib/ovirt/sdk/v4/writer.rb D sdk/lib/ovirt/sdk/v4/xml_formatter.rb D sdk/lib/ovirt/sdk/v4/xml_reader.rb D sdk/lib/ovirt/sdk/v4/xml_writer.rb R sdk/lib/ovirtsdk4.rb A sdk/lib/ovirtsdk4/http.rb C sdk/lib/ovirtsdk4/reader.rb A sdk/lib/ovirtsdk4/service.rb A sdk/lib/ovirtsdk4/type.rb C sdk/lib/ovirtsdk4/writer.rb A sdk/lib/ovirtsdk4/xml.rb M sdk/ovirt-engine-sdk.gemspec M sdk/spec/action_reader_spec.rb M sdk/spec/clusters_service_spec.rb M sdk/spec/connection_spec.rb M sdk/spec/data_centers_service_spec.rb M sdk/spec/fault_reader_spec.rb M sdk/spec/parameters.yaml M sdk/spec/service_spec.rb M sdk/spec/spec_helper.rb M sdk/spec/storage_domains_service_spec.rb M sdk/spec/vm_reader_spec.rb M sdk/spec/vm_spec.rb M sdk/spec/vm_writer_spec.rb M sdk/spec/vms_service_spec.rb M sdk/spec/xml_formatter_spec.rb M sdk/spec/xml_reader_spec.rb M sdk/spec/xml_writer_spec.rb 69 files changed, 971 insertions(+), 1,063 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54240 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib186d0cdd6afad5f4c50c9aa889eee89ebb0739c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-reports[ovirt-engine-reports-3.6]: reports:fixed bug in query of br44
by sradco＠redhat.com 02 Mar '16

02 Mar '16

Shirly Radco has submitted this change and it was merged. Change subject: reports:fixed bug in query of br44 ...................................................................... reports:fixed bug in query of br44 fixed bug in query of br44. vm uptime(hours) was calculated incorrectly. Change-Id: I95692100ca057ad369ec78f3e388c2b7c49e77f8 Bug-Url: https://bugzilla.redhat.com/1304656 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/Reports/Inventory/ccp_vm_inventory_br44_files/ccp_vm_inventory_br44_jrxml.data 1 file changed, 9 insertions(+), 6 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54123 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95692100ca057ad369ec78f3e388c2b7c49e77f8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.6 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Use mixin for methods common to structs and lists
by juan.hernandez＠redhat.com 01 Mar '16

01 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: Use mixin for methods common to structs and lists ...................................................................... Use mixin for methods common to structs and lists Currently the "Struct" and "List" base classes contain duplicated code to manage the "id" and "href" attributes and the "follow_link" method. This patch introduces a new "Type" module that is used as a mixin to contain that code and avoid the duplication. Change-Id: I0a5a095dfcae70fed878eaf3d95ce331e68625c2 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/lib/ovirt/sdk/v4.rb D sdk/lib/ovirt/sdk/v4/list.rb R sdk/lib/ovirt/sdk/v4/type.rb 3 files changed, 19 insertions(+), 107 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54232 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a5a095dfcae70fed878eaf3d95ce331e68625c2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Rename "connection.rb" to "http.rb"
by juan.hernandez＠redhat.com 01 Mar '16

01 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: Rename "connection.rb" to "http.rb" ...................................................................... Rename "connection.rb" to "http.rb" This file contains several HTTP related classes, not just the connection class, so "http" is a better name than "connection". Change-Id: I283b072a4674fc5b2e197de026057427d93939f8 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/lib/ovirt/sdk/v4.rb R sdk/lib/ovirt/sdk/v4/http.rb 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54231 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I283b072a4674fc5b2e197de026057427d93939f8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add support for debug log file
by juan.hernandez＠redhat.com 01 Mar '16

01 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add support for debug log file ...................................................................... Add support for debug log file Currently when the debug mode is enabled the SDK writes the debug output to stdout. This isn't convenient for applications that need to write other things to stdout. This patch adds a new "log" parameter to the constructor of the connection. This parameter can contain a file name or an IO object. If it contains a file name the file will be created if needed, and the debug output will be added to the end of the file. If it contains an IO object then the debug output will be written directly to that IO object. Change-Id: I80e61eb6585ba9f31e95c41ac99615a0681ba2e9 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/lib/ovirt/sdk/v4/connection.rb M sdk/spec/connection_spec.rb 2 files changed, 65 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54230 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80e61eb6585ba9f31e95c41ac99615a0681ba2e9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Unit tests for VmDevicesMonitoring
by ahadas＠redhat.com 01 Mar '16

01 Mar '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Unit tests for VmDevicesMonitoring ...................................................................... core: Unit tests for VmDevicesMonitoring Adding unit tests to verify VmDevicesMonitoring functionality. Change-Id: I2a29bc894606af872d89e9b0a8e9e148c7b6d82e Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoring.java A backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoringTest.java 2 files changed, 453 insertions(+), 8 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53553 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a29bc894606af872d89e9b0a8e9e148c7b6d82e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: prevent duplicate watchdog device on new vm
by ahadas＠redhat.com 01 Mar '16

01 Mar '16

Arik Hadas has submitted this change and it was merged. Change subject: core: prevent duplicate watchdog device on new vm ...................................................................... core: prevent duplicate watchdog device on new vm When a template is set with watchdog device and the user creates a VM from that template, the VM ends up with 2 watchdog devices: 1. The one that was copied from the template 2. Additional device that is added by AddVmCommand#addVmWatchdog The solution is not to add another watchdog device if one is already defined in the template. Change-Id: I1280cb9fe3f9e9047c796bf54cb05dceda4ff43f Bug-Url: https://bugzilla.redhat.com/1304676 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateWatchdogCommand.java 2 files changed, 17 insertions(+), 7 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54120 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1280cb9fe3f9e9047c796bf54cb05dceda4ff43f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Tag selection exception
by tnisan＠redhat.com 01 Mar '16

01 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Tag selection exception ...................................................................... webadmin: Tag selection exception - Fix exception when using tags and switching tabs. Change-Id: I43938f8dc15ee8b64be2d199c3d7b273d5daace8 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1307030 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43938f8dc15ee8b64be2d199c3d7b273d5daace8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: periodic decrease of 20 days for warning & abandoning
by sbonazzo＠redhat.com 01 Mar '16

01 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: periodic decrease of 20 days for warning & abandoning ...................................................................... periodic decrease of 20 days for warning & abandoning Change-Id: Ia3ad52a2bb7f74d2265ee26db879122a8a09679d Signed-off-by: Anton Marchukov <amarchuk(a)redhat.com> --- M jobs/confs/yaml/jobs/system/system_gerrit-alert-old-patches.yaml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for merge Anton Marchukov: Verified; Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54202 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3ad52a2bb7f74d2265ee26db879122a8a09679d Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: prevent duplicate virtio-serial device
by ahadas＠redhat.com 01 Mar '16

01 Mar '16

Arik Hadas has submitted this change and it was merged. Change subject: core: prevent duplicate virtio-serial device ...................................................................... core: prevent duplicate virtio-serial device In 3.6 the virtio-serial device becomes managed device. However, it can still be reported as unmanaged if the VM was started in pre 3.6 version and was running during the upgrade and its ID will be different than the one stored in the database. This patch suggests to look for virtio-serial devices not only by their ID but by their type as well. That way, when we get unamanged virtio-serial reported by VDSM, we will be able to correlate it to the managed device and it will prevent adding it again. This solution assumes that only one virtio-serial device is defined for each VM. Change-Id: I3546332024b6ee7667340f031c6c225e1ee67ead Bug-Url: https://bugzilla.redhat.com/1308885 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoring.java 2 files changed, 24 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/54145 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3546332024b6ee7667340f031c6c225e1ee67ead Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0