- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: storage_domain_shared_status SQL calculation
by amureini＠redhat.com 22 Feb '16

22 Feb '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: storage_domain_shared_status SQL calculation ...................................................................... core: storage_domain_shared_status SQL calculation A storage domain's shared status was calculated by the fn_get_storage_domain_shared_status_by_domain_id function, which posed several performance issues, as it forced the switching between pgplsql and sql contexts several times, not to mention performing DML and even potentially DDL operations as part of the flow. Additionally, this function was phrased in a convoluted and hard to understand fashion, making it hard to maintain. The old logic, before this patch, was as follows: IF (domain.type != ISO) THEN IF (domain not attached to a pool) THEN RETURN Unattached ELSE IF (domain.status == Active) THEN RETURN Active ELSE RETURN Inactive ENDIF ELSE IF (num of distinct statuses == 0) THEN RETURN Unattached ELSE IF (num of distinct statuses == 1) THEN IF (domain.status == Active) THEN RETURN Active ELSE RETURN Inactive ENDIF ELSE IF (domain is active in at lest one pool) THEN RETURN Mixed ELSE RETURN Inactive END END END This logic can clearly be simplified. First and foremost, the special treatment for an ISO domain should be removed. Instead, a general treatment for a domain with multiple pools should be set in place, where ISO just happens to be the only type that supports this. The refactored logic should handle two variables: the number of distinct statuses a domain has and the number of active statuses it has: IF (num_distinct_statuses) == 0 THEN RETURN Unattached ELSE IF (num_active_statuses > 0) THEN IF (num_distinct_statuses > 1) THEN RETURN Mixed ELSE RETURN Active ELSE RETURN Inactive END This logic can easily be expressed as an SQL query which can be joined on and save the context switches associated with a pgplsql function. Change-Id: I9c1695a41e7a9ca3fb32cbbbfc8fc8e4ae80f6ef Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDaoTest.java M packaging/dbscripts/create_dwh_views.sql M packaging/dbscripts/create_functions.sql M packaging/dbscripts/create_views.sql 4 files changed, 33 insertions(+), 81 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/53687 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c1695a41e7a9ca3fb32cbbbfc8fc8e4ae80f6ef Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Remove StorageDomainSharedStatus#Locked
by amureini＠redhat.com 22 Feb '16

22 Feb '16

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Remove StorageDomainSharedStatus#Locked ...................................................................... engine: Remove StorageDomainSharedStatus#Locked The only place that set's a storage domain's shared status is the StorageDomainDaoImpl#StorageDomainRowMapper inner class, indicating it's a calculated field that's only read from the database. By examining the create_views.sql and create_dwh_views.sql files, it's evident that the field "storage_domain_shared_status" is always returned as the result of invoking the fn_get_storage_domain_shared_status_by_domain_id stored procedure. By examining create_functions.sql its evident that this function may only ever return the values 0 (Unattached), 1 (Active), 2 (Inactive) or 3 (Mixed). In other words, there is no flow that could possible return a shared status of 4 (Locked), and thus any code that refers to it is clearly dead code that has no real usage. This patch remove the StorageDomainSharedStatus#Locked enum constant and any instance in the code base that checks against it, as these conditions will never evaluate to true. Change-Id: I574a000b2c57d15bc3c9c45cd50e7aceeb3d9166 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AttachStorageDomainToPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/RemoveStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AddStoragePoolWithStoragesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainSharedStatus.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/StorageDomainSharedStatusColumn.java 9 files changed, 8 insertions(+), 45 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Eli Mesika: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/53686 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I574a000b2c57d15bc3c9c45cd50e7aceeb3d9166 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: fix typo - management rather than managemenEt
by masayag＠redhat.com 22 Feb '16

22 Feb '16

Moti Asayag has submitted this change and it was merged. Change subject: engine: fix typo - management rather than managemenEt ...................................................................... engine: fix typo - management rather than managemenEt Change-Id: Ib406ac2aa7ac65a255ba4c92d9ac64c66b570156 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkConfigurator.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/53843 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib406ac2aa7ac65a255ba4c92d9ac64c66b570156 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.3]: userportal, webadmin: disable uncaught exception popup.
by piotr.kliczewski＠gmail.com 22 Feb '16

22 Feb '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: userportal, webadmin: disable uncaught exception popup. ...................................................................... userportal, webadmin: disable uncaught exception popup. - Added the ability to disable the uncaught exception popup. Change-Id: Iad7f6888229e09ed9588e449e925ba14cfb4a387 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1309562 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GwtDynamicHostPageServlet.java M frontend/webadmin/modules/frontend/src/main/resources/META-INF/resources/GwtHostPage.jsp M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/UserPortalHostPageServletTest.java M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/WebAdminHostPageServletTest.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/DisplayUncaughtUIExceptions.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 10 files changed, 50 insertions(+), 9 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53837 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad7f6888229e09ed9588e449e925ba14cfb4a387 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.3 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.3]: webadmin: Populate host protocol on 'edit host'
by oourfali＠redhat.com 22 Feb '16

22 Feb '16

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Populate host protocol on 'edit host' ...................................................................... webadmin: Populate host protocol on 'edit host' In cluster level >= 3.6, only jsonrpc protocol is supported. In cluster level 3.5 both xmlrpc and jsonrpc are supported. In cluster level <= 3.4 only xmlrpc is supported. The UI should be able to set 'jsonrpc' as a protocol for the host when the cluster is set to 3.6. To allow the user to select the desired protocol in 3.5 and set protocol to xmlrpc in 3.4. Change-Id: I51c50e7311ef536785cfc06f5e640fec2262f6f3 Bug-Url: https://bugzilla.redhat.com/1289868 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpdateVdsCommand.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 3 files changed, 13 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53828 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51c50e7311ef536785cfc06f5e640fec2262f6f3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.3 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: Fix NPE in async task manager
by piotr.kliczewski＠gmail.com 22 Feb '16

22 Feb '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: Fix NPE in async task manager ...................................................................... engine: Fix NPE in async task manager Since child command id isn't enforced in the database, there shouldn't be any assumption about the appearance of value for it. Change-Id: Id6b6c238232b985c522aedd9eb67e0196ba796ec Bug-Url: https://bugzilla.redhat.com/1308868 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Piotr Kliczewski: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53826 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6b6c238232b985c522aedd9eb67e0196ba796ec Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Populate host protocol on 'edit host'
by piotr.kliczewski＠gmail.com 22 Feb '16

22 Feb '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Populate host protocol on 'edit host' ...................................................................... webadmin: Populate host protocol on 'edit host' In cluster level >= 3.6, only jsonrpc protocol is supported. In cluster level 3.5 both xmlrpc and jsonrpc are supported. In cluster level <= 3.4 only xmlrpc is supported. The UI should be able to set 'jsonrpc' as a protocol for the host when the cluster is set to 3.6. To allow the user to select the desired protocol in 3.5 and set protocol to xmlrpc in 3.4. Change-Id: I51c50e7311ef536785cfc06f5e640fec2262f6f3 Bug-Url: https://bugzilla.redhat.com/1289868 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpdateVdsCommand.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 3 files changed, 13 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53825 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51c50e7311ef536785cfc06f5e640fec2262f6f3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Cluster > Resilience Policy renamed to Migration
by tjelinek＠redhat.com 22 Feb '16

22 Feb '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Cluster > Resilience Policy renamed to Migration ...................................................................... webadmin: Cluster > Resilience Policy renamed to Migration Tab "Resilience Policy" in Cluster dialogs renamed to more general "Migration" to be able to contain other migration related settings. Resilience Policy is now one group on tab Migration. Change-Id: I14a092f3bb94c3574c60a2d7b98cfde24200f778 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1252426 Feature-Page: http://www.ovirt.org/Features/Migration_Enhancements --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/TabName.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml 5 files changed, 55 insertions(+), 30 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14a092f3bb94c3574c60a2d7b98cfde24200f778 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Document support for multiple versions
by juan.hernandez＠redhat.com 22 Feb '16

22 Feb '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Document support for multiple versions ...................................................................... restapi: Document support for multiple versions This patch adds initial documentation of the support for multiple versions of the API. Change-Id: I62051d6b4fbe247b9783883b607bde0a00503bd9 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.adoc 1 file changed, 38 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53829 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62051d6b4fbe247b9783883b607bde0a00503bd9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-reports[master]: reports: fixed issue with additional line in br49
by sradco＠redhat.com 22 Feb '16

22 Feb '16

Shirly Radco has submitted this change and it was merged. Change subject: reports: fixed issue with additional line in br49 ...................................................................... reports: fixed issue with additional line in br49 Fixed issue with additional line appearing in some cases. Change-Id: I11d3a95d7647483ce30cf17dbb6bc5124247e40d Bug-Url: https://bugzilla.redhat.com/1296585 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/Reports/Service_level/Hosts/heatmap_report_cpu_usage_br49.xml M packaging/ovirt-reports/resources/Reports/Service_level/Hosts/heatmap_report_cpu_usage_br49_files/heatmap_report_cpu_usage_br49_jrxml.data M packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/host_ic/.folder.xml A packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/host_ic/P_Hosts_List_Multi.xml 4 files changed, 155 insertions(+), 41 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53768 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11d3a95d7647483ce30cf17dbb6bc5124247e40d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0