- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6.3]: Fix the race between committed memory and pending memory upd...
by tnisan＠redhat.com 16 Feb '16

16 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: Fix the race between committed memory and pending memory updates ...................................................................... Fix the race between committed memory and pending memory updates The pending values are cleared once the VM monitor get the asynchronous message announcing the state change to Powering Up (via RunVmCommnand#OnPowerringUp, SchedulingManager#clearVm and VdsManager#updatePendingData methods). But the committed memory of host is not recomputed here. The committed memory is recomputed in HostMonitoring#refreshCommitedMemory which gets called when the polling returns new host data. But that can take up to 15 seconds. So we have at max a 15 second window between when we clear the pending values and when we update the committed memory information. The solution calls refreshCommitedMemory from the updatePendingData, and provides the list of all VMs from the DB that should already contain the newly received VM. Change-Id: I6aa63edbaddcca30c9898af07316facdbee01b4e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1289468 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 2 files changed, 23 insertions(+), 15 deletions(-) Approvals: Tal Nisan: Passed CI tests Martin Sivák: Verified Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53551 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6aa63edbaddcca30c9898af07316facdbee01b4e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.3 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.3]: scheduling: Use the right memory value for pending memory ch...
by tnisan＠redhat.com 16 Feb '16

16 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: scheduling: Use the right memory value for pending memory checks ...................................................................... scheduling: Use the right memory value for pending memory checks Signed-off-by: Martin Sivak <msivak(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1289468 Change-Id: I41493dfbcfa7d4e1710aa0cb7619c35c24e10e7b --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/pending/PendingResourceManager.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Passed CI tests Martin Sivák: Verified Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53550 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41493dfbcfa7d4e1710aa0cb7619c35c24e10e7b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.3 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.3]: scheduling: Initialize pending resource manager after all be...
by tnisan＠redhat.com 16 Feb '16

16 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: scheduling: Initialize pending resource manager after all beans are injected ...................................................................... scheduling: Initialize pending resource manager after all beans are injected Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1289468 Change-Id: I718545f3eb90c782d259f635481fc76d4d55f871 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Martin Sivák: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I718545f3eb90c782d259f635481fc76d4d55f871 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.3 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: bll: Hosted Engine editing validator
by tnisan＠redhat.com 16 Feb '16

16 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: bll: Hosted Engine editing validator ...................................................................... bll: Hosted Engine editing validator Adding a validator for the update Vm flow. Specifically for Hosted Engine. Currently following the below bug we want to block that by default. Future hosted engine validation can go strictly into that validator or to additional composeable constraints. Change-Id: I7f4fc729a262de3e853d1fb51afaa235572e537e Bug-Url: https://bugzilla.redhat.com/1305484 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/HostedEngineUpdateValidator.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/HostedEngineUpdate.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 12 files changed, 109 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Roy Golan: Verified -- To view, visit https://gerrit.ovirt.org/53547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f4fc729a262de3e853d1fb51afaa235572e537e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: Fix the race between committed memory and pending memory upd...
by tnisan＠redhat.com 16 Feb '16

16 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: Fix the race between committed memory and pending memory updates ...................................................................... Fix the race between committed memory and pending memory updates The pending values are cleared once the VM monitor get the asynchronous message announcing the state change to Powering Up (via RunVmCommnand#OnPowerringUp, SchedulingManager#clearVm and VdsManager#updatePendingData methods). But the committed memory of host is not recomputed here. The committed memory is recomputed in HostMonitoring#refreshCommitedMemory which gets called when the polling returns new host data. But that can take up to 15 seconds. So we have at max a 15 second window between when we clear the pending values and when we update the committed memory information. The solution calls refreshCommitedMemory from the updatePendingData, and provides the list of all VMs from the DB that should already contain the newly received VM. Change-Id: I6aa63edbaddcca30c9898af07316facdbee01b4e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1289468 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 2 files changed, 23 insertions(+), 15 deletions(-) Approvals: Tal Nisan: Passed CI tests Martin Sivák: Verified Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53544 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6aa63edbaddcca30c9898af07316facdbee01b4e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: scheduling: Use the right memory value for pending memory ch...
by tnisan＠redhat.com 16 Feb '16

16 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: scheduling: Use the right memory value for pending memory checks ...................................................................... scheduling: Use the right memory value for pending memory checks Signed-off-by: Martin Sivak <msivak(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1289468 Change-Id: I41493dfbcfa7d4e1710aa0cb7619c35c24e10e7b --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/pending/PendingResourceManager.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Passed CI tests Martin Sivák: Verified Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53543 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41493dfbcfa7d4e1710aa0cb7619c35c24e10e7b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: scheduling: Initialize pending resource manager after all be...
by tnisan＠redhat.com 16 Feb '16

16 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: scheduling: Initialize pending resource manager after all beans are injected ...................................................................... scheduling: Initialize pending resource manager after all beans are injected Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1289468 Change-Id: I718545f3eb90c782d259f635481fc76d4d55f871 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Martin Sivák: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53542 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I718545f3eb90c782d259f635481fc76d4d55f871 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.3]: core: Block adding host with XML-RPC protocol to 3.6 cluster
by tnisan＠redhat.com 16 Feb '16

16 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Block adding host with XML-RPC protocol to 3.6 cluster ...................................................................... core: Block adding host with XML-RPC protocol to 3.6 cluster Cluster levels 3.6 and above support only JSON-RPC protocol. Attempt to add a host which is configured to work with XML-RPC to 3.6 cluster and above, should be blocked. Change-Id: I7a6582113ba323b54361ddf4e49cceb0ee52da00 Bug-Url: https://bugzilla.redhat.com/1289868 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/AddVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/transport/ProtocolDetector.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/HostValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/HostValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsProtocol.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 8 files changed, 29 insertions(+), 23 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53541 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a6582113ba323b54361ddf4e49cceb0ee52da00 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.3 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: Fix the race between committed memory and pending memory upd...
by rgolan＠redhat.com 15 Feb '16

15 Feb '16

Roy Golan has submitted this change and it was merged. Change subject: Fix the race between committed memory and pending memory updates ...................................................................... Fix the race between committed memory and pending memory updates The pending values are cleared once the VM monitor get the asynchronous message announcing the state change to Powering Up (via RunVmCommnand#OnPowerringUp, SchedulingManager#clearVm and VdsManager#updatePendingData methods). But the committed memory of host is not recomputed here. The committed memory is recomputed in HostMonitoring#refreshCommitedMemory which gets called when the polling returns new host data. But that can take up to 15 seconds. So we have at max a 15 second window between when we clear the pending values and when we update the committed memory information. The solution calls refreshCommitedMemory from the updatePendingData, and provides the list of all VMs from the DB that should already contain the newly received VM. Change-Id: I6aa63edbaddcca30c9898af07316facdbee01b4e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1289468 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/HostMonitoring.java 2 files changed, 23 insertions(+), 15 deletions(-) Approvals: Martin Sivák: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53063 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6aa63edbaddcca30c9898af07316facdbee01b4e Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: bll: Hosted Engine editing validator
by rgolan＠redhat.com 15 Feb '16

15 Feb '16

Roy Golan has submitted this change and it was merged. Change subject: bll: Hosted Engine editing validator ...................................................................... bll: Hosted Engine editing validator Adding a validator for the update Vm flow. Specifically for Hosted Engine. Currently following the below bug we want to block that by default. Future hosted engine validation can go strictly into that validator or to additional composeable constraints. Change-Id: I7f4fc729a262de3e853d1fb51afaa235572e537e Bug-Url: https://bugzilla.redhat.com/1305484 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/HostedEngineUpdateValidator.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/HostedEngineUpdate.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 12 files changed, 110 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Roy Golan: Verified -- To view, visit https://gerrit.ovirt.org/53425 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f4fc729a262de3e853d1fb51afaa235572e537e Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0