- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6.3]: core: verify Live Merge image deletion on SPM
by piotr.kliczewski＠gmail.com 12 Feb '16

12 Feb '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: verify Live Merge image deletion on SPM ...................................................................... core: verify Live Merge image deletion on SPM Bug 1227497 described a case where the engine may forget that it has removed an image during Live Merge, causing a difficult-to-recover failure. The fix submitted did not work for block storage where the VM was running on a host other than the SPM, because the GetVolumeInfo verb used is not aware of block storage changes that take place on the SPM. To avoid this, we created a new SPM GetVolumeInfo command. Change-Id: Ie14a78a59312c3846be8dc3b1530aa5535c9fb9b Bug-Url: https://bugzilla.redhat.com/1302215 Related-To: https://bugzilla.redhat.com/1227497 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DestroyImageCheckCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/DestroyImageCheckCommandTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SPMGetVolumeInfoVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SPMGetVolumeInfoVDSCommand.java 5 files changed, 167 insertions(+), 13 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/53433 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie14a78a59312c3846be8dc3b1530aa5535c9fb9b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.3 Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: verify Live Merge image deletion on SPM
by piotr.kliczewski＠gmail.com 12 Feb '16

12 Feb '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: verify Live Merge image deletion on SPM ...................................................................... core: verify Live Merge image deletion on SPM Bug 1227497 described a case where the engine may forget that it has removed an image during Live Merge, causing a difficult-to-recover failure. The fix submitted did not work for block storage where the VM was running on a host other than the SPM, because the GetVolumeInfo verb used is not aware of block storage changes that take place on the SPM. To avoid this, we created a new SPM GetVolumeInfo command. Change-Id: Ie14a78a59312c3846be8dc3b1530aa5535c9fb9b Bug-Url: https://bugzilla.redhat.com/1302215 Related-To: https://bugzilla.redhat.com/1227497 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DestroyImageCheckCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/DestroyImageCheckCommandTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SPMGetVolumeInfoVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SPMGetVolumeInfoVDSCommand.java 5 files changed, 167 insertions(+), 13 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/53432 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie14a78a59312c3846be8dc3b1530aa5535c9fb9b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: German messages overlapp with icons in Nic dialog
by piotr.kliczewski＠gmail.com 12 Feb '16

12 Feb '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: German messages overlapp with icons in Nic dialog ...................................................................... webadmin: German messages overlapp with icons in Nic dialog There is an overlapping between icon and text (German locales) observed in nic dialog in VM --> Network Interfaces Change-Id: I8e725c661f01c4ca18191662a68cf10fb66f60e9 Bug-Url: https://bugzilla.redhat.com/1291146 Signed-off-by: mirecki <mmirecki(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Marcin Mirecki: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53358 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e725c661f01c4ca18191662a68cf10fb66f60e9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: vdsm: drop fc23 on 3.5 branch
by sbonazzo＠redhat.com 12 Feb '16

12 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: vdsm: drop fc23 on 3.5 branch ...................................................................... vdsm: drop fc23 on 3.5 branch Change-Id: I3997ca2d2656cf479fa61a88e75c85f6bd87cb4e Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/vdsm/vdsm_standard.yaml 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53446 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3997ca2d2656cf479fa61a88e75c85f6bd87cb4e Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-host-deploy[master]: packaging: spec: drop EL6 support
by sbonazzo＠redhat.com 12 Feb '16

12 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: drop EL6 support ...................................................................... packaging: spec: drop EL6 support EL6 is not supported anymore for 4.0 Change-Id: Iea69e1914eb4a6747a15cf390de92a7e8352b5c6 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-host-deploy-offline.spec.in M ovirt-host-deploy.spec.in 2 files changed, 9 insertions(+), 80 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/53435 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea69e1914eb4a6747a15cf390de92a7e8352b5c6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Propagate lock state when running async commands via CoCo
by masayag＠redhat.com 11 Feb '16

11 Feb '16

Moti Asayag has submitted this change and it was merged. Change subject: core: Propagate lock state when running async commands via CoCo ...................................................................... core: Propagate lock state when running async commands via CoCo A command may need to propagate acquired locks to executed child commands, such as when AddDiskCommand calls AddImageFromScratchCommand. For Image Upload, I had temporarily changed the above call to use the Command Coordinator and discovered that the lock held by the parent was not being passed to the child. The root cause was the lock was being overwritten in CommandBase when the execution context for the child was initialized. To avoid this, we now pass the lock defined in the Command instance to the context inititialization method. Change-Id: I8cab6aa4d8788703285fb43003995f7f9d7b4efb Related-To: https://bugzilla.redhat.com/1091377 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Greg Padgett: Verified Ravi Nori: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53151 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8cab6aa4d8788703285fb43003995f7f9d7b4efb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: broker: Do not autogenerate numatune node pinnings
by rgolan＠redhat.com 11 Feb '16

11 Feb '16

Roy Golan has submitted this change and it was merged. Change subject: broker: Do not autogenerate numatune node pinnings ...................................................................... broker: Do not autogenerate numatune node pinnings Only pin virtual NUMA nodes to the memory of specific host NUMA nodes when it is explicitly requested. Otherwise VM NUMA nodes are implicitliy pinned to specific host NUMA nodes (with a specific NUMA node architecture). Then the VM can't be migrated when the host architecture of the target host differs, although no specific NUMA configuration was requested by the user. Change-Id: If0d737618a692833d0162ac09303864d651b3ead Bug-Url: https://bugzilla.redhat.com/1303842 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/NumaSettingFactory.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/NumaSettingFactoryTest.java 3 files changed, 21 insertions(+), 17 deletions(-) Approvals: Roman Mohr: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53278 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0d737618a692833d0162ac09303864d651b3ead Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: V3 compatibility for "timezone"
by juan.hernandez＠redhat.com 11 Feb '16

11 Feb '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: V3 compatibility for "timezone" ...................................................................... restapi: V3 compatibility for "timezone" In version 4 of the API the VM "timezone" element has been removed and replaced by the structured "time_zone" element, containing the time zone name and the UTC offset. Now that the API supports multiple versions this support can be rea-added without modifying the V4 implementation. Change-Id: I689ad8cd5e5c2a5ef001cf2bd7df817bfab1245a Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3InstanceTypeInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3InstanceTypeOutAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3TemplateInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3TemplateOutAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3VMInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3VmOutAdapter.java 6 files changed, 63 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53086 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I689ad8cd5e5c2a5ef001cf2bd7df817bfab1245a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: automation: add debug code for CI
by tnisan＠redhat.com 11 Feb '16

11 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: automation: add debug code for CI ...................................................................... automation: add debug code for CI Change-Id: I3f61713661ecd2d2fefbfbb9860d1149852e707a Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M Makefile M build/dbscripts-duplicate_upgrade_scripts.sh M build/python-check.sh.in M build/shell-check.sh 4 files changed, 4 insertions(+), 3 deletions(-) Approvals: Lev Veyde: Verified; Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53430 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f61713661ecd2d2fefbfbb9860d1149852e707a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Use AsciiDoc for documentation files
by sbonazzo＠redhat.com 11 Feb '16

11 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: core: Use AsciiDoc for documentation files ...................................................................... core: Use AsciiDoc for documentation files This patch changes the top level documentation files so that they use AsciiDoc format. Change-Id: I2ef1cc72557cfdb4369436d91d5e6c34bc4b229b Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A BRANDING.adoc A MANUAL.adoc A OID.adoc A README.adoc D README.branding D README.developer D README.manual D README.oid 8 files changed, 715 insertions(+), 670 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53401 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ef1cc72557cfdb4369436d91d5e6c34bc4b229b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0