- Engine-commits - oVirt List Archives

Change in jenkins[master]: ovirt-wgt: new builder job
by sbonazzo＠redhat.com 08 Feb '16

08 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-wgt: new builder job ...................................................................... ovirt-wgt: new builder job we're not going to use standard ci on this job since we need to sync with upstream and we don't want to fork. Change-Id: I177ddb468ff15e92d50a5032718e4919781e5be8 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A jobs/confs/projects/ovirt-wgt/ovirt-wgt_create-rpms.yaml A jobs/confs/yaml/scms/ovirt-wgt.yaml 2 files changed, 41 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Ready for merge Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me -- To view, visit https://gerrit.ovirt.org/53215 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I177ddb468ff15e92d50a5032718e4919781e5be8 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: BaseGetAttachableDisksQuery streaming API
by amureini＠redhat.com 08 Feb '16

08 Feb '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: BaseGetAttachableDisksQuery streaming API ...................................................................... core: BaseGetAttachableDisksQuery streaming API Replaced a cumbersome for loop with a cleaner call to Java 8's streaming API. Change-Id: I6dec931be640d2abfd3345379e019851bae0768f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/BaseGetAttachableDisksQuery.java 1 file changed, 4 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53182 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6dec931be640d2abfd3345379e019851bae0768f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: VmTemplateDaoTest steaming API
by amureini＠redhat.com 08 Feb '16

08 Feb '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: VmTemplateDaoTest steaming API ...................................................................... core: VmTemplateDaoTest steaming API Removed the cumbersome usage of the org.apache.commons.collections.Transformer and replaced it with the cleaner, built-in streaming API. Change-Id: I2e9e634982c72e0e70e318c77ec8d18a73e4f64c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmTemplateDaoTest.java 1 file changed, 2 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53179 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e9e634982c72e0e70e318c77ec8d18a73e4f64c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: VmDaoTest steaming API
by amureini＠redhat.com 08 Feb '16

08 Feb '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: VmDaoTest steaming API ...................................................................... core: VmDaoTest steaming API Removed the cumbersome usage of the org.apache.commons.collections.Transformer and replaced it with the cleaner, built-in streaming API. Change-Id: Icd54aa12c4e363e9010116529eaa9c0babd8669b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDaoTest.java 1 file changed, 2 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53178 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd54aa12c4e363e9010116529eaa9c0babd8669b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CpuAndMemoryBalancingPolicyUnit ReverseComparator
by amureini＠redhat.com 08 Feb '16

08 Feb '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: CpuAndMemoryBalancingPolicyUnit ReverseComparator ...................................................................... core: CpuAndMemoryBalancingPolicyUnit ReverseComparator Remove the redundant dependency on Apache Commons Collections and use Java's standard way of reversing a Comparator's order. Change-Id: Ic65537b53b0a4775ad57a67c09828ab0156a9939 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuAndMemoryBalancingPolicyUnit.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Roman Mohr: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53176 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic65537b53b0a4775ad57a67c09828ab0156a9939 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove IdentifiableUtils
by amureini＠redhat.com 08 Feb '16

08 Feb '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove IdentifiableUtils ...................................................................... core: Remove IdentifiableUtils Removed IdentifiableUtils - in Java 8's world, having utilities to convert formats makes no sense, as you could just as easily stream() and map(). As a side bonus, this also offers a minor performance enhancement, as collections don't need to be recreated in every step of the conversion. Change-Id: I37e726eec932bd320cd1bc75374a310cdbe95574 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/IdentifiableUtils.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java 2 files changed, 9 insertions(+), 21 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53188 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37e726eec932bd320cd1bc75374a310cdbe95574 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: PmHealthCheckManager lambda expression
by amureini＠redhat.com 08 Feb '16

08 Feb '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: PmHealthCheckManager lambda expression ...................................................................... core: PmHealthCheckManager lambda expression Replace a lambda block with an expression lambda to make the code clearer and easier to read. Change-Id: I40bdc464bac762562fad62ff3ee4c5c4aa9de66e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/PmHealthCheckManager.java 1 file changed, 5 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53183 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40bdc464bac762562fad62ff3ee4c5c4aa9de66e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: cleanup in vm-analyzer
by ahadas＠redhat.com 08 Feb '16

08 Feb '16

Arik Hadas has submitted this change and it was merged. Change subject: core: cleanup in vm-analyzer ...................................................................... core: cleanup in vm-analyzer Remove getDbVm and getVdsManager from VmAnalyzer. Change-Id: I2b54c0f16c3b2bca77caaf088482ea1002874ae7 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java 2 files changed, 38 insertions(+), 49 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53168 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b54c0f16c3b2bca77caaf088482ea1002874ae7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: pass dependencies of vm-analyzer using the ctor
by ahadas＠redhat.com 08 Feb '16

08 Feb '16

Arik Hadas has submitted this change and it was merged. Change subject: core: pass dependencies of vm-analyzer using the ctor ...................................................................... core: pass dependencies of vm-analyzer using the ctor Pass the dependencies of VmAnalyzer using its constructor rather than using setters in order to simplify the code. Note that some of dependencies can be injected but it since there might be a lot of VMs running on each host, we prefer to inject them once in the factory and pass their reference instead. Change-Id: Ib347bf5e6da59ce1e3f0fa57130a7e6294c1ff3f Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzerFactory.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzerTest.java 4 files changed, 145 insertions(+), 109 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53167 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib347bf5e6da59ce1e3f0fa57130a7e6294c1ff3f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: inject specific daos to vms monitoring
by ahadas＠redhat.com 08 Feb '16

08 Feb '16

Arik Hadas has submitted this change and it was merged. Change subject: core: inject specific daos to vms monitoring ...................................................................... core: inject specific daos to vms monitoring Inject the specific DAOs that VmsMonitoring is using instead of fetching them using DbFacade. Change-Id: I284fa964247d4bc30bf74d76c03520eff606186e Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java 1 file changed, 31 insertions(+), 12 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53166 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I284fa964247d4bc30bf74d76c03520eff606186e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0