- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.1]: packaging: license: add NOTICE file
by Code Review 22 Jun '17

22 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: packaging: license: add NOTICE file ...................................................................... packaging: license: add NOTICE file Most Apache License 2.0 projects don't have a NOTICE file, but ASF proejects always do. So whenever you are using code from an ASF project you have to make sure you copy over that project's NOTICE file. In ovirt-engine, it looks like the files in utils/src/main/java/org/ovirt/engine/core/utils/ssl were taken from the old Apache HttpClient project. The NOTICE file for one revision of this project is here: https://svn.apache.org/repos/asf/httpcomponents/oac.hc3x/trunk/NOTICE.txt Another use of ASF code I found was: frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/StringUtils.java which seems to be taken from an old version of Apache Commons Lang, which had a NOTICE file approximately like this one: https://git-wip-us.apache.org/repos/asf?p=commons-lang.git;a=blob;f=NOTICE.… Adding the NOTICE to the project. Change-Id: I640c5d46cb3d78cf9f95c789e3956633ac8c5741 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit 1044a0e7a2baafaccdf804e1d75b8b8a5d8acd3b) --- A NOTICE 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78494 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I640c5d46cb3d78cf9f95c789e3956633ac8c5741 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: packaging: licenses: fix webadmin licenses
by Code Review 22 Jun '17

22 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: packaging: licenses: fix webadmin licenses ...................................................................... packaging: licenses: fix webadmin licenses frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/java/util/UUID.java: * Copyright 2003-2007 Sun Microsystems, Inc. All Rights Reserved. frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/java/util/StringTokenizer.java: * Copyright 1994-2004 Sun Microsystems, Inc. All Rights Reserved. LICENSE: 2. Grant of Copyright License. Subject to the terms and conditions of LICENSE: Copyright [yyyy] [name of copyright owner] These two must have been taken from OpenJDK. They are covered by GPLv2 plus the Classpath Exception. Change-Id: I6f424e2ca585e1c5b8f382e88240f8b4c16f544b Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/java/util/LICENSE M ovirt-engine.spec.in 2 files changed, 350 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78492 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f424e2ca585e1c5b8f382e88240f8b4c16f544b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: packaging: licenses: fix checkstyle
by Code Review 22 Jun '17

22 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: packaging: licenses: fix checkstyle ...................................................................... packaging: licenses: fix checkstyle build-tools-root/ovirt-checkstyle-extension/src/main/java/org/ovirt/checkstyle/checks/DiamondOperatorCheck.java:// Copyright (C) 2001-2011 Oliver Burn Copyright (C) 2015 Allon Mureinik (adoption to oVirt) This is covered by LGPLv2.1+. Change-Id: Ie9ef5b8d3c7ed40956b34675272dab25ea28aa45 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A build-tools-root/ovirt-checkstyle-extension/src/main/java/org/ovirt/checkstyle/checks/lgpl-2.1.txt 1 file changed, 502 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78493 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9ef5b8d3c7ed40956b34675272dab25ea28aa45 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: packaging: licenses: fix backend licensing
by Code Review 22 Jun '17

22 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: packaging: licenses: fix backend licensing ...................................................................... packaging: licenses: fix backend licensing backend/manager/modules/services/src/main/webapp/spicehtml5-main.jsp: Copyright (C) 2012 by Jeremy P. White <jwhite(a)codeweavers.com> backend/manager/modules/services/src/main/webapp/novnc-main.jsp: Copyright (C) 2011 Joel Martin These two are covered by LGPLv3, as indicated in their license notices. We need to comply with the license by including a copy of both LGPLv3 (https://www.gnu.org/licenses/lgpl-3.0.txt) and GPLv3 (https://www.gnu.org/licenses/gpl-3.0.txt) Change-Id: I07deb61296afd80a523c79efb0572e01984eefc4 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A backend/manager/modules/services/src/main/webapp/gpl-3.0.txt A backend/manager/modules/services/src/main/webapp/lgpl-3.0.txt M ovirt-engine.spec.in 3 files changed, 842 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78495 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07deb61296afd80a523c79efb0572e01984eefc4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-release[ovirt-4.1]: build: ovirt-release41-4.1.3_rc3
by Code Review 22 Jun '17

22 Jun '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-release41-4.1.3_rc3 ...................................................................... build: ovirt-release41-4.1.3_rc3 Change-Id: Id2f7dcfb46a44a9c4ca1e99771cd4cf6be0ccf41 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-release41.spec.in 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78496 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2f7dcfb46a44a9c4ca1e99771cd4cf6be0ccf41 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: licenses: fix backend licensing
by Code Review 22 Jun '17

22 Jun '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: licenses: fix backend licensing ...................................................................... packaging: licenses: fix backend licensing backend/manager/modules/services/src/main/webapp/spicehtml5-main.jsp: Copyright (C) 2012 by Jeremy P. White <jwhite(a)codeweavers.com> backend/manager/modules/services/src/main/webapp/novnc-main.jsp: Copyright (C) 2011 Joel Martin These two are covered by LGPLv3, as indicated in their license notices. We need to comply with the license by including a copy of both LGPLv3 (https://www.gnu.org/licenses/lgpl-3.0.txt) and GPLv3 (https://www.gnu.org/licenses/gpl-3.0.txt) Change-Id: I07deb61296afd80a523c79efb0572e01984eefc4 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A backend/manager/modules/services/src/main/webapp/gpl-3.0.txt A backend/manager/modules/services/src/main/webapp/lgpl-3.0.txt M ovirt-engine.spec.in 3 files changed, 842 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78368 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07deb61296afd80a523c79efb0572e01984eefc4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.1]: build: ovirt-live 4.1.3 rc3
by Code Review 22 Jun '17

22 Jun '17

>From Lev Veyde <lveyde(a)redhat.com>: Lev Veyde has submitted this change and it was merged. Change subject: build: ovirt-live 4.1.3 rc3 ...................................................................... build: ovirt-live 4.1.3 rc3 Change-Id: Ib923a4ff9c2586e4eb16a164ffcdf68483102ba6 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M centos-7/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Lev Veyde: Verified; Looks good to me, approved; Passed CI tests Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib923a4ff9c2586e4eb16a164ffcdf68483102ba6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.1 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: license: add NOTICE file
by Code Review 22 Jun '17

22 Jun '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: license: add NOTICE file ...................................................................... packaging: license: add NOTICE file Most Apache License 2.0 projects don't have a NOTICE file, but ASF proejects always do. So whenever you are using code from an ASF project you have to make sure you copy over that project's NOTICE file. In ovirt-engine, it looks like the files in utils/src/main/java/org/ovirt/engine/core/utils/ssl were taken from the old Apache HttpClient project. The NOTICE file for one revision of this project is here: https://svn.apache.org/repos/asf/httpcomponents/oac.hc3x/trunk/NOTICE.txt Another use of ASF code I found was: frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/StringUtils.java which seems to be taken from an old version of Apache Commons Lang, which had a NOTICE file approximately like this one: https://git-wip-us.apache.org/repos/asf?p=commons-lang.git;a=blob;f=NOTICE.… Adding the NOTICE to the project. Change-Id: I640c5d46cb3d78cf9f95c789e3956633ac8c5741 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A NOTICE 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I640c5d46cb3d78cf9f95c789e3956633ac8c5741 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: licenses: fix checkstyle
by Code Review 22 Jun '17

22 Jun '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: licenses: fix checkstyle ...................................................................... packaging: licenses: fix checkstyle build-tools-root/ovirt-checkstyle-extension/src/main/java/org/ovirt/checkstyle/checks/DiamondOperatorCheck.java:// Copyright (C) 2001-2011 Oliver Burn Copyright (C) 2015 Allon Mureinik (adoption to oVirt) This is covered by LGPLv2.1+. Change-Id: Ie9ef5b8d3c7ed40956b34675272dab25ea28aa45 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A build-tools-root/ovirt-checkstyle-extension/src/main/java/org/ovirt/checkstyle/checks/lgpl-2.1.txt 1 file changed, 502 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/78369 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9ef5b8d3c7ed40956b34675272dab25ea28aa45 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: licenses: fix webadmin licenses
by Code Review 22 Jun '17

22 Jun '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: licenses: fix webadmin licenses ...................................................................... packaging: licenses: fix webadmin licenses frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/java/util/UUID.java: * Copyright 2003-2007 Sun Microsystems, Inc. All Rights Reserved. frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/java/util/StringTokenizer.java: * Copyright 1994-2004 Sun Microsystems, Inc. All Rights Reserved. LICENSE: 2. Grant of Copyright License. Subject to the terms and conditions of LICENSE: Copyright [yyyy] [name of copyright owner] These two must have been taken from OpenJDK. They are covered by GPLv2 plus the Classpath Exception. Change-Id: I6f424e2ca585e1c5b8f382e88240f8b4c16f544b Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/java/util/LICENSE M ovirt-engine.spec.in 2 files changed, 350 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/78373 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f424e2ca585e1c5b8f382e88240f8b4c16f544b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0