- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: User version 3.1 of the servlet API
by juan.hernandez＠redhat.com 25 Jan '16

25 Jan '16

Juan Hernandez has submitted this change and it was merged. Change subject: core: User version 3.1 of the servlet API ...................................................................... core: User version 3.1 of the servlet API The engine has been recently updated to use WildFly 10, which uses version 3.1 of the servlet API. But we are still building using version 3.0. This doesn't currently create any problem, but it is good practice to build with the same version that will be used during runtime. This patch changes the POM files so that the version used for the build will be the same used during runtime. Change-Id: I15f299a5ecbf462305785ec23aae0527ac76c2d5 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/aaa/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/enginesso/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/uutils/pom.xml M backend/manager/modules/welcome/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M pom.xml 14 files changed, 15 insertions(+), 16 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/52552 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15f299a5ecbf462305785ec23aae0527ac76c2d5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: Do not assign creator as owner to VMs from pool
by tnisan＠redhat.com 25 Jan '16

25 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: Do not assign creator as owner to VMs from pool ...................................................................... engine: Do not assign creator as owner to VMs from pool If VM is created to attach it to a VM pool, do not assign its creator as owner in any case. Assignment of a user to the VM in this case will designate this VM as occupied and prevent other users from taking it. This assignment happens currently when pool creator doesn't have MANIPULATE_PERMISSIONS role on the pool VMs. Change-Id: I6af18a2b7caa8181523a277f4d63cc688e69a59e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1298094 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/52697 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6af18a2b7caa8181523a277f4d63cc688e69a59e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in mom[master]: Convert big numbers to i8 type in the XML-RPC interface
by msivak＠redhat.com 25 Jan '16

25 Jan '16

Martin Sivák has submitted this change and it was merged. Change subject: Convert big numbers to i8 type in the XML-RPC interface ...................................................................... Convert big numbers to i8 type in the XML-RPC interface Make sure all numbers are transferable over XML-RPC with its signed 32 bit limitation. All numbers greater than that need to be converted to long and the XML-RPC server configured to serialize long type using the i8 extension. Python supports reading i8 in the default configuration (https://bugs.python.org/issue2985) and so the clients do not have to do anything special. Change-Id: Ief62c3dd120c9efca7e270b768e394f467ac3417 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1294833 Signed-off-by: Martin Sivak <msivak(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/51396 Reviewed-by: Dan Kenigsberg <danken(a)redhat.com> Continuous-Integration: Jenkins CI --- M mom.spec.in M mom/MOMFuncs.py M mom/RPCServer.py M mom/__init__.py M momd M tests/GeneralTests.py 6 files changed, 63 insertions(+), 2 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/51396 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief62c3dd120c9efca7e270b768e394f467ac3417 Gerrit-PatchSet: 8 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: frontend: Fix name uniqueness chack in ImportVmModel
by tjelinek＠redhat.com 25 Jan '16

25 Jan '16

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Fix name uniqueness chack in ImportVmModel ...................................................................... frontend: Fix name uniqueness chack in ImportVmModel Now when checking the name uniqueness of imported VM, we check for conflict only VMs in target data center. To facilitate this the data center loading part from ImportVmFromExportDomainModel#doInit() and ImportVmFromExternalProviderModel#doInit() had to be extracted into special helpers withDataCenterLoaded() that are used to wrap the setItems() method doing the name uniqueness analysis - since it requires access to storagePool.id. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=912263 Change-Id: I86c8b17bee0d676bc09c758e98439e5d672eb885 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/ImportTemplateModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExternalProviderModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java 4 files changed, 102 insertions(+), 79 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Verified Arik Hadas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/52574 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86c8b17bee0d676bc09c758e98439e5d672eb885 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fetch guest agent nic statistics from vm analyzers
by ahadas＠redhat.com 25 Jan '16

25 Jan '16

Arik Hadas has submitted this change and it was merged. Change subject: core: fetch guest agent nic statistics from vm analyzers ...................................................................... core: fetch guest agent nic statistics from vm analyzers Use Stream API to fetch the dynamic information for guest agent NICs instead of holding them in VmsMonitoring. Change-Id: I8355501738ee83fdd3e1cf7ba8a00d4650a180e1 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java 2 files changed, 10 insertions(+), 5 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/52683 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8355501738ee83fdd3e1cf7ba8a00d4650a180e1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: Add Attach Disk/Cpu profile permissions to all Import/Export...
by tnisan＠redhat.com 25 Jan '16

25 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: Add Attach Disk/Cpu profile permissions to all Import/Export capable roles ...................................................................... Add Attach Disk/Cpu profile permissions to all Import/Export capable roles Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1255405 Change-Id: Id2cc0e56bd1ea4a5f9aeac0684a2acc3998a5e9d Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- A packaging/dbscripts/upgrade/04_00_0230_add_profile_perms_to_import_export.sql 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Martin Sivák: Verified -- To view, visit https://gerrit.ovirt.org/51880 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2cc0e56bd1ea4a5f9aeac0684a2acc3998a5e9d Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: adding missing ctors
by laravot＠redhat.com 25 Jan '16

25 Jan '16

Liron Aravot has submitted this change and it was merged. Change subject: core: adding missing ctors ...................................................................... core: adding missing ctors When the AsyncTaskManager creats a command it creates it without the context. When migrating the different flows to use coco rather than rely on the async task manager, the modified commands that were used as child commands until now will be created by the async task manager. This patch adds the missing parameters ctor to those commands. Change-Id: Iaae93b7e6b041749c4911806bfdb78fa4afe166c Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateSnapshotFromTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveTemplateSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RestoreFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/TryBackToSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/AddImageFromScratchCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CreateImageTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ExtendImageSizeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/MoveImageGroupCommand.java 9 files changed, 36 insertions(+), 0 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52573 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaae93b7e6b041749c4911806bfdb78fa4afe166c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Fix of label Do Not Migrate Virtual Machines
by tjelinek＠redhat.com 25 Jan '16

25 Jan '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Fix of label Do Not Migrate Virtual Machines ...................................................................... webadmin: Fix of label Do Not Migrate Virtual Machines Label 'Edit Cluster' > 'Resilience Policy' > 'Do Not Migrate Virtual Machins', previously 'None - Disable memory overcommit'. Change-Id: If72d6a06f74153b10b51bfb5113e0b7655f7b1a3 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/52639 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If72d6a06f74153b10b51bfb5113e0b7655f7b1a3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: VmDevice null safe hashCode() method
by tnisan＠redhat.com 25 Jan '16

25 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: VmDevice null safe hashCode() method ...................................................................... core: VmDevice null safe hashCode() method Change-Id: I5cc635a81f90745aac19780f893f1f1661ecddfc Bug-Url: https://bugzilla.redhat.com/1293269 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java 1 file changed, 17 insertions(+), 17 deletions(-) Approvals: Tal Nisan: Passed CI tests Jakub Niedermertl: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/52386 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5cc635a81f90745aac19780f893f1f1661ecddfc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fetch vm lun disk statistics from vm analyzers
by ahadas＠redhat.com 25 Jan '16

25 Jan '16

Arik Hadas has submitted this change and it was merged. Change subject: core: fetch vm lun disk statistics from vm analyzers ...................................................................... core: fetch vm lun disk statistics from vm analyzers Use Stream API to fetch the dynamic information for lun disks instead of holding them in VmsMonitoring. Change-Id: I0961ca6c7c2559e2b59efef1be81ea82c0edee06 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java 2 files changed, 16 insertions(+), 13 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/52664 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0961ca6c7c2559e2b59efef1be81ea82c0edee06 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0