- Engine-commits - oVirt List Archives

Change in jenkins[master]: Added fix_rpmdb_problems as a build step in upgrade jobs
by dcaro＠redhat.com 21 Jan '16

21 Jan '16

David Caro has submitted this change and it was merged. Change subject: Added fix_rpmdb_problems as a build step in upgrade jobs ...................................................................... Added fix_rpmdb_problems as a build step in upgrade jobs Change-Id: Ic802b9397d9f8af366230ab12b38aa342ec77010 Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com> --- M jobs/confs/yaml/templates/engine-upgrade.yaml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Barak Korren: Looks good to me Jenkins CI: Passed CI tests David Caro: Verified; Ready for merge -- To view, visit https://gerrit.ovirt.org/52460 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic802b9397d9f8af366230ab12b38aa342ec77010 Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Added fix_rpmdb_problems.sh as a builder in yaml
by dcaro＠redhat.com 21 Jan '16

21 Jan '16

David Caro has submitted this change and it was merged. Change subject: Added fix_rpmdb_problems.sh as a builder in yaml ...................................................................... Added fix_rpmdb_problems.sh as a builder in yaml The code was taken from ds jenkins yaml conf. Change-Id: Ifa1601ed330a7e9c596154538db392808e3de25c Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com> Signed-off-by: David Caro <dcaroest(a)redhat.com> --- A jobs/confs/shell-scripts/fix_rpmdb_problems.sh M jobs/confs/yaml/builders/cleanup.yaml 2 files changed, 62 insertions(+), 0 deletions(-) Approvals: Barak Korren: Looks good to me Jenkins CI: Passed CI tests David Caro: Verified; Ready for merge -- To view, visit https://gerrit.ovirt.org/52456 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa1601ed330a7e9c596154538db392808e3de25c Gerrit-PatchSet: 4 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Use JAX-RS 2.0 API artifacts
by juan.hernandez＠redhat.com 21 Jan '16

21 Jan '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use JAX-RS 2.0 API artifacts ...................................................................... restapi: Use JAX-RS 2.0 API artifacts The engine has been recently updated to work with WildFly 10. This version of WildFly implements JAX-RS 2.0, but we are still using 1.x artifacts for the build. This doesn't generate a real problem, but it may in the future. This patch changes the POM files so that they use versions of the artifact matching those provided by the application server. In addition, we are currently explicitly using the JAX-RS API artifacts provided by Resteasy, which introduces a bit of locking. To avoid that this patch changes the POM files so that they use more implementation independent artifacts where possible. The Resteasy artifacts still be needed by the tests, as they need an actual implementation of the JAX-RS API. Change-Id: I97ae0d6c9762d7e2130f4a1780a85bf8c1de38ec Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java M backend/manager/modules/restapi/pom.xml 5 files changed, 69 insertions(+), 17 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/52549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97ae0d6c9762d7e2130f4a1780a85bf8c1de38ec Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ClusterDaoTest members
by amureini＠redhat.com 21 Jan '16

21 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: ClusterDaoTest members ...................................................................... core: ClusterDaoTest members Converted members to local variables where possible in order to improve readability and reduce memory footprint. Change-Id: I27312b45a2cf9a3d9bd6c7b84fa78631236efe53 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ClusterDaoTest.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52248 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27312b45a2cf9a3d9bd6c7b84fa78631236efe53 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddVmCommand validation early return
by amureini＠redhat.com 21 Jan '16

21 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddVmCommand validation early return ...................................................................... core: AddVmCommand validation early return Used the early return idiom to improve the validation methods' readability. Change-Id: I0ba706ba0cd60885197006722590b636b0e9fe43 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 29 insertions(+), 39 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52244 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ba706ba0cd60885197006722590b636b0e9fe43 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: ExistingVmModelBehavior local variables
by amureini＠redhat.com 21 Jan '16

21 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: ExistingVmModelBehavior local variables ...................................................................... webadmin: ExistingVmModelBehavior local variables Removed redundant local variables. Change-Id: I2f9c43b3af1bea8abd790e58825a52893b326934 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java 1 file changed, 5 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f9c43b3af1bea8abd790e58825a52893b326934 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: EventsManager empty strings
by amureini＠redhat.com 21 Jan '16

21 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: EventsManager empty strings ...................................................................... core: EventsManager empty strings Remove useless empty strings being concatinated to SQL statements. Change-Id: Ifd413c8df48df51f761c5b00c6dc26a639d0c216 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/dao/EventsManager.java 1 file changed, 6 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52254 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd413c8df48df51f761c5b00c6dc26a639d0c216 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: EndExternalJobCommand serialVersionUID
by amureini＠redhat.com 21 Jan '16

21 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: EndExternalJobCommand serialVersionUID ...................................................................... core: EndExternalJobCommand serialVersionUID Since EndExternalJobCommand does not implement Serializable (directly or indirectly), it should not have a serialVersionUID member. Change-Id: I7cdaba1bd96142ad8cf8fe7e413c47c300e8b7d8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EndExternalJobCommand.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52253 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7cdaba1bd96142ad8cf8fe7e413c47c300e8b7d8 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: DataCenterGuideModel local variables
by amureini＠redhat.com 21 Jan '16

21 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: DataCenterGuideModel local variables ...................................................................... webadmin: DataCenterGuideModel local variables Removed redundant local variables. Change-Id: Id4b68b43fb1574dea320ed416bfd41333ee68344 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java 1 file changed, 15 insertions(+), 29 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52252 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4b68b43fb1574dea320ed416bfd41333ee68344 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: ClusterGuideModel local variables
by amureini＠redhat.com 21 Jan '16

21 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: ClusterGuideModel local variables ...................................................................... webadmin: ClusterGuideModel local variables Removed redundant local variables. Change-Id: Ie2141f05260af747b9cb71d79dd6b2e7bdd8af1a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java 1 file changed, 3 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52249 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2141f05260af747b9cb71d79dd6b2e7bdd8af1a Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0