- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: GetGlusterServersForImportQueryTest members
by amureini＠redhat.com 18 Jan '16

18 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetGlusterServersForImportQueryTest members ...................................................................... core: GetGlusterServersForImportQueryTest members Converted members to local variables where possible in order to improve readability and reduce memory footprint. Change-Id: I61137aadec95495367bec2b6b4d5b50809935b77 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterServersForImportQueryTest.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52266 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61137aadec95495367bec2b6b4d5b50809935b77 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GetGlusterVolumeAdvancedDetailsQueryTest members
by amureini＠redhat.com 18 Jan '16

18 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetGlusterVolumeAdvancedDetailsQueryTest members ...................................................................... core: GetGlusterVolumeAdvancedDetailsQueryTest members Converted members to local variables where possible in order to improve readability and reduce memory footprint. Change-Id: I3313f43221f88f80d9acc336add382decced31bf Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQueryTest.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52267 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3313f43221f88f80d9acc336add382decced31bf Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GlusterSnapshotSyncJobTest generics
by amureini＠redhat.com 18 Jan '16

18 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: GlusterSnapshotSyncJobTest generics ...................................................................... core: GlusterSnapshotSyncJobTest generics Used the type-safe anyListOf(Class) instead of the unsage any(List.class). Change-Id: I7f8fd2e4ca45e4cf5d571a410fb159b674a4a73e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterSnapshotSyncJobTest.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52285 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f8fd2e4ca45e4cf5d571a410fb159b674a4a73e Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GetDiskAlignmentCommand streaming API
by amureini＠redhat.com 18 Jan '16

18 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetDiskAlignmentCommand streaming API ...................................................................... core: GetDiskAlignmentCommand streaming API Used Java 8 streaming API when creating new collections instead of cumbersome for-loops. Change-Id: I6a2bde2bdc1e7f074960c8a22ae8995fac9faffb Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/GetDiskAlignmentCommand.java 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52265 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a2bde2bdc1e7f074960c8a22ae8995fac9faffb Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: HealthStatus try with resource
by amureini＠redhat.com 18 Jan '16

18 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: HealthStatus try with resource ...................................................................... core: HealthStatus try with resource Used the try with resource syntax introduced in Java 7 to improve the code's readability. Change-Id: I1b9cf5709c55f535997c64122d11c861ef446d00 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/HealthStatus.java 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52287 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b9cf5709c55f535997c64122d11c861ef446d00 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GetUnregisteredDisksQueryTest remove Arrays.asList
by amureini＠redhat.com 18 Jan '16

18 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetUnregisteredDisksQueryTest remove Arrays.asList ...................................................................... core: GetUnregisteredDisksQueryTest remove Arrays.asList Replace single argument Arrays.asList calls with the better performing Collections.singletonList. Change-Id: I58ba8d36ad5341ba6fe2988c832fa2390f4d60f7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/GetUnregisteredDisksQueryTest.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52277 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58ba8d36ad5341ba6fe2988c832fa2390f4d60f7 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GlusterVolumeSnapshotInfoReturnForXmlRpc unboxing
by amureini＠redhat.com 18 Jan '16

18 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: GlusterVolumeSnapshotInfoReturnForXmlRpc unboxing ...................................................................... core: GlusterVolumeSnapshotInfoReturnForXmlRpc unboxing Removed redundant explicit unboxing to improve the code's readability. Change-Id: I2ee3351278e6ae5c1abda1e375586ebf4c23daa5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeSnapshotInfoReturnForXmlRpc.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52286 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ee3351278e6ae5c1abda1e375586ebf4c23daa5 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GetSessionUser modifiers
by amureini＠redhat.com 18 Jan '16

18 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetSessionUser modifiers ...................................................................... core: GetSessionUser modifiers Made constants private static final, as per Java's best practices. Change-Id: If3f6bf047cea73433cff2c62530adcf6c05e1617 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/GetSessionUser.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52275 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3f6bf047cea73433cff2c62530adcf6c05e1617 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GetSessionUser#runQuery cleanup
by amureini＠redhat.com 18 Jan '16

18 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetSessionUser#runQuery cleanup ...................................................................... core: GetSessionUser#runQuery cleanup Remove redundant parameter, local variable and initializations. Change-Id: I48b3722ebb85ff6c41aa9f1d2947cf8c0c5e2379 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/GetSessionUser.java 1 file changed, 4 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52274 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48b3722ebb85ff6c41aa9f1d2947cf8c0c5e2379 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove GetoVirtISOsTest#checkReturnValue
by amureini＠redhat.com 18 Jan '16

18 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove GetoVirtISOsTest#checkReturnValue ...................................................................... core: Remove GetoVirtISOsTest#checkReturnValue Removed unused method. Change-Id: I17a9912191fbc69b89f97830b1cb01c8530645ef Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostdeploy/GetoVirtISOsTest.java 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52272 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17a9912191fbc69b89f97830b1cb01c8530645ef Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0