- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: SyntaxCheckerTest prints
by amureini＠redhat.com 13 Jan '16

13 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: SyntaxCheckerTest prints ...................................................................... core: SyntaxCheckerTest prints Removed prints to stdout which have no place in an automatic test. Change-Id: Ibaaea565e89bb93999b976f6ec7e6478d6fd9828 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/51260 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibaaea565e89bb93999b976f6ec7e6478d6fd9828 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Standardize SyntexCheckerTest static imports
by amureini＠redhat.com 13 Jan '16

13 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Standardize SyntexCheckerTest static imports ...................................................................... core: Standardize SyntexCheckerTest static imports Statically import org.junit.Assert, org.mockito.Mockito and org.mockito.Matchers methods as per the project's conventions. Change-Id: I41868dc4ed5cb164782700d182b257e77404df07 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java 1 file changed, 14 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/51259 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41868dc4ed5cb164782700d182b257e77404df07 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix SyntaxCheckerTest asserts
by amureini＠redhat.com 13 Jan '16

13 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix SyntaxCheckerTest asserts ...................................................................... core: Fix SyntaxCheckerTest asserts Fixed asserts to use equality instead of identity (==, !=). While the JVM usually produces the same literal from the pool this is not a behavior that should be relied on. Instead, logical equality should be checked. Change-Id: I36e9106ae39b4fc0ef0ba315c0a65de04a0267b4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/51258 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36e9106ae39b4fc0ef0ba315c0a65de04a0267b4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: One statement per line checkstyle
by amureini＠redhat.com 13 Jan '16

13 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: engine: One statement per line checkstyle ...................................................................... engine: One statement per line checkstyle As the project's style already (mostly) follows Java's style recommendation of having a single statement per line, this patch fixes the several places that do not follow this guideline and applies a checkstyle check to make sure no violations are introduced in the future. Change-Id: Id70f9e6d37f67d04d7a944aef4fb3925a9b72f4a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterServiceSyncJobTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypeWatchdogsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateWatchdogsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmWatchdogsResourceTest.java M build-tools-root/checkstyles/src/main/resources/checkstyle.xml 5 files changed, 16 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Verified Sahina Bose: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/51257 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id70f9e6d37f67d04d7a944aef4fb3925a9b72f4a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Run unit tests for patches
by juan.hernandez＠redhat.com 13 Jan '16

13 Jan '16

Juan Hernandez has submitted this change and it was merged. Change subject: Run unit tests for patches ...................................................................... Run unit tests for patches This patch changes the "check-patch.sh" so that the code generator is built, and executed and then the unit tests are executed. Change-Id: I70afcc8ef94fe8356153d06ad66cce1e7738a0b8 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- D automation/check-patch.packaages A automation/check-patch.packages M automation/check-patch.sh 3 files changed, 40 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51803 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70afcc8ef94fe8356153d06ad66cce1e7738a0b8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add support for "Get" and "List" parameters
by juan.hernandez＠redhat.com 13 Jan '16

13 Jan '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add support for "Get" and "List" parameters ...................................................................... Add support for "Get" and "List" parameters Some of the "Get" and "List" operations of the API support parameters. For example, the operation to list virtual machines supports the "search" parameter. This patch adds support for this kind of parameters, so that this, for example, will work: # Create the connection: connection = Ovirt::SDK::V4Connection.new({ :url => 'https://engine.example.com/ovirt-engine/api', :username => 'admin@internal', :password => '...', :ca_file => 'ca.pem', }) # Get the VMs service: vms_service = connection.system.vms # Search for VMs with a given name and print their id: vms = vms_service.list({:search => 'name=myvm'}) vms.each do |vm| puts vm.id end # Close the connection: connection.close The patch also improves the tests so that this support is better tested. Change-Id: I0f1fe53af1f81a29c72c4a5ab99f88d4ceda3e1b Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M README.md M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java M pom.xml M sdk/examples/list_vms.rb A sdk/examples/search_vms.rb M sdk/lib/ovirt/sdk/v4.rb M sdk/lib/ovirt/sdk/v4/connection.rb A sdk/lib/ovirt/sdk/v4/xml_formatter.rb A sdk/spec/connection_spec.rb A sdk/spec/parameters.yaml M sdk/spec/spec_helper.rb A sdk/spec/vms_service_spec.rb A sdk/spec/xml_formatter_spec.rb 13 files changed, 695 insertions(+), 10 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/51791 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f1fe53af1f81a29c72c4a5ab99f88d4ceda3e1b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add support for the "Remove" operation
by juan.hernandez＠redhat.com 13 Jan '16

13 Jan '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add support for the "Remove" operation ...................................................................... Add support for the "Remove" operation This patch adds support for the "Remove" operation. Change-Id: Ieb1ca304fb0a194af714ec9d437823ca1032768b Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java A sdk/examples/remove_vm.rb M sdk/lib/ovirt/sdk/v4/connection.rb 3 files changed, 70 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/51790 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb1ca304fb0a194af714ec9d437823ca1032768b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: frontend: fix FcpStorageView faults
by derez＠redhat.com 13 Jan '16

13 Jan '16

Daniel Erez has submitted this change and it was merged. Change subject: frontend: fix FcpStorageView faults ...................................................................... frontend: fix FcpStorageView faults FcpStorageView has four faults that are fixed in this patch: 1. It extends from AbstractSanStorageView, which is useless since it's the only subclass of AbstractSanStorageView. 2. The corresponding ui.xml file is AbstractSanStorageView.ui.xml (and not FcpStorageView.ui.xml), which causes the editor to ignore the label "errorMessage" in FcpStorageView and to malfunction. 3. The @Path annotation of the label "errorMessage" is "GetLUNsFailure", while the corresponding string field in the model, SanStorageModel, is "getLUNsFailure". 4. AbstractSanStorageView extends from AbstractStorageView<SanStorageModelBase>, while the model of FcpStorageView is SanStorageModel. This patch: - Merges AbstractSanStorageView into FcpStorageView. - Renames the AbstractSanStorageView.ui.xml to FcpStorageView.ui.xml. - Renames the Path annotation of the label "errorMessage" to "getLUNsFailure". - Replaces the generics type of AbstractStorageView to SanStorageModel. As a consequence, the label "errorMessage" is finally shown when it's supposed to be shown in the FcpStorageView. Change-Id: Idff765f50ce3d461c18f0db428687e7a27e8b64c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1297689 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/FcpStorageView.java R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/FcpStorageView.ui.xml 3 files changed, 84 insertions(+), 103 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/51720 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idff765f50ce3d461c18f0db428687e7a27e8b64c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-node-plugin-vdsm[ovirt-3.6]: Disable engine registration if hosted engine is configured
by dougsland＠redhat.com 13 Jan '16

13 Jan '16

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: Disable engine registration if hosted engine is configured ...................................................................... Disable engine registration if hosted engine is configured We can trivially check for HE configuration by importing the config paths from the HE plugin and checking those. Do so, and don't let users register if HE is configured, since it's probably registered to HE Change-Id: Ia5c86134968a1fa2d6661ac163908112fe1018a4 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1258397 Signed-off-by: Ryan Barry <rbarry(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/49052 Continuous-Integration: Jenkins CI Reviewed-by: Fabian Deutsch <fabiand(a)redhat.com> (cherry picked from commit b18463d1992ac0c130c1b4d448e2eb9f8b7627c2) Reviewed-on: https://gerrit.ovirt.org/51800 Reviewed-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> Continuous-Integration: Douglas Schilling Landgraf <dougsland(a)redhat.com> Tested-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/engine_page.py 1 file changed, 27 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/51800 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5c86134968a1fa2d6661ac163908112fe1018a4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: increase default nodes in cell tree
by awels＠redhat.com 13 Jan '16

13 Jan '16

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: increase default nodes in cell tree ...................................................................... webadmin: increase default nodes in cell tree - The default number of nodes shown in a cell tree was 25. It would automatically include a 'show more' link to show another 25, until all nodes are shown. Since we include a 'show all' button at the top this makes no sense in our application. This patch increases the number of visible nodes to all. And as a side effect solves the translation problem of the 'show more' link. Change-Id: I508fd174c5abf569397c0a52b60d1fe23f0646f4 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1269433 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tree/ElementIdCellTree.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51794 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I508fd174c5abf569397c0a52b60d1fe23f0646f4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0