- Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: add-host: temporary disabling host-deploy packager
by sbonazzo＠redhat.com 22 Dec '15

22 Dec '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: add-host: temporary disabling host-deploy packager ...................................................................... add-host: temporary disabling host-deploy packager Temporary disabling host-deploy packager when we had the host to ensure we avoid any updates to the relevant packages when the engine VM is running. Because, after this, host-deploy will not install required packages at all it will became up to this package to require all the relevant dependencies. Change-Id: Iabda5f2114c23d65b5b89fc9160189fcaac3fc6d Bug-Url: https://bugzilla.redhat.com/1236588 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py 2 files changed, 73 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/50819 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iabda5f2114c23d65b5b89fc9160189fcaac3fc6d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine : Add search for child commands by action type and st...
by masayag＠redhat.com 22 Dec '15

22 Dec '15

Moti Asayag has submitted this change and it was merged. Change subject: engine : Add search for child commands by action type and status ...................................................................... engine : Add search for child commands by action type and status Add method to coco CommandCoordinatorUtil getChildCommandIds(commandId, childActionType, status) to get the list of child command ids filtering them by their action type and status. Change-Id: I9b7177ff05cdcaa85c73ac889fef88aeb46eaf57 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorUtil.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCRUDOperations.java 3 files changed, 27 insertions(+), 0 deletions(-) Approvals: Ravi Nori: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48204 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b7177ff05cdcaa85c73ac889fef88aeb46eaf57 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: fix vnic type init in (New|Edit)VnicModel
by tnisan＠redhat.com 22 Dec '15

22 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: fix vnic type init in (New|Edit)VnicModel ...................................................................... webadmin: fix vnic type init in (New|Edit)VnicModel Fix vNIC type field initialization in (New|Edit)Vnic screens. The patch fixes the UI behaviour where a user can see the defaulti vnic type and then that is changed to the actual value. Change-Id: I01437e487274e18d53a326f48fb0f3ee14823261 Bug-Url: https://bugzilla.redhat.com/1290315 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseEditVmInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmInterfaceModel.java 2 files changed, 28 insertions(+), 10 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/50468 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01437e487274e18d53a326f48fb0f3ee14823261 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: Fix memory based filtering
by tnisan＠redhat.com 22 Dec '15

22 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: Fix memory based filtering ...................................................................... Fix memory based filtering There are two memory based rules that have to be obeyed for a successful VM start. 1) QEMU can allocate the full VM memory when starting the VM process. sysctl option vm.overcommit_memory then controls whether the malloc call succeeds even though there is not enough free memory at the time. The allocation is not visible in free memory reporting, because the kernel memory pages are then assigned on demand. This does not happen always, but we can't really tell in advance and so we need to make sure the necessary memory is available for the malloc call to succeed (even though the memory won't be actually used). The pending mechanism is used, but only counts the guest overhead memory consumption for this case as it is unlikely the VM will eat more memory faster than VDSM reports it to the engine. 2) oVirt over-commitment rules limit the total amount of VM memory that can be assigned on a host. This amount does not correspond to the actual used physical memory, it represents the theoretical maximum of memory all VMs on a host can consume. The full memory is used in the pending counter for this case. We already had number two (sans a tiny change to the formula). Rule number one is a new one and it will not cause more memory or swap usage, because it only makes the rules more strict together. This patch also fixes a small bug in deserialization of memFree when retrieved as part of the full VDS entity. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1180071 Change-Id: I335324841b8df6561d6aa2203a394164d44ee9a9 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/HaReservationHandling.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SlaValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/VdsFreeMemoryChecker.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/pending/PendingMemory.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/pending/PendingOvercommitMemory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/MemoryPolicyUnit.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/SlaValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatistics.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 17 files changed, 324 insertions(+), 78 deletions(-) Approvals: Martin Sivák: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/50105 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I335324841b8df6561d6aa2203a394164d44ee9a9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: check hotplugged nics for duplicated pci address als...
by tnisan＠redhat.com 22 Dec '15

22 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: check hotplugged nics for duplicated pci address also when vm is not running ...................................................................... engine: check hotplugged nics for duplicated pci address also when vm is not running Hotplugged nics should be checked for duplicated pci addresses also when the vm is not running. Duplicated address could happen in the following scenario: 1. Run vm 2. Add a nic, an address will be assigned on the vm 3. Unplug nic, the address will be remembered in engine. 4. Plug another nic, the same address could be assigned. 5. Power off vm. 6. Plug first nic again 7. During vm power on, both nics will have the same address Change-Id: Ia4526cf628a726e579045e283df8bfc366e741ef Bug-Url: https://bugzilla.redhat.com/1199782 Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Marcin Mirecki: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/50812 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4526cf628a726e579045e283df8bfc366e741ef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: backend: Fix sound device handling on ppc desktops
by tnisan＠redhat.com 22 Dec '15

22 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: backend: Fix sound device handling on ppc desktops ...................................................................... backend: Fix sound device handling on ppc desktops When adding a VM to pool via rest API we automatically fall back to enabling sound device only based on the VM's desktop type. Extracted check already present in AddVmCommand into VmDeviceUtils and used it to replace all ocurrences of setSoundDeviceEnabled(vmType == DESKTOP). Change-Id: I6459f5cfb51b4dbdd53af6e7138e690ec4bb9c80 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1291626 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmTemplateCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java 7 files changed, 54 insertions(+), 28 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Verified Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/50676 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6459f5cfb51b4dbdd53af6e7138e690ec4bb9c80 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Fix ScrollableTabBarView.removeTabWidget
by tnisan＠redhat.com 22 Dec '15

22 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix ScrollableTabBarView.removeTabWidget ...................................................................... webadmin: Fix ScrollableTabBarView.removeTabWidget This fixes the problem when RedrawDynamicTabContainerEvent forces redraw of all tabs and the tab-drop-down list would still contain 'old' items. Change-Id: I2843788ebaf424b386c3a24d8ebe035fa6025580 Bug-Url: https://bugzilla.redhat.com/1258462 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> (cherry picked from commit 7c6ba89222ce86a4cacecf9021685280bc69e6fa) --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/ScrollableTabBarView.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/50650 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2843788ebaf424b386c3a24d8ebe035fa6025580 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: enable host plug/unplug of VFs
by alkaplan＠redhat.com 21 Dec '15

21 Dec '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: enable host plug/unplug of VFs ...................................................................... engine: enable host plug/unplug of VFs Change-Id: I9bdf0d4cf9713691246015cf0297364a0dc40e95 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/NetworkDeviceHelperImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/VfScheduler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/VfSchedulerImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/NetworkDeviceHelperImplTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/VfSchedulerImplTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/SchedulingManagerTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugNicVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 15 files changed, 218 insertions(+), 48 deletions(-) Approvals: Alona Kaplan: Verified; Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/50459 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9bdf0d4cf9713691246015cf0297364a0dc40e95 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: rename: Move new fqdn prompt to customization
by sbonazzo＠redhat.com 21 Dec '15

21 Dec '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: rename: Move new fqdn prompt to customization ...................................................................... packaging: rename: Move new fqdn prompt to customization Was in stage validation. Bug-Url: https://bugzilla.redhat.com/1250556 Change-Id: I311fde09a2002c38abc9427e02de12be57948baa Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/misc.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/50395 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I311fde09a2002c38abc9427e02de12be57948baa Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin: fixing cluster and tuned profile selection
by sabose＠redhat.com 21 Dec '15

21 Dec '15

Sahina Bose has submitted this change and it was merged. Change subject: webadmin: fixing cluster and tuned profile selection ...................................................................... webadmin: fixing cluster and tuned profile selection While editing a cluster(with multiple possible compat versions) the version and tuned profile are not selected correctly Change-Id: I179ef2f162e1c218d3d108e101f0279fc6f440f8 Bug-Url: https://bugzilla.redhat.com/1290748 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java 1 file changed, 15 insertions(+), 13 deletions(-) Approvals: Sahina Bose: Verified; Looks good to me, approved; Passed CI tests Ramesh N: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/50717 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I179ef2f162e1c218d3d108e101f0279fc6f440f8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0