- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: hosted-engine: detect connection details only for ISCSI
by rgolan＠redhat.com 15 Dec '15

15 Dec '15

Roy Golan has submitted this change and it was merged. Change subject: core: hosted-engine: detect connection details only for ISCSI ...................................................................... core: hosted-engine: detect connection details only for ISCSI When importing the hosted engine storage domain there is no need to detect the connection details for FCP, otherwise it fails with NPE. The command to add FCP domain already detects the VG details from vdsm, we just need the VG id. Change-Id: Ibfb9c831cb45175b1043d254d6ecbaff4de5ff13 Bug-Url: https://bugzilla.redhat.com/1291634 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ImportHostedEngineStorageDomainCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/50557 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibfb9c831cb45175b1043d254d6ecbaff4de5ff13 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Move Entities.vmInterfacesByVmId() to NetworkUtils
by mperina＠redhat.com 15 Dec '15

15 Dec '15

Martin Peřina has submitted this change and it was merged. Change subject: core: Move Entities.vmInterfacesByVmId() to NetworkUtils ...................................................................... core: Move Entities.vmInterfacesByVmId() to NetworkUtils Moves Entities.vmInterfacesByVmId() to NetworkUtils and reimplements it using streams API. Change-Id: I536d2df444b3664022aacb2d08cf4f037f90e4af Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Entities.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java 3 files changed, 10 insertions(+), 20 deletions(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/50482 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I536d2df444b3664022aacb2d08cf4f037f90e4af Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: remove snapshot with Cinder disks - failure flow
by derez＠redhat.com 15 Dec '15

15 Dec '15

Daniel Erez has submitted this change and it was merged. Change subject: core: remove snapshot with Cinder disks - failure flow ...................................................................... core: remove snapshot with Cinder disks - failure flow RemoveDiskSnapshotsCommand/RemoveSnapshotCommand: Use ConcurrentChildCommandsExecutionCallback instead of invoking parent's endAction on RemoveAllCinderSnapshotDisksCommand. Change-Id: Ie06be612162e654cd120edcd9f542ba0d076112f Bug-Url: https://bugzilla.redhat.com/1287771 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveDiskSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveAllCinderSnapshotDisksCommand.java 4 files changed, 18 insertions(+), 20 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49997 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie06be612162e654cd120edcd9f542ba0d076112f Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: create snapshot with Cinder disks - failure flow
by derez＠redhat.com 15 Dec '15

15 Dec '15

Daniel Erez has submitted this change and it was merged. Change subject: core: create snapshot with Cinder disks - failure flow ...................................................................... core: create snapshot with Cinder disks - failure flow CreateAllSnapshotsFromVmCommand: Use ConcurrentChildCommandsExecutionCallback instead of invoking parent's endAction on CreateCinderSnapshotCommand. Change-Id: I4a6162e96d64939fa973b0630a81aa8e07f6acf9 Bug-Url: https://bugzilla.redhat.com/1287771 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/CreateCinderSnapshotCommand.java 2 files changed, 11 insertions(+), 15 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49996 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a6162e96d64939fa973b0630a81aa8e07f6acf9 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: remove template with Cinder disks - failure flow
by derez＠redhat.com 15 Dec '15

15 Dec '15

Daniel Erez has submitted this change and it was merged. Change subject: core: remove template with Cinder disks - failure flow ...................................................................... core: remove template with Cinder disks - failure flow RemoveVmTemplateCommand: Use ConcurrentChildCommandsExecutionCallback when remove a template with Cinder disks. Change-Id: I5c4885e5f552062478813bd24d3619887f6153f4 Bug-Url: https://bugzilla.redhat.com/1287771 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveAllVmCinderDisksCommand.java 2 files changed, 34 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/50401 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c4885e5f552062478813bd24d3619887f6153f4 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Possible to display no elements in ListModelMultip...
by tnisan＠redhat.com 15 Dec '15

15 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Possible to display no elements in ListModelMultipleSelectListBox ...................................................................... webadmin: Possible to display no elements in ListModelMultipleSelectListBox When ListModel is set to be empty, ListModelMultipleSelectListBox will be empty too. Change-Id: I12d23f4b8c84d580a6738ede9b3daea0900e151b Bug-Url: https://bugzilla.redhat.com/1282449 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelMultipleSelectListBox.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelMultipleSelectListBoxEditor.java 2 files changed, 7 insertions(+), 5 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/50539 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12d23f4b8c84d580a6738ede9b3daea0900e151b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Visual enhancement of Options dialog
by tnisan＠redhat.com 15 Dec '15

15 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Visual enhancement of Options dialog ...................................................................... webadmin: Visual enhancement of Options dialog * Description text moved to info icons. * Public key editor inserts empty line among entered keys to visually separate them * Alignments Change-Id: I37457924b923a7f01f9f4cb63c9f4986b7c76206 Bug-Url: https://bugzilla.redhat.com/1269108 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/section/main/presenter/OptionsPopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/OptionsPopupView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/OptionsPopupView.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/InfoIcon.java 6 files changed, 92 insertions(+), 60 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/50465 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37457924b923a7f01f9f4cb63c9f4986b7c76206 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Use a new Cinder volume when running a stateless VM.
by mlipchuk＠redhat.com 15 Dec '15

15 Dec '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use a new Cinder volume when running a stateless VM. ...................................................................... core: Use a new Cinder volume when running a stateless VM. When running a stateless VM with Cinder volume we need to add a new Cinder volume instead of Cinder snapshot to support the same flow being also used for images with stateless VM. Bug-Url: https://bugzilla.redhat.com/1288157 Change-Id: I9266c89212603d801427eb463d6b08104e518923 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/CreateCinderSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/CreateCinderSnapshotCommandCallback.java 3 files changed, 34 insertions(+), 8 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/50385 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9266c89212603d801427eb463d6b08104e518923 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add new parameter class for createCinderSnapshot.
by mlipchuk＠redhat.com 15 Dec '15

15 Dec '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add new parameter class for createCinderSnapshot. ...................................................................... core: Add new parameter class for createCinderSnapshot. Add a paraemter class so the snapshot type can be passed as a parameter, so it can be used for stateless snapshot Change-Id: I03afe8bab4c5547bac4246bf5077bc91486f8d84 Bug-Url: https://bugzilla.redhat.com/1288157 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/CreateCinderSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/CreateCinderSnapshotCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/TryBackToAllCinderSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/TryBackToCinderSnapshotCommand.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateCinderSnapshotParameters.java 6 files changed, 37 insertions(+), 13 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/50384 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03afe8bab4c5547bac4246bf5077bc91486f8d84 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Support restore of stateless snapshot
by mlipchuk＠redhat.com 15 Dec '15

15 Dec '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Support restore of stateless snapshot ...................................................................... core: Support restore of stateless snapshot Longer description using lines' length under 72 chars. With multiple paragraphs if necessary. Change-Id: I83a31d240f454592ef534d264c0aeee356f720f3 Bug-Url: https://bugzilla.redhat.com/?????? Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RestoreAllCinderSnapshotsCommand.java 1 file changed, 17 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/50404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83a31d240f454592ef534d264c0aeee356f720f3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0