- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: findbugs: Remove unused variables in SchedulingManager
by tnisan＠redhat.com 09 Dec '15

09 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: findbugs: Remove unused variables in SchedulingManager ...................................................................... findbugs: Remove unused variables in SchedulingManager Change Ic496411257a5290bbe688e35e18a290ea91d77a3 introduced 2 UUF_UNUSED_FIELD findbugs warnings This patch solves them. Change-Id: I0332eb72ba73002f821587ed0bb5fc63ccb929ef Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/50178 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0332eb72ba73002f821587ed0bb5fc63ccb929ef Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: NetworkQosValidatorTest methods naming conventions
by amureini＠redhat.com 09 Dec '15

09 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: NetworkQosValidatorTest methods naming conventions ...................................................................... core: NetworkQosValidatorTest methods naming conventions Fixed naming conventions of the NetworkQosValidatorTest class' methods as per the recommended Java naming conventions. Change-Id: I79410e858e1beda2fca4645aeeaa01b8cff12d88 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkQosValidatorTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/49898 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79410e858e1beda2fca4645aeeaa01b8cff12d88 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: build: ovirt-hosted-engine-ha-1.3.3.3
by msivak＠redhat.com 09 Dec '15

09 Dec '15

Martin Sivák has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-ha-1.3.3.3 ...................................................................... build: ovirt-hosted-engine-ha-1.3.3.3 Change-Id: I28bc8e62442ad3759cda427b99adb8885f3aecc7 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Martin Sivák: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/50172 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28bc8e62442ad3759cda427b99adb8885f3aecc7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: upgrade: Use unpersist/persist cmds for ovirt node
by msivak＠redhat.com 09 Dec '15

09 Dec '15

Martin Sivák has submitted this change and it was merged. Change subject: upgrade: Use unpersist/persist cmds for ovirt node ...................................................................... upgrade: Use unpersist/persist cmds for ovirt node This patch adds the unperist and persist call to make ovirt-hosted-engine-ha upgrade compatible with ovirt-node. Change-Id: Iddd5b27952fb1c000e20d23740a613b028e1c469 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1280310 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org> --- M ovirt_hosted_engine_ha/lib/upgrade.py M ovirt_hosted_engine_ha/lib/util.py 2 files changed, 28 insertions(+), 11 deletions(-) Approvals: Fabian Deutsch: Verified; Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/50166 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iddd5b27952fb1c000e20d23740a613b028e1c469 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.3 Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: Revert "build: post ovirt-hosted-engine-ha-1.3.3.2"
by sbonazzo＠redhat.com 09 Dec '15

09 Dec '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: Revert "build: post ovirt-hosted-engine-ha-1.3.3.2" ...................................................................... Revert "build: post ovirt-hosted-engine-ha-1.3.3.2" This reverts commit ef45759d29d6b64cd8900ac1aa227af26c3077ff. We need to respin. Change-Id: Ia86fc16a1ac7cf15f6c9b1e54dc47c8654f76111 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 6 insertions(+), 9 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/50167 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia86fc16a1ac7cf15f6c9b1e54dc47c8654f76111 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Auto-Generate Enums in the API.
by juan.hernandez＠redhat.com 09 Dec '15

09 Dec '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Auto-Generate Enums in the API. ...................................................................... restapi: Auto-Generate Enums in the API. This patch adds infrastructure for auto-generating API enums. 'Skeleton' enums, containing only the enum entries, are placed in 'types' package in 'model' project (alongside the API's other business entities). A skeleton enum looks like this: package types; import org.ovirt.api.metamodel.annotations.Type; @Type public enum DiskFormat { COW, RAW; } Full Enum classes with value() and fromValue() methods are generated from the skeleton enums and placed in: ...definition/target/generated-sources/model/org/ovirt/engine/api/model directory. The enums are *not* added to the schema file (api.xsd). The exception to this rule are three existing enums: ValueType, StatisticType, StatisticKind, which do exist in the schema for historic reasons. In the schema file, enums are still represented as strings, for example: <xs:complexType name="Disk"> <xs:element maxOccurs="1" minOccurs="0" name="format" type="xs:string"/> </xs:complexType> But in the model files, the enums themselves are used (instead of strings, which is the case today), for example: @Type public interface Disk extends Device { DiskFormat format(); } Future patches will delete all existing enums, place skeletons for them in model project, and replace string references with enum references where appropriate in model interfaces. Change-Id: If4643497a5cc0fce8e78d820da8a90c612a3ca21 Signed-off-by: Ori Liel <oliel(a)redhat.com> Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/DiskFormat.java M backend/manager/modules/restapi/metamodel/analyzer/src/main/java/org/ovirt/api/metamodel/analyzer/ModelAnalyzer.java A backend/manager/modules/restapi/metamodel/tool/src/main/java/org/ovirt/api/metamodel/tool/EnumGenerator.java M backend/manager/modules/restapi/metamodel/tool/src/main/java/org/ovirt/api/metamodel/tool/JavaClassBuffer.java M backend/manager/modules/restapi/metamodel/tool/src/main/java/org/ovirt/api/metamodel/tool/SchemaGenerator.java M backend/manager/modules/restapi/metamodel/tool/src/main/java/org/ovirt/api/metamodel/tool/SchemaNames.java M backend/manager/modules/restapi/metamodel/tool/src/main/java/org/ovirt/api/metamodel/tool/Tool.java M backend/manager/modules/restapi/model/src/main/java/types/Disk.java A backend/manager/modules/restapi/model/src/main/java/types/DiskFormat.java 9 files changed, 201 insertions(+), 48 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49560 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4643497a5cc0fce8e78d820da8a90c612a3ca21 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: handle bond options mode text value
by alkaplan＠redhat.com 09 Dec '15

09 Dec '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: handle bond options mode text value ...................................................................... engine: handle bond options mode text value Bond options value can be both numeric and text value. This patch adds support for the text value. Longer description using lines' length under 72 chars. Bond options comming from vds will be converted to numeric values to store them uniformly. Change-Id: If0fd5df3d02288b72e0b210849cc43a0ff74b507 Bug-Url: https://bugzilla.redhat.com/1286967 Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/BondMode.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/network/BondModeTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 3 files changed, 74 insertions(+), 46 deletions(-) Approvals: Marcin Mirecki: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49724 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0fd5df3d02288b72e0b210849cc43a0ff74b507 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.1]: build: post ovirt-engine-3.6.1.2
by tnisan＠redhat.com 09 Dec '15

09 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: build: post ovirt-engine-3.6.1.2 ...................................................................... build: post ovirt-engine-3.6.1.2 Change-Id: I14a03dcbd7830fe6e48447a0b4ef69ef14d5e53a Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/build-artifacts.sh M backend/manager/dependencies/common/pom.xml M backend/manager/dependencies/pom.xml M backend/manager/dependencies/tools/pom.xml M backend/manager/extensions-tool/pom.xml M backend/manager/modules/aaa/pom.xml M backend/manager/modules/auth-plugin/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/builtin-extensions/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/extensions-api-root/extensions-api/pom.xml M backend/manager/modules/extensions-api-root/pom.xml M backend/manager/modules/extensions-manager/pom.xml M backend/manager/modules/logger/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/uutils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/jboss-modules-maven-plugin/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/pom.xml M build/validations/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend-symbols/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M mavenmake/pom.xml M pom.xml M version.mak 58 files changed, 65 insertions(+), 62 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/50138 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14a03dcbd7830fe6e48447a0b4ef69ef14d5e53a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in jenkins[master]: periodic reduce of limits
by eedri＠redhat.com 09 Dec '15

09 Dec '15

Eyal Edri has submitted this change and it was merged. Change subject: periodic reduce of limits ...................................................................... periodic reduce of limits - will warn on older than 140 days - will abandon older than 240 days Change-Id: I08939b979c8912355257bbd9f5bf5c78383c41e4 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/yaml/jobs/system/system_gerrit-alert-old-patches.yaml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/50093 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08939b979c8912355257bbd9f5bf5c78383c41e4 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: async:replace Runnable creation with lambda exp
by emesika＠redhat.com 09 Dec '15

09 Dec '15

Eli Mesika has submitted this change and it was merged. Change subject: async:replace Runnable creation with lambda exp ...................................................................... async:replace Runnable creation with lambda exp Change-Id: I7b7cc92b444839456b73ce5240269e0867f24603 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandAsyncTask.java 2 files changed, 8 insertions(+), 17 deletions(-) Approvals: Eli Mesika: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/50155 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b7cc92b444839456b73ce5240269e0867f24603 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0