- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: BuilderExecutorTest methods naming conventions
by amureini＠redhat.com 07 Dec '15

07 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: BuilderExecutorTest methods naming conventions ...................................................................... core: BuilderExecutorTest methods naming conventions Fixed naming conventions of the BuilderExecutorTest class' methods as per the recommended Java naming conventions. Change-Id: I64d985c26969d6c3490a001d34ade91b38fd128c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/builders/BuilderExecutorTest.java 1 file changed, 9 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49908 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64d985c26969d6c3490a001d34ade91b38fd128c Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Tar methods naming conventions
by amureini＠redhat.com 07 Dec '15

07 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Tar methods naming conventions ...................................................................... core: Tar methods naming conventions Fixed naming conventions of the Tar class and its test's methods as per the recommended Java naming conventions. Change-Id: I5817f2c89ef7c64f42ec4dd32f718f742f165185 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/archivers/tar/Tar.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/archivers/tar/TarTest.java 2 files changed, 10 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Martin Peřina: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49858 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5817f2c89ef7c64f42ec4dd32f718f742f165185 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: SpmStatusVDSCommand comment
by amureini＠redhat.com 07 Dec '15

07 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: SpmStatusVDSCommand comment ...................................................................... core: SpmStatusVDSCommand comment Removed useless, inflammatory comment. Change-Id: Ieede77be50e6aef913ef56c747e0cc9b55e91211 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStatusVDSCommand.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieede77be50e6aef913ef56c747e0cc9b55e91211 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: UpdateVMVDSCommand methods naming conventions
by amureini＠redhat.com 07 Dec '15

07 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateVMVDSCommand methods naming conventions ...................................................................... core: UpdateVMVDSCommand methods naming conventions Fixed naming conventions of the UpdateVMVDSCommand class' methods as per the recommended Java naming conventions. Change-Id: I2c28b713ca9e74fca215b145cb7b020cf4543f2b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/UpdateVMVDSCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49874 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c28b713ca9e74fca215b145cb7b020cf4543f2b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GetStoragePoolInfoVDSCommand methods naming conventions
by amureini＠redhat.com 07 Dec '15

07 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetStoragePoolInfoVDSCommand methods naming conventions ...................................................................... core: GetStoragePoolInfoVDSCommand methods naming conventions Fixed naming conventions of the GetStoragePoolInfoVDSCommand class' methods as per the recommended Java naming conventions. Change-Id: I40c08ffc3cdd397547b943b7fec5f1578f6f7eab Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetStoragePoolInfoVDSCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49869 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40c08ffc3cdd397547b943b7fec5f1578f6f7eab Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: HSMGetStorageDomainInfoVDSCommand methods naming conve...
by amureini＠redhat.com 07 Dec '15

07 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: HSMGetStorageDomainInfoVDSCommand methods naming conventions ...................................................................... core: HSMGetStorageDomainInfoVDSCommand methods naming conventions Fixed naming conventions of the HSMGetStorageDomainInfoVDSCommand class' methods as per the recommended Java naming conventions. Change-Id: Ibf739737065fd8f698e22324bc50d83d8f88a3c0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMGetStorageDomainInfoVDSCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49868 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf739737065fd8f698e22324bc50d83d8f88a3c0 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AuditLogableBaseTest methods naming conventions
by amureini＠redhat.com 07 Dec '15

07 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: AuditLogableBaseTest methods naming conventions ...................................................................... core: AuditLogableBaseTest methods naming conventions Fixed naming conventions of the AuditLogableBaseTest class' methods as per the recommended Java naming conventions. Change-Id: I6a87e5232bbcd2732e231f7a6b5fb151a652ff98 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBaseTest.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49867 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a87e5232bbcd2732e231f7a6b5fb151a652ff98 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AsyncTaskManager methods naming conventions
by amureini＠redhat.com 07 Dec '15

07 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: AsyncTaskManager methods naming conventions ...................................................................... core: AsyncTaskManager methods naming conventions Fixed naming conventions of the AsyncTaskManager class' methods as per the recommended Java naming conventions. Change-Id: I2554422a74d3aa7b5cd7a98c847828d72c7ebcf7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49897 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2554422a74d3aa7b5cd7a98c847828d72c7ebcf7 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: SyntaxCheckerFacotry MockConfigRule usage
by amureini＠redhat.com 07 Dec '15

07 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: SyntaxCheckerFacotry MockConfigRule usage ...................................................................... core: SyntaxCheckerFacotry MockConfigRule usage Use MockConfigRule to clean up the test and make it easier to read. As an added bonus, the MockConfigRule takes care of cleaning up the mocked configuration once the test is over, a cleanup missing from the original test. Change-Id: I8634dd0a0aeea0dab9a26a5899001f534c774841 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerFactoryTest.java 1 file changed, 6 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49880 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8634dd0a0aeea0dab9a26a5899001f534c774841 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: SyntaxCheckerFactoryTest methods naming conventions
by amureini＠redhat.com 07 Dec '15

07 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: SyntaxCheckerFactoryTest methods naming conventions ...................................................................... core: SyntaxCheckerFactoryTest methods naming conventions Fixed naming conventions of the SyntaxCheckerFactoryTest class' methods as per the recommended Java naming conventions. Change-Id: I4be27828fa42cdd043714a06d5156a5f1865de0b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerFactoryTest.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49879 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4be27828fa42cdd043714a06d5156a5f1865de0b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0