- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: refactor: use StandardCharsets constants
by masayag＠redhat.com 29 Oct '15

29 Oct '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: refactor: use StandardCharsets constants ...................................................................... engine: refactor: use StandardCharsets constants This patch replaces every call to Charset.forName with a call to StandardCharsets constants. Change-Id: Ib8bde3207ea864232a175e7e631be9aed583d9fc Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/aaa/AAAServiceImpl.java M backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/core/InfoServiceImpl.java M backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/logger/LoggerServiceImpl.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/BasicAuthenticationFilter.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/AddVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/OVirtNodeUpgrade.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/BaseProviderProxy.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVMFromConfigurationCommandTest.java M backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmGraphicsConsoleResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendGroupsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUsersResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/DirectoryEntryIdUtils.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/HexUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/EngineEncryptionUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/OpenSslCAWrapper.java M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ArgumentsParser.java M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/config/ShellLikeConfd.java M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/crypto/CryptMD5.java M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/crypto/EnvelopeEncryptDecrypt.java M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/crypto/EnvelopePBE.java M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/crypto/ticket/TicketDecoder.java M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/crypto/ticket/TicketEncoder.java M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/OpenSSHUtils.java M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/SSHClient.java M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/SSHDialog.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/config/ShellLikeConfdTest.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/crypto/EnvelopeEncryptDecryptTest.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/crypto/ticket/TicketTest.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/SSHDialogTest.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/cryptotool/Main.java 31 files changed, 84 insertions(+), 82 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved Idan Shaby: Verified Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/47802 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8bde3207ea864232a175e7e631be9aed583d9fc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: backend: improve storage domain illegal status message
by tnisan＠redhat.com 29 Oct '15

29 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: backend: improve storage domain illegal status message ...................................................................... backend: improve storage domain illegal status message This patch changes the CDA message about an illegal storage domain status to work with its shared status in case that the regular one is "Unknown" (to be more informative). Change-Id: If607d3b206aead5454ec2559b576032c3efece2c Bug-Url: https://bugzilla.redhat.com/1221163 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Ala Hino: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/47657 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If607d3b206aead5454ec2559b576032c3efece2c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-release[master]: build: ovirt-release36-001-1
by sbonazzo＠redhat.com 29 Oct '15

29 Oct '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-release36-001-1 ...................................................................... build: ovirt-release36-001-1 Change-Id: Iaa4fa44c4154b286efa1e36e036308b89f42e61c Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-release-3.6/configure.ac M ovirt-release-3.6/ovirt-release36.spec.in 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47834 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa4fa44c4154b286efa1e36e036308b89f42e61c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: Adding NIC to VM fails because boot order is used by...
by tnisan＠redhat.com 29 Oct '15

29 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: Adding NIC to VM fails because boot order is used by another device ...................................................................... engine: Adding NIC to VM fails because boot order is used by another device When nics are plugged/unplugged, the device boot order on the vm and in the db can get out of sync. This is not a problem during these operations, as the boot order is only relevant during vm startup, but it can cause a duplicated boot order to be submitted when a new device is created. As the boot order is not relevant during these operations, it is safe to assing no boot order to the device. Change-Id: Ib874807e395007a799dc5ff3eb2fd67b218137c6 Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1216929 (cherry picked from commit 41ea7b4a52a5d39d3b6809d11689b4d6f0643b72) --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugNicVDSCommand.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Marcin Mirecki: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47811 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib874807e395007a799dc5ff3eb2fd67b218137c6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Populate "placement_policy.hosts" even with only on...
by juan.hernandez＠redhat.com 29 Oct '15

29 Oct '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Populate "placement_policy.hosts" even with only one host ...................................................................... restapi: Populate "placement_policy.hosts" even with only one host Currently the "placement_policy.hosts" element is populated only if the VM is pinned to 2 or more hosts. When it is pinned to only one host the element isn't populated, only "placement_policy.host" is populated. This patch changes the RESTAPI so that the multiple hosts will be always populated, even if there is only one host. Change-Id: I1819a1a2a35ca216071e225c319fb4423d7c3629 Bug-Url: https://bugzilla.redhat.com/1275733 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Dudi Maroshi: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47792 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1819a1a2a35ca216071e225c319fb4423d7c3629 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: Added Brazilian localization
by sbonazzo＠redhat.com 28 Oct '15

28 Oct '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: Added Brazilian localization ...................................................................... Added Brazilian localization Change-Id: I35e81ede1c35998585a285491e84b3ca5615621f Signed-off-by: Wesley Morais de Oliveira <wesleymoraisdeoliveira18(a)gmail.com> --- M ovirt-hosted-engine-setup.spec.in M po/LINGUAS A po/pt_BR.po 3 files changed, 2,599 insertions(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Wesley Morais de Oliveira: Verified Rafael Martins: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/46730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35e81ede1c35998585a285491e84b3ca5615621f Gerrit-PatchSet: 11 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Wesley Morais de Oliveira <wesleymoraisdeoliveira18(a)gmail.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Wesley Morais de Oliveira <wesleymoraisdeoliveira18(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: remove ie9 GWT permutation
by gshereme＠redhat.com 28 Oct '15

28 Oct '15

Greg Sheremeta has submitted this change and it was merged. Change subject: engine: remove ie9 GWT permutation ...................................................................... engine: remove ie9 GWT permutation Change-Id: I9e9cf052df00931ad1f6a7e070fc52216c1e457f Bug-Url: https://bugzilla.redhat.com/1275719 Signed-off-by: Scott J Dickerson <sdickers(a)redhat.com> --- M frontend/webadmin/modules/pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Greg Sheremeta: Verified; Looks good to me, approved; Passed CI tests Scott Dickerson: Verified -- To view, visit https://gerrit.ovirt.org/47827 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e9cf052df00931ad1f6a7e070fc52216c1e457f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: remove ie8 GWT permutation
by gshereme＠redhat.com 28 Oct '15

28 Oct '15

Greg Sheremeta has submitted this change and it was merged. Change subject: engine: remove ie8 GWT permutation ...................................................................... engine: remove ie8 GWT permutation Change-Id: Ie69b5b546ed418994809617a67baedb136a9d645 Bug-Url: https://bugzilla.redhat.com/1275719 Signed-off-by: Scott J Dickerson <sdickers(a)redhat.com> --- M frontend/webadmin/modules/pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Scott Dickerson: Verified -- To view, visit https://gerrit.ovirt.org/47825 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie69b5b546ed418994809617a67baedb136a9d645 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: packaging: setup: validate full fqdn
by sbonazzo＠redhat.com 28 Oct '15

28 Oct '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: validate full fqdn ...................................................................... packaging: setup: validate full fqdn ovirt-hosted-engine-setup must validate the full fqdn instead of just validate the domain part of the hostname. Change-Id: I9dd0e6a39b2e4c920be18daa72fe142ff9f9a050 Bug-Url: https://bugzilla.redhat.com/1269182 Signed-off-by: Rafael Martins <rmartins(a)redhat.com> (cherry picked from commit 12ce409f30d1bb64255bfd9c78a42c22fdc57276) --- M src/plugins/ovirt-hosted-engine-setup/engine/fqdn.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47784 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9dd0e6a39b2e4c920be18daa72fe142ff9f9a050 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Add Findbugs exclusion filters
by juan.hernandez＠redhat.com 28 Oct '15

28 Oct '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add Findbugs exclusion filters ...................................................................... restapi: Add Findbugs exclusion filters Findbugs complains about the use of the "System.exit" method in the main class of the tool, but that is acceptable. To avoid that complaint this patch adds exclusion filters to the metamodel, so that this is ignored. Change-Id: Ibd1943c2dee930a669d05761bbdb89cf75125f3a Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A backend/manager/modules/restapi/metamodel/analyzer/exclude-filters.xml A backend/manager/modules/restapi/metamodel/annotations/exclude-filters.xml A backend/manager/modules/restapi/metamodel/concepts/exclude-filters.xml A backend/manager/modules/restapi/metamodel/exclude-filters.xml M backend/manager/modules/restapi/metamodel/pom.xml A backend/manager/modules/restapi/metamodel/tool/exclude-filters.xml 6 files changed, 121 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Barak Korren: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47824 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd1943c2dee930a669d05761bbdb89cf75125f3a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0