- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6.0]: engine: Use UUID as content host id on Satellite
by tnisan＠redhat.com 15 Oct '15

15 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: Use UUID as content host id on Satellite ...................................................................... engine: Use UUID as content host id on Satellite There is a difference in the semantic of the ID field under: /katello/api/v2/systems/:id resource between Katello to Satellite. The :id field in Katello represents the UUID of the content host, however under satellite it is a sequence number, which causes the requests sent from the engine to fail with unknown resource identifier. On Satellite (and also on Katello) the value of the UUID field of the content host can be used to identify it @candlepin. The solution will be to use the UUID field of the system resource instead of the ID. Change-Id: I44ee45ac9770238c8d353ae30bf18a280b92b7ea Bug-Url: https://bugzilla.redhat.com/1271340 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ContentHost.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/SystemProviderFinder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/BaseProviderProxy.java 4 files changed, 14 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47352 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44ee45ac9770238c8d353ae30bf18a280b92b7ea Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.0 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: Use UUID as content host id on Satellite
by oourfali＠redhat.com 15 Oct '15

15 Oct '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Use UUID as content host id on Satellite ...................................................................... engine: Use UUID as content host id on Satellite There is a difference in the semantic of the ID field under: /katello/api/v2/systems/:id resource between Katello to Satellite. The :id field in Katello represents the UUID of the content host, however under satellite it is a sequence number, which causes the requests sent from the engine to fail with unknown resource identifier. On Satellite (and also on Katello) the value of the UUID field of the content host can be used to identify it @candlepin. The solution will be to use the UUID field of the system resource instead of the ID. Change-Id: I44ee45ac9770238c8d353ae30bf18a280b92b7ea Bug-Url: https://bugzilla.redhat.com/1271340 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ContentHost.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/SystemProviderFinder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/BaseProviderProxy.java 4 files changed, 14 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47350 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44ee45ac9770238c8d353ae30bf18a280b92b7ea Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Use UUID as content host id on Satellite
by masayag＠redhat.com 15 Oct '15

15 Oct '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Use UUID as content host id on Satellite ...................................................................... engine: Use UUID as content host id on Satellite There is a difference in the semantic of the ID field under: /katello/api/v2/systems/:id resource between Katello to Satellite. The :id field in Katello represents the UUID of the content host, however under satellite it is a sequence number, which causes the requests sent from the engine to fail with unknown resource identifier. On Satellite (and also on Katello) the value of the UUID field of the content host can be used to identify it @candlepin. The solution will be to use the UUID field of the system resource instead of the ID. Change-Id: I44ee45ac9770238c8d353ae30bf18a280b92b7ea Bug-Url: https://bugzilla.redhat.com/1271340 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ContentHost.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/SystemProviderFinder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/BaseProviderProxy.java 4 files changed, 14 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47319 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44ee45ac9770238c8d353ae30bf18a280b92b7ea Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[ovirt-live-3.6]: build: ovirt-live-3.6.0_rc2
by sbonazzo＠redhat.com 15 Oct '15

15 Oct '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-live-3.6.0_rc2 ...................................................................... build: ovirt-live-3.6.0_rc2 Change-Id: I6e0ddcfe5da1882715a73717374cfe0e7691cd37 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/47346 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e0ddcfe5da1882715a73717374cfe0e7691cd37 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Remove unused StorageDomain#setQueryableIs
by amureini＠redhat.com 14 Oct '15

14 Oct '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused StorageDomain#setQueryableIs ...................................................................... core: Remove unused StorageDomain#setQueryableIs Change-Id: I3e82b06867d83d8db4891367b1803348c0d7fac9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java 1 file changed, 1 insertion(+), 13 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/47275 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e82b06867d83d8db4891367b1803348c0d7fac9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: StorageDomain.getId() with null static data
by amureini＠redhat.com 14 Oct '15

14 Oct '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: StorageDomain.getId() with null static data ...................................................................... core: StorageDomain.getId() with null static data If a StorageDomain object's static data is null, getId() should return null, not crash with a NullPointerException. This patch fixes Coverity issue #1062039. Change-Id: I9a904a5a4ff4724f612118f4aabd0cbc2600caf4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/47274 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a904a5a4ff4724f612118f4aabd0cbc2600caf4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: StorageDomain parentheses
by amureini＠redhat.com 14 Oct '15

14 Oct '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: StorageDomain parentheses ...................................................................... core: StorageDomain parentheses Removed redundant parentheses that just hinder readability. Change-Id: I7645b0ca5d9d8cae26c545d85e13409f70801fd6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java 1 file changed, 8 insertions(+), 8 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/47273 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7645b0ca5d9d8cae26c545d85e13409f70801fd6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: RunVmCommand not loading defalut VmInit
by tnisan＠redhat.com 14 Oct '15

14 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: RunVmCommand not loading defalut VmInit ...................................................................... RunVmCommand not loading defalut VmInit Bug-Url: https://bugzilla.redhat.com/1269534 Change-Id: Ibd727b23f64cdc75afd8f30f6ccac4fc06c7f785 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47325 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd727b23f64cdc75afd8f30f6ccac4fc06c7f785 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Logging null check
by oourfali＠redhat.com 14 Oct '15

14 Oct '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: Logging null check ...................................................................... core: Logging null check value may very well be null. If this happens AND an exception is thrown, the logging statement will fail when attempting to call value.getClass().getName(). This fix safe-guards against this condition and just log "null" in such a situation. This patch fixed Coverity issue #1088577. Change-Id: I9d520a01fb3950193d8c93293c09fc7ee7d51e85 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/BatchProcedureExecutionConnectionCallback.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47272 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d520a01fb3950193d8c93293c09fc7ee7d51e85 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in otopi[master]: packagers: fix ordering dnf/yum
by Alon Bar-Lev 14 Oct '15

14 Oct '15

Alon Bar-Lev has submitted this change and it was merged. Change subject: packagers: fix ordering dnf/yum ...................................................................... packagers: fix ordering dnf/yum Change-Id: Id9b6c1b717b0147274cdc177dc27b4ce911ea89e Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/otopi/packagers/dnfpackager.py M src/plugins/otopi/packagers/yumpackager.py 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/47324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9b6c1b717b0147274cdc177dc27b4ce911ea89e Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0