- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: scheduler: Let AffinityGroup always return empty lists
by rgolan＠redhat.com 02 Sep '15

02 Sep '15

Roy Golan has submitted this change and it was merged. Change subject: scheduler: Let AffinityGroup always return empty lists ...................................................................... scheduler: Let AffinityGroup always return empty lists Sometimes an AffinityGroup is created without VMs in it. Make sure that all lists it returns are never null for safer usage. Bug-Url: https://bugzilla.redhat.com/1251742 Change-Id: I0b504d99ab0cbe0f37b2eb3429d871aa207584ad Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/AffinityGroup.java 2 files changed, 9 insertions(+), 8 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Roman Mohr: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Objections: Tomer Saban: I would prefer that you didn't submit this -- To view, visit https://gerrit.ovirt.org/44803 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b504d99ab0cbe0f37b2eb3429d871aa207584ad Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Treat template watchdogs as template devices
by juan.hernandez＠redhat.com 02 Sep '15

02 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Treat template watchdogs as template devices ...................................................................... restapi: Treat template watchdogs as template devices When support for WildFly was intruduced a series of changes were needed to move the DELETE methods from collections to resources. The change to the watchdogs resources introduced a regression in the treatment of template watchdogs: they are treated as VM resources instead of template resources. This patch fixes that issue. Change-Id: I8c8dbad721446e71bd6dc135af37ad42fd8518bf Bug-Url: https://bugzilla.redhat.com/1258224 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendWatchdogsResource.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ori Liel: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45515 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c8dbad721446e71bd6dc135af37ad42fd8518bf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: VDS-to-Maintenance Message Severity
by oliel＠redhat.com 02 Sep '15

02 Sep '15

Ori Liel has submitted this change and it was merged. Change subject: engine: VDS-to-Maintenance Message Severity ...................................................................... engine: VDS-to-Maintenance Message Severity When host is switched to maintenace, the alert has a warning sign next to it. But this is a normal operation, which does not require a warning. Changed the priority of the message to NORMAL. Bug-Url: http://bugzilla/redhat/com/1162547 Change-Id: I75884efaf60c8e9050bc4f4f51bdc2eb5cef15b0 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ori Liel: Verified; Looks good to me, approved; Passed CI tests Omer Frenkel: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/45216 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75884efaf60c8e9050bc4f4f51bdc2eb5cef15b0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: make template - disable volume format for Cinder
by tnisan＠redhat.com 01 Sep '15

01 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: make template - disable volume format for Cinder ...................................................................... webadmin: make template - disable volume format for Cinder Disable volume format select-box for Cinder disks (as it's irrelevant). Change-Id: I864db99f664f9cf2873162233ba35fc917da09e5 Bug-Url: https://bugzilla.redhat.com/1252969 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Daniel Erez: Verified Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/45562 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I864db99f664f9cf2873162233ba35fc917da09e5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: packaging: spec: update deps and source URL
by sbonazzo＠redhat.com 01 Sep '15

01 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: update deps and source URL ...................................................................... packaging: spec: update deps and source URL Change-Id: Ied2feb33750667df331101f022211cb622e5b1dc Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-hosted-engine-setup.spec.in 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45612 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied2feb33750667df331101f022211cb622e5b1dc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: Display message for unknown CPU type
by tnisan＠redhat.com 01 Sep '15

01 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: Display message for unknown CPU type ...................................................................... engine: Display message for unknown CPU type When creating a VM, if CPU type set for the cluster is unknown, display descriptive message to the user instead of failing with NPE. Change-Id: I5d5b1fadb2c6bcb222a69f66a78c5f61b4e2c582 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1243038 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 11 files changed, 57 insertions(+), 17 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45556 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d5b1fadb2c6bcb222a69f66a78c5f61b4e2c582 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: common: remove DomainPasswordMap behaviour
by masayag＠redhat.com 01 Sep '15

01 Sep '15

Moti Asayag has submitted this change and it was merged. Change subject: common: remove DomainPasswordMap behaviour ...................................................................... common: remove DomainPasswordMap behaviour Change-Id: I443e26038046caa92f7ebc6b588889c19eea28ca Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/OptionBehaviour.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtils.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtilsTest.java D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/collections/DomainsPasswordMap.java 4 files changed, 2 insertions(+), 124 deletions(-) Approvals: Alon Bar-Lev: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45606 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I443e26038046caa92f7ebc6b588889c19eea28ca Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: common: remove unused ConfigValues.Password
by masayag＠redhat.com 01 Sep '15

01 Sep '15

Moti Asayag has submitted this change and it was merged. Change subject: common: remove unused ConfigValues.Password ...................................................................... common: remove unused ConfigValues.Password Change-Id: I984455ee822edcf276e951b7bb74b278deff920e Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45607 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I984455ee822edcf276e951b7bb74b278deff920e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-node-plugin-vdsm[ovirt-3.6]: configure.ac: adjust version suffix to 3.6
by dougsland＠redhat.com 01 Sep '15

01 Sep '15

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: configure.ac: adjust version suffix to 3.6 ...................................................................... configure.ac: adjust version suffix to 3.6 Change-Id: I4d63de859dc0a5932bcb9edc50cbca2c1b30bae1 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/45601 --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45601 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d63de859dc0a5932bcb9edc50cbca2c1b30bae1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: ExportRepoImage - persistAsyncTask
by tnisan＠redhat.com 01 Sep '15

01 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: ExportRepoImage - persistAsyncTask ...................................................................... core: ExportRepoImage - persistAsyncTask ExportRepoImage: use 'persistAsyncTaskPlaceHolder' instead of 'getAsyncTaskId' to ensure proper clearance of tasks (see BZ for details). Change-Id: I05b03d0659fb07d4041173cf95d07a3509f4e306 Bug-Url: https://bugzilla.redhat.com/1216019 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportRepoImageCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Verified Allon Mureinik: Looks good to me, approved Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45561 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05b03d0659fb07d4041173cf95d07a3509f4e306 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0