- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: frontend: Fix NPE in edit host dialog
by tjelinek＠redhat.com 11 Aug '15

11 Aug '15

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Fix NPE in edit host dialog ...................................................................... frontend: Fix NPE in edit host dialog EntityModel<Boolean> was not initialized which resulted in null being implicitly converted to primitive boolean. Change-Id: I8877632678ec91b7a4edabf32e71f30bc3975d8c Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/44678 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8877632678ec91b7a4edabf32e71f30bc3975d8c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Adding null check in SSCE mapper.
by tnisan＠redhat.com 11 Aug '15

11 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Adding null check in SSCE mapper. ...................................................................... restapi: Adding null check in SSCE mapper. Host nullity and isSet checks was missing in StorageServerConnectionExtensionMapper. Change-Id: Icb1017028b35f12e7f3f883b95969a4811763974 Bug-Url: https://bugzilla.redhat.com/1239266 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageServerConnectionExtensionMapper.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/44603 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb1017028b35f12e7f3f883b95969a4811763974 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: Directly use vdscli to connectStorageServer
by sbonazzo＠redhat.com 11 Aug '15

11 Aug '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: Directly use vdscli to connectStorageServer ...................................................................... Directly use vdscli to connectStorageServer - vdsClient is no loger well supported - we have no reverse dep. between ha-agent and setup see also: https://gerrit.ovirt.org/#/c/44306/ Change-Id: Ib11f6afad0ab8541d39b101306475afd78094ca1 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> (cherry picked from commit a253f5111b35acb4e4a383817794bf53664f3ef3) --- M src/bin/hosted-engine.in M src/ovirt_hosted_engine_setup/Makefile.am A src/ovirt_hosted_engine_setup/connect_storage_server.py 3 files changed, 35 insertions(+), 35 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved; Passed CI tests Simone Tiraboschi: Verified -- To view, visit https://gerrit.ovirt.org/44688 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib11f6afad0ab8541d39b101306475afd78094ca1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: change GetErrataForVm to use VdsDynamic as well
by oourfali＠redhat.com 11 Aug '15

11 Aug '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: change GetErrataForVm to use VdsDynamic as well ...................................................................... core: change GetErrataForVm to use VdsDynamic as well Change-Id: Ic1930cdb1007e3a068f9f1e834238e0d46eb9aa4 Bug-Url: https://bugzilla.redhat.com/1252317 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetErrataForVmQuery.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Verified; Looks good to me, approved Oved Ourfali: Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/44683 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1930cdb1007e3a068f9f1e834238e0d46eb9aa4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin, userportal: Cache of VmConsoles removed
by tnisan＠redhat.com 11 Aug '15

11 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin, userportal: Cache of VmConsoles removed ...................................................................... webadmin, userportal: Cache of VmConsoles removed VmConsoles objects are not cached, rather created on demand thus they can be well configured all the time. The bug was caused by resolving wrong console type during first list show (when the vms were down) and keeping that settings even after vms were capable of non-rdp connection. Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> Change-Id: I92fd4807a9d2daea67b8ba547c75717a1764268d Bug-Url: https://bugzilla.redhat.com/1236674 --- D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ConsoleModelsCache.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ConsolesFactory.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/AbstractUserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalItemModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 7 files changed, 102 insertions(+), 165 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Tal Nisan: Passed CI tests Jakub Niedermertl: Verified -- To view, visit https://gerrit.ovirt.org/44440 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92fd4807a9d2daea67b8ba547c75717a1764268d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: packaging: setup: config: show warning during upgrade if leg...
by oourfali＠redhat.com 11 Aug '15

11 Aug '15

Oved Ourfali has submitted this change and it was merged. Change subject: packaging: setup: config: show warning during upgrade if legacy kerbldap ...................................................................... packaging: setup: config: show warning during upgrade if legacy kerbldap Shows warning during upgrade that legacy kerbldap is obsoleted by aaa-ldap extension and users should migrate because kerbldap provider will be removed in future. Change-Id: I096e5d604538c39a01bc4eb976aa5c30b5927295 Bug-Url: https://bugzilla.redhat.com/1252391 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/__init__.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/aaakerbldap.py 2 files changed, 84 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, approved Martin Peřina: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44677 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I096e5d604538c39a01bc4eb976aa5c30b5927295 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: vdsm: add 3.6 branch jobs
by sbonazzo＠redhat.com 11 Aug '15

11 Aug '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: vdsm: add 3.6 branch jobs ...................................................................... vdsm: add 3.6 branch jobs - publisher: take artifacts from the 3.6 job - renamed vdsm_create-rpms to vdsm_3.5_create-rpms - added vdsm_3.6_create-rpms - renamed vdsm_install-rpm-sanity to vdsm_master_install-rpm-sanity - added vdsm_3.6_install-rpm-sanity - splitted vdsm_3.5_install-rpm-sanity out of vdsm_install-rpm-sanity - excluded libgfapi job since HC has moved to 4.0 Change-Id: Ic16fcff77599d233079d4d4d104f58b10f7a8446 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt/publish-rpms-nightly-3.6.yaml M jobs/confs/projects/vdsm/vdsm_create-rpms.yaml M jobs/confs/projects/vdsm/vdsm_install-rpm-sanity.yaml 3 files changed, 155 insertions(+), 8 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Yaniv Bronhaim: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44551 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic16fcff77599d233079d4d4d104f58b10f7a8446 Gerrit-PatchSet: 4 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: @Test testValidateUniqueTemplateNameInDC
by amureini＠redhat.com 11 Aug '15

11 Aug '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: @Test testValidateUniqueTemplateNameInDC ...................................................................... core: @Test testValidateUniqueTemplateNameInDC testValidateUniqueTemplateNameInDC is clearly a test method, but for some reason it lacked the @Test annotation, which prevented the JUnit test runner running it. Change-Id: Ica2da3caf36e8c2a77ef681fae7ac07bcd0d09c5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmTemplateCommandTest.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica2da3caf36e8c2a77ef681fae7ac07bcd0d09c5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in otopi[master]: packagers: mdf: do not attempt to work with different major
by Alon Bar-Lev 11 Aug '15

11 Aug '15

Alon Bar-Lev has submitted this change and it was merged. Change subject: packagers: mdf: do not attempt to work with different major ...................................................................... packagers: mdf: do not attempt to work with different major Change-Id: I1d546adcac03403a03e86ac918315218451c2aca Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/otopi/minidnf.py M src/plugins/otopi/packagers/dnfpackager.py M src/plugins/otopi/packagers/yumpackager.py 3 files changed, 53 insertions(+), 50 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44680 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d546adcac03403a03e86ac918315218451c2aca Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: disallow redeploy on dirty storage
by sbonazzo＠redhat.com 11 Aug '15

11 Aug '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: disallow redeploy on dirty storage ...................................................................... packaging: setup: disallow redeploy on dirty storage In the past we had the capability to re-deploy hosted-engine over a previously partially deployed system; the trick was simply to let the user boot the VM from CD and than exit without touching the engine VM disk and than continue frm there. With the appliance it doesn't make sense cause it will always overwrite the previously deployed one destroying it. Explicitly disable it to prevent confusion. Change-Id: I3a2a1ab7b74450ad9341bd6d3e7694d99c97f5da Bug-Url: https://bugzilla.redhat.com/1238709 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/storage/storage.py 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44674 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a2a1ab7b74450ad9341bd6d3e7694d99c97f5da Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0