- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: use runQuery to get a StorageServerConnection
by Code Review 01 Jun '17

01 Jun '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: restapi: use runQuery to get a StorageServerConnection ...................................................................... restapi: use runQuery to get a StorageServerConnection BackendStorageDomainsResource -> getStorageServerConnection: use 'runQuery' instead of 'getEntity' in order to return a correct error code in case of a missing storage connection for a storage domain (500 instead of 404). Change-Id: Idd737198b59dc5feb2fb5e60c0eba96873756919 Bug-Url: https://bugzilla.redhat.com/1448399 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java 1 file changed, 12 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/77322 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd737198b59dc5feb2fb5e60c0eba96873756919 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: engine : Hide tracebacks in engine.log by upgrading non resp...
by Code Review 01 Jun '17

01 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: engine : Hide tracebacks in engine.log by upgrading non responsive host ...................................................................... engine : Hide tracebacks in engine.log by upgrading non responsive host All host exceptions should be in debug logs, only the root cause messages should be in normal engine logs. Change-Id: Ide61e78e46643cbabcb71239d5fdf820fe345dcc Bug-Url: https://bugzilla.redhat.com/1414787 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployBase.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/log/LoggedUtils.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/log/LoggedUtilsTest.java M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/SSHClient.java M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/SSHDialog.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FutureVDSCommand.java 7 files changed, 43 insertions(+), 22 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77595 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide61e78e46643cbabcb71239d5fdf820fe345dcc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: restapi: Update to model 4.1.37
by Code Review 01 Jun '17

01 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: restapi: Update to model 4.1.37 ...................................................................... restapi: Update to model 4.1.37 The more relevant changes in the new version of the model are the following: * Add the `all_content` parameter to `Host.Get` and `Hosts.List`. * Fix the documentation of the method that lists events. * Fix the direction of the main parameter of the method that adds a CDROM to a virtual machine. It should be input and output. * Improve the documentation explaining that in general the order of the results of _list_ methods isn't guaranteed. * Add the `index` attribute to the `Event` type. Change-Id: I5f60c0b3fe0a795a07929b4691660e76ddb6f681 Related-To: https://bugzilla.redhat.com/1444081 Bug-Url: https://bugzilla.redhat.com/1447622 Bug-Url: https://bugzilla.redhat.com/1448511 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/EventMapper.java M pom.xml 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77594 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f60c0b3fe0a795a07929b4691660e76ddb6f681 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: sos: fix configuration on engine host
by Code Review 01 Jun '17

01 Jun '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: sos: fix configuration on engine host ...................................................................... sos: fix configuration on engine host Fixed sos configuration for execution on engine host adding logs plugin correctly. Change-Id: I7e0ae57a2a853ba8bccdc25c8ec278bad8de7987 Bug-Url: https://bugzilla.redhat.com/1447790 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Yuval Turgeman: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/77618 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e0ae57a2a853ba8bccdc25c8ec278bad8de7987 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: add email notification to build artifacts
by Code Review 01 Jun '17

01 Jun '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: add email notification to build artifacts ...................................................................... add email notification to build artifacts Change-Id: Id922e490e4b6f12c7248c67db4e9437e02fd099b --- M jobs/confs/projects/defaults.yaml M jobs/confs/yaml/publishers/standard.yaml M jobs/confs/yaml/templates/standard-stage.yaml 3 files changed, 7 insertions(+), 0 deletions(-) Approvals: Eyal Edri: Looks good to me, approved Daniel Belenky: Verified; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77502 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id922e490e4b6f12c7248c67db4e9437e02fd099b Gerrit-PatchSet: 4 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Update to model 4.2.12
by Code Review 01 Jun '17

01 Jun '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Update to model 4.2.12 ...................................................................... restapi: Update to model 4.2.12 The more relevant changes in the new version of the model are the following: * Fix the documentation of the method that lists events. * Fix the direction of the main parameter of the method that adds a CDROM to a virtual machine. It should be input and output. * Improve the documentation explaining that in general the order of the results of _list_ methods isn't guaranteed. * Add the `index` attribute to the `Event` type. Change-Id: I5f60c0b3fe0a795a07929b4691660e76ddb6f681 Bug-Url: https://bugzilla.redhat.com/1447622 Bug-Url: https://bugzilla.redhat.com/1448511 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/EventMapper.java M pom.xml 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77592 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f60c0b3fe0a795a07929b4691660e76ddb6f681 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Fix cleanup code for libvirt VMs
by Code Review 01 Jun '17

01 Jun '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. Change subject: Fix cleanup code for libvirt VMs ...................................................................... Fix cleanup code for libvirt VMs Turns out it wasn't working and throwing errors instead. Change-Id: I0352c05633bf63df05b18d6b5cd183f684d4296c Signed-off-by: Barak Korren <bkorren(a)redhat.com> Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1417 --- M jobs/confs/shell-scripts/mock_cleanup.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Barak Korren: Verified; Looks good to me, approved; Ready for merge Yuval Turgeman: Looks good to me Daniel Belenky: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77500 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0352c05633bf63df05b18d6b5cd183f684d4296c Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com>

1 0

Change in jenkins[master]: ovirt-engine-dashboard: add fc26 jobs
by Code Review 01 Jun '17

01 Jun '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-engine-dashboard: add fc26 jobs ...................................................................... ovirt-engine-dashboard: add fc26 jobs Change-Id: I82151f137e1ac5ac4b190d51da3ad97537a08d57 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-dashboard/ovirt-engine-dashboard_standard.yaml 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me -- To view, visit https://gerrit.ovirt.org/77601 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82151f137e1ac5ac4b190d51da3ad97537a08d57 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: make each disk appear on its own separate line
by Code Review 31 May '17

31 May '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. Change subject: webadmin: make each disk appear on its own separate line ...................................................................... webadmin: make each disk appear on its own separate line Currently when multiple disks are selected to be moved, the disks allocation dialog makes some of the disk's fields appear in the previous row instead. Fixed by wrapping each disk with a bootstrap row. Before screenshot: http://i.imgur.com/ucne2s4.png After screenshot: http://i.imgur.com/q9ZIWKD.png Change-Id: I86981b1538f08e728842dcc974ebfb45bd2aea83 Bug-Url: https://bugzilla.redhat.com/1436766 Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationItemView.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationView.ui.xml 2 files changed, 36 insertions(+), 26 deletions(-) Approvals: Benny Zlotnik: Verified Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/77182 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86981b1538f08e728842dcc974ebfb45bd2aea83 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: do not mix graphic admonition with awesomeicons + macros.
by Code Review 31 May '17

31 May '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: do not mix graphic admonition with awesomeicons + macros. ...................................................................... do not mix graphic admonition with awesomeicons + macros. Change-Id: I16be5d7cead45c44855828ee4ea9aef3d036221f Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M src/inventory_report/produceReport/pre-upgrade-checks M src/inventory_report/produceReport/produceReport.sh 2 files changed, 21 insertions(+), 18 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77606 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16be5d7cead45c44855828ee4ea9aef3d036221f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0