- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: coverity: Dereference null return value
by masayag＠redhat.com 19 Jun '15

19 Jun '15

Moti Asayag has submitted this change and it was merged. Change subject: coverity: Dereference null return value ...................................................................... coverity: Dereference null return value Change-Id: I101f840cd321361ebab8f632c52389dab8c1ce48 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtils.java 1 file changed, 12 insertions(+), 11 deletions(-) Approvals: Piotr Kliczewski: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42575 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I101f840cd321361ebab8f632c52389dab8c1ce48 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Form panel label/value width
by awels＠redhat.com 19 Jun '15

19 Jun '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Form panel label/value width ...................................................................... webadmin: Form panel label/value width - The form panel label width and value width were always at 50%/50%. So if you made one column the width of the entire available space, the spacing between the label and value would be off. So one would decrease the width of the panel. However this can cause some cut offs for really large values, like in the path of the storage general panel. This patch allows the developer more control over how the label/value are distributed allowing for larger columns to not have strange spacing. Change-Id: I43f35cd46116b8d386b86383e97fca9862e7d479 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1230723 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/AbstractFormPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/FormBuilder.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageGeneralView.java 3 files changed, 33 insertions(+), 23 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Looks good to me, but someone else must approve; Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42461 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43f35cd46116b8d386b86383e97fca9862e7d479 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Events list
by awels＠redhat.com 19 Jun '15

19 Jun '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Events list ...................................................................... webadmin: Events list - Both the bottom event tab and the events main tab were using the same list model. If you refreshed/paged in the events Main tab it would also page/refresh in the bottom events tab. This patch creates 2 instances of the event list model and properly assigns each to their respective views. - Clean up some generics for the EventListModel. Change-Id: Ib5675f0e67b7f57f1cc7a132bea0d4bb3c091c2f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1224707 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1193935 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/ClientGinjectorExtension.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/UiCommonModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/EventModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabEventPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/MainSectionView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabEventView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/EventModelProvider.java 8 files changed, 41 insertions(+), 21 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42457 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5675f0e67b7f57f1cc7a132bea0d4bb3c091c2f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Host->VM refresh on events
by awels＠redhat.com 19 Jun '15

19 Jun '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Host->VM refresh on events ...................................................................... webadmin: Host->VM refresh on events - The refresh mechanism that refreshes the active models when a new event comes in was broken, this patch fixes that. - The HostVmListModel didn't activate the refresh timer at all thus any changes to the status of the list would never appear in the webadmin portal. This patch activates the timer of that model. Change-Id: Ic8ee45c59a1b9944bafce3bc9a1b75ee3ef79697 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1203431 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/EventListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostVmListModel.java 3 files changed, 35 insertions(+), 17 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42559 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8ee45c59a1b9944bafce3bc9a1b75ee3ef79697 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Make search string management intelligent
by awels＠redhat.com 19 Jun '15

19 Jun '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Make search string management intelligent ...................................................................... webadmin: Make search string management intelligent - Before the search string was purely stored in the actual model and it didn't know/care about who the search string was generated. However we want to distinguish between search strings generated while the system node is selected vs ones when a particular item in the tree is selected. This patch stores the search string based on the selected model as well as the selected system node. Change-Id: Ibd3575406da3d78b34a1d5286cca128dd983fd4d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1226661 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java 1 file changed, 27 insertions(+), 3 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42501 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd3575406da3d78b34a1d5286cca128dd983fd4d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Role descriptions
by awels＠redhat.com 19 Jun '15

19 Jun '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Role descriptions ...................................................................... webadmin: Role descriptions - Due to ec00576171bf1f7a123eaa36046d989d43d1bf30 which cleaned up how the tree was created. However it started using the name instead of the description of the node to display, which was fine for the first two levels but the last level which had all the configurable items got broken. This patch uses the description to display the label in the tree. - Cleaned up some of the code formatting to adhere to current standards. - Fixed minor height issue which caused 2 scrollbars to appear. Change-Id: Ie38f9482f686e83b9b3738fa96e33f9713d28087 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1199753 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleNode.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RolePopupView.ui.xml 4 files changed, 53 insertions(+), 97 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie38f9482f686e83b9b3738fa96e33f9713d28087 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: check unique data center name
by awels＠redhat.com 19 Jun '15

19 Jun '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: check unique data center name ...................................................................... webadmin: check unique data center name - There was no validation for a unique data center name. This patch add a check to make sure the name is unique and high lights the name field if it is not unique. Change-Id: I1032aed8c7f23c65cad4c813bf5759904ca524b8 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=956562 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java 1 file changed, 31 insertions(+), 5 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42548 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1032aed8c7f23c65cad4c813bf5759904ca524b8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: spec: require specific jsonrpc version
by piotr.kliczewski＠gmail.com 19 Jun '15

19 Jun '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: spec: require specific jsonrpc version ...................................................................... spec: require specific jsonrpc version There is api incompatibility between 1.0.x and 1.1.x so we need to make sure that 3.5 engine uses the latest 1.0 version. Change-Id: I967e083dd45545478d90fdcdaa85562239154ce5 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> Bug-Url: https://bugzilla.redhat.com/1233132 --- M ovirt-engine.spec.in 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/42572 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I967e083dd45545478d90fdcdaa85562239154ce5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in mom[master]: vdsm xml rpc: fix locking
by alitke＠redhat.com 19 Jun '15

19 Jun '15

Adam Litke has submitted this change and it was merged. Change subject: vdsm xml rpc: fix locking ...................................................................... vdsm xml rpc: fix locking Multiple threads will call concurrently the hypervisor interface. Without proper locking, we will have races. The most noticeable effect is an unbounded amount of calls to VDSM, due to the raceful age check. This completely defeats the purpose of caching. This patch adds a lock to make sure the check is safe, and that the caching is effective. Change-Id: I8a6d058ee2631bd100153c2091400a2a35b4fb1d Signed-off-by: Francesco Romani <fromani(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/42574 Reviewed-by: Martin Sivák <msivak(a)redhat.com> Continuous-Integration: Jenkins CI --- M mom/HypervisorInterfaces/vdsmxmlrpcInterface.py 1 file changed, 8 insertions(+), 4 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/42574 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a6d058ee2631bd100153c2091400a2a35b4fb1d Gerrit-PatchSet: 2 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Remove "graphics_consoles" from "VmBase"
by juan.hernandez＠redhat.com 19 Jun '15

19 Jun '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Remove "graphics_consoles" from "VmBase" ...................................................................... restapi: Remove "graphics_consoles" from "VmBase" The presence of this element in the the base class for VMs and Templates induces a type error in the Java SDK. The Java class generated by the "xjc" compiler from the "VmBase" class contains the following method: List<GraphicsConsoles> getGraphicsConsoles() The "VM" decorator class generated by the code generator contains the following method: VMGraphicsConsoles getGraphicsConsoles() The return types are icompatible. The "graphics_consoles" element isn't currently used, so this patch removes it to avoid the issue in the Java SDK. Change-Id: Ibdf5a15be99b636be0a4bf57abe83fbc15c5ac81 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/42481 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibdf5a15be99b636be0a4bf57abe83fbc15c5ac81 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0