- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: remove unused method
by ahadas＠redhat.com 17 Jun '15

17 Jun '15

Arik Hadas has submitted this change and it was merged. Change subject: core: remove unused method ...................................................................... core: remove unused method VmsMonitoring#resetStatusUpdateTime was unused, thus removed. Change-Id: I8ca6110451758c3ce5209c85b07aacee89d61200 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/42467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ca6110451758c3ce5209c85b07aacee89d61200 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: add ctor to VmInternalData (2)
by ahadas＠redhat.com 17 Jun '15

17 Jun '15

Arik Hadas has submitted this change and it was merged. Change subject: core: add ctor to VmInternalData (2) ...................................................................... core: add ctor to VmInternalData (2) Add constructor that gets VmDynamic and VmStatistics Change-Id: I8233a7de380c3831eda232f0a55c3373dc03b0bb Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVMStatsRefresher.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/entities/VmInternalData.java 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/42463 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8233a7de380c3831eda232f0a55c3373dc03b0bb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: fix pep8 issue
by sbonazzo＠redhat.com 17 Jun '15

17 Jun '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: fix pep8 issue ...................................................................... packaging: fix pep8 issue Change-Id: I127e9c5f789fac4bc3ece31364b682d6a25ffc88 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/libexec/ovirt-vmconsole-proxy-helper/ovirt-vmconsole-list.py 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/42456 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I127e9c5f789fac4bc3ece31364b682d6a25ffc88 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: add another ctor to VmInternalData
by ahadas＠redhat.com 17 Jun '15

17 Jun '15

Arik Hadas has submitted this change and it was merged. Change subject: core: add another ctor to VmInternalData ...................................................................... core: add another ctor to VmInternalData Add constructor that gets only VmDynamic Change-Id: I149fb3557fcc4926e1ac7094562a4ef36241a133 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/entities/VmInternalData.java 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/42462 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I149fb3557fcc4926e1ac7094562a4ef36241a133 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: added volume types existence validation
by derez＠redhat.com 16 Jun '15

16 Jun '15

Daniel Erez has submitted this change and it was merged. Change subject: core: added volume types existence validation ...................................................................... core: added volume types existence validation Added 'validateCinderVolumeTypesExist' to CinderDisksValidator, in order to validate that the specified volume type exists (upon creating a cinder disk). Change-Id: I781ba3667f4f28db3ab79e2e31346154097ea664 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/CinderDisksValidator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 40 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved Objections: Jenkins CI: I would prefer that you didn't submit this -- To view, visit https://gerrit.ovirt.org/41967 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I781ba3667f4f28db3ab79e2e31346154097ea664 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: re-factor method of deleteVolume to CinderBroker
by mlipchuk＠redhat.com 16 Jun '15

16 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: re-factor method of deleteVolume to CinderBroker ...................................................................... core: re-factor method of deleteVolume to CinderBroker Use the delete volume and delete volume snapshot in a CinderBroker method to delete volume of unknown type (to be used for restore). Change-Id: Id1be5020e4d95b10164a5216b0bb793573c743c5 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CinderBroker.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskCommand.java 2 files changed, 16 insertions(+), 17 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/42449 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1be5020e4d95b10164a5216b0bb793573c743c5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: re-order CinderBroker imports.
by mlipchuk＠redhat.com 16 Jun '15

16 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: re-order CinderBroker imports. ...................................................................... core: re-order CinderBroker imports. Re-order Cinder broker imports Change-Id: Ib3436f634fc7affae729666392102356ea03578a Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CinderBroker.java 1 file changed, 13 insertions(+), 13 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/42448 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3436f634fc7affae729666392102356ea03578a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Change CinderBroker to use getImageId.
by mlipchuk＠redhat.com 16 Jun '15

16 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Change CinderBroker to use getImageId. ...................................................................... core: Change CinderBroker to use getImageId. Use getImageId instead of getId since a volume in Cinder can be a commited previewed volume which is acctually a new volume in Cinder. Change-Id: I72432dd8c16f5eabe50f2ec3315d8b15cf4e464c Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CinderBroker.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/42450 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72432dd8c16f5eabe50f2ec3315d8b15cf4e464c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Make remove Cinder disks call back to be generic.
by mlipchuk＠redhat.com 16 Jun '15

16 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Make remove Cinder disks call back to be generic. ...................................................................... core: Make remove Cinder disks call back to be generic. 1) Rename call back to be more general 2) Use generics so it can be used also for restore Cinder snapshot. Change-Id: I27ed952af20fc315e58c591c1d5eb1042f2dedd1 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllCinderDisksCommandCallBack.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmCinderDisksCommand.java 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/42454 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27ed952af20fc315e58c591c1d5eb1042f2dedd1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: VmIcons DAO for the REST part
by ofrenkel＠redhat.com 16 Jun '15

16 Jun '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: VmIcons DAO for the REST part ...................................................................... core: VmIcons DAO for the REST part DAO methods necessary for efficient implementation of Vm Icons REST interface. Change-Id: I765eafe88cbb6f9d0c0fb8019970a6c7134ceddd Bug-Url: https://bugzilla.redhat.com/1103175 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmIconDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmIconDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmIconDefaultDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmIconDefaultDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmIconDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmIconDefaultDaoTest.java M packaging/dbscripts/vm_icons_sp.sql 7 files changed, 70 insertions(+), 1 deletion(-) Approvals: Jakub Niedermertl: Verified Eli Mesika: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42046 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I765eafe88cbb6f9d0c0fb8019970a6c7134ceddd Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0