- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: add template from snapshot
by ahadas＠redhat.com 01 Jun '15

01 Jun '15

Arik Hadas has submitted this change and it was merged. Change subject: core: add template from snapshot ...................................................................... core: add template from snapshot Introduce AddVmTemplateFromSnapshotCommand that creates a template from a snapshot. Change-Id: I4262e738110f868c9987f5bc4b87325acabb7ad3 Bug-Url: https://bugzilla.redhat.com/1003492 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateFromSnapshotCommand.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmTemplateFromSnapshotParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 5 files changed, 284 insertions(+), 13 deletions(-) Approvals: Jenkins CI: Verified; Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/41258 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4262e738110f868c9987f5bc4b87325acabb7ad3 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[master]: reports: added Capacity Planing (BR48) report
by sradco＠redhat.com 31 May '15

31 May '15

Shirly Radco has submitted this change and it was merged. Change subject: reports: added Capacity Planing (BR48) report ...................................................................... reports: added Capacity Planing (BR48) report Change-Id: Ie811404cb38b243959fcbcf8311f1e98e43f681a Bug-Url:https://bugzilla.redhat.com/1179118 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/Reports/Inventory/.folder.xml A packaging/ovirt-reports/resources/Reports/Inventory/capacity_planing_br48.xml A packaging/ovirt-reports/resources/Reports/Inventory/capacity_planing_br48_files/br48 full details.jrxml.data A packaging/ovirt-reports/resources/Reports/Inventory/capacity_planing_br48_files/br48_legend.jrxml.data A packaging/ovirt-reports/resources/Reports/Inventory/capacity_planing_br48_files/capacity_planing_br48_jrxml.data M packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Period_Affected/non-002dquery_IC/.folder.xml A packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Period_Affected/non-002dquery_IC/P_Display_By_DC_Cluster.xml A packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Period_Affected/non-002dquery_IC/P_Group_By_Tag.xml M packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Regular_Input_Controls/.folder.xml A packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Regular_Input_Controls/all_dcs_with_hosts_multi_select/.folder.xml A packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Regular_Input_Controls/all_dcs_with_hosts_multi_select/P_DataCenter_ID.xml M packaging/ovirt-reports/resources/reports_resources/localization/ovirt_reports_bundle_en_US.properties.data 12 files changed, 3,995 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/39005 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie811404cb38b243959fcbcf8311f1e98e43f681a Gerrit-PatchSet: 12 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[master]: reports: Fixed server ui
by sradco＠redhat.com 31 May '15

31 May '15

Shirly Radco has submitted this change and it was merged. Change subject: reports: Fixed server ui ...................................................................... reports: Fixed server ui Change-Id: Icf850907332cd1455f4ea4670ab795bae644c3be Bug-Url:https://bugzilla.redhat.com/1209556 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/themes/ovirt-002dreports-002dtheme/images/button_action_primary_sprite.png.data M packaging/ovirt-reports/resources/themes/ovirt-002dreports-002dtheme/images/button_capsule_sprite.png.data M packaging/ovirt-reports/resources/themes/ovirt-002dreports-002dtheme/overrides_custom.css.data 3 files changed, 5 insertions(+), 1 deletion(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/41572 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf850907332cd1455f4ea4670ab795bae644c3be Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Null pointer dereferences in model classes
by vszocs＠redhat.com 29 May '15

29 May '15

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Null pointer dereferences in model classes ...................................................................... webadmin: Null pointer dereferences in model classes Added null check when calling Configurator#getSyntaxChecker in WebAdmin context (CommonModel and SearchSuggestModel) to fix FindBugs "Null pointer dereferences" warning. In practice, WebAdminConfigurator#getSyntaxChecker (bound in WebAdmin's UiCommonModule) always returns non-null reference so this is just to eliminate the FindBugs warning. Change-Id: I6b352518d0a306c69e7fcb5d778b76f38e0c848e Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/autocomplete/SearchSuggestModel.java 2 files changed, 15 insertions(+), 8 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Verified; Looks good to me, but someone else must approve Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/41405 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b352518d0a306c69e7fcb5d778b76f38e0c848e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: cluster guide me datacenter
by awels＠redhat.com 28 May '15

28 May '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: cluster guide me datacenter ...................................................................... webadmin: cluster guide me datacenter - Added add data center button to popup view when the cluster has no data center associated with it. - Added popup window to select the data center to associate with the cluster. This popup contains a list of available data centers filtered by the following rules: - Data center compatibility level <= Cluster compatibility level - Date center with local data and no assigned cluster. - Fixed issue where this patch would not allow new VMs to be created. Change-Id: Ifaafdd5593d3721b9e6a8b466b2ac186b18bd6ff Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1136414 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCellTable.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/cluster/AddDataCenterClusterPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/guide/GuidePopupPresenterWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/AddDataCenterClusterPopupView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/AddDataCenterClusterPopupView.ui.xml 8 files changed, 441 insertions(+), 174 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Verified; Looks good to me, but someone else must approve Shmuel Leib Melamud: Looks good to me, but someone else must approve Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41486 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifaafdd5593d3721b9e6a8b466b2ac186b18bd6ff Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin : Fix Menu Cell click event
by gshereme＠redhat.com 28 May '15

28 May '15

Greg Sheremeta has submitted this change and it was merged. Change subject: webadmin : Fix Menu Cell click event ...................................................................... webadmin : Fix Menu Cell click event A cell registers to events that it wants to listen with its table. The table notifies the cell by invoking onBrowserEvent when a registered event occurs. In case of ActivityColumn of Volumes main tab, it is a column of a CompositeCell - VolumeActivityCompositeCell which is in-turn a combination of : 1.VolumeActivityStatusColumn - Column of AbstractCell VolumeActivityStatusCell 2.Column of AbstractCell - VolumeActivitySeperatorCell 3.Column of AbstractCell - MenuCell - for rebalance 4.Column of AbstractCell - MenuCell - for remove-brick So, this being the situation, the Composite of the Composites which is the VolumeActivityCompositeCell receieves the events to which it subscribes from the table and then only constituent cells can get them but in our case, the VolumeActivityCompositeCell was not subscribing for the click event and hence the constituent MenuCell was not notified of the click. Hence this patch modifies VolumeActivityCompositeCell to subscribe to a superset of all events that its constituent cells need. Change-Id: I32a223494d23848c530ee083dc14e1d072a86967 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1209422 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VolumeActivityCompositeCell.java 1 file changed, 23 insertions(+), 0 deletions(-) Approvals: anmolbabu: Verified Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41528 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32a223494d23848c530ee083dc14e1d072a86967 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Avoid permission removal during updateVmVersion
by ofrenkel＠redhat.com 28 May '15

28 May '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: Avoid permission removal during updateVmVersion ...................................................................... core: Avoid permission removal during updateVmVersion When updateVmVersionCommand calls removeVmCommand, the remove command shouldn't remove permissions because the VM is re-created and permissions are still relevant. Change-Id: I68f2b23e255110d206f90a378e8785d65fe89a0f Bug-Url: https://bugzilla.redhat.com/1140569 Signed-off-by: Eldan Shachar <eshachar(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmVersionCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins CI: Verified; Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40101 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68f2b23e255110d206f90a378e8785d65fe89a0f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: userportal, webadmin: include jQuery 1.11.3
by gshereme＠redhat.com 28 May '15

28 May '15

Greg Sheremeta has submitted this change and it was merged. Change subject: userportal, webadmin: include jQuery 1.11.3 ...................................................................... userportal, webadmin: include jQuery 1.11.3 We explicitly depend on jQuery now, but were previously relying on PatternFly's copy of it. Since it is an explicit dependency, we should include it ourselves. Also -- older versions of PatternFly (<1.2.1) shipped a 2.0+ version of jQuery. When oVirt included this version, IE8 could not render, since jQuery 2.0 drops IE8 support. While we will no longer support IE8 in oVirt 3.6.0+, it's nice to have it at least render. Change-Id: I32b24168795e1852a3ebb142a7b6c364c9808107 Bug-Url: https://bugzilla.redhat.com/1222584 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M backend/manager/modules/branding/src/main/resources/META-INF/tags/obrand/javascripts.tag A packaging/branding/ovirt.brand/jquery-1.11.3.min.js 2 files changed, 6 insertions(+), 1 deletion(-) Approvals: Greg Sheremeta: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32b24168795e1852a3ebb142a7b6c364c9808107 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: Allow to avoid lock screen on spice disconnect
by ofrenkel＠redhat.com 28 May '15

28 May '15

Omer Frenkel has submitted this change and it was merged. Change subject: Allow to avoid lock screen on spice disconnect ...................................................................... Allow to avoid lock screen on spice disconnect This patch introduces a feature to be able to select the type of action to perform, when an user disconnects from the spice console. Previously this was always trying to perform 'lock screen' via the guest agent. Now this can be disabled, the user can be logged out, the VM rebooted or shutdown. Change-Id: Ia2ef5ffaceed619f6630b56a7156f25e9111fd9e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1171638 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetVmTicketCommand.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ConsoleDisconnectAction.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetVmTicketVDSCommandParameters.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmBaseDaoDbFacade.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStaticDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/DisplayDisconnectAction.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/TemplateMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmBaseMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/TemplateMapperTest.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetVmTicketVDSCommand.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/instancetypes/InstanceTypesPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/CoreUnitToVmBaseBuilder.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/CoreVmBaseToUnitBuilder.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseVmListModelTest.java M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseVmModelBehaviorTest.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_06_1450_add_vm_static_console_disconnect_action.sql M packaging/dbscripts/vms_sp.sql 35 files changed, 299 insertions(+), 20 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Ori Liel: Looks good to me, but someone else must approve Eli Mesika: Looks good to me, but someone else must approve Vinzenz Feenstra: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/34079 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2ef5ffaceed619f6630b56a7156f25e9111fd9e Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: add consoleAddress to migration command params
by ofrenkel＠redhat.com 28 May '15

28 May '15

Omer Frenkel has submitted this change and it was merged. Change subject: engine: add consoleAddress to migration command params ...................................................................... engine: add consoleAddress to migration command params will use console address added in: http://wiki.ovirt.org/Features/Display_Address_Override Change-Id: I788e713c279fc2c6c90b4609554383c067217add Signed-off-by: Yeela Kaplan <ykaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MigrateVDSCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/MigrateBrokerVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java 4 files changed, 21 insertions(+), 5 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Yeela Kaplan: Verified Yaniv Bronhaim: Looks good to me, but someone else must approve Jenkins CI: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved Moti Asayag: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/41222 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I788e713c279fc2c6c90b4609554383c067217add Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0