- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: userportal, webadmin: fix broken helptag implementation
by tnisan＠redhat.com 25 May '15

25 May '15

Tal Nisan has submitted this change and it was merged. Change subject: userportal, webadmin: fix broken helptag implementation ...................................................................... userportal, webadmin: fix broken helptag implementation Helptags were reusing some of the hashname infrastructure. This was 1. messy, 2. caused a bug where the help icon would not render unless the helptag == hashname. Cleaned this up and fixed the bug. Change-Id: Id244c5d068c6146da92287536bf919da1d5aee3c Bug-Url: https://bugzilla.redhat.com/1176581 Bug-Url: https://bugzilla.redhat.com/1176583 Bug-Url: https://bugzilla.redhat.com/1223529 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java 2 files changed, 15 insertions(+), 12 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Looks good to me, but someone else must approve Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/41348 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id244c5d068c6146da92287536bf919da1d5aee3c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: fix creation of instance-type
by ahadas＠redhat.com 25 May '15

25 May '15

Arik Hadas has submitted this change and it was merged. Change subject: core: fix creation of instance-type ...................................................................... core: fix creation of instance-type The addition of cinder disks broke creation of instance-type. While trying to create an instance-type, one would have get NPE in the AddVmTemplateCommand where cinder disks were about to be added. The problem was that instance-types are not based on any existing VM so getVm() returns null. The solution is to check if getVm()!=null before trying to add cinder disks. This is ok because instance-type don't have disks and in particular don't have cinder disks. Change-Id: Idb8b7e439f675fcfe29f403770a5ca52357ab6c4 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Jenkins CI: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/41301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb8b7e439f675fcfe29f403770a5ca52357ab6c4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine, webadmin: Disable add/remove bricks for EC volumes
by kmayilsa＠redhat.com 25 May '15

25 May '15

Kanagaraj M has submitted this change and it was merged. Change subject: engine, webadmin: Disable add/remove bricks for EC volumes ...................................................................... engine, webadmin: Disable add/remove bricks for EC volumes Modified to disable the add/remove bricks options in UI for erasure encoded volumes. Change-Id: Id96714b4faea8f0f1c29cb5ef4426b8c4a2a7ffa Bug-Url: https://bugzilla.redhat.com/1221306 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeRemoveBricksCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 7 insertions(+), 22 deletions(-) Approvals: Shubhendu Tripathi: Verified Jenkins CI: Looks good to me, but someone else must approve Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41053 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id96714b4faea8f0f1c29cb5ef4426b8c4a2a7ffa Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: DRY with host type check
by masayag＠redhat.com 25 May '15

25 May '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: DRY with host type check ...................................................................... engine: DRY with host type check Instead of examining the host type, the entity can report if it is an oVirt-node or not. Change-Id: Id73aeb7ec3c343eae097d6b6f123487a8865cdaf Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpgradeHostInternalCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpgradeOvirtNodeInternalCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddLocalStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/UpgradeHostValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/UpgradeHostValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java 11 files changed, 24 insertions(+), 30 deletions(-) Approvals: Alona Kaplan: Looks good to me, but someone else must approve Jenkins CI: Looks good to me, but someone else must approve Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41128 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id73aeb7ec3c343eae097d6b6f123487a8865cdaf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: userportal, webadmin: automatically show header tooltip unde...
by gshereme＠redhat.com 22 May '15

22 May '15

Greg Sheremeta has submitted this change and it was merged. Change subject: userportal, webadmin: automatically show header tooltip underline ...................................................................... userportal, webadmin: automatically show header tooltip underline Previously, grid headers with tooltips needed the tooltip style (underline) manually switched on. This patch makes it automatic -- if a tooltip is set on a grid header, the header text will have an underline -- giving the visual clue that it can be hovered over. Change-Id: I7392b13a30bfb23bcd026e0491e415e0e87d6e54 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/header/ResizeableCheckboxHeader.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/header/SafeHtmlHeader.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java 3 files changed, 28 insertions(+), 23 deletions(-) Approvals: Jenkins CI: Looks good to me, but someone else must approve Greg Sheremeta: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41298 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7392b13a30bfb23bcd026e0491e415e0e87d6e54 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: userportal, webadmin: added visual indicator for tooltips
by gshereme＠redhat.com 22 May '15

22 May '15

Greg Sheremeta has submitted this change and it was merged. Change subject: userportal, webadmin: added visual indicator for tooltips ...................................................................... userportal, webadmin: added visual indicator for tooltips In AbstractValidatedWidgetWithLabel, added a visual indicator (a dotted underline) to all labels when they get tooltips set on them. This is similar to the functionality we currently have for grid headers that have tooltips. Change-Id: I68ed5a61677bf798e692122452c8fed5d493c1fb Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/css/OvirtCss.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/header/SafeHtmlHeader.java M packaging/branding/ovirt.brand/ovirt.css 5 files changed, 28 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Looks good to me, but someone else must approve Greg Sheremeta: Verified Vojtech Szocs: Looks good to me, approved Objections: Jenkins CI: Fails -- To view, visit https://gerrit.ovirt.org/41296 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68ed5a61677bf798e692122452c8fed5d493c1fb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: fix refresh status.
by awels＠redhat.com 22 May '15

22 May '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: fix refresh status. ...................................................................... webadmin: fix refresh status. - The refresh flag was improperly set for some operation on the snapshot VM subtab. Change-Id: I73e0238229e458491e6e8e9995b54d39419357f5 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Looks good to me, but someone else must approve Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41359 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73e0238229e458491e6e8e9995b54d39419357f5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: build: post ovirt-hosted-engine-setup-1.2.4
by sbonazzo＠redhat.com 22 May '15

22 May '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: post ovirt-hosted-engine-setup-1.2.4 ...................................................................... build: post ovirt-hosted-engine-setup-1.2.4 Change-Id: I71b665999a519ac4f6eea7d4110249d704a3dae3 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-setup.spec.in 2 files changed, 8 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/41345 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71b665999a519ac4f6eea7d4110249d704a3dae3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: build: ovirt-hosted-engine-setup-1.2.4
by sbonazzo＠redhat.com 22 May '15

22 May '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-setup-1.2.4 ...................................................................... build: ovirt-hosted-engine-setup-1.2.4 Change-Id: Id3dad726a0f1b8489273bc12f25ec45d0d12f981 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-setup.spec.in 2 files changed, 12 insertions(+), 9 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/41344 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3dad726a0f1b8489273bc12f25ec45d0d12f981 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: fix broken helptag implementation
by gshereme＠redhat.com 22 May '15

22 May '15

Greg Sheremeta has submitted this change and it was merged. Change subject: userportal, webadmin: fix broken helptag implementation ...................................................................... userportal, webadmin: fix broken helptag implementation Helptags were reusing some of the hashname infrastructure. This was 1. messy, 2. caused a bug where the help icon would not render unless the helptag == hashname. Cleaned this up and fixed the bug. Change-Id: Id244c5d068c6146da92287536bf919da1d5aee3c Bug-Url: https://bugzilla.redhat.com/1176581 Bug-Url: https://bugzilla.redhat.com/1176583 Bug-Url: https://bugzilla.redhat.com/1223529 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java 2 files changed, 15 insertions(+), 12 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Looks good to me, but someone else must approve Greg Sheremeta: Verified Vojtech Szocs: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/41238 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id244c5d068c6146da92287536bf919da1d5aee3c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0