- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin: UI plugin API - revealPlace
by kmayilsa＠redhat.com 20 May '15

20 May '15

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: UI plugin API - revealPlace ...................................................................... webadmin: UI plugin API - revealPlace This patch adds new UI plugin API function ('revealPlace') that can be used to reveal desired application place, e.g. main or sub tab. An application place denotes a logical state of the web application, represented as '#placeToken' in application's URL, for example: WebAdmin.html#vms // 'VM' main tab place WebAdmin.html#vms-general // 'VM General' sub tab place revealPlace function works for both standard (built-in) and custom (UI-plugin-contributed) places, assuming that given place to reveal is available at time the function is called. (Otherwise, WebAdmin will transition to its default place, currently set to 'VM' main tab.) API signature: revealPlace(placeToken) Example usage: // switch to 'Hosts' main tab api.revealPlace('hosts'); // add custom main tab and switch to it api.addMainTab('Test', 'test', 'plugin/TestPlugin/tab.html'); api.revealPlace('test'); Note: setting place parameters, such as: WebAdmin.html#placeToken;paramName=paramValue is not supported (yet) since there currently aren't any application places utilizing such parameters. Change-Id: Ib4ae30f62c5bcd6793e19c8be6806f32bf68eee1 Bug-Url: https://bugzilla.redhat.com/1168334 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginManager.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/PluginUiFunctions.java 2 files changed, 24 insertions(+), 1 deletion(-) Approvals: Shubhendu Tripathi: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41029 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4ae30f62c5bcd6793e19c8be6806f32bf68eee1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-node-plugin-vdsm[ovirt-3.5]: Revert "persist: /etc/multipath/wwwids"
by dougsland＠redhat.com 19 May '15

19 May '15

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: Revert "persist: /etc/multipath/wwwids" ...................................................................... Revert "persist: /etc/multipath/wwwids" This reverts commit d9d9e760f622bc7173d5e83a75e136ac346cc92f. Change-Id: Icc41bb4a0c3c7a475447a3ea8e32b43649423777 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/41129 --- M hooks/Makefile.am D hooks/on-boot/03-persist-multipath-wwids D hooks/pre-upgrade/03-persist-multipath-wwids M ovirt-node-plugin-vdsm.spec.in 4 files changed, 0 insertions(+), 28 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc41bb4a0c3c7a475447a3ea8e32b43649423777 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Avoid spying HostMonitoring if not need
by masayag＠redhat.com 19 May '15

19 May '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Avoid spying HostMonitoring if not need ...................................................................... engine: Avoid spying HostMonitoring if not need Now, when all HostMonitoring Dependencies are mocked, it can be tested without mock/spy. Change-Id: I974aa32e3ae693983c7de5057af2d80c983a09e0 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/HostMonitoringTest.java 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40951 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I974aa32e3ae693983c7de5057af2d80c983a09e0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Use dynamically obtained ResourceManager instance
by masayag＠redhat.com 19 May '15

19 May '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Use dynamically obtained ResourceManager instance ...................................................................... engine: Use dynamically obtained ResourceManager instance Change-Id: If510093ac9ac054342d34b2a50f8cd6f6654503d Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Maor Lipchuk: Looks good to me, approved Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/40959 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If510093ac9ac054342d34b2a50f8cd6f6654503d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Use VdsCommand.setVdsStatus when possible
by masayag＠redhat.com 19 May '15

19 May '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Use VdsCommand.setVdsStatus when possible ...................................................................... engine: Use VdsCommand.setVdsStatus when possible Change-Id: I595b0dfbbde45475f49b4fb2a418642e50347200 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/ApproveVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/FenceVdsBaseCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/RestartVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/VdsKdumpDetectionCommand.java 8 files changed, 26 insertions(+), 54 deletions(-) Approvals: Jenkins CI: Looks good to me, but someone else must approve Moti Asayag: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41110 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I595b0dfbbde45475f49b4fb2a418642e50347200 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Avoid static methods in VdsManager
by masayag＠redhat.com 19 May '15

19 May '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Avoid static methods in VdsManager ...................................................................... engine: Avoid static methods in VdsManager static methods can be spared from VdsManager. Change-Id: If67c4fafcd8fcbb9f12c5f39c84d50d653970d6d Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Moti Asayag: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40936 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If67c4fafcd8fcbb9f12c5f39c84d50d653970d6d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Avoid static access to ResourceManager from VdsManager
by masayag＠redhat.com 19 May '15

19 May '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Avoid static access to ResourceManager from VdsManager ...................................................................... engine: Avoid static access to ResourceManager from VdsManager Change-Id: I945f3ff94bf8022d4efc13bcec289edd85755749 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 2 files changed, 22 insertions(+), 28 deletions(-) Approvals: Moti Asayag: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40935 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I945f3ff94bf8022d4efc13bcec289edd85755749 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Delete AuditLogDaoMocker
by masayag＠redhat.com 19 May '15

19 May '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Delete AuditLogDaoMocker ...................................................................... engine: Delete AuditLogDaoMocker The class is no longer used, since any usage of AuditLogDirector should be mocked. Change-Id: I9e0e17901748c995c3057e2e6c2aaee7fa2f3f08 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- D backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/AuditLogDaoMocker.java 1 file changed, 0 insertions(+), 108 deletions(-) Approvals: Moti Asayag: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40943 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e0e17901748c995c3057e2e6c2aaee7fa2f3f08 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Avoid use of AuditLogDaoMocker when log director mocked
by masayag＠redhat.com 19 May '15

19 May '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Avoid use of AuditLogDaoMocker when log director mocked ...................................................................... engine: Avoid use of AuditLogDaoMocker when log director mocked Since the AuditLogDirector can be mocked, there is no real need to use AuditLogDaoMocker. Change-Id: I88437e09fd935c9258488bff97c378685cbc4368 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmsMonitoringTest.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Moti Asayag: Verified Yair Zaslavsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88437e09fd935c9258488bff97c378685cbc4368 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Avoid instantiating AuditLogDirector
by masayag＠redhat.com 19 May '15

19 May '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Avoid instantiating AuditLogDirector ...................................................................... engine: Avoid instantiating AuditLogDirector The AuditLogDirector instance can be passed as argument to the c'tor which simplifies the instantiation and so the testing. Change-Id: I47a08f849300eb9bae8acbe32798ca539b078d24 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/HostMonitoringTest.java 3 files changed, 22 insertions(+), 21 deletions(-) Approvals: Moti Asayag: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40941 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47a08f849300eb9bae8acbe32798ca539b078d24 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0