- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Remove transaction field from CINDER constructor
by derez＠redhat.com 26 Mar '15

26 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: core: Remove transaction field from CINDER constructor ...................................................................... core: Remove transaction field from CINDER constructor Remove the constructors of CINDERStorageHelper to be compatible with the rest of the Storage Helpers Change-Id: If3cb4babe23fe11ffb04c58ed5dc0c9a1de98a59 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackVolumeProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CINDERStorageHelper.java 2 files changed, 8 insertions(+), 7 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39243 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3cb4babe23fe11ffb04c58ed5dc0c9a1de98a59 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: cleanup constants in PermissionListMod...
by gshereme＠redhat.com 26 Mar '15

26 Mar '15

Greg Sheremeta has submitted this change and it was merged. Change subject: userportal, webadmin: cleanup constants in PermissionListModelTable ...................................................................... userportal, webadmin: cleanup constants in PermissionListModelTable No need to pass around CommonApplicationConstants in PermissionListModelTable. Removed all the parameters. Fixed indentation. Change-Id: I3b2bfb86aa297142c28e17beca2c24c31a1f300c Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/permissions/PermissionListModelTable.java 1 file changed, 19 insertions(+), 18 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/39107 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b2bfb86aa297142c28e17beca2c24c31a1f300c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: removed unused variable
by gshereme＠redhat.com 26 Mar '15

26 Mar '15

Greg Sheremeta has submitted this change and it was merged. Change subject: webadmin: removed unused variable ...................................................................... webadmin: removed unused variable removed unused variable in GlusterVolumeSnapshotStatusColumn. Change-Id: I15a9d1db7ec76f98db7525c010da2df016abb391 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/GlusterVolumeSnapshotStatusColumn.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/39106 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15a9d1db7ec76f98db7525c010da2df016abb391 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: rename SelectAllCheckboxHeader -> Abst...
by gshereme＠redhat.com 26 Mar '15

26 Mar '15

Greg Sheremeta has submitted this change and it was merged. Change subject: userportal, webadmin: rename SelectAllCheckboxHeader -> Abstract ...................................................................... userportal, webadmin: rename SelectAllCheckboxHeader -> Abstract rename SelectAllCheckboxHeader -> AbstractSelectAllCheckboxHeader Change-Id: I7247a939b1f8249ba988601f8ef18d627535bffe Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCellTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelObjectCellTable.java R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/header/AbstractSelectAllCheckBoxHeader.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/ImportIscsiStorageView.java 4 files changed, 10 insertions(+), 12 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/39103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7247a939b1f8249ba988601f8ef18d627535bffe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: removed delayed creation of CellTemplates
by awels＠redhat.com 26 Mar '15

26 Mar '15

Alexander Wels has submitted this change and it was merged. Change subject: userportal, webadmin: removed delayed creation of CellTemplates ...................................................................... userportal, webadmin: removed delayed creation of CellTemplates Change-Id: I04ecaf1b869568b0239896e6ee2491705dfcff3d Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/TextCell.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/CustomSelectionCell.java 2 files changed, 2 insertions(+), 10 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/39105 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04ecaf1b869568b0239896e6ee2491705dfcff3d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: remove unused textWithTooltip template
by awels＠redhat.com 26 Mar '15

26 Mar '15

Alexander Wels has submitted this change and it was merged. Change subject: userportal, webadmin: remove unused textWithTooltip template ...................................................................... userportal, webadmin: remove unused textWithTooltip template Change-Id: I6ad76d0322781208489c24fa69ceb888577cb26c Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/39102 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ad76d0322781208489c24fa69ceb888577cb26c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: rename ImageButtonCell -> AbstractImag...
by awels＠redhat.com 26 Mar '15

26 Mar '15

Alexander Wels has submitted this change and it was merged. Change subject: userportal, webadmin: rename ImageButtonCell -> AbstractImageButtonCell ...................................................................... userportal, webadmin: rename ImageButtonCell -> AbstractImageButtonCell Change-Id: Ide4c8b76490e579e81b9c7813436364aaaea8a4a Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/AbstractImageButtonCell.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedVirtualMachineView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/table/cell/VmButtonsImageButtonCell.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/footer/AlertsEventsFooterView.java 4 files changed, 13 insertions(+), 14 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/39101 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide4c8b76490e579e81b9c7813436364aaaea8a4a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix creating instance type via ui
by ofrenkel＠redhat.com 26 Mar '15

26 Mar '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix creating instance type via ui ...................................................................... core: fix creating instance type via ui Previously when user was creating an instance type via ui, graphics device was not created. This patch adds creating graphics from params on adding new instance type/template. Change-Id: I782cde707241312483ce5f668a0fb45d7d3d33ee Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GraphicsParameters.java 2 files changed, 23 insertions(+), 6 deletions(-) Approvals: Frank Kobzik: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/37562 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I782cde707241312483ce5f668a0fb45d7d3d33ee Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Add missing fence option type
by emesika＠redhat.com 26 Mar '15

26 Mar '15

Eli Mesika has submitted this change and it was merged. Change subject: engine: Add missing fence option type ...................................................................... engine: Add missing fence option type - The newly added encrypt_options parameter did not have a type defined in the database, this caused parsing to fail and in some cases jboss wouldn't start. This patch fixes the issue and adds a unit test demonstrating the fix works. Change-Id: I305de12cdaeac8c018fb5282b3bc0592a1252d20 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/util/FenceOptionsParserTest.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 2 files changed, 15 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Alexander Wels: Verified -- To view, visit https://gerrit.ovirt.org/39236 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I305de12cdaeac8c018fb5282b3bc0592a1252d20 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: generate cloud-init ISO image
by sbonazzo＠redhat.com 26 Mar '15

26 Mar '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: generate cloud-init ISO image ...................................................................... packaging: setup: generate cloud-init ISO image Ask a few question and generate cloud-init ISO image to customize an appliance. Change-Id: Iec4f409203e3a2d6da314208e9a0f422be00ce1b Bug-Url: https://bugzilla.redhat.com/1198138 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt-hosted-engine-setup.spec.in M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/engine/fqdn.py M src/plugins/ovirt-hosted-engine-setup/vm/Makefile.am M src/plugins/ovirt-hosted-engine-setup/vm/__init__.py M src/plugins/ovirt-hosted-engine-setup/vm/boot_cdrom.py A src/plugins/ovirt-hosted-engine-setup/vm/cloud_init.py 7 files changed, 334 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit https://gerrit.ovirt.org/38811 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec4f409203e3a2d6da314208e9a0f422be00ce1b Gerrit-PatchSet: 11 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0