- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: add confirm 'Host has been Rebooted' button
by Code Review 22 May '17

22 May '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: webadmin: add confirm 'Host has been Rebooted' button ...................................................................... webadmin: add confirm 'Host has been Rebooted' button Add Confirm 'Host has been Rebooted' button to the Hosts main tab under Management options. Change-Id: I503e55d6b3e8035ea21319b8286914f31d82c398 Bug-Url: https://bugzilla.redhat.com/1421715 Signed-off-by: Irit Goihman <igoihman(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Irit Goihman: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/75828 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I503e55d6b3e8035ea21319b8286914f31d82c398 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ConfigureConsoleOptionsQueryTest mocking
by Code Review 22 May '17

22 May '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: ConfigureConsoleOptionsQueryTest mocking ...................................................................... core: ConfigureConsoleOptionsQueryTest mocking VdcQueryReturnValue is a POJO with no interesting logic defined in the common module. As such, there's very little benefit in mocking it instead of just returning a new instance in the test. Besides cleaning up the code, this patch mainly lays some ground work towards making VdcQueryReturnValue final. Change-Id: I920d6b94f3714e0d72773a841895b90f87c6fe4b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ConfigureConsoleOptionsQueryTest.java 1 file changed, 5 insertions(+), 9 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Vojtech Szocs: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76964 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I920d6b94f3714e0d72773a841895b90f87c6fe4b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Mocking VdcQueryReturnValue
by Code Review 22 May '17

22 May '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: restapi: Mocking VdcQueryReturnValue ...................................................................... restapi: Mocking VdcQueryReturnValue VdcQueryReturnValue is a POJO with no interesting logic defined in the common module. As such, there's very little benefit in mocking it instead of just returning a new instance in the test. Besides cleaning up the code, this patch mainly lays some ground work towards making VdcQueryReturnValue final. Change-Id: Idbfbefff9b673d95fb6e7c66d9a4d39dabfbc71e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCpuProfilesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendDiskProfilesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendNetworkAttachmentsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendVnicProfilesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendAttachedStorageDomainsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendExportDomainDiskResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendExportDomainDisksResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendMacPoolsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBricksResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterHooksResourceTest.java 13 files changed, 75 insertions(+), 75 deletions(-) Approvals: Ori Liel: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Vojtech Szocs: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/76963 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idbfbefff9b673d95fb6e7c66d9a4d39dabfbc71e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: resatpi: Mocking backend exceptions in tests
by Code Review 22 May '17

22 May '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: resatpi: Mocking backend exceptions in tests ...................................................................... resatpi: Mocking backend exceptions in tests In the backend, once a VdcQueryRetrunValue is generated, it can no longer throw an exception when it's accessed, so mocking queryResult.getExceptionString() to throw an exception is artificial, and doesn't represent any real world use case. This patch moves the mocking of throwing a [runtime] Exception to the backend.runQuery call, which represents a query that actually fails catastrophically. Change-Id: Ibd9d1f5555c5a357f9947f727a7b6f1c5ea568bf Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendExportDomainDiskResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendExportDomainDisksResourceTest.java 4 files changed, 38 insertions(+), 20 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Vojtech Szocs: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76962 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd9d1f5555c5a357f9947f727a7b6f1c5ea568bf Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Mocking VdcReturnValueBase
by Code Review 22 May '17

22 May '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: restapi: Mocking VdcReturnValueBase ...................................................................... restapi: Mocking VdcReturnValueBase VdcReturnValueBase is a POJO with no interesting logic defined in the common module. As such, there's very little benefit in mocking it instead of just returning a new instance in the test. Besides cleaning up the code, this patch mainly lays some ground work towards making VdcReturnValueBase final. Change-Id: I7da59e00a683ebd828d776d19870ccafa8cf9588 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResourceTest.java 2 files changed, 15 insertions(+), 17 deletions(-) Approvals: Ori Liel: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Vojtech Szocs: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/76961 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7da59e00a683ebd828d776d19870ccafa8cf9588 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: resatpi: BackendSnapshotResourceTest#testRestore mocking
by Code Review 22 May '17

22 May '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: resatpi: BackendSnapshotResourceTest#testRestore mocking ...................................................................... resatpi: BackendSnapshotResourceTest#testRestore mocking testRestore mocks an expectation for a JobId when performing a snapshot restore, which just isn't correct. This patch removes this redundant (read: wrong) mocking. Change-Id: Ic8357880b0b2e562a0ba574b8bcecc6219716394 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotResourceTest.java 1 file changed, 2 insertions(+), 10 deletions(-) Approvals: Ori Liel: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Moti Asayag: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/76960 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8357880b0b2e562a0ba574b8bcecc6219716394 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: WelcomeServletTest mocking
by Code Review 22 May '17

22 May '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: WelcomeServletTest mocking ...................................................................... core: WelcomeServletTest mocking VdcQueryReturnValue is a POJO with no interesting logic defined in the common module. As such, there's very little benefit in mocking it instead of just returning a new instance in the test. Besides cleaning up the code, this patch mainly lays some ground work towards making VdcQueryReturnValue final. Change-Id: Ia99fa3cb6b07b3b1746e50c41d688f791d840cdf Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/welcome/src/test/java/org/ovirt/engine/core/WelcomeServletTest.java 1 file changed, 3 insertions(+), 5 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests Vojtech Szocs: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76965 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia99fa3cb6b07b3b1746e50c41d688f791d840cdf Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddClusterCommandTest mocking
by Code Review 22 May '17

22 May '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: AddClusterCommandTest mocking ...................................................................... core: AddClusterCommandTest mocking VdcReturnValueBase is a POJO with no interesting logic defined in the common module. As such, there's very little benefit in mocking it instead of just returning a new instance in the test. Besides cleaning up the code, this patch mainly lays some ground work towards making VdcReturnValueBase final. Change-Id: I2d2dee53766bf91da16c3fae63230fcfd703f5a1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddClusterCommandTest.java 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Vojtech Szocs: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76959 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d2dee53766bf91da16c3fae63230fcfd703f5a1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: Add transition to EngineMaybeAway from EngineStarting
by Code Review 22 May '17

22 May '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. Change subject: Add transition to EngineMaybeAway from EngineStarting ...................................................................... Add transition to EngineMaybeAway from EngineStarting When the agent tries to start the VM and it is already running on another host, the VDSM reports an error: "Failed to acquire lock". Broker periodically checks the state of the VM, but it sees the error message only once and then the VM is destroyed. The agent may miss the message if it sleeps too long. This patch adds transition to EngineMaybeAway, to check if the VM is running elsewhere. Change-Id: I4d92e021ebf6398d7846a233531f1be5e94dbe5f Bug-Url: https://bugzilla.redhat.com/1448699 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/states.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Denis Chaplygin: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/77030 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d92e021ebf6398d7846a233531f1be5e94dbe5f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: backend: remove old luns from db on sd sync
by Code Review 22 May '17

22 May '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: backend: remove old luns from db on sd sync ...................................................................... backend: remove old luns from db on sd sync This patch removes the method cleanupLunsFromDb and instead wraps its logic inside a LunUpdateHandler object, just like when updating or saving new luns. It also fixes a bug where luns are being removed only if new or existing and not up to date luns were found. That is, we now always check if old luns exist and then remove them. Change-Id: Ia95a44ef269a5daecf71a2bddfa813919d179ca6 Bug-Url: https://bugzilla.redhat.com/1439692 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommandTest.java 2 files changed, 71 insertions(+), 34 deletions(-) Approvals: Tal Nisan: Passed CI tests Allon Mureinik: Looks good to me, approved Idan Shaby: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/77074 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia95a44ef269a5daecf71a2bddfa813919d179ca6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0