- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Javanize SPMAsyncTask
by masayag＠redhat.com 15 Mar '15

15 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Javanize SPMAsyncTask ...................................................................... engine: Javanize SPMAsyncTask * Declare class variable at the beginning of the class * Use proper naming convention * Initial members in c'tor Change-Id: I2c76afd1779dff9d80fb97adbf81f9ae30741324 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/SPMAsyncTask.java 1 file changed, 27 insertions(+), 32 deletions(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38688 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c76afd1779dff9d80fb97adbf81f9ae30741324 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Remove redundant modifier from CommandContextsCache
by masayag＠redhat.com 15 Mar '15

15 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Remove redundant modifier from CommandContextsCache ...................................................................... engine: Remove redundant modifier from CommandContextsCache Change-Id: I9b949038082dcd5e67a39b6daecb1cf99ba75af3 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandContextsCache.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38687 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b949038082dcd5e67a39b6daecb1cf99ba75af3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Format AsyncCommandCallBack
by masayag＠redhat.com 15 Mar '15

15 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Format AsyncCommandCallBack ...................................................................... engine: Format AsyncCommandCallBack Change-Id: Ia86a756c3ed3ec52763ab72bce03eab513da5c49 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/AsyncCommandCallBack.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38686 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia86a756c3ed3ec52763ab72bce03eab513da5c49 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Format and remove default modifiers from AsyncTaskCR...
by masayag＠redhat.com 15 Mar '15

15 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Format and remove default modifiers from AsyncTaskCRUDOperations ...................................................................... engine: Format and remove default modifiers from AsyncTaskCRUDOperations Change-Id: Icb3521f38c2f53d017090f27d7ced05b8a76a2bd Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/AsyncTaskCRUDOperations.java 1 file changed, 16 insertions(+), 9 deletions(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38685 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb3521f38c2f53d017090f27d7ced05b8a76a2bd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Use formatter for Command
by masayag＠redhat.com 15 Mar '15

15 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Use formatter for Command ...................................................................... engine: Use formatter for Command Change-Id: I03554ca006cce684a57fbf0720e3382f0d018bf4 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/Command.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38684 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03554ca006cce684a57fbf0720e3382f0d018bf4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Remove default modifiers in CommandScheduler
by masayag＠redhat.com 15 Mar '15

15 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Remove default modifiers in CommandScheduler ...................................................................... engine: Remove default modifiers in CommandScheduler The public abstract are default modifiers in interface and no need to specify it. Change-Id: Ie58cc4712b190d6a3ca433f7b83245bd4ed19d51 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandScheduler.java 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38683 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie58cc4712b190d6a3ca433f7b83245bd4ed19d51 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Decrease visibility of variable in CommandsCacheImpl
by masayag＠redhat.com 15 Mar '15

15 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Decrease visibility of variable in CommandsCacheImpl ...................................................................... engine: Decrease visibility of variable in CommandsCacheImpl Change-Id: I12c549c1278a60dda29a0889a394c8938f7a059e Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38682 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12c549c1278a60dda29a0889a394c8938f7a059e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Remove redundant public modifier CacheWrapper
by masayag＠redhat.com 15 Mar '15

15 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Remove redundant public modifier CacheWrapper ...................................................................... engine: Remove redundant public modifier CacheWrapper Change-Id: Idd4e62b4fed3a1414ccebc97b841389be744456c Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CacheWrapper.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38681 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd4e62b4fed3a1414ccebc97b841389be744456c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Reduce need for constant casting
by masayag＠redhat.com 15 Mar '15

15 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Reduce need for constant casting ...................................................................... engine: Reduce need for constant casting By generics we can simplify the usage of the CoCo util and avoid constant casting by the clients. Change-Id: Iee9caa732a0a2d84889d9dd6d0e0a4e5e06397c8 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeStatusCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorUtil.java 6 files changed, 8 insertions(+), 7 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Moti Asayag: Verified Arik Hadas: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/38667 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee9caa732a0a2d84889d9dd6d0e0a4e5e06397c8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Fix punctuation in threshold warnings
by tnisan＠redhat.com 15 Mar '15

15 Mar '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix punctuation in threshold warnings ...................................................................... webadmin: Fix punctuation in threshold warnings audit log messages were missing points and a space. Change-Id: If30f094e52f42b78537e215a2699cf74c248bd83 Bug-Url: https://bugzilla.redhat.com/1201385 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit https://gerrit.ovirt.org/38677 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If30f094e52f42b78537e215a2699cf74c248bd83 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0