- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Format code and remove default access modifiers
by oourfali＠redhat.com 12 Mar '15

12 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Format code and remove default access modifiers ...................................................................... engine: Format code and remove default access modifiers Change-Id: I4ff814bbf4ceaf2c66baacccf923ad8a13aa6562 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCRUDOperations.java 1 file changed, 32 insertions(+), 16 deletions(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38562 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ff814bbf4ceaf2c66baacccf923ad8a13aa6562 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Maintain camelCase in updateCallbackNotified
by oourfali＠redhat.com 12 Mar '15

12 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Maintain camelCase in updateCallbackNotified ...................................................................... engine: Maintain camelCase in updateCallbackNotified Change-Id: If17dd7daabbb3199d952f70906bc77a434fa79a7 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCRUDOperations.java 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38561 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If17dd7daabbb3199d952f70906bc77a434fa79a7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Maintain camelCase in updateCallbackNotified
by oourfali＠redhat.com 12 Mar '15

12 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Maintain camelCase in updateCallbackNotified ...................................................................... engine: Maintain camelCase in updateCallbackNotified Change-Id: I0a4b7ecb725b2ff83fb2b8166cb56c20c246179d Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCache.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38560 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a4b7ecb725b2ff83fb2b8166cb56c20c246179d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Remove unused variable from CommandBase
by oourfali＠redhat.com 12 Mar '15

12 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Remove unused variable from CommandBase ...................................................................... engine: Remove unused variable from CommandBase Change-Id: I60c46804c00adb335668ac72308edfc7ee3a1836 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38535 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60c46804c00adb335668ac72308edfc7ee3a1836 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Add missing switch case to Backend
by oourfali＠redhat.com 12 Mar '15

12 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Add missing switch case to Backend ...................................................................... engine: Add missing switch case to Backend and return from method with a single return value. Change-Id: Idb3bb4b0891729684c25ef5fa21e79b96c58522c Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38534 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb3bb4b0891729684c25ef5fa21e79b96c58522c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: add missing switch default case
by masayag＠redhat.com 12 Mar '15

12 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: add missing switch default case ...................................................................... engine: add missing switch default case Signed-off-by: Moti Asayag <masayag(a)redhat.com> Change-Id: I0753c3a11c4b6b0a3817cced39a613f65a274063 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Vered Volansky: Looks good to me, but someone else must approve Moti Asayag: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38533 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0753c3a11c4b6b0a3817cced39a613f65a274063 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Replace deprecated access to ResourceManager
by oourfali＠redhat.com 12 Mar '15

12 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Replace deprecated access to ResourceManager ...................................................................... engine: Replace deprecated access to ResourceManager Change-Id: Ie78fff7c5be5998bd9c769cbefa99317ac590b89 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsInternalCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/transport/ProtocolDetector.java 2 files changed, 7 insertions(+), 5 deletions(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38524 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie78fff7c5be5998bd9c769cbefa99317ac590b89 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Organize imports
by oourfali＠redhat.com 12 Mar '15

12 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Organize imports ...................................................................... engine: Organize imports Change-Id: Ifa344cf7e173f4b51a86581fafabee4015a19367 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCRUDOperations.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38523 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa344cf7e173f4b51a86581fafabee4015a19367 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Add type argument to CommandBase
by oourfali＠redhat.com 12 Mar '15

12 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Add type argument to CommandBase ...................................................................... engine: Add type argument to CommandBase Change-Id: If307b519d358449ea84c9fadcf1142f760044d2c Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/TaskHelper.java 2 files changed, 12 insertions(+), 12 deletions(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38521 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If307b519d358449ea84c9fadcf1142f760044d2c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Simplify getChildCommandIds(Guid) * Remove local var...
by oourfali＠redhat.com 12 Mar '15

12 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Simplify getChildCommandIds(Guid) * Remove local variable * Use typed empty list from Collections. ...................................................................... engine: Simplify getChildCommandIds(Guid) * Remove local variable * Use typed empty list from Collections. Change-Id: I59703183876498db2a4cc157176e87817bd2ef92 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38520 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59703183876498db2a4cc157176e87817bd2ef92 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0