- Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk[sdk_3.5]: sdk: Regenerate against the latest API
by juan.hernandez＠redhat.com 26 Feb '15

26 Feb '15

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Regenerate against the latest API ...................................................................... sdk: Regenerate against the latest API This patch regenerates the SDK using the latest API obtained from the engine built from commit fdb16f4, corresponding to tag ovirt-engine-3.5.2_rc1. Change-Id: If8dbd4fc24ac5c0da2abcc0e7a7cff34ab92213a Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/resources/api.rsdl M generator/src/main/resources/api.xsd M src/ovirtsdk/infrastructure/brokers.py M src/ovirtsdk/xml/params.py 4 files changed, 95 insertions(+), 8 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/37953 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8dbd4fc24ac5c0da2abcc0e7a7cff34ab92213a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core : Remove place holders from AddImageFromScratchCommand
by oourfali＠redhat.com 26 Feb '15

26 Feb '15

Oved Ourfali has submitted this change and it was merged. Change subject: core : Remove place holders from AddImageFromScratchCommand ...................................................................... core : Remove place holders from AddImageFromScratchCommand Change AddImageFromScratchCommand to not use the place holder infrastructure Change-Id: Id64ecbb4332dc2ab63f66742d235e1e8462fc2b4 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java 1 file changed, 1 insertion(+), 6 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved Liron Aravot: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/37408 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id64ecbb4332dc2ab63f66742d235e1e8462fc2b4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5.2]: packaging: setup: clearing only zombie tasks
by piotr.kliczewski＠gmail.com 26 Feb '15

26 Feb '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: packaging: setup: clearing only zombie tasks ...................................................................... packaging: setup: clearing only zombie tasks We cannot upgrade while async tasks are still running and we have to wait till they ends. To avoid getting stuck we need to clear zombie task from the list before checking if we have to wait. If installed version is 3.5 or upper, before removing zombie tasks we have also to remove zombie commands so we have to call the taskcleaner utility twice. Change-Id: I73dcb9ee0a465ef9552a085e59ab36576ee3b660 Bug-Url: https://bugzilla.redhat.com/1196136 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py 1 file changed, 50 insertions(+), 24 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit https://gerrit.ovirt.org/38159 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73dcb9ee0a465ef9552a085e59ab36576ee3b660 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5.2 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: clearing only zombie tasks
by piotr.kliczewski＠gmail.com 26 Feb '15

26 Feb '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: packaging: setup: clearing only zombie tasks ...................................................................... packaging: setup: clearing only zombie tasks We cannot upgrade while async tasks are still running and we have to wait till they ends. To avoid getting stuck we need to clear zombie task from the list before checking if we have to wait. If installed version is 3.5 or upper, before removing zombie tasks we have also to remove zombie commands so we have to call the taskcleaner utility twice. Change-Id: I73dcb9ee0a465ef9552a085e59ab36576ee3b660 Bug-Url: https://bugzilla.redhat.com/1196136 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py 1 file changed, 50 insertions(+), 24 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified oVirt Jenkins CI Server: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/38158 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73dcb9ee0a465ef9552a085e59ab36576ee3b660 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: clearing only zombie tasks
by sbonazzo＠redhat.com 26 Feb '15

26 Feb '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: clearing only zombie tasks ...................................................................... packaging: setup: clearing only zombie tasks We cannot upgrade while async tasks are still running and we have to wait till they ends. To avoid getting stuck we need to clear zombie task from the list before checking if we have to wait. If installed version is 3.5 or upper, before removing zombie tasks we have also to remove zombie commands so we have to call the taskcleaner utility twice. Change-Id: I73dcb9ee0a465ef9552a085e59ab36576ee3b660 Bug-Url: https://bugzilla.redhat.com/1119639 Bug-Url: https://bugzilla.redhat.com/1164771 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py 1 file changed, 50 insertions(+), 24 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/36302 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73dcb9ee0a465ef9552a085e59ab36576ee3b660 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: setup: Fix indentation issue in titles.py
by sbonazzo＠redhat.com 26 Feb '15

26 Feb '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: setup: Fix indentation issue in titles.py ...................................................................... setup: Fix indentation issue in titles.py Change-Id: I98414f3bacc04047440da306fe83c1a5a9ad58a8 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/dialog/titles.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/38187 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98414f3bacc04047440da306fe83c1a5a9ad58a8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5.2]: host-deploy: simplify remote bootstarp command
by oourfali＠redhat.com 26 Feb '15

26 Feb '15

Oved Ourfali has submitted this change and it was merged. Change subject: host-deploy: simplify remote bootstarp command ...................................................................... host-deploy: simplify remote bootstarp command + add -t parameter dropped in I9c780005a4. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1195672 Change-Id: I0c3260f61b0acbd914d587a59e610a9d627227b3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> (cherry picked from commit 6c3a6f38eb56eeaec746820556a5e90596089f28) --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Oved Ourfali: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38160 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c3260f61b0acbd914d587a59e610a9d627227b3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5.2 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core : Change CreateAllSnapshotsFromVmCommand to not use pla...
by oourfali＠redhat.com 26 Feb '15

26 Feb '15

Oved Ourfali has submitted this change and it was merged. Change subject: core : Change CreateAllSnapshotsFromVmCommand to not use placeholders mechanism ...................................................................... core : Change CreateAllSnapshotsFromVmCommand to not use placeholders mechanism CreateAllSnapshotsFromVmCommand has been changed not to insert placeholders for all child commands before execution by vdsm Change-Id: Ic6a6bba5d34e49efc06803ae042de9eb92fa3bc2 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java 2 files changed, 6 insertions(+), 16 deletions(-) Approvals: Ravi Nori: Verified Arik Hadas: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/37146 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6a6bba5d34e49efc06803ae042de9eb92fa3bc2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Revert "restapi: optimize getUriBuilder"
by tnisan＠redhat.com 25 Feb '15

25 Feb '15

Tal Nisan has submitted this change and it was merged. Change subject: Revert "restapi: optimize getUriBuilder" ...................................................................... Revert "restapi: optimize getUriBuilder" This reverts commit d83d67ff715c0707b1715e09249532ca14c7e21a. The original patch added a static Map that cached UriBuilders. This made the test "testGet" in "BackendHostNicLabelResourceTest" fail in some cases. Since JUnit test order is not deterministic some tests would wrongly use cached UriBuilders from previous tests and thus fail. Change-Id: I18db692bcfd0de26bb57481657b7645a01acb7d3 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendResource.java 2 files changed, 13 insertions(+), 54 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/38165 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18db692bcfd0de26bb57481657b7645a01acb7d3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: forbid single (vm mem) > (host mem)
by rgolan＠redhat.com 25 Feb '15

25 Feb '15

Roy Golan has submitted this change and it was merged. Change subject: engine: forbid single (vm mem) > (host mem) ...................................................................... engine: forbid single (vm mem) > (host mem) Forbid running single vm with mem > host physical memory. Yet we allow running few vms with total mem > host physical memory. (relying on balloning). This might be unwise yet can occour after migration or/and host downsizing. Whenever the: (vm mem) > (host mem) the host will start swaping and performance degrage. If it possible to think of scenrios vm allocated large mem and not using it, and cannot downsize vm mem. Fix swap and refactor reused messages. If fail run vm due to insufficent mem. Report the available mem. Added unit test to SlaValidatorTest Change-Id: Ia5f5280c43820732a36a235024ec5c887c9fcb98 Bug-Url: https://bugzilla.redhat.com/1180071 Signed-off-by: Dudi Maroshi <dudi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SlaValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/MemoryPolicyUnit.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/SlaValidatorTest.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 99 insertions(+), 13 deletions(-) Approvals: Dudi Maroshi: Verified Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/37429 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5f5280c43820732a36a235024ec5c887c9fcb98 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0